Commit aa787c9d authored by Tristan Van Berkom's avatar Tristan Van Berkom

Fixed focus handling on embedded windows.

Now GtkWindow chains up in focus vfuncs when non-toplevel, this
fixes focus in testtoplevelembed.
parent 387d745e
......@@ -3717,8 +3717,6 @@ gtk_widget_unparent (GtkWidget *widget)
toplevel = gtk_widget_get_toplevel (widget);
if (gtk_widget_is_toplevel (toplevel))
_gtk_window_unset_focus_and_default (GTK_WINDOW (toplevel), widget);
toplevel = NULL;
if (gtk_container_get_focus_child (GTK_CONTAINER (priv->parent)) == widget)
gtk_container_set_focus_child (GTK_CONTAINER (priv->parent), NULL);
......@@ -3777,7 +3775,7 @@ gtk_widget_unparent (GtkWidget *widget)
g_signal_emit (widget, widget_signals[PARENT_SET], 0, old_parent);
if (toplevel)
if (toplevel && gtk_widget_is_toplevel (toplevel))
_gtk_widget_propagate_hierarchy_changed (widget, toplevel);
g_object_unref (toplevel);
......@@ -5996,6 +5996,9 @@ gtk_window_focus (GtkWidget *widget,
GtkWidget *old_focus_child;
GtkWidget *parent;
if (!gtk_widget_is_toplevel (GTK_WIDGET (widget)))
return GTK_WIDGET_CLASS (gtk_window_parent_class)->focus (widget, direction);
container = GTK_CONTAINER (widget);
window = GTK_WINDOW (widget);
priv = window->priv;
......@@ -6049,6 +6052,12 @@ static void
gtk_window_move_focus (GtkWidget *widget,
GtkDirectionType dir)
if (!gtk_widget_is_toplevel (GTK_WIDGET (widget)))
GTK_WIDGET_CLASS (gtk_window_parent_class)->move_focus (widget, dir);
gtk_widget_child_focus (widget, dir);
if (! gtk_container_get_focus_child (GTK_CONTAINER (widget)))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment