Commit 8ed04717 authored by Bastien Nocera's avatar Bastien Nocera Committed by Matthias Clasen

window: Warn when gtk_window_present_with_time() is passed 0

When 0 or GDK_CURRENT_TIME is passed to gtk_window_present_with_time(),
print a warning so that the application developer knows that this isn't
a supported use of the function, but carry on working for now.
parent 5d7183ee
......@@ -10529,6 +10529,7 @@ gtk_window_present_with_time (GtkWindow *window,
GtkWindowPrivate *priv;
GtkWidget *widget;
GdkWindow *gdk_window;
static gsize warned_current_time = FALSE;
g_return_if_fail (GTK_IS_WINDOW (window));
......@@ -10546,6 +10547,15 @@ gtk_window_present_with_time (GtkWindow *window,
/* Translate a timestamp of GDK_CURRENT_TIME appropriately */
if (timestamp == GDK_CURRENT_TIME)
if (g_once_init_enter (&warned_current_time))
gboolean warned = TRUE;
g_warning ("gtk_window_present_with_time() should not be called with 0, or "
"GDK_CURRENT_TIME as a timestamp, the timestamp should instead be "
"gathered at the time the user initiated the request for the window "
"to be shown");
g_once_init_leave (&warned_current_time, warned);
if (GDK_IS_X11_WINDOW(gdk_window))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment