• Emmanuele Bassi's avatar
    Avoid O(n²) walking of string arrays · e259b2f3
    Emmanuele Bassi authored
    "Yo, we heard you like traversing NULL-terminated arrays to operate on
    them, so we called g_strv_length() as the for condition, so you can
    iterate the array while iterating the array."
    Instead of making famed rapper and television producer Xzibit proud, we
    should avoid calling g_strv_length() on an array while looping on the
    array, to avoid quadratic complexity.
    We do this in various places that deal with arrays of strings that we
    cannot really guess are short enough not to matter — e.g. the list of
    CSS selectors in the inspector, or the required authentication
    information for printing.
selector.c 3.02 KB