Skip to content
  • Alexander Larsson's avatar
    TextView: Use saner coordinate space in draw_layer. · 0af45763
    Alexander Larsson authored
    When I added the draw_layer vfunc it accidentally got passed a cairo_t
    that was configured with to draw in the viewport coordinate space (rather
    than the buffer coordinate space). This makes things unnecessary complex,
    because you have to convert between the two.
    
    The pixel cache is shared between the text and the layers, so there is
    no way to use draw_layer to get a stationary overlay effect. Thus it makes
    much more sense for the draw_layer vfunc to draw in the buffer space.
    
    Just changing this would break ABI for existing code, so this is fixed
    by adding new layer types and deprecating the old ones.
    
    Also, we use the new layer types to fix gtk3-widget-factory.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757856
    0af45763