Skip to content

Try to fix textview cursors going missing

Matthias Clasen requested to merge matthiasc/gtk:for-main into main

The second commit adds an assertion that triggers quickly when moving focus in and out of a textview, showing that we don't properly re-validate the line display cache before snapshotting.

The third commit fixes things so that the assertion dosn't trigger, and the cursor doesn't go missing. It needs some scrutiny to figure out what (if anything) the purpose of cache->cursor_line is, and how to manage it properly - currently, invalidating the display of the cursor line has the side-effect of clearing cache->cursor_line, and that messes up the accounting for when display_line->cursors needs to be updated.

Edited by Matthias Clasen

Merge request reports

Loading