These commits fix two different, but similarly ugly and clumsy looking, bugs with
spinbutton button:backdrop:disabled in both Adwaita and HighContrast. (
master will need the same of course.)
commit 6eb1be27f7b495bacf2d671f5bd8ede5fce45d51 Author: Daniel Boles <firstname.lastname@example.org> Date: Sun Jan 6 19:18:47 2019 +0000 Adwaita: Fix bg of backdrop:disabled spinbutton +- The +/- buttons are meant to be transparent, showing the base_color, but when backdropped they were picking up background-image from the base button, meaning they suddenly became more like theme_bg_color instead, and jumped out of the spinbutton when in backdrop unlike the rest of it. This looks strange and achieves nothing (especially not indicating that they are disabled, which is already served fine by their dim fg colour). Fix this by explicitly saying we don't want any background-image there.
commit d1b14a7deb9d27f510dc18ba5b4c9b8954e0715f (HEAD -> wip/dboles/spinbutton-button-backdrop-disabled-3, origin/wip/dboles/spinbutton-button-backdrop-disabled-3) Author: Daniel Boles <email@example.com> Date: Sun Jan 6 19:58:50 2019 +0000 HC: Fix fgcolor of backdrop:disabled spinbutton +- We shouldn't give the icons here the same fg colour as the bg... which makes them disappear and the buttons look like meaningless flat squares. Fix by just using the same colour the same as foreground disabled. Note: insensitive_fg_color is more prominent than !disabled, so clearly wrong.