Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,498
    • Issues 1,498
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 248
    • Merge requests 248
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gtkgtk
  • Merge requests
  • !4774

Gtk.TextView: ensure overlays are rendered above ChildAnchors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Florian "sp1rit" requested to merge sp1rit/gtk:textview-fix_overlays into main May 28, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

TextViewChildren are currently rendered before the ChildAnchors get rendered. Since overlay widgets (added with gtk_text_view_add_overlay) are using the center_child TextViewChild to be rendered, the overlays do not work as one'd imagine an overlay to work, since they appear "behind" any ChildAnchors that might have been added.

This commit fixes this by simply moving the snapshot_text_view_child calls behind the loop responsible for rendering the ChildAnchors.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: textview-fix_overlays