Skip to content

textbtree: Initialize to zero the tags counting array

Marco Trevisan requested to merge 3v1n0/gtk:invisible-char-fix into master

We're using the tag contents array to count the number of invisible tags set but we always increase it without being initialized.

This may lead to unexpected behavior when traversing them and it's causing a reliable failure in the textiter tests under s390x.

So, memset that area content to 0 once allocated. It's not needed to do the same for the tags themselves as we always assign them.

 Conditional jump or move depends on uninitialised value(s)
   at 0x4CFAA00: _gtk_text_btree_char_is_invisible (gtktextbtree.c:2569)
   by 0x4B8A1BB: find_visible_by_log_attrs (gtktextiter.c:3244)
   by 0x10E93D: check_backward_visible_word_start (textiter.c:484)
   by 0x10E93D: test_visible_word_boundaries (textiter.c:523)
   by 0x533288F: g_test_run_suite (in /usr/lib/s390x-linux-gnu/libglib-2.0.so.0)
   by 0x53328E7: g_test_run (in /usr/lib/s390x-linux-gnu/libglib-2.0.so.0)
   by 0x109CC1: main (textiter.c:807)
Edited by Marco Trevisan

Merge request reports