Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,490
    • Issues 1,490
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 247
    • Merge requests 247
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gtkgtk
  • Merge requests
  • !361

gtkstack: fix null pointer dereference

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hugo Lefeuvre requested to merge hlef/gtk:master into master Sep 26, 2018
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

The gtk_stack_snapshot_slide() function dereferences the last_visible_child pointer without proper != NULL check. This might result in NULL pointer dereference and crash if last_visible_child is invalid.

This patch adds a != NULL check before dereferencing the pointer.

I stumbled across this bug during my investigations on a crash issue affecting Account creation in (GNU) Ring.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master