Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,601
    • Issues 1,601
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 219
    • Merge requests 219
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !351

Resolve "GtkFileChooser: Unfocused location entry keeps selection, with same colour as focused"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Daniel Boles requested to merge 665-entry-textview-deselect-text-on-focus-out-4 into master Sep 22, 2018
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

We don't differentiate between foreground and backdropped selections, which confuses/infuriates users, particularly in the FileChooser entry. There's no design desire to introduce that differentiation in the theme. The preferred fix is instead to clear the selection on focussing out.

This patch does that by changing the existing code that clears the selection when the state changes and the widget is no longer :sensitive to instead clear the selection if it's not the focus within its toplevel

#665 (comment 110313)

Closes #665 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 665-entry-textview-deselect-text-on-focus-out-4