Skip to content

Application: Do not reuse Ctrl+F1 for help-overlay

Robert Roth requested to merge robertroth/shortcuts-overlay-accel into master

It just gets overridden to do something else, as the 1st GtkWidget’s class_init() adds it as a binding to toggle tooltips with the keyboard. The last entity to hook it (& return TRUE) is the only one who gets it.

So, worse: If users needed to manually set accels for a ShortcutsWindow, coincidentally waited until after the 1st GtkWidget init() to do it, & copied what GtkApplication said in an attempt to be good & consistent — they inadvertently broke the keyboard tooltips (except for users with a GDK_KEY_KP_F1 – whatever that is) as their handler blocked GtkWidget’s.

So, one side has to drop this accelerator, and it seems clear that being able to open tooltips with the keyboard is more important than having a second accel for the help-overlay. We can make up a replacement later.

#626 (closed)

Merge request reports