Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,605
    • Issues 1,605
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 219
    • Merge requests 219
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !297
The source project of this merge request has been removed.

updateiconcache: Sort list of entries

Merged Bernhard M. Wiedemann requested to merge (removed):sort into master Aug 15, 2018
  • Overview 0
  • Pipelines 0
  • Changes 1

because filesystem readdir order is indeterministic.

Without this patch, building openSUSE's balsa package had variations between builds in /usr/share/balsa/icon-theme.cache

patch inspired by https://bugzilla.gnome.org/show_bug.cgi?id=786528

Alternatively, one could also sort in write_file, but would have to handle key+value pairs and make sure that all previous processing happens independent of filesystem order.

Interestingly, https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/balsa.html lists Debian's balsa-2.5.5 package already as reproducible with libgtk-3-0 (= 3.22.30-2) though I cannot find patches for this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sort