Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.6k
    • Issues 1.6k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 238
    • Merge requests 238
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !2738

Fullscreen windows with WS_EX_NOACTIVATE | WS_EX_TRANSPARENT interfere with UI events

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jehan requested to merge wip/Jehan/gimp-issue-1082-transparent-window into gtk-3-24 Oct 23, 2020
  • Overview 16
  • Commits 1
  • Pipelines 2
  • Changes 1

This is the GTK+3 port of a patch we have been applying on GTK+2 built for GIMP's Windows installer for the last 3 years (cf. gimp#1082 (closed)). Basically many applications apply an invisible window over the whole desktop (screencast software, video conference, gesture-triggered actions, etc.) which interfere with mouse events and break various GUI interactions of GTK applications on Windows. This issue has been a huge problem (we had many reports about this) though we have had very few (apparently there may exist some other similar issues though) ever since this patch got applied. Since Inkscape had the same issues, even on GTK+3, they contributed it on the MSYS2 package of GTK+3 (which is the main package used by projects building GTK software for Windows) as it was confirmed to fix bugs reported to them as well.

I think it makes sense that this patch which has been now used for years on built packages and proven to work be committed upstream, no? 🙂

This should fix #370 (closed) or at least some cases of a more generic issue.

Edited Oct 23, 2020 by Jehan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/Jehan/gimp-issue-1082-transparent-window