Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.6k
    • Issues 1.6k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 240
    • Merge requests 240
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !1209

Adwaita: Avoid directly coloring labels wherever possible (GTK4)

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged nana-4 requested to merge nana-4/gtk:dont-color-labels-directly-gtk4 into master Nov 25, 2019
  • Overview 9
  • Commits 2
  • Pipelines 2
  • Changes 5

Directly coloring labels can create a lot of unintended behaviors. Unfortunately we can't avoid directly coloring label:disabled because it can be used individually. This, however, tries to inherit color from the parent element of labels wherever possible.

Fixes #1643 (closed)

Before/After:

image image

This also fixes the button's label color on the selected row;

image image

and also fixes the modelbutton's label color when an app has .devel class (only happened in gtk4):

image image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dont-color-labels-directly-gtk4