Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,607
    • Issues 1,607
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 221
    • Merge requests 221
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !1114

Fix reuse of list box header widgets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gtk:list-box-headers into master Oct 04, 2019
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 1

gnome-software reuses a header widget in its GsUpdatesSection list box. If the order of header row update calls happens in the wrong way, that widget ends up unparented but still in the list box’s forall iteration. See the commit messages for more details.

If this is accepted, can it please be backported to gtk-3-24? It applies cleanly there. gnome-software uses GTK 3.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: list-box-headers