Skip to content

Ensure to emit GDK_SELECTION_NOTIFY on all circumstances

Carlos Garnacho requested to merge wip/carlosg/ensure-selection-notify into gtk-3-24

I read on #fedora-desktop that there were DnD issues in nautilus, gave it a try and came up with these patches. Downstream bug is https://bugzilla.redhat.com/show_bug.cgi?id=1648569

The gist is that when you have files copied in the clipboard and try to drag another file to another nautilus window, nautilus then 1) checks clipboard and dnd content, and unsets the clipboard in result, while 2) at the same time, a number of places in nautilus are asynchronously requesting clipboard content in order to update menu item sensitivities and whatnot, and of course 3) dnd drop is going on.

This results in clipboard request being left stale, which botches internal state (until the retrieval timeout in gtkselection.c kicks in) an later DnD operations.

Merge request reports