Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,497
    • Issues 1,497
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 251
    • Merge requests 251
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gtkgtk
  • Merge requests
  • !1057

Ensure to emit GDK_SELECTION_NOTIFY on all circumstances

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Carlos Garnacho requested to merge wip/carlosg/ensure-selection-notify into gtk-3-24 Aug 20, 2019
  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 3

I read on #fedora-desktop that there were DnD issues in nautilus, gave it a try and came up with these patches. Downstream bug is https://bugzilla.redhat.com/show_bug.cgi?id=1648569

The gist is that when you have files copied in the clipboard and try to drag another file to another nautilus window, nautilus then 1) checks clipboard and dnd content, and unsets the clipboard in result, while 2) at the same time, a number of places in nautilus are asynchronously requesting clipboard content in order to update menu item sensitivities and whatnot, and of course 3) dnd drop is going on.

This results in clipboard request being left stale, which botches internal state (until the retrieval timeout in gtkselection.c kicks in) an later DnD operations.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wip/carlosg/ensure-selection-notify