Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,603
    • Issues 1,603
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 220
    • Merge requests 220
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Issues
  • #5544
Closed
Open
Issue created Jan 24, 2023 by Bart Jacobs@btj

Reset chars_changed_stamp in _gtk_text_btree_unref

Using a TextIter after it has been invalidated by changes to the contents of a TextBuffer causes a helpful warning. However, using it after the TextBuffer has been disposed, but before the TextBuffer's memory is overwritten, does not. I propose that a line tree->chars_changed_stamp = 0; be added to _gtk_text_btree_unref so that this scenario also causes a helpful warning.

After this change, it seems fine for language bindings to treat TextIter records as plain values. Without this change, language bindings have to take special measures to ensure that a live TextIter keeps the TextBuffer alive.

Assignee
Assign to
Time tracking