gtkmediafile/gst: Doesn't handle pixel-aspect-ratio
Not all pixels are square unfortunately, so simply returning the width/height from the GstVideoFrame
as width/height of the paintable is not going to result in useful frames.
I don't know how the GdkPaintable
API is supposed to work, so I'm just creating an issue.
I see that there's an "intrinsic aspect ratio", which I assume is a display aspect ratio. So presumably width/height need to be scaled accordingly between the texture and gst paintable, aspect ratio be returned according, and then during snapshotting the paintable needs to be scaled to convert the underlying texture to square pixels.
This test file reproduces the problem: test . It should be shown 16:9 but instead is shown 3:2.
CC @otte
Edited by Sebastian Dröge