Entry icons steal size from :width-chars and don't get unset cleanly
Entry icons have a couple of suboptimal cases that I noticed.
-
If you have a
:width-chars
that is suitable to show your values, but then add an icon to the entry, the icon appears over the left/right of the value and obscures it, meaning you can't see the width you want. What happens is that we request size for the larger of (:primary-icon
+:secondary-icon
) or the:text
. Should these perhaps be additive instead? But it seems hard to change that in 3 without throwing off the size of existing applications. -
Unsetting an icon (by
NULL
ing any property that sets it, which callsgtk_entry_clear_icon()
) does not free up that space to show the value again; rather, we leave an empty region and show a vertical dashed line if clipping the value at that side; clipping continues as above. Shouldn't it restore the entry to a state as if it had never had any icon set there?
quick screenshot showing both: :width-chars = 30
, :text = "012345678901234567890123456789"
, set and then unset :primary-icon-name
: