1. 02 Feb, 2018 7 commits
  2. 01 Feb, 2018 6 commits
  3. 31 Jan, 2018 4 commits
  4. 30 Jan, 2018 4 commits
  5. 28 Jan, 2018 1 commit
  6. 27 Jan, 2018 5 commits
  7. 26 Jan, 2018 3 commits
  8. 24 Jan, 2018 2 commits
  9. 23 Jan, 2018 3 commits
  10. 22 Jan, 2018 3 commits
    • Daniel Boles's avatar
      Widget: Don’t call reset() on NULL EventController · b91fc17a
      Daniel Boles authored
      GtkGesture is a GtkEventController. gtk_event_controller_dispose() calls
      _gtk_widget_remove_controller(). That NULLs the pointer-to-Controller in
      our EventControllerData but does not delete said ECData from our GList.
      
      Subsequently, if that same Widget gets unparent()ed, that method calls
      unset_state_flags(), which leads to doing reset_controllers() if we are
      insensitive. Now, unlike most most other loops over the GList of ECData,
      reset_controllers() does not skip nodes whose pointer-to-Controller is
      NULL. So, we call gtk_event_controller_reset(NULL) and get a CRITICAL.
      
      This surfaced in a gtkmm program. The Gesture is destroyed before the
      Widget. The Widget then gets dispose()d, which calls unparent()… boom.
      I didn’t find an MCVE yet but would hope this logic is correct anyway:
      
      The simplest fix is to make the loop in gtk_widget_reset_controllers()
      skip GList nodes with a NULL Controller pointer, like most other such
      loops, so we avoid passing the NULL to gtk_event_controller_reset().
      
      In other, live cases, _gtk_widget_run_controllers() loops over the GList
      and removes/frees nodes having NULL Controllers, so that should suffice.
      But this clearly was not getting a chance to happen in the failing case.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=792624
      b91fc17a
    • Administrator's avatar
      Update Esperanto translation · 37482c81
      Administrator authored
      (cherry picked from commit 814c55d4)
      37482c81
    • Juan Pablo Ugarte's avatar
      GtkGestureMultiPress: check event state before emiting released signal · f2019e61
      Juan Pablo Ugarte authored and Carlos Garnacho's avatar Carlos Garnacho committed
      Fix bug 771986 "Inconsistent 'row-activated' signal emission before \
      drag'n'drop, 'activate-on-single-click'=TRUE, 'reorderable'=TRUE"
      f2019e61
  11. 21 Jan, 2018 2 commits