1. 11 May, 2022 1 commit
  2. 07 Jan, 2022 1 commit
    • Christian Hergert's avatar
      textview: remove drag selection after dnd move action · e14d6fe9
      Christian Hergert authored
      If we have a GDK_ACTION_MOVE, we need to delete the selection. However,
      previously this only worked when the drop target and drag source were
      different applications, as the selection would get messed up along the
      way.
      
      Instead, we stash marks for the duration of the operation so that we can
      delete the appropriate selection when completing the move.
      e14d6fe9
  3. 26 Dec, 2021 1 commit
    • Christian Hergert's avatar
      textview: scroll insert onscreen after undo/redo · 344ad035
      Christian Hergert authored
      After performing an action such as undo/redo, we need to actually scroll
      to the position where the operation occurred.
      
      I do note that the scroll here seems to often get invalidated if it is
      pages away, and we never make the full scroll. But I've seen this all over
      the place elsewhere too and that needs to be handled, most likely, as a
      more comprehensive fix for scrolling during line validation.
      
      Related #4575
      344ad035
  4. 03 Dec, 2021 1 commit
  5. 02 Dec, 2021 1 commit
    • Matthias Clasen's avatar
      textview: Improve scroll-to-mark behavior · 67ad5661
      Matthias Clasen authored
      The idea of within-margin is to scroll as little
      as possible to bring the mark within the margins
      defined by the factor. The code was achieving
      that when scrolling down, but not when scrolling
      up. This change makes things symmetrical.
      
      Fixes: #4325
      67ad5661
  6. 01 Dec, 2021 1 commit
    • Matthias Clasen's avatar
      textview: Avoid misplacing the Emoji chooser · b3b03216
      Matthias Clasen authored
      When the iter is at the end of the buffer,
      gtk_text_view_get_iter_location returns a
      rectangle with width 0, which in turn makes
      gdk_rectangle_intersect return FALSE.
      
      Avoid that by always giving the rectangle
      non-empty dimensions.
      
      Fixes: #4503
      b3b03216
  7. 30 Nov, 2021 1 commit
  8. 08 Nov, 2021 2 commits
    • Matthias Clasen's avatar
      textview: Don't leave embedded children behind · 4c029af6
      Matthias Clasen authored
      When scrolling embedded widgets out of view,
      they sometimes get left behind because we don't
      reallocated them. To avoid that, move _all_ children
      out of view in size_allocate, and let the current
      child allocation plumbing move the visible ones
      back in place.
      4c029af6
    • Matthias Clasen's avatar
      Remove a confusing comment · 1c6efea3
      Matthias Clasen authored
      It talks about propagating to unanchored children,
      but then iterates over anchored_children. That does
      not add up.
      1c6efea3
  9. 23 Sep, 2021 1 commit
    • Christian Hergert's avatar
      textview: improve undo grouping when overwriting · 65939304
      Christian Hergert authored
      We want to group in more than one undo group when removing a selection
      and replacing it with a new character or characters, unless we're
      replacing a single character. In that case, the natural thing is to treat
      it as an atomic change.
      65939304
  10. 21 Sep, 2021 1 commit
    • Jordan Yelloz's avatar
      gtktextview: Fixed arrow key crash. · 5f913e95
      Jordan Yelloz authored
      When pressing the keyboard arrows to move around when the insertion point is
      hidden, it causes an assertion error in blink_cb.
      
      Insertion point blinks should only be scheduled when blinking is enabled and the
      insertion point is visible.
      
      Closes #4275
      5f913e95
  11. 18 Sep, 2021 1 commit
  12. 04 Sep, 2021 1 commit
    • Matthias Clasen's avatar
      textview: Invalidate Pango contexts · 754212d0
      Matthias Clasen authored
      We need to invalidate the Pango contexts when
      font settings change. Use the new helper
      gtk_widget_update_pango_context to make it less
      likely that we forget to update some things.
      754212d0
  13. 27 Aug, 2021 2 commits
  14. 26 Aug, 2021 3 commits
  15. 22 Aug, 2021 1 commit
  16. 19 Aug, 2021 1 commit
  17. 18 Aug, 2021 1 commit
  18. 05 Aug, 2021 1 commit
  19. 03 Aug, 2021 2 commits
  20. 29 Jul, 2021 2 commits
  21. 08 Jul, 2021 1 commit
    • Christian Hergert's avatar
      joinedmenu: add helper to join menus instead of nesting · d63d9b23
      Christian Hergert authored
      In many cases, we have an "extra-menu" property that is used to allow
      applications to join menus into the native menu for the widget. Previously,
      this was done by nesting that menu in a section.
      
      Doing so increases the complexity of the rules for GtkMenuTracker as you
      may want different handling from inside of the section vs toplevel
      sections.
      
      If instead we synthetically glue the menus together, we have a much more
      natural joining of menus as the application developer would expect for
      their menu.
      
      This also ports GtkLabel, GtkText, GtkPasswordEntry, and GtkTextView to
      use the joined menu helper.
      
      The joined menu helper comes originally from GNOME Builder and has had
      extensive use there.
      
      Fixes #4094
      d63d9b23
  22. 19 Jun, 2021 1 commit
    • Christian Hergert's avatar
      textview: give application developers access to RTL and LTR context · a6101f01
      Christian Hergert authored
      This allows developers to modify the pango context that is used when
      rendering text within the text view.
      
      Such access can be useful to alter how rounding occurs with API such as
      pango_context_set_round_glyph_positions() and is needed by GtkSourceView
      for proper placement of glyphs within the overview map.
      a6101f01
  23. 22 May, 2021 2 commits
  24. 21 May, 2021 1 commit
    • Matthias Clasen's avatar
      docs: Reduce redundancy · 4a0d3d7a
      Matthias Clasen authored
      Remove a boatload of "or %NULL" from nullable parameters
      and return values. gi-docgen generates suitable text from
      the annotation that we don't need to duplicate.
      
      This adds a few missing nullable annotations too.
      4a0d3d7a
  25. 20 May, 2021 2 commits
  26. 03 May, 2021 1 commit
  27. 26 Mar, 2021 1 commit
  28. 11 Mar, 2021 5 commits