input: Drop legacy text input module

See merge request !5476

This wayland protocol was merely some scaffolding until the
text_input protocol shaped up and took over. Nowadays this
could only ever help with really old versions of Mutter
(pre 3.28). This can be simply removed nowadays.

Fixes incorrect grabbing behaviour causing subsequent rejection of input

See merge request !5212

Revert "Revert "wayland: Add support for gtk_surface1_titlebar_gesture()""

See merge request !5452

This reverts commit 5aaa373b

Revert "wayland: Add support for gtk_surface1_titlebar_gesture()"

See merge request !5451

This reverts commit 45ba6e93.

This caused regressions in libhandy-using applications.

Fixes: #5389

Backport "gdk/wayland: set requesting surface to xdg-activation" to gtk-3-24

See merge request !5398

gl: Synchronize when calling MakeCurrent

See merge request !5448

Joan Bruguera authored Dec 04, 2022 and Carlos Garnacho committed Jan 27, 2023

The argument to xdg_activation_token_v1_set_surface is documented to be the
surface requesting the activation, not the surface to be activated, which is
given later when calling xdg_activation_v1_activate.
(c.f. https://gitlab.freedesktop.org/wayland/wayland-protocols/-/commit/36cee4bdbcaf3a75f567315809953b5e21d703da)

Use the same logic as in gdk_wayland_app_launch_context_get_startup_notify_id,
i.e. if we have a surface with focus, set that, otherwise set NULL.

This fixes requesting urgent/focus on wlroots (compositors like Sway, etc.),
which was blocked as the surface requesting the activation didn't have focus.

Backport of: 43c1a433



Signed-off-by: Joan Bruguera <joanbrugueram@gmail.com>

When making out GL context current, wait
until the GPU is done with commands from
the previous context.

Fixes: #5517

Consider startup vs focus requests for the Wayland platform [3.24]

See merge request !5443

This should do nothing worthwhile anymore, the X11/Wayland GtkApplication
implementations do already pass the startup ID from the platform_data
via windowing specific APIs, and the application handling the request
via show()/present() should trigger the activation request.

(cherry-picked from commit 3526d8b2)

While this used to be tangential to windows showing or requesting
focus, the xdg-activation Wayland protocol does merge both concepts
together.

But also, for a correct interaction with the compositor, the
toolkit should ideally merge the activation request resulting from
both into the same one, so that the gdk_window_focus() request
replies to the startup token that started the application and
correct focus-stealing prevention/etc happens, instead making up
one just in time for the focus request.

This kind of requires doing things in the right order, a show()
request on the GtkWindow should activate any pending activation
token on the toplevel, a present() request should additionally
create a new token if there was none pending. And
xdg_activation_v1_activate() should happen once on both.

Shuffle the gdk_window_set_startup_id() calls so that this
happens in the right order for Wayland, while making X11 happy
too.

(cherry-picked from commit e8adfa2a)

In the way towards deprecating gdk_display_notify_startup_complete(),
make gdk_toplevel_set_startup_id() on X11 perform this piece of messaging
itself. It should be harmless that the message is emitted twice, if
callers do still use that API.

(cherry-picked from commit 7fab1b85)

This call has everything to perform activation as specified by the
xdg_activation protocol, notably a surface to activate as opposed to
gdk_notify_startup_complete().

Make activation happen here, so that the surface gets activated when
its gets a startup ID assigned.

(cherry-picked from commit 5aeabdb3)

Move the handling of the startup ID to a separate function, since
this will be called from several places.

(cherry-picked from commit 6f01f846)

Take UI scale into acount when loading "image-missing" fallback

See merge request !5438

Fallback icons loaded were loading at half size (for a 2x scale) and for
cases where it mattered, were being positioned off-center.

The cairo surface must be padded to 4 pixels in order to
transfer correctly to the GPU. The GdkWindow and GdkNSView's
content frame must be the same width, otherwise there's a mismatch
that causes either the GdkWindow to draw wider than the frame or the
frame to be clipped narrower than the title bar.

Fixes #5535.

Matteo Percivaldi authored Jan 13, 2023 and Matthias Clasen committed Jan 13, 2023

This was causing animation and transition to stop randomly and reset
their state to initial state.

This issue has existed since commit
7b68bdb8.

Closes #4426

Backport "filechoosernativewin32: Set default extension"

See merge request !5403

Setting the default extension before a filter is selected allows
the IFileDialog to automatically change the extension when the
filter is changed. See:
https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifiledialog-setdefaultextension

Treat XKB_MOD_NAME_LOGO as super key

See merge request !5387

Loosely based on !5304, which fixes #4913 for GTK3.

build: Fix build_gir logic

See merge request !5371

This reverts commit 3a871c91.

This broke one of our tests.

clipboard: improve EOL conversion of plain text

See merge request !5366

Handle the case of clipboard text with CR line endings

[GTK3] gtkimcontextwayland: Convert byte based offset to char based offset in delete_surrounding_text

See merge request !5255