1. 21 Dec, 2020 1 commit
  2. 21 Sep, 2020 2 commits
  3. 14 Sep, 2020 1 commit
  4. 31 Aug, 2020 1 commit
  5. 30 Aug, 2020 1 commit
  6. 26 Aug, 2020 2 commits
    • Emmanuele Bassi's avatar
      Merge branch 'wip/lantw/build-Move-gtk.def-to-builddir' into 'gtk-2-24' · 2b3d6589
      Emmanuele Bassi authored
      build: Move gtk.def to builddir
      
      See merge request !2481
      2b3d6589
    • Ting-Wei Lan's avatar
      build: Move gtk.def to builddir · f203b1a7
      Ting-Wei Lan authored
      GTK2 uses different gtk.def files on 32-bit and 64-bit Windows. GTK2
      source tarballs ship pre-generated gtk.def for 32-bit Windows. If the
      user wants to build for 64-bit Windows, the pre-generated gtk.def must
      be deleted before the build to force regeneration, or it will fail to
      link with 'symbol not defined' errors because the 32-bit Windows build
      includes more legacy functions than the 64-bit Windows build.
      
      While users who want to build for 64-bit Windows can delete gtk.def in
      the build script, which is currently what most build scripts do, doing
      so breaks out-of-source build. On AUR, MinGW packages are usually built
      and packaged in the following order:
      
      1. Run 'configure' and 'make' to build for i686-w64-mingw32.
      2. Run 'configure' and 'make' to build for x86_64-w64-mingw32.
      3. Run 'make install' for i686-w64-mingw32.
      4. Run 'make install' for x86_64-w64-mingw32.
      
      It fails because step 3 sees gtk.def left by step 2, which is generated
      for a different build. In step 3, make sees the gtk.def change and runs
      libtool to relink libgtk-win32-2.0-0.dll. libtool fails to find a lot of
      necessary libraries, decides that it is not possible to build a DLL with
      -no-undefined, and produces only the static library. It then tries to
      relink executables with the static library, and fails with undefined
      reference to 'IID_IUnknown' because -Wl,--start-group isn't used and
      the use of -Wl,-luuid prevents libtool from using the correct order.
      
      To resolve the problem, move gtk.def to builddir so different builds can
      have different gtk.def files while sharing the same source tree. This
      also means that the source tarball will no longer include pre-generated
      gtk.def file, which should be acceptable because it is already broken on
      64-bit Windows.
      
      Fixes #3029
      f203b1a7
  7. 29 Jul, 2020 1 commit
  8. 28 Jul, 2020 1 commit
  9. 01 May, 2020 2 commits
  10. 14 Jan, 2020 1 commit
  11. 16 Nov, 2019 2 commits
  12. 07 Oct, 2019 3 commits
  13. 03 Sep, 2019 4 commits
  14. 25 Aug, 2019 1 commit
  15. 06 Aug, 2019 1 commit
    • John Lindgren's avatar
      Fix use-after-free due to unexpected unref of context->default_style. · 539a596e
      John Lindgren authored
      Segfault occurred when displaying two windows on different X11 displays.
      
      valgrind said:
      
      Invalid read of size 8
        at 0x4A20962: _gtk_style_init_for_settings (gtkstyle.c:398)
        by 0x49ED785: gtk_rc_get_style (gtkrc.c:2036)
        by 0x4AC39C2: gtk_widget_reset_rc_style (gtkwidget.c:6601)
      Address 0x70b8e80 is 560 bytes inside a block of size 1,024 free'd
        at 0x48399AB: free (vg_replace_malloc.c:530)
        by 0x51180D6: g_type_free_instance (in /usr/lib/libgobject-2.0.so.0.6000.6)
        by 0x49E98CE: gtk_rc_reset_styles (gtkrc.c:1702)
        by 0x49E9A0C: _gtk_rc_context_get_default_font_name (gtkrc.c:1740)
        by 0x4A20961: _gtk_style_init_for_settings (gtkstyle.c:396)
        by 0x49ED785: gtk_rc_get_style (gtkrc.c:2036)
        by 0x4AC39C2: gtk_widget_reset_rc_style (gtkwidget.c:6601)
      Block was alloc'd at
        at 0x483877F: malloc (vg_replace_malloc.c:299)
        by 0x51BD289: g_malloc (in /usr/lib/libglib-2.0.so.0.6000.6)
        by 0x519F673: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.6000.6)
        by 0x51A62BA: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.6000.6)
        by 0x5119141: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.6000.6)
        by 0x513563D: ??? (in /usr/lib/libgobject-2.0.so.0.6000.6)
        by 0x5136A54: g_object_new_with_properties (in /usr/lib/libgobject-2.0.so.0.6000.6)
        by 0x5136B51: g_object_new (in /usr/lib/libgobject-2.0.so.0.6000.6)
        by 0x49ED774: gtk_rc_get_style (gtkrc.c:2035)
        by 0x4AC39C2: gtk_widget_reset_rc_style (gtkwidget.c:6601)
      539a596e
  16. 18 Jun, 2019 2 commits
    • Chun-wei Fan's avatar
      Visual Studio builds: Fix previous commit · cd196c4f
      Chun-wei Fan authored
      I forgot to include configure.ac in the commit, which is needed.
      cd196c4f
    • Chun-wei Fan's avatar
      Visual Studio builds: "Add" Visual Studio 2019 projects · a63b70f1
      Chun-wei Fan authored
      Copy and update the relevant fields from the Visual Studio 2010 projects
      so that we can have project files that work out-of-the-box for Visual
      Studio 2019, as we did for Visual Studio 2012 through 2017.
      
      Also update the NMake Makefiles for building the introspection files
      so that we properly detect that we are building with Visual Studio 2019.
      a63b70f1
  17. 15 Mar, 2019 1 commit
  18. 14 Mar, 2019 1 commit
    • LRN's avatar
      Fix UAC manifest RC file · 6ae30826
      LRN authored
      CREATEPROCESS_MANIFEST_RESOURCE_ID is a macro defined in winbase.h,
      so we need an include to resolve that macro to its value, 1.
      
      Without that it stays as a literal CREATEPROCESS_MANIFEST_RESOURCE_ID,
      and ends up in the .exe file as-is, and Windows can't find it by that name,
      resulting in UAC manifest not working and gtk-update-icon-cache bringing
      up UAC prompt.
      6ae30826
  19. 12 Mar, 2019 2 commits
  20. 06 Mar, 2019 2 commits
  21. 21 Jan, 2019 1 commit
    • Chun-wei Fan's avatar
      MSVC introspection: Make more robust and avoid confusion · 6b558981
      Chun-wei Fan authored
      This updates the introspection build process that we also check on
      changes in the Makefiles when we generate the NMake Makefile snippets
      and file lists, so that any changes to the source file list can be
      reflected.  Also ensure that we build against the freshly-built
      libraries.
      
      Make the NMake Makefiles also output the built introspection items to
      the output directories of the various Visual Studio versions, according
      to the build configuration and architecture, so that we avoid confusion
      for different Visual Studio build configs.
      6b558981
  22. 09 Jan, 2019 1 commit
  23. 04 Jan, 2019 1 commit
  24. 21 Dec, 2018 5 commits
    • Chun-wei Fan's avatar
      Merge branch 'gtk-2-24.win.fixes' into 'gtk-2-24' · 8042e078
      Chun-wei Fan authored
      gtk/gtkiconcache.c: Fix running on GLib-2.57.3 or later on Windows
      
      See merge request !469
      8042e078
    • Chun-wei Fan's avatar
      gtk/gtkiconcache.c: Fix running on GLib-2.57.3 or later on Windows · 4612f0b3
      Chun-wei Fan authored
      In GLib-2.57.3 and later, GStatBuf may not be a struct stat on Windows,
      depending on the architecture and the compiler used, so we can't just
      call fstat() on the GStatBuf.
      
      Instead, we need to use the correct CRT function to call on the
      GStatBuf, which is as follows:
      
      -_fstat32() for Windows 32-bit builds on mingw-w64 and MSVC
      -_fstat64() for Windows 64-bit builds on mingw-w64
      -stat() for Windows 64-bit builds on MSVC, and on all other platforms.
      4612f0b3
    • Chun-wei Fan's avatar
      MSVC builds: Fix pkg-config file generation · 16682dd2
      Chun-wei Fan authored
      We are not passing in the correct architecture to the script that we use
      to generate the pkg-config files for Release/x86 builds and Debug/x64
      builds.  Fix this.
      16682dd2
    • Chun-wei Fan's avatar
      MSVC builds: Improve pkg-config files generation · 0b7ee988
      Chun-wei Fan authored
      Just link to Cairo instead of looking for the Cairo .pc file as the
      Cairo build system for Visual Studio currently does not generate a
      pkg-config file for us.  This will eliminate the need to hand-craft a
      pkg-config file for Cairo to be able to use the pkg-config files that we
      generate here.
      0b7ee988
    • Chun-wei Fan's avatar
      [gdk|gtk]/Makefile.am: Fix CFlags passed to introspecion on MSVC · 639688d3
      Chun-wei Fan authored
      Don't pass in G_LOG_DOMAIN=\"...\" to the CFlags that is passed into the
      generation the NMake Makefiles.  This will avoid the introspection scanner
      from choking because the resulting NMake Makefiles may not have that
      CFlag escaped properly, and it is not really needed for building the
      introspection binary.
      639688d3