1. 12 Apr, 2004 1 commit
    • Matthias Clasen's avatar
      Typo fix. · d7cb9461
      Matthias Clasen authored
      2004-04-12  Matthias Clasen  <mclasen@dhcp64-228.boston.redhat.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
      	a shadow inside the scrolled window, add it around the vbox.
      
      	* gtk/gtkentryprivate.h:
      	* gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
      	Return a boolean indicating whether the popup is positioned above
      	or below. Scroll the completions to the beginning or the end,
      	depending on the positioning.
      
      	* gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
      	wrap around in the entry completion popup, and allow GDK_UP to
      	enter the popup.  (#137440)
      
      2004-04-12  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
      	there before using it.
      d7cb9461
  2. 11 Apr, 2004 1 commit
    • Jonathan Blandford's avatar
      Moved search entries into priv data. · 0aebe343
      Jonathan Blandford authored
      Sun Apr 11 15:08:45 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtktreeprivate.h: Moved search entries into priv data.
      
              * gtk/gtktreeview.c: Prep for type-ahead support.
      
              (gtk_tree_view_destroy): Destroy the search window explicitly.
              (gtk_tree_view_key_press): Minor change; prep for type-ahead
              (gtk_tree_view_ensure_interactive_directory): New function
              (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
              (gtk_tree_view_real_start_interactive_search): rework
              (gtk_tree_view_search_dialog_hide): ditto
              (gtk_tree_view_search_delete_event): ditto
              (gtk_tree_view_search_button_press_event): ditto
              (gtk_tree_view_search_key_press_event): ditto
              (gtk_tree_view_search_move): ditto
              (gtk_tree_view_search_init): ditto
      
              * gtk/gtktreeviewcolumn.c:
              (gtk_tree_view_column_cell_layout_clear): remove unused variable.
      
              * tests/testfilechooser.c: (main): change
      0aebe343
  3. 02 Apr, 2004 1 commit
  4. 15 Mar, 2004 1 commit
    • Owen Taylor's avatar
      Mention GtkTreeViewSearchEqualFunc return value oddity here as well. · 6bc9b7f5
      Owen Taylor authored
      Sun Mar 14 22:32:36 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Mention
              GtkTreeViewSearchEqualFunc return value oddity here as well.
      
              * gtk/gtktreeview.c (gtk_tree_view_search_equal_func): On failure
              to get a string to compare to, return TRUE (no match), not
              FALSE (match). Handle %NULL string values gracefully.
              Remove unused variable. (#135962, Mark McLoughlin)
      6bc9b7f5
  5. 06 Mar, 2004 1 commit
  6. 05 Mar, 2004 2 commits
    • Jonathan Blandford's avatar
      scroll to the new path. · 48bfdd51
      Jonathan Blandford authored
      Fri Mar  5 18:00:36 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c (new_folder_button_clicked): scroll
              to the new path.
      
              * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update the
              allocation when scrolling instead of cancelling editing.
      48bfdd51
    • Matthias Clasen's avatar
      Clarify the doc comment. (#118602) · 61fd5219
      Matthias Clasen authored
      Fri Mar  5 23:37:16 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreeview.c (gtk_tree_view_set_reorderable): Clarify the
      	doc comment.  (#118602)
      61fd5219
  7. 24 Feb, 2004 1 commit
  8. 15 Feb, 2004 1 commit
    • Matthias Clasen's avatar
      Document the tree DND API. · 6993105c
      Matthias Clasen authored
      Sun Feb 15 02:49:45 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreednd.c:
      	* gtk/gtktreeview.c: Document the tree DND API.
      
      	* gtk/gtktreeview.c (gtk_tree_view_unset_rows_drag_source):
      	Call gtk_drag_source_unset().
      6993105c
  9. 12 Feb, 2004 1 commit
  10. 02 Feb, 2004 2 commits
    • Matthias Clasen's avatar
      Add init_hadjust_value and prev_width. Initialize them here. ...and here. · 4ec8e2b2
      Matthias Clasen authored
      Tue Feb  3 00:15:17 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): Add
      	init_hadjust_value and prev_width.
      	* gtk/gtktreeview.c (gtk_tree_view_init): Initialize
      	them here.
      	* gtk/gtktreeview.c (gtk_tree_view_update_size): ...and here.
      	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Use them
      	here to properly handle the initial position of rtl-oriented
      	tree views.  (#127581, chinen@jp.ibm.com)
      4ec8e2b2
    • Federico Mena Quintero's avatar
      Fix #130846, reported by R. McFarland <rwmcfa1@neces.com>. · f480c797
      Federico Mena Quintero authored
      2004-01-20  Federico Mena Quintero  <federico@ximian.com>
      
      	Fix #130846, reported by R. McFarland <rwmcfa1@neces.com>.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): Return TRUE when
      	we handle an event in the colums, and FALSE at the end if the
      	event is not handled at all.
      f480c797
  11. 30 Jan, 2004 1 commit
    • Not Zed's avatar
      Fixes #132929. · ca644c41
      Not Zed authored
      2004-01-30  Not Zed  <NotZed@Ximian.com>
      
      	Fixes #132929.
      
      	* gtk/gtktreeview.c (cancel_arrow_animation): remove the timeout
      	handler when we clear the timeout id.
      ca644c41
  12. 23 Jan, 2004 1 commit
  13. 16 Jan, 2004 1 commit
    • Matthias Clasen's avatar
      The first part of the fix for #114351 (see also gdk-pixbuf/ChangeLog and · 07d4d314
      Matthias Clasen authored
      Fri Jan 16 23:59:01 2004  Matthias Clasen  <maclas@gmx.de>
      
      	The first part of the fix for #114351 (see also
      	gdk-pixbuf/ChangeLog and po/ChangeLog):
      
      	* gtk/gtkintl.h:
      	* gdk-pixbuf/gdk-pixbuf-i18n.h:
      	* gdk/gdkintl.h: Define P_() for property blurbs and nicks.
      
      	* gdk/gdkdisplaymanager.c:
      	* gdk-pixbuf/gdk-pixbuf.c:
      	* modules/input/gtkimcontextxim.c:
      	* gtk/*.c:  Mark property blurbs and nicks with P_().
      
      	* po/Makefile.in.in: Add --keyword=P_ to the xgettext
      	invocation, since property blurbs and nicks are
      	now marked with P_().
      07d4d314
  14. 15 Jan, 2004 1 commit
  15. 21 Dec, 2003 1 commit
    • Matthias Clasen's avatar
      Fix memory leaks caused by the failure to free the result of · 6a6455d7
      Matthias Clasen authored
      Sun Dec 21 23:17:01 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkuimanager.c (update_node):
      	(update_smart_separators):
      	(_gtk_menu_is_empty):
      	(find_menu_position):
      	* gtk/gtktreeview.c (gtk_tree_view_search_dialog_destroy):
      	* gtk/gtkcombobox.c (gtk_combo_box_relayout_item):
      	(gtk_combo_box_relayout): Fix memory leaks caused by the
      	failure to free the result of gtk_container_get_children().
      	(#127576, Yao Zhang)
      6a6455d7
  16. 20 Dec, 2003 1 commit
  17. 19 Dec, 2003 1 commit
  18. 18 Dec, 2003 3 commits
  19. 17 Dec, 2003 3 commits
    • Kristian Rietveld's avatar
      only try to strcmp or strlen if we managed to normalize and casefold the · b1187d9e
      Kristian Rietveld authored
      Wed Dec 17 23:31:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): only
      	try to strcmp or strlen if we managed to normalize and casefold
      	the string correctly. Fixes crashes with non-UTF8 strings.
      	(#121617, Patch from Tim-Philipp Müller).
      b1187d9e
    • Kristian Rietveld's avatar
      fix compile warning. (#122727, patch from Kjartan Maraas). · d1f4899f
      Kristian Rietveld authored
      Wed Dec 17 23:16:45 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix compile warning.
      	(#122727, patch from Kjartan Maraas).
      d1f4899f
    • Kristian Rietveld's avatar
      Yay! Fixed height mode! Hooray! (Part 2 of #80868). · f219093f
      Kristian Rietveld authored
      Wed Dec 17 21:23:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Yay! Fixed height mode! Hooray! (Part 2 of #80868).
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init),
      	(gtk_tree_view_init), (gtk_tree_view_set_property),
      	(gtk_tree_view_get_property), (gtk_tree_view_set_model): add a
      	fixed_height_mode property,
      	(intialize_fixed_height_mode), (do_validate_rows),
      	(column_sizing_notify), (gtk_tree_view_set_fixed_height_mode),
      	(gtk_tree_view_style_set), (gtk_tree_view_row_changed),
      	(gtk_tree_view_row_inserted), (gtk_tree_view_remove_column),
      	(gtk_tree_view_insert_column): implement fixed height mode,
      	(gtk_tree_view_append_column), (gtk_tree_view_insert_column),
      	(gtk_tree_view_insert_column_with_attributes),
      	(gtk_tree_view_insert_column_with_data_func): update docs.
      
      	* gtk/gtktreeprivate.h: add two fields to GtkTreePrivate.
      f219093f
  20. 13 Dec, 2003 1 commit
    • Kristian Rietveld's avatar
      A trick for a faster treeview, step 1. Patch to short circuit · 5f3cde77
      Kristian Rietveld authored
      Sat Dec 13 16:13:27 2003  Kristian Rietveld  <kris@gtk.org>
      
      	A trick for a faster treeview, step 1. Patch to short circuit
      	_build_tree(), inspired by Jonathan (#80868).
      
      	* gtk/gtktreeview.c (gtk_tree_view_init): don't put _IS_LIST in
      	flags by default,
      	(gtk_tree_view_build_tree): don't even try to recurse when the
      	model says that it is a list, remove flag unsetter,
      	(gtk_tree_view_set_model): change flag setting logic.
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_get_flags):
      	propagate whether or not the child model has _IS_LIST set.
      
      	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_get_flags):
      	ditto.
      5f3cde77
  21. 29 Nov, 2003 1 commit
  22. 21 Oct, 2003 1 commit
  23. 13 Oct, 2003 1 commit
  24. 19 Sep, 2003 1 commit
  25. 12 Sep, 2003 1 commit
    • Jonathan Blandford's avatar
      Merge from stable. · 9ded36af
      Jonathan Blandford authored
      Fri Sep 12 16:32:53 2003  Jonathan Blandford  <jrb@redhat.com>
      
      	Merge from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): only save the
      	pressed button (used to determine if we want to initiate a drag later
      	on) if the current grab widget is either NULL or tree_view (Reported
      	by Jeroen Zwartepoorte).
      9ded36af
  26. 09 Sep, 2003 1 commit
    • Kristian Rietveld's avatar
      Big TreeView DnD fixage, makes drops on empty models work, makes TreeStore · b78691f0
      Kristian Rietveld authored
      Wed Sep 10 01:06:44 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Big TreeView DnD fixage, makes drops on empty models work, makes
      	TreeStore DnD work and gets rid of gtk-tree-model-drop-append.
      	Related bugs #95362 and #113314. I don't want to touch this code
      	ever again.
      
      	* gtk/gtktreeprivate.h (GtkTreePrivate): add empty_view_drop field.
      
      	* gtk/gtktreednd.c (gtk_tree_get_row_drag_data): add check
      	for selection_data->length.
      
      	* gtk/gtktreeview.c (struct DestRow), (dest_row_free),
      	(set_dest_row), (get_dest_row): we don't store just the row ref
      	anymore, but a struct with the row ref and additional info,
      	(set_destination_row): handle drops on empty space and some
      	style fixes,
      	(get_logical_dest_row): also return path_down_mode/drop_append_mode
      	flags, handle dropping childs on their new parents, rewrite
      	drop append handling into something saner,
      	(gtk_tree_view_drag_motion): show a "drop possible arrow" on empty
      	spaces,
      	(gtk_tree_view_drag_drop): updates for updated backend,
      	(gtk_tree_view_drag_data_received): updates for updated backend,
      	path down mode (treestore DnD) handling,
      	(gtk_tree_view_set_drag_dest_row): set empty_view_drop flag,
      	when we are trying to drop a row on an empty model,
      	(gtk_tree_view_get_drag_dest_row): handle empty_view_drop flag.
      
      	* gtk/gtkliststore.c (gtk_list_store_drag_data_received),
      	(gtk_list_store_row_drop_possible): style and drop-append fixes.
      
      	* gtk/gtktreestore.c (gtk_tree_store_drag_data_received): ditto.
      b78691f0
  27. 02 Sep, 2003 1 commit
    • Kristian Rietveld's avatar
      Merge from stable. · e5efd714
      Kristian Rietveld authored
      Tue Sep  2 21:01:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merge from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): revert the change
      	to only select when button 1 is pressed introduced in the fix of
      	bug #120187.
      e5efd714
  28. 25 Aug, 2003 1 commit
    • Kristian Rietveld's avatar
      Merge from stable. · 43d99929
      Kristian Rietveld authored
      Mon Aug 25 23:21:43 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merge from stable.
      
      	Fixes #115871, reported by Michael Natterer.
      
      	* gtk/gtktreeprivate.h: added GtkTreeSelectMode enum,
      	added ctrl_pressed and shift_pressed bitfields,
      	(_gtk_tree_selection_internal_select_node): replace GdkModifierType
      	arg with GtkTreeSelectMode.
      
      	* gtk/gtktreeselection.c (gtk_tree_selection_set_mode),
      	(gtk_tree_selection_select_path), (gtk_tree_selection_unselect_path),
      	(_gtk_tree_selection_internal_select_node): all updated for
      	GdkModifierType -> GtkTreeSelectMode move.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): set ctrl_pressed
      	and shift_pressed around selection handling block,
      	(gtk_tree_view_real_select_cursor_row),
      	(gtk_tree_view_real_toggle_cursor_row),
      	(gtk_tree_view_real_selection_cursor_parent),
      	(gtk_tree_view_real_set_cursor): use ctrl_pressed and shift_pressed,
      	instead of checking the event state. And also updates for the
      	GdkModifierType -> GtkTreeSelectMode move.
      43d99929
  29. 21 Aug, 2003 1 commit
    • Kristian Rietveld's avatar
      Slightly modified patch from Yann Rouillard to improve selection behavior · 28a466a6
      Kristian Rietveld authored
      Thu Aug 21 20:53:46 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Slightly modified patch from Yann Rouillard to improve selection
      	behavior with the mouse. Fixes #120187.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): only
      	select/deselect items on the first button press of button 1,
      	expand checks for row_activated to include triple clicks.
      28a466a6
  30. 15 Aug, 2003 2 commits
    • Kristian Rietveld's avatar
      Merged from stable. · 4254bdbb
      Kristian Rietveld authored
      Fri Aug 15 21:57:34 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): stop editing
      	on vertical scrolling. (#108035, reported by Tim Janik).
      4254bdbb
    • Kristian Rietveld's avatar
      (Note: This is not exactly the same as the patch which went in gtk-2-2). · 2e299387
      Kristian Rietveld authored
      Fri Aug 15 19:43:14 2003  Kristian Rietveld  <kris@gtk.org>
      
      	(Note: This is not exactly the same as the patch which went in
      	 gtk-2-2).
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init),
      	(gtk_tree_view_key_press), (gtk_tree_view_search_key_press_event):
      	Also support the up, down, left, right, home, end, page up and
      	page down keys on the numpad. (#119419, reported by Alex Larsson).
      2e299387
  31. 17 Jul, 2003 3 commits
    • Kristian Rietveld's avatar
      Merged from stable. · e733ed3e
      Kristian Rietveld authored
      Thu Jul 17 19:24:51 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	Fixes issues pointed out by Morten Welinder in #115140.
      
      	* gtk/gtktreeview.c (gtk_tree_view_size_request): fix comment,
      	(do_validate_rows): update validated_area with a logic OR instead
      	of a bitwise OR,
      	(validate_rows_handler): make the if statement match the one in
      	validate_rows(), so we don't leak the timeout.
      e733ed3e
    • Kristian Rietveld's avatar
      Merged from stable. · fd9992d8
      Kristian Rietveld authored
      Thu Jul 17 19:12:02 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_remove_widget): the treeview
      	should only grab focus back if the "cell_editable" widget still
      	has focus. (Fixes #110104, testcase provided by Marco Pesenti
      	Gritti).
      fd9992d8
    • Kristian Rietveld's avatar
      Merged from stable. · bdce65ea
      Kristian Rietveld authored
      Thu Jul 17 16:11:21 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_rows_reordered): stop editing
      	if needed. (Fixes #115869, reported by Michael Natterer).
      bdce65ea