1. 04 Dec, 2001 8 commits
    • Jonathan Blandford's avatar
      Minor fix. · 57506c43
      Jonathan Blandford authored
      Tue Dec  4 18:38:35 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* demos/gtk-demo/main.c: (create_tree): Minor fix.
      
      	* docs/tree-column-sizing.txt: Update
      
      	* gtk/gtkrbtree.[ch]: Massive work to support validation.
      
      	* gtk/gtktreemodel.c: Doc fixes.
      
      	* gtk/gtktreeview.c: Incremental reflow added.
      	* gtk/gtktreeviewcolumn.c: ditto
      	* gtk/gtktreeviewcolumn.h: ditto
      
      itty bitty ChangeLog entry.  Big 'ol changes.
      57506c43
    • Havoc Pennington's avatar
      add a warning for "invisible" property, #65999 · f6f43536
      Havoc Pennington authored
      2001-12-04  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktexttag.c (gtk_text_tag_set_property): add a warning for
      	"invisible" property, #65999
      f6f43536
    • Matt Wilson's avatar
      fixed docs · f27cf774
      Matt Wilson authored
      2001-12-04  Matt Wilson  <msw@redhat.com>
      
      	* gtk/gtktreestore.c (gtk_tree_store_insert): fixed docs
      f27cf774
    • Owen Taylor's avatar
      Simplify, make more efficient and fix memory leak when turning quark into · b36b2298
      Owen Taylor authored
      Tue Dec  4 12:16:31 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtksettings.c (gtk_settings_set_property_value):
      	Simplify, make more efficient and fix memory leak
      	when turning quark into a string. (#66103, HideToshi
      	Tajima)
      b36b2298
    • Owen Taylor's avatar
      Ref and sink priv->tooltips in init() and unref priv->tooltips in destroy · feca5a64
      Owen Taylor authored
      Tue Dec  4 12:06:13 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
      	init() and unref priv->tooltips in destroy rather
      	than calling gtk_object_destroy() which has no
      	effect on memory management. (#66104, HideToshi
      	Tajima)
      	* gtk/gtkcolorsel.c (palette_set_color): Use g_object_set_data_full()
      	so we free the when the object is freed. (Fixes memory
      	leak, #66096, HideToshi Tajima)
      	* gdk/gdkevents.c (gdk_synthesize_window_state): Use
      	a full GdkEvent structure to avoid reads of uninitialized/
      	invalid memory in gdk_event_put() (#65877, patch
      	from Hidetoshi Tajima)
      feca5a64
    • Owen Taylor's avatar
      Revert my last mistaken change - toggle-size-request doesn't take a · f84b1ed0
      Owen Taylor authored
      Tue Dec  4 11:06:54 2001  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmenuitem.c: Revert my last mistaken change -
              toggle-size-request doesn't take a requisition.
      
              * gtk/gtkmenuitem.c (gtk_menu_item_class_init): Fix
              reference to marshaler that no longer exists.
      f84b1ed0
    • Owen Taylor's avatar
      Patch from Bill Haneman (with many modifications) to make the focus color · 7537825b
      Owen Taylor authored
      Mon Dec  3 16:39:17 2001  Owen Taylor  <otaylor@redhat.com>
      
      	Patch from Bill Haneman (with many modifications) to make
      	the focus color work on dark themes and to make the
      	focus line width configurable. (#61079, #63074)
      
              * gtk/gtkwidget.c: Add style properties,
      	::focus-widget, ::focus-line-width, and ::focus-padding.
      
      	* gtk/gtkstyle.[ch]: Make gtk_paint_focus() take a
      	state argument as well so we can use fg[STATE] to
      	draw instead of always drawing with black.
      	Cange paint_focus() to respect GtkWidget::focus-width
      	and GtkWidget::focus-line-pattern. Fix continuity
      	problem where the default 1-1 stipple had a blob
      	in one corner and a gap in the other. Change the
      	interpretation of x/y/width/height to be the bounding
      	box of the focus rect instead of the rectangle
      	passed to gdk_draw_rectangle.
      
      	* gtk/gtkcheckbutton.c gtk/gtklistitem.c gtk/gtknotebook.c
      	gtk/gtkoptionmenu.c gtk/gtkradiobutton.c gtk/gtkspinbutton.c
      	gtk/gtktextview.c gtk/gtktreeview.c: Handle ::focus-width
      	and ::focus-line-padding.
      
      	* gtk/gtkentry.c: Handle :;focus-width property; cleanup
      	and remove duplicated code; fix drawing of focus rectangle
      	when interior-focus = FALSE. (#63072, #63073)
      
      	* gtk/gtkrange.c gtk/gtktext.c gtk/gtktreeitem.c
      	gtk/gtktreeviewcolumn.c: Basic fixups to make compile;
      	Range and TreeViewColumn will need more extensive fixing.
      
      	* gtk/gtkcolorsel.c: Honor focus line attributes when
      	drawing the focus on the color swatches. (#63071)
      
      	* gtk/gtkhsv.c: Honor focus line attributes when
      	drawing the focus for the ring and triangle.
      
      	* docs/widget_geometry.txt: Start at documenting how
      	various widgets are drawn.
      
      	* gtk/gtkbutton.c (_gtk_button_paint): Export
      	_gtk_button_paint() librarywide, so we don't have
      	duplicate a bunch of code in gtktogglebutton.c.
      
      	* gtk/gtktogglebutton.c: Use _gtk_button_paint().
      7537825b
    • Jonathan Blandford's avatar
      remove VOID:BOXED,POINTER and NONE:POINTER. and now everyone else has to · cac3ad31
      Jonathan Blandford authored
      Mon Dec  3 21:04:13 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtkmarshalers.list: remove VOID:BOXED,POINTER and
      	NONE:POINTER.
      and now everyone else has to recompile their GTK too.... (-:
      cac3ad31
  2. 03 Dec, 2001 4 commits
    • Alexander Larsson's avatar
      Return FALSE from expose handlers. · c7cd3421
      Alexander Larsson authored
      2001-12-03  Alex Larsson  <alexl@redhat.com>
      
      	* gtk/gtkaccellabel.c:
      	* gtk/gtkarrow.c:
      	* gtk/gtkcolorsel.c:
      	* gtk/gtkcontainer.c:
      	* gtk/gtklabel.c:
      	* gtk/gtktextview.c:
      	* gtk/gtktogglebutton.c:
      	* gtk/gtktreeview.c:
      	* gtk/gtkwindow.c:
      	Return FALSE from expose handlers.
      c7cd3421
    • Kristian Rietveld's avatar
      if we use pointers, we should free the previous pointer first (if it · 5a2ebedc
      Kristian Rietveld authored
      Mon Dec  3 21:15:59 2001  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreedatalist.c (_gtk_tree_data_list_value_to_node): if
              we use pointers, we should free the previous pointer first (if
              it exists), before we set a new pointer. (#64726)
      
              * gtk/gtktreeprivate.h: get rid of cursor_drag
      
              * gtk/gtktreeview.c (gtk_tree_view_unrealize): remove check
              for cursor_drag
              (gtk_tree_view_bin_expose): don't directly return in the while
              loop
              (gtk_tree_view_class_init): indentend expanders by default
              (gtk_tree_view_header_focus): only give the button focus
              if it's clickable, visible and the column is reorderable
              (#65539)
      
              * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_realize_button):
              create and free cursor
      5a2ebedc
    • Owen Taylor's avatar
      Fix some bugs with size requisition. (From Bill Haneman) Draw headers and · 168b7505
      Owen Taylor authored
      Mon Dec  3 10:23:07 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkcalendar.c (gtk_calendar_size_request): Fix
      	some bugs with size requisition. (From Bill Haneman)
      	* gtk/gtkcalendar.c: Draw headers and selection in
      	base/text[SELECTED] instead of fg/bg[SELECTED].
      	* gtk/gtkcalendar.c: Miscellaneous cleanups to drawing
      	code and formatting.
      168b7505
    • Havoc Pennington's avatar
      Hmm, setter functions normally assign the new value to the object field. · 35fcacbf
      Havoc Pennington authored
      2001-12-03  Havoc Pennington  <hp@pobox.com>
      
      	* gtk/gtktextview.c (set_window_height):
      	(set_window_width): Hmm, setter functions normally assign the new
      	value to the object field. Reported by Chris Phelps.
      35fcacbf
  3. 30 Nov, 2001 4 commits
    • jacob berkman's avatar
      set the signal id to 0 after we disconnect from it · 5e0b93dc
      jacob berkman authored
      2001-11-30  jacob berkman  <jacob@ximian.com>
      
      	* gtk/gtknotebook.c (gtk_notebook_remove_tab_label): set the
      	signal id to 0 after we disconnect from it
      5e0b93dc
    • Matthias Clasen's avatar
      Deprecate. · 101d4488
      Matthias Clasen authored
              * gdk/gdkdrawable.h (gdk_drawable_ref, gdk_drawable_unref),
              gdk/gdkcolor.h (gdk_colormap_ref, gdk_colormap_unref),
              gdk/gdkdnd.h (gdk_drag_context_ref, gdk_drag_context_unref),
              gdk/gdkgc.h (gdk_gc_ref, gdk_gc_unref):  Deprecate.
      
              * gdk/gdkvisual.h: Use GDK_DISABLE_DEPRECATED, not
              GTK_DISABLE_DEPRECATED.
      
              * gdk/gdkcolor.c (gdk_colormap_ref, gdk_colormap_unref),
              gdk/gdkgc.c (gdk_gc_ref, gdk_gc_unref): Document.
      
              * gdk/tmpl/colors.sgml, gdk/tmpl/pixmaps.sgml, gdk/tmpl/dnd.sgml,
              gdk/tmpl/gcs.sgml: Document ref and unref functions as deprecated.
      101d4488
    • Owen Taylor's avatar
      Sanitize move/resize code, removing various bad, non-functional hacks. · d2b64a0b
      Owen Taylor authored
      Fri Nov 30 16:37:01 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkcombo.c (gtk_combo_popup_list): Sanitize
      	move/resize code, removing various bad, non-functional
      	hacks. (Fixes #65048, reported by Damon Chaplin.)
      d2b64a0b
    • Owen Taylor's avatar
      Patch from Hidetoshi Tajima to fix bad match error when target drawable is · 845d3701
      Owen Taylor authored
      Fri Nov 30 16:12:21 2001  Owen Taylor  <otaylor@redhat.com>
      	* gdk/gdkpango.c: Patch from Hidetoshi Tajima to fix
      	bad match error when target drawable is not the
      	same depth as the root window. (#65841)
      	* HACKING: Update.
      845d3701
  4. 29 Nov, 2001 5 commits
    • Matthias Clasen's avatar
      Typo fix. · 24aef23a
      Matthias Clasen authored
              * gdk/gdkwindow.c: Typo fix.
      
              * gtk/gtk-sections.sgml: Add GtkTextChildAnchor.
      
              * gdk/tmpl/dnd.sgml: Updates.
      
              * gdk/tmpl/pango_interaction.sgml: Document GdkPangoAttrEmbossed
              and GdkPangoAttrStipple.
      24aef23a
    • Kristian Rietveld's avatar
      add checks for empty menu items to behave like insensitive items (#59456) · 209d0867
      Kristian Rietveld authored
      Thu Nov 29 21:35:56 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * gtk/gtkmenu.c (gtk_menu_motion_notify): add checks for
              empty menu items to behave like insensitive items (#59456)
      
              * gtk/gtkmenuitem.c (gtk_real_menu_item_activate_item): select
              next item if the first item in the menu is a tear off item
              (#59456-2, suggestion by Matthias Clasen)
      
              * gtk/gtkmenushell.c (gtk_menu_shell_button_press),
              (gtk_menu_shell_button_release), (gtk_menu_shell_entry_notify),
              (gtk_menu_shell_leave_notify), (gtk_real_menu_shell_move_current),
              (gtk_real_menu_shell_activate_current): add check, so empty
              menu items behave like insensitive items (#59456)
      
              * gtk/gtkmenuitem.[ch]: add _gtk_menu_item_is_selectable to make
              the checks more readable ...
      
              * gtk/gtkmenushell.c (gtk_menu_shell_button_press),
              (gtk_menu_shell_button_release): causes the menu to dropdown if the
              caption is clicked again (#64977)
      209d0867
    • Havoc Pennington's avatar
      assertion here that we were at the end iterator was not correct; change · ddfc7377
      Havoc Pennington authored
      2001-11-29  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
      	assertion here that we were at the end iterator was not correct;
      	change code to move us to the end iterator. bug #65731
      ddfc7377
    • Owen Taylor's avatar
      Remove improper use of g_locale_to_utf8() to convert from latin-1, and do · ea644d35
      Owen Taylor authored
      Wed Nov 28 20:05:44 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkaccellabel.c (gtk_accel_label_refetch): Remove
      	improper use of g_locale_to_utf8() to convert from
      	latin-1, and do it the easy way by building the string
      	correctly in the first place.
      ea644d35
    • Owen Taylor's avatar
      Convert atoms to and from atoms for properties of type XA_ATOM. (#65555, · 51f1c2a7
      Owen Taylor authored
      Wed Nov 28 19:34:15 2001  Owen Taylor  <otaylor@redhat.com>
      	* gdk/x11/gdkproperty-x11.c (gdk_property_change, gdk_property_get):
      	Convert atoms to and from atoms for properties of type XA_ATOM.
      	(#65555, patch from Hidetoshi Tajima)
      51f1c2a7
  5. 28 Nov, 2001 9 commits
    • Owen Taylor's avatar
      Rename 'id' parameter to avoid problems with Objective C. · 3e332260
      Owen Taylor authored
      Wed Nov 28 18:37:04 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtksocket.[ch] (gtk_socket_add_id): Rename 'id' parameter
      	to avoid problems with Objective C.
      3e332260
    • Matthias Clasen's avatar
      Typo fixes. (#65607) · a381648f
      Matthias Clasen authored
              * gtk/gtkaccelmap.c: Typo fixes. (#65607)
      
              * gtk/gtkfixed.c (gtk_fixed_set_has_window, gtk_fixed_get_has_window):
              Fix docs. (#65505)
      
              * gtk/gtkwindow.c (gtk_window_set_mnemnonic_modifier): Document.
      
              * gtk/tmpl/gtkwindow.sgml: Document gtk_window_position.
      
              * gdk/tmpl/dnd.sgml: Document GdkDragProtocol and GdkDragContext.
      
              * gdk/tmpl/events.sgml: Document gdk_setting_get.
      
              * gdk/tmpl/fonts.sgml: Document gdk_font_full_name_get and
              gdk_font_full_name_free.
      
              * gdk/tmpl/windows.sgml: Document gdk_window_register_dnd.
      a381648f
    • Owen Taylor's avatar
      Move accounting of menu->tearoff_scrollbar width to here and make sure we · 476d2a84
      Owen Taylor authored
      Wed Nov 28 18:19:12 2001  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmenu.c (gtk_menu_set_tearoff_hints): Move
              accounting of menu->tearoff_scrollbar width to here
              and make sure we have the correct requisition.
      
              * gtk/gtkmenu.c (gtk_menu_position): Fix fixme
              by using gtk_window_move().
      
              * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Force
              the requisition to be updated by calling
              gtk_widget_size_request() (#65440)
      
              * gtk/gtktearoffmenuitem.c (gtk_tearoff_menu_item_activate):
              queue resize before calling gtk_menu_set_tearoff_state().
      476d2a84
    • Kristian Rietveld's avatar
      fix typo · 2418e923
      Kristian Rietveld authored
      Wed Nov 28 22:20:44 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * demos/gtk-demo/editable_cells.c: fix typo
      
              * demos/gtk-demo/list_store.c (add_columns): remove call to
              gtk_tree_view_column_set_clickable which didn't make sense
      2418e923
    • Havoc Pennington's avatar
      put the warning explaining the validation error in front of the · 53da925c
      Havoc Pennington authored
      2001-11-28  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_paint): put the warning
      	explaining the validation error in front of the G_BREAKPOINT
      
      	* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
      	process updates with include_children = FALSE instead of TRUE, so
      	we redraw the range only, not the whole darn window.  Making
      	GtkRange a NO_WINDOW widget had weirdly caused the text widget
      	Trace/breakpoint trap bug to become much easier to trigger.
      53da925c
    • Owen Taylor's avatar
      Remove reference to gdkcursors.h. · 931fe180
      Owen Taylor authored
      Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
      	* gdk/Makefile.am (gdk_public_h_sources): Remove reference
      	to gdkcursors.h.
      931fe180
    • Matthias Clasen's avatar
      Add markup to docs. · fa7f3023
      Matthias Clasen authored
              * gtk/gtkwindow.c (gtk_window_move): Add markup to docs.
      fa7f3023
    • Matthias Clasen's avatar
      forgotten Changelog entry. · 0b0b2b64
      Matthias Clasen authored
      0b0b2b64
    • Owen Taylor's avatar
      Notify on the ::active property _here_, not in · 488463ef
      Owen Taylor authored
      Tue Nov 27 20:17:55 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkcheckmenuitem.c (gtk_check_menu_item_activate):
      	Notify on the ::active property _here_, not in
      	gtk_check_menu_item_set_active.
      488463ef
  6. 27 Nov, 2001 1 commit
  7. 26 Nov, 2001 2 commits
    • Owen Taylor's avatar
      Add long, but horribly sketchy comment about what is going on in this · 6a252271
      Owen Taylor authored
      Sun Nov 25 21:19:02 2001  Owen Taylor  <otaylor@redhat.com>
      	* gdk/x11/gdkgeometry-x11.c: Add long, but horribly sketchy
      	comment about what is going on in this file.
      	* gdk/x11/gdkgeometry-x11.c (gdk_window_compute_position): Fix
      	x/y problem.
      6a252271
    • Owen Taylor's avatar
      Calculate size based on the _child_ of the menu item, not the menuitem. · bc99cf97
      Owen Taylor authored
      Sun Nov 25 18:59:19 2001  Owen Taylor  <otaylor@redhat.com>
      	* gtk/gtkoptionmenu.c (gtk_option_menu_calc_size):
      	Calculate size based on the _child_ of the menu item,
      	not the menuitem. (#65005, Damon Chaplin)
      	* gtk/gtklistitem.c (gtk_list_item_new_with_label): Add
      	some extra vertical padding to the label widget ... restores
      	GTK+-1.2 spacing. (#65085, Damon Chaplin.)
      bc99cf97
  8. 25 Nov, 2001 2 commits
    • Tor Lillqvist's avatar
      demos/pixbuf-demo.c M_PI -> G_PI. · 9a60bfac
      Tor Lillqvist authored
      2001-11-26  Tor Lillqvist  <tml@iki.fi>
      
      	* demos/pixbuf-demo.c
      	* demos/gtk-demo/pixbufs.c: M_PI -> G_PI.
      
      	* demos/gtk-demo/main.c (read_line): No flockfile() or
      	getc_unlocked() on Win32.
      
      2001-11-25  Tor Lillqvist  <tml@iki.fi>
      
      	* configure.in
      	* acconfig.h: As we now use GDir, no need to check for dirent.h.
      9a60bfac
    • Kristian Rietveld's avatar
      free font_desc when finished (#65266) · 7a181cf5
      Kristian Rietveld authored
      Sun Nov 25 23:18:39 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * gtk/gtktexttag.c (gtk_text_tag_set_property): free font_desc
              when finished (#65266)
      
      Sun Nov 25 23:16:29 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): free
              data after we set the property. (#65264)
      
      Sun Nov 25 23:14:06 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * gtk/gtkbutton.c: add destroy method so label_text gets freed
              if it has been allocated (#65268)
      7a181cf5
  9. 24 Nov, 2001 5 commits