1. 18 Jun, 2005 5 commits
  2. 17 Jun, 2005 13 commits
    • Matthias Clasen's avatar
      Support the ICCCM urgency hint. (#61858, Havoc Pennington) · 23fabedc
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	Support the ICCCM urgency hint.  (#61858, Havoc Pennington)
      
      	* gtk/gtk.symbols:
      	* gtk/gtkwindow.[hc]: Add a GtkWindow::urgency-hint property
      	with getter and setter.
      
      	* gdk/gdk.symbols:
      	* gdk/gdkwindow.h:
      	* gdk/x11/gdkwindow-x11.c (gdk_window_set_urgency_hint):
      	Add a setter for the urgency hint.
      
      	* gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store
      	urgency hint here.
      
      	* gdk/x11/gdkwindow-x11.c (update_wm_hints): Set the urgency
      	hint in the WM_HINTS property when appropriate.
      23fabedc
    • Kristian Rietveld's avatar
      Fix #160281, testcase from Peter Bloomfield. · 015b3c56
      Kristian Rietveld authored
      2005-06-17  Kristian Rietveld  <kris@gtk.org>
      
      	Fix #160281, testcase from Peter Bloomfield.
      
      	* gtk/gtktreeview.c (do_presize_handler): always size request
      	and update adjustments in fixed height mode,
      	(gtk_tree_view_build_tree): if a fixed height is set, set this
      	height on newly added nodes.
      015b3c56
    • Tor Lillqvist's avatar
      Set the actions and suggested_action fields in the GdkDragContext to · 9c8f987d
      Tor Lillqvist authored
      2005-06-17  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkdnd-win32.c (gdk_dropfiles_filter): Set the actions
      	and suggested_action fields in the GdkDragContext to
      	GDK_ACTION_COPY. Otherwise apps that check the suggested_action
      	field, like eog, won't accept dropped files.
      9c8f987d
    • Matthias Clasen's avatar
      Define GDK_IS_CURSOR() and GDK_CURSOR(). · 4e077183
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/gdkcursor.h: Define GDK_IS_CURSOR() and GDK_CURSOR().
      4e077183
    • Matthias Clasen's avatar
      Improve some return_if_fail checks, and add the missing non-Xcursor · 3d6ed059
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkcursor-x11.c:
      	* gdk/gdkcursor.c: Improve some return_if_fail checks,
      	and add the missing non-Xcursor fallback for
      	_gdk_x11_cursor_update_theme(), noticed by Jeroen
      	Zwartepoorte.
      3d6ed059
    • Matthias Clasen's avatar
      Document several button signals as not useful. ` · c06b5609
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkbutton.c (gtk_button_class_init): Document
      	several button signals as not useful.
      `
      c06b5609
    • Matthias Clasen's avatar
      Resize the popup if necessary. (#308076, Vincent Noel) · 7535bc04
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_complete):
      	Resize the popup if necessary.  (#308076, Vincent Noel)
      7535bc04
    • Matthias Clasen's avatar
      Queue a draw on the old and new focus widgets, if their defaultness · 7f47f6b1
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkwindow.c (gtk_window_real_set_focus): Queue a
      	draw on the old and new focus widgets, if their defaultness
      	changes.  (#305607, Billy Biggs)
      7f47f6b1
    • Kristian Rietveld's avatar
      make sure the row above 'above_path' is always in a validated state, so it · 07712974
      Kristian Rietveld authored
      2005-06-17  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (validate_visible_area): make sure the row
      	above 'above_path' is always in a validated state, so it does
      	not mess up scrolling. (#303319, testcase from Billy Biggs).
      07712974
    • Matthias Clasen's avatar
      Handle cursor theme changes for cached cursors which are not associated · beb73ece
      Matthias Clasen authored
      2005-06-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkprivate-x11.h:
      	* gdk/x11/gdkcursor-x11.c: Handle cursor theme changes
      	for cached cursors which are not associated with a window
      	at the time of the theme change, by storing a serial
      	number in each cursor, and updating the theme_serial
      	counter whenever the cursor theme changes.
      
      	* gdk/x11/gdkcursor-x11.c (_gdk_x11_cursor_update_theme):
      	Private function to update a cursor to the current
      	cursor theme if necessary.
      
      	* gdk/x11/gdkmain-x11.c (gdk_pointer_grab):
      	* gdk/x11/gdkwindow-x11.c (gdk_window_set_cursor): Call
      	_gdk_x11_cursor_update_theme() here.
      beb73ece
    • Owen Taylor's avatar
      Fix #if G_BYTE_ORDER == GDK_LSB_FIRST. · c96795ff
      Owen Taylor authored
      2005-06-17  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/gdkcairo.c (gdk_cairo_set_source_pixbuf): Fix
              #if G_BYTE_ORDER == GDK_LSB_FIRST.
      c96795ff
    • Kristian Rietveld's avatar
      don't try to update the top_row rowref ourselves here, but just have · b060f6e1
      Kristian Rietveld authored
      2005-06-17  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (validate_visible_area): don't try to update
      	the top_row rowref ourselves here, but just have _dy_to_top_row()
      	do it,
      	(gtk_tree_view_scroll_to_cell): handle scrolling via
      	validate_visible_area() if the treeview is not visible or needs
      	reallocation. (#165246, Nickolay V. Shmyrev).
      b060f6e1
    • Kristian Rietveld's avatar
      Fixes #307914 (Alexander Larsson), fixing some breakage caused by my · 51f11dd4
      Kristian Rietveld authored
      2005-06-17  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes #307914 (Alexander Larsson), fixing some breakage caused
      	by my previous commit.
      
      	* gtk/gtktreeview.c (validate_visible_area): force dy to be zero
      	when it fits on a single page,
      	(scroll_sync_handler): same here.
      51f11dd4
  3. 16 Jun, 2005 5 commits
  4. 15 Jun, 2005 9 commits
    • Matthias Clasen's avatar
      Get red and blue in place. · 19b9451c
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkcursor-x11.c (gdk_cursor_get_image): Get
      	red and blue in place.
      19b9451c
    • Matthias Clasen's avatar
      Fox doc formatting, pointed out by Kjartan Maraas. · 5870262a
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkwindow.c (gtk_window_parse_geometry): Fox doc
      	formatting, pointed out by Kjartan Maraas.
      5870262a
    • Matthias Clasen's avatar
      Add two new settings, gtk-cursor-theme-name and gtk-cursor-theme-size to · df517cb1
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtksettings.c: Add two new settings,
      	gtk-cursor-theme-name and gtk-cursor-theme-size to
      	control the cursor theme.
      
      	* gdk/x11/gdkevents-x11.c: Add two new X settings,
      	Gtk/CursorThemeName and Gtk/CursorThemeSize, and map
      	these to the gtk settings.
      
      	* tests/testgtk.c (create_cursors): Add a cursor theme
      	testcase.
      df517cb1
    • Matthias Clasen's avatar
      Keep a reference to the GdkCursor and add a private getter for it, so that · 3c96358f
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkwindow-x11.[hc]: Keep a reference to the
      	GdkCursor and add a private getter for it, so that we can
      	update the cursor when the cursor theme changes.
      
      	* gdk/gdk.symbols:
      	* gdk/x11/gdkx.h:
      	* gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
      	New function to change the cursor theme.
      3c96358f
    • Matthias Clasen's avatar
      Remove a lot of pointless g_return_if_fail() non-NULL checks. · cd872269
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkwindow-x11.c: Remove a lot of pointless
      	g_return_if_fail() non-NULL checks.
      cd872269
    • Matthias Clasen's avatar
      Make make check happier · abb3b2e7
      Matthias Clasen authored
      abb3b2e7
    • Matthias Clasen's avatar
      Fix some docs · f5bf23da
      Matthias Clasen authored
      f5bf23da
    • Matthias Clasen's avatar
      Fix 307689 · eee3d974
      Matthias Clasen authored
      eee3d974
    • Federico Mena Quintero's avatar
      Merged from gtk-2-6: · cd3c641c
      Federico Mena Quintero authored
      2005-06-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-6:
      
      	Fix #302087:
      
      	* gtk/gtkfilechooserdefault.c (list_selection_changed): Emit
      	"selection-changed" and do the normal housekeeping even if we are
      	in SAVE mode and there is nothing selected.  We didn't emit that
      	signal if we were in SAVE mode and unselect_all() got called.
      	(gtk_file_chooser_default_unselect_all): Call
      	pending_select_paths_free() so that we cancel any asynchronous
      	selections.
      	(gtk_file_chooser_default_set_current_name): Likewise.
      cd3c641c
  5. 14 Jun, 2005 6 commits
    • Federico Mena Quintero's avatar
      Merged from gtk-2-6: · fb323cfb
      Federico Mena Quintero authored
      2005-06-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-6:
      
      	Fixes #307640:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_should_respond): Oops, I broke SAVE
      	mode.  If the parent path is a folder, only create a subfolder if
      	we are in CREATE_FOLDER mode; if we are in SAVE mode, just return
      	and respond.  Also, pick up the case where the user types
      	"dirname/" instead of "dirname".
      	(check_save_entry): Make the return type void.  Add some return
      	parameters so that we can do more thorough checking.
      	(gtk_file_chooser_default_get_paths): If the file part is empty
      	and we are in SAVE mode, return an empty selection.
      fb323cfb
    • Kristian Rietveld's avatar
      Patch for #163214 (reported by Tommi Komulainen) and fixes some other · 5641d252
      Kristian Rietveld authored
      2005-06-15  Kristian Rietveld  <kris@gtk.org>
      
      	Patch for #163214 (reported by Tommi Komulainen) and fixes some
      	other scrolling/validation related bugs along the why.
      
      	* gtk/gtktreeview.c (gtk_tree_view_size_request): run
      	do_validate_rows once and don't queue a size request there,
      	(gtk_tree_view_size_allocate): don't update vadj value without
      	reason, sync top_row/dy after the window sizes and adjustments
      	are in sync again,
      	(validate_visible_area): always update dy when scrolling,
      	manually set top_row here after changing the vadj (don't depend
      	on _adjustment_changed and top_row/dy sync to do this), since we
      	now always set top_row here correctly, we can always free
      	scroll_to_path at the end which avoids infinite expose loops,
      	(do_validate_rows): add queue_resize boolean, remove top_row/dy
      	sync here, we cannot do it safely at this place since the
      	window sizes and adjustments are out of sync,
      	(validate_rows), (validate_rows_handler): update call to
      	do_validate_rows().
      5641d252
    • Matthias Clasen's avatar
      Add a stub for the no-Xcursor case. (noticed by Luis Villa) · daab95c2
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkcursor-x11.c (gdk_cursor_new_from_name): Add a
      	stub for the no-Xcursor case. (noticed by Luis Villa)
      daab95c2
    • Matthias Clasen's avatar
      Use named cursors for the DND cursors, the names are "dnd-none", · 920b5749
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	Use named cursors for the DND cursors, the names are "dnd-none",
      	"dnd-copy", "dnd-link", "dnd-move" and "dnd-ask". Also use an RGBA
      	cursor instead of cursor+window when possible. This saves
      	roundtrips during the drag operation, and makes translucent icons
      	possible.
      
      	* gtk/gtkdndcursors.h: New file, containing inlined pixbufs
      	for the default dnd cursors.
      
      	* gtk/gtkdnd.c (struct _GtkDragSourceInfo): Store the cursors
      	used during the drag here, also store the icon pixbuf here.
      
      	* gtk/gtkdnd.c (drag_cursors): Store the cursor names here. Also
      	switch the default cursors from xbm to inlined pixbufs.
      
      	* gtk/gtkdnd.c (gtk_drag_get_cursor): This function now takes the
      	GtkDragSourceInfo as well, since it has to composite the
      	drag-specific cursors. The cursors combined from the image of
      	the themed cursor and the icon_pixbuf stored in the info.
      
      	* gtk/gtkdnd.c (gtk_drag_begin_internal): Don't set the default
      	icon if there is an icon_pixbuf, which will be composited into
      	the cursor later.
      
      	* gtk/gtkdnd.c (set_icon_stock_pixbuf): If appropriate, store
      	the pixbuf in the info struct for later compositing into the
      	cursor instead of creating an icon window.
      
      	* gtk/gtkdnd.c (gtk_drag_drop_finished): If we used an
      	RGBA cursor for the drag, and need to display the cancel
      	animation, construct the icon window here.
      
      	* gtk/gtkdnd.c (gtk_drag_source_info_destroy): Unref the
      	drag-specific cursors and the icon_pixbuf when done with
      	the drag.
      920b5749
    • Matthias Clasen's avatar
      Use a named cursor with the name "color-picker", when available. · d1f2cb63
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcolorsel.c (make_picker_cursor): Use a named cursor
      	with the name "color-picker", when available.
      d1f2cb63
    • Matthias Clasen's avatar
      New functions to construct named cursors and to get the image used for a · 6b5b2698
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/gdk.symbols:
      	* gdk/gdkcursor.h:
      	* gdk/x11/gdkcursor-x11.c (gdk_cursor_get_image)
      	(gdk_cursor_new_from_name): New functions to construct named
      	cursors and to get the image used for a cursor.
      6b5b2698
  6. 13 Jun, 2005 2 commits
    • Matthias Clasen's avatar
      Rework the way in which rerooting of the path bar is done, implementing · 60113bed
      Matthias Clasen authored
      
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkpathbar.[hc]: Rework the way in which rerooting of the
      	path bar is done, implementing the following principles:
      	(#137289, patch by Benjamin Otte)
      
      	1. Re-root only if $HOME is an ancestor of the current path.
      
      	2. When re-rooting, make sure the Left arrow appears in the path
      	bar, so that you can navigate up from $HOME to /.  In that case,
      	make sure the Right arrow doesn't appear if the sub-hierarchy from
      	$HOME to the cwd fits in the window.
      
      	3. Make sure that hitting Alt-Up takes you always one folder up,
      	even when the path bar is re-rooted.
      60113bed
    • Matthias Clasen's avatar
      Try harder not to modify readonly strings. (#307541, Torsten Schoenfeld) · 9962a15c
      Matthias Clasen authored
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
      	Try harder not to modify readonly strings. (#307541, Torsten Schoenfeld)
      9962a15c