1. 05 Mar, 2004 2 commits
    • Jonathan Blandford's avatar
      insert in the correct place instead of naïvely appending. · 8bb74888
      Jonathan Blandford authored
      Fri Mar  5 01:45:04 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (shortcuts_append_paths): insert in
              the correct place instead of naïvely appending.
              (shortcuts_add_volumes): refilter the model
              (shortcuts_add_bookmarks): refilter the model
              (gtk_file_chooser_default_add_shortcut_folder): refilter the model
      8bb74888
    • Federico Mena Quintero's avatar
      New handler. Ask the GtkFileChooser widget if it wants to do something · d64c7c08
      Federico Mena Quintero authored
      2004-03-04  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdialog.c (response_cb):  New handler.  Ask the
      	GtkFileChooser widget if it wants to do something special rather
      	than letting us terminate the dialog.
      	(gtk_file_chooser_dialog_init): Connect to "response"; see the
      	comment in the sources to see why we don't override the method in
      	class_init.
      
      	* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
      	Added a ::should_respond() method.
      
      	* gtk/gtkfilechooserembed.c
      	(_gtk_file_chooser_embed_delegate_iface_init): Add a delegate for ::should_respond().
      	(delegate_should_respond): New delegate.
      	(_gtk_file_chooser_embed_should_respond): New function.
      
      	* gtk/gtkfilechooserdefault.c (set_list_model, create_file_list):
      	Use dashes in signal names rather than underscores.
      	(gtk_file_chooser_default_init): Hook up our ::should_respond() implementation.
      	(gtk_file_chooser_default_should_respond): Implement.  go into a
      	folder rather than responding if we are in File mode and the
      	selected file is a folder.
      	(get_selection): New helper function.
      	(add_bookmark_button_clicked_cb): Use get_selection().
      	(bookmarks_check_add_sensitivity): Likewise.
      	(gtk_file_chooser_default_get_paths): Likewise.
      	(check_save_entry): New helper function.
      	(gtk_file_chooser_default_get_paths): Use check_save_entry().
      	(selection_check): Renamed from selection_is_folders().  Now
      	checks whether the selection is empty, all files, all folders.
      	(bookmarks_check_add_sensitivity): Use selection_check().
      d64c7c08
  2. 04 Mar, 2004 6 commits
    • Matthias Clasen's avatar
      Connect to key_press_event and handle Alt-Down/Alt-Up to show or hide the · 1810dba3
      Matthias Clasen authored
      Fri Mar  5 00:05:59 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_setup):
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Connect to
      	key_press_event and handle Alt-Down/Alt-Up to show or hide the
      	list popup. Also handle Down/Up/PageDown/PageUp/Home/End and
      	make them change the active item without popping up the list.
      	These keybindings are inherited from GtkCombo.
      
      Thu Mar  4 23:15:58 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Initially
      	select the active item when using optionmenu-like positioning.
      1810dba3
    • Owen Taylor's avatar
      Don't open/close the file, just check for existence with g_file_test(). · 1af39383
      Owen Taylor authored
      Thu Mar  4 16:54:30 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Don't
              open/close the file, just check for existence
              with g_file_test(). This is considerably cheaper,
              and lack-of-permissions for pixmap dirs is
              pathological.
      
      Wed Mar  3 17:53:21 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtksocket.c (gtk_socket_class_init): Overide
              show_all/hide_all to be gtk_widget_show/gtk_widget_hide,
              since we don't want to propagate to the in-process
              plug, if any. (#122949, Michael Meeks)
      1af39383
    • Jonathan Blandford's avatar
      show the 'New Folder' button in SAVE mode again. · b1ac4367
      Jonathan Blandford authored
      Thu Mar  4 15:20:55 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (update_appearance): show the 'New
              Folder' button in SAVE mode again.
      b1ac4367
    • Matthias Clasen's avatar
      Increment the reference count of the style when copying the cached icon. · 897f3aac
      Matthias Clasen authored
      Thu Mar  4 21:53:46 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkiconfactory.c (copy_cache): Increment the reference
      	count of the style when copying the cached icon.  (#135890, Crispin
      	Flowerday)
      897f3aac
    • Matthias Clasen's avatar
      In list mode, set the background color of the cell view to the base color · f855ea2d
      Matthias Clasen authored
      Thu Mar  4 21:45:43 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c: In list mode, set the background color
      	of the cell view to the base color of the style, instead of
      	hardwiring white. (#136158)
      f855ea2d
    • Jonathan Blandford's avatar
      Modified patch from muppet <scott@asofyet.org> to keep child directories · 778d6904
      Jonathan Blandford authored
      Thu Mar  4 01:32:19 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkpathbar.c (gtk_path_bar_set_path): Modified patch from
              muppet <scott@asofyet.org> to keep child directories around if we
              change to a child.
      
              * gtk/gtkpathbar.c (_gtk_path_bar_set_home_icon): Start of
              icon-setting functions.  Not used yet.
              (_gtk_path_bar_set_root_icon): Ditto.
      778d6904
  3. 03 Mar, 2004 16 commits
    • Matthias Clasen's avatar
      Allow to select the last word in the buffer. (#135487, Paolo Borelli) · befe86f1
      Matthias Clasen authored
      Thu Mar  4 00:31:54 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktextview.c (extend_selection):
      	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): Allow
      	to select the last word in the buffer.  (#135487, Paolo Borelli)
      befe86f1
    • Matthias Clasen's avatar
      Doc update. · 576ce814
      Matthias Clasen authored
      576ce814
    • Owen Taylor's avatar
      Check whether widgets are viewable, not just if they are mapped. (#122912, · 2ddeb7cd
      Owen Taylor authored
      Wed Mar  3 17:30:18 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkwindow.c (gtk_window_mnemonic_activate): Check
              whether widgets are viewable, not just if they are
              mapped. (#122912, reported by Tim Evans)
      2ddeb7cd
    • Matthias Clasen's avatar
      Move the actual implementation into a new · 19369fea
      Matthias Clasen authored
      Wed Mar  3 23:28:48 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_active): Move the actual
      	implementation into a new gtk_combo_box_set_active_internal()
      	function, which doesn't do the short-circuiting.
      	* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted): Use
      	set_active_internal() here, since the active item may change here,
      	although the index is unchanged.
      
      Wed Mar  3 23:26:49 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Reintroduce the
      	traditional option menu placement of the popup for regular combo
      	boxes. Grids and editable combo boxes use the combo-like placement
      	below the entry.  (#136021)
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press):
      	* gtk/gtkcombobox.c (gtk_combo_box_popup): Call gtk_menu_set_active()
      	before popping up the menu, to make the placement work.
      19369fea
    • Owen Taylor's avatar
      Special case scroll events so that they propagate up the widget heirarchy · 7a9bec28
      Owen Taylor authored
      Wed Mar  3 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmain.c (gtk_propagate_event): Special case
              scroll events so that they propagate up the widget
              heirarchy when received on insensitive widgets.
              (#101102, reported by Geoff Reedy)
      7a9bec28
    • Owen Taylor's avatar
      #109594, reported by Olivier Ripoll · 0d898ffc
      Owen Taylor authored
      Wed Mar  3 16:47:10 2004  Owen Taylor  <otaylor@redhat.com>
      
               #109594, reported by Olivier Ripoll
      
              * gtk/gtkentry.c (gtk_entry_size_request): Use max of
              width and digit width for gtk_entry_set_width_chars,
              and round up.
      
              * gtk/gtkcolorsel.c (gtk_color_selection_init): Set the
              width of the entry to 7 chars.
      0d898ffc
    • Owen Taylor's avatar
      Strip out the "export-dynamic" libtool option from library link lines. · d7681e7c
      Owen Taylor authored
      Wed Mar  3 16:00:10 2004  Owen Taylor  <otaylor@redhat.com>
      
              * configure.in: Strip out the "export-dynamic" libtool
              option from library link lines. (#124687, James Henstridge)
      d7681e7c
    • Jonathan Blandford's avatar
      Don't activate the combo if we're in the midst of changing folders. · e47f7d58
      Jonathan Blandford authored
      Wed Mar  3 16:06:03 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (save_folder_combo_changed_cb):
              Don't activate the combo if we're in the midst of changing
              folders.
      e47f7d58
    • Mark McLoughlin's avatar
      don't try and store pointers in ints. Fixes 64-bit build. · 81ea4248
      Mark McLoughlin authored
      2004-03-03  Mark McLoughlin  <mark@skynet.ie>
      
              * tests/testsocket_common.c: (print_hello): don't try and store
              pointers in ints. Fixes 64-bit build.
      81ea4248
    • Federico Mena Quintero's avatar
      Simplify by not using a temporary variable, and clarify the documentation. · ecb01c42
      Federico Mena Quintero authored
      2004-03-03  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_system_get_parent): Simplify by
      	not using a temporary variable, and clarify the documentation.
      	Fixes #136008.
      ecb01c42
    • Mark McLoughlin's avatar
      Set the label widget's state to prelight if we're prelit. Fixes bug · 3c8e60e7
      Mark McLoughlin authored
      2004-03-03  Mark McLoughlin  <mark@skynet.ie>
      
              * gtk/gtkexpander.c:
              (gtk_expander_enter_notify), (gtk_expander_leave_notify),
              (gtk_expander_set_label_widget): Set the label widget's
              state to prelight if we're prelit. Fixes bug #136078.
      3c8e60e7
    • Murray Cumming's avatar
      Corrected the group_changed signal vfunc declaration, adding the first · 1cbdd62c
      Murray Cumming authored
      2004-03-03  Murray Cumming  <murrayc@murrayc.com>
      
              * gtk/gtkradiobutton.h, radiomenuitem.h: Corrected the group_changed
              signal vfunc declaration, adding the first parameter, which is the
              widget emitting the signal.
      1cbdd62c
    • Morten Welinder's avatar
      Plug leak. · eb7f75b7
      Morten Welinder authored
      2004-03-03  Morten Welinder  <terra@gnome.org>
      
      	* tests/testfilechooser.c (update_preview_cb): Plug leak.
      eb7f75b7
    • Jonathan Blandford's avatar
      Split function into realized and unrealized variants, and consolidate the · bb5a4999
      Jonathan Blandford authored
      Tue Mar  2 23:39:55 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdialog.c
              (file_chooser_widget_default_realized_size_changed): Split
              function into realized and unrealized variants, and consolidate
              the handling fo size-changing and default changing.
      
              * gtk/gtkfilechooserembed.[ch] (gtk_file_chooser_embed_class_init):
              remove resizable-hints-changed, as it just complicated things.
      
              * gtk/gtkfilechooserdefault.c (update_appearance): Don't emit
              resizable-hints-changed.
      bb5a4999
    • Tor Lillqvist's avatar
      Add a missing entry. (#135982, J. Ali Harlow) · 9ca11bfa
      Tor Lillqvist authored
      2004-03-03  Tor Lillqvist  <tml@iki.fi>
      
      	* gtk/gtk.def: Add a missing entry. (#135982, J. Ali Harlow)
      
      	* NEWS: Correct spelling of my name in one place.
      9ca11bfa
    • Federico Mena Quintero's avatar
      Handle errors in setting the path bar's path. Fixes #136000, based on a · e50fb687
      Federico Mena Quintero authored
      2004-03-02  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_set_current_folder): Handle errors in
      	setting the path bar's path.  Fixes #136000, based on a patch by
      	Morten Welinder.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_insert_bookmark):
      	Don't free our own propagated error.
      
      	* gtk/gtkpathbar.c (gtk_path_bar_set_path): Likewise, and free the
      	parent_path upon error.  Fixes #136006, patch by Morten Welinder.
      	(gtk_path_bar_set_path): Unref the file_folder upon error.
      	(gtk_path_bar_set_path): Return a boolean success code.
      e50fb687
  4. 02 Mar, 2004 16 commits
    • Matthias Clasen's avatar
      Add an animation mode, to test how the combobox behaves if the model · 2169f509
      Matthias Clasen authored
      Wed Mar  3 00:28:59 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/testcombochange.c: Add an animation mode, to test
      	how the combobox behaves if the model changes while it is popped
      	up.
      2169f509
    • Owen Taylor's avatar
      === Released 2.3.5 === · 30121c9a
      Owen Taylor authored
      Tue Mar  2 17:06:05 2004  Owen Taylor  <otaylor@redhat.com>
      
              * === Released 2.3.5 ===
      
              * NEWS: Updates
      
              * configure.in: Version 2.3.5, interface age 0.
              Require glib-2.3.5, pango-1.3.5.
      30121c9a
    • Matthias Clasen's avatar
      Avoid popping up the completions across the edge of the monitor. Part of · f2cc9ae8
      Matthias Clasen authored
      Tue Mar  2 23:08:12 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Avoid
      	popping up the completions across the edge of the monitor.
      	Part of #135561.
      f2cc9ae8
    • Owen Taylor's avatar
      Move the /nonexistant stuff out of the main window, keep the main window · ce52e077
      Owen Taylor authored
      Tue Mar  2 16:47:40 2004  Owen Taylor  <otaylor@redhat.com>
      
              * tests/testfilechooser.c (set_filename_existing_nonexistent_cb):
              Move the /nonexistant stuff out of the main window,
              keep the main window somewhat normal looking.
      ce52e077
    • Owen Taylor's avatar
      gtk/gtktreestore.c (gtk_tree_store_reorder) Fix up the interpretation of · d0f6b481
      Owen Taylor authored
      Tue Mar  2 16:18:43 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreestore.c (gtk_tree_store_reorder)
              * gtk/gtkliststore.c (gtk_list_store_reorder): Fix
              up the interpretation of new_order to match what
              it means elsewhere, document the meaning of new_order.
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_rows_reordered):
              Fix interpretation of new_order.
      
              * tests/testcombochange.c (on_reorder): Fix interpretation
              of new_order.
      
              * tests/testcombochange.c (on_reorder): Fix hitting
              "reorder" with an empty list.
      d0f6b481
    • Søren Sandmann Pedersen's avatar
      Remove conflict markers · 32e21f2b
      Søren Sandmann Pedersen authored
      32e21f2b
    • Soeren Sandmann's avatar
      Patch from Frederic Crozat, test code from Jean-Philippe Chancelier. Fixes · cddfd994
      Soeren Sandmann authored
      Tue Mar  2 21:23:30 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	Patch from Frederic Crozat, test code from Jean-Philippe
      	Chancelier. Fixes bug #120479.
      
      	* gtk/gtkcombo.c (gtk_combo_popup_list): Make sure popup belongs
      	to the right window group.
      
      	* gtk/gtkmenu.c (gtk_menu_popup): Same
      
      	* tests/testsocket.c (main): Pack the plugs into an hbox instead
      	of a vbox.
      
      	* tests/testsocket_common.c: Add a GtkMenuBar, a GtkCombo and a
      	GtkComboBox to the children.
      cddfd994
    • Owen Taylor's avatar
      If the model was empty before, select the first inserted item. · f05cb42d
      Owen Taylor authored
      Tue Mar  2 14:38:23 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
              If the model was empty before, select the first inserted
              item.
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted):
              Fix up the logic for the new row to select.
      
              * gtk/gtkcombobox.c (gtk_combo_box_class_init):
              Rename "appearance" property to "appears-as-list".
      
              * tests/testcombochange.c tests/Makefile.am: Test case
              for combos and dynamically changing models.
      f05cb42d
    • Jonathan Blandford's avatar
      set the default value, spotted by Morten Welinder. · e8c5b648
      Jonathan Blandford authored
      Tue Mar  2 15:19:52 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c
              (gtk_file_chooser_default_get_resizable_hints): set the default
              value, spotted by Morten Welinder.
      e8c5b648
    • Jonathan Blandford's avatar
      get the logic correct. This will fix sizing on save dialogs. · 87a6680f
      Jonathan Blandford authored
      Tue Mar  2 15:03:15 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c
              (gtk_file_chooser_default_get_resizable_hints): get the logic
              correct.  This will fix sizing on save dialogs.
      
              (save_widgets_create): set_mnemonic_widget.
      87a6680f
    • Federico Mena Quintero's avatar
      Don't update the save folder combo if we are already switching folders; · 9133c58b
      Federico Mena Quintero authored
      2004-03-02  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_set_current_folder): Don't update the
      	save folder combo if we are already switching folders; based on a
      	patch by Jonathan Blandford.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
      	Handle failure to insert the path.  Based on a patch by Morten
      	Welinder attached to bug #135380.
      
      	* tests/testfilechooser.c (extra_widget_create): Add a bunch of
      	buttons to test various things.
      9133c58b
    • Matthias Clasen's avatar
      Add testentrycompletion. · 596cbff9
      Matthias Clasen authored
      Tue Mar  2 20:59:23 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/Makefile.am: Add testentrycompletion.
      
      	* tests/testentrycompletion.c: New file to test some of the
      	more exotic GtkEntryCompletion features.
      596cbff9
    • Jonathan Blandford's avatar
      improve tests a little. · fe8838bc
      Jonathan Blandford authored
      Tue Mar  2 14:38:10 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * tests/testfilechooser.c (main): improve tests a little.
      fe8838bc
    • Owen Taylor's avatar
      Always connect to the changed signals on the model, update the active item · 1d64b555
      Owen Taylor authored
      Tue Mar  2 11:45:50 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkcombobox.c: Always connect to the changed
              signals on the model, update the active item as
              appropriate when rows are inserted/deleted/reordered,
              re-layout the menu on ::rows-reordered.
      
              * gtk/gtkcellview.c (gtk_cell_view_set_displayed_row):
              Allow %NULL for path to unset and leave no current
              path.
      1d64b555
    • Matthias Clasen's avatar
      Position the popup above the sample if there is not enough room below. · de011a6d
      Matthias Clasen authored
      Tue Mar  2 19:54:53 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_position): Position
      	the popup above the sample if there is not enough room below.
      	Part of #135543.
      
      Tue Mar  2 19:53:36 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make the
      	frame for the list mode etched in, to give the popup a slightly
      	less flat appearance.
      
      Tue Mar  2 17:55:31 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtk.def: Add gtk_combo_box_entry_new_text().
      de011a6d
    • Morten Welinder's avatar
      Don't scale images that are small enough to fit. Avoid using incompatibly · e4cec76b
      Morten Welinder authored
      2004-03-02  Morten Welinder  <terra@gnome.org>
      
      	* tests/testfilechooser.c (size_prepared_cb): Don't scale images
      	that are small enough to fit.  Avoid using incompatibly typed data
      	pointer.
      e4cec76b