1. 15 Oct, 2003 2 commits
    • Kristian Rietveld's avatar
      mention in the docs that -1 is a valid value and what it means. · 8b34c308
      Kristian Rietveld authored
      Wed Oct 15 22:04:59 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_get_active),
      	(gtk_combo_box_set_active): mention in the docs that -1 is a valid
      	value and what it means.
      
      	* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init): set the active
      	item to -1 (default),
      	(gtk_combo_box_entry_active_changed): do nothing when the index is
      	< 0.
      8b34c308
    • Federico Mena Quintero's avatar
      Added a button to remove a bookmark. (remove_bookmark_button_clicked_cb): · 5a51188b
      Federico Mena Quintero authored
      2003-10-14  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtkfilechooserimpldefault.c (create_shortcuts_tree): Added a
      	button to remove a bookmark.
      	(remove_bookmark_button_clicked_cb): New callback.
      	(shortcuts_append_bookmarks): Show/hide the bookmarks buttons
      	here, rather than in create_shortcuts_tree().
      	(shortcuts_append_path): Return whether the operation succeeded.
      	(shortcuts_selection_changed): Set the sensitivity of the button
      	used to remove a bookmark.
      	(shortcuts_append_bookmarks): Do not select the shortcuts folder
      	here; let the caller do it if needed.
      	(create_shortcuts_tree): Select the shortcuts folder here.
      	(bookmarks_changed_cb): Likewise.
      	(create_shortcuts_tree): Also set the sensitivity of the bookmarks
      	buttons.
      	(bookmarks_check_add_sensitivity): Renamed from
      	check_bookmarks_sensitivity().
      	(shortcuts_select_folder): Renamed from select_shortcuts_folder().
      	(bookmarks_check_add_sensitivity): The current_path may not be set
      	yet.
      	(shortcuts_append_bookmarks): Oops, remove all the bookmark rows,
      	not just the separator node.
      	(bookmarks_changed_cb): Set the sensitivity of the bookmarks
      	buttons.
      5a51188b
  2. 14 Oct, 2003 2 commits
  3. 13 Oct, 2003 9 commits
    • Federico Mena Quintero's avatar
      Don't do operations on windows if the tree view is not mapped. · f6bb7584
      Federico Mena Quintero authored
      2003-10-13  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): Don't do
      	operations on windows if the tree view is not mapped.
      	(gtk_tree_view_button_press): Compare equal types of pointers, not
      	GtkWidget* vs. GtkTreeView*.
      f6bb7584
    • Federico Mena Quintero's avatar
      Walk the whole shortcuts model, not just the bookmarks part --- there is · 36eccd81
      Federico Mena Quintero authored
      2003-10-13  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtkfilechooserimpldefault.c (check_bookmarks_sensitivity): Walk
      	the whole shortcuts model, not just the bookmarks part --- there
      	is no need to add bookmarks for "stock" volume items.
      	(gtk_file_chooser_impl_default_set_property): Oops, hide/show the
      	tree/list as appropriate for the folder_mode property.
      36eccd81
    • Kristian Rietveld's avatar
      remove the reset of first_sel_changed, as after the first popup the · 027d6900
      Kristian Rietveld authored
      Mon Oct 13 21:01:43 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_popup): remove
      	the reset of first_sel_changed, as after the first popup the treeview
      	will always have a row selected and will thus not focus_to_cursor.
      
      	* gtk/gtkentry.c (keyval_is_cursor_move): new function to determine
      	whether the keyval should move the completion selection cursor (used
      	to avoid ending up with extreme cluttered code), also added
      	all KP_ equivalents of the keys here,
      	(gtk_entry_completion_key_press): Keynav tweaks based on comments
      	from Dave Bordoley and Marco Pesenti Gritti; add the -1 state
      	as possible current selection, implement Home/End keys, modified
      	the down key to stop cycling. Maybe page up/down should be implemented
      	at some later time.
      027d6900
    • Matthias Clasen's avatar
      Make it work as documented when pixmap or mask is NULL. (#124081) · 2baa63a1
      Matthias Clasen authored
      Mon Oct 13 20:58:07 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gdk/x11/gdkwindow-x11.c (gdk_window_set_icon): Make it work
      	as documented when pixmap or mask is NULL.  (#124081)
      2baa63a1
    • Kristian Rietveld's avatar
      Fix changelog. Doh. · a4508202
      Kristian Rietveld authored
      a4508202
    • Kristian Rietveld's avatar
      I overlooked an if when I was adding the signal block/unblock code. Oops. · f84b5d51
      Kristian Rietveld authored
      Mon Oct 13 20:21:38 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkentry.c (gtk_entry_set_text): I overlooked an if when
      	I was adding the signal block/unblock code. Oops. (Noticed by
      	Marco Pesenti Gritti).
      f84b5d51
    • Kristian Rietveld's avatar
      enable GTK_DISABLE_DEPRECATED again, (set_interp_type), (main): port over · 9607ba37
      Kristian Rietveld authored
      Mon Oct 13 20:21:55 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* demos/testpixbuf-scale.c: enable GTK_DISABLE_DEPRECATED again,
      	(set_interp_type), (main): port over from option menu to GtkComboBox.
      9607ba37
    • Kristian Rietveld's avatar
      Still uses option menus, so turn off GTK_DISABLE_DEPRECATED. · d4627e1d
      Kristian Rietveld authored
      Mon Oct 13 19:41:55 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* tests/testmenus.c: Still uses option menus, so turn off
      	GTK_DISABLE_DEPRECATED.
      d4627e1d
    • Federico Mena Quintero's avatar
      Read the file's information from gnome-vfs if we haven't finished loading · 1d8d7be3
      Federico Mena Quintero authored
      2003-10-12  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtkfilesystemgnomevfs.c (gtk_file_folder_gnome_vfs_get_info):
      	Read the file's information from gnome-vfs if we haven't finished
      	loading the directory yet.
      
      	* gtkfilechooserimpldefault.c (tree_selection_changed): Set the
      	sensitivity of the bookmarks button depending on whether the
      	current folder already exists in the bookmarks list.
      	(shortcuts_selection_changed): Re-select the appropriate shortcuts
      	folder if the user clicks on the separator row.
      	(set_list_model): New function; moved the code from
      	tree_selection_changed().
      	(tree_selection_changed): Use set_list_model().
      	(create_folder_tree): Show the tree model only if we are in folder
      	mode.
      	(create_file_list): Show the list model only if we are not in
      	folder mode.
      1d8d7be3
  4. 11 Oct, 2003 8 commits
    • Matthias Clasen's avatar
      Move GET_PRIVATE macros from header to implementation. · 9119557b
      Matthias Clasen authored
      Sun Oct 12 01:10:29 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkalignment.[hc]:
      	* gtk/gtkcombobox.[hc]:
      	* gtk/gtkcomboboxentry.[hc]:
      	* gtk/gtktreemodelfilter.[hc]: Move GET_PRIVATE macros
      	from header to implementation.
      9119557b
    • Matthias Clasen's avatar
      Add the get_type() functions for GtkEntryCompletion, GtkTreeModelFilter, · c4739fb5
      Matthias Clasen authored
      Sun Oct 12 00:33:48 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtk.types: Add the get_type() functions for
      	GtkEntryCompletion, GtkTreeModelFilter, GtkCellLayout,
      	GtkComboBox, GtkComboBoxEntry.
      c4739fb5
    • Matthias Clasen's avatar
      These files still use option menus, so turn off GTK_DISABLE_DEPRECATED to · 99925612
      Matthias Clasen authored
      Sun Oct 12 00:18:02 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/testtreeview.c:
      	* demos/testpixbuf-scale.c:
      	* tests/prop-editor.c: These files still use option menus,
      	so turn off GTK_DISABLE_DEPRECATED to fix the build.
      99925612
    • Matthias Clasen's avatar
      Add G_BEGIN_DECLS/G_END_DECLS to make these usable in C++. (#124351, · c44e5b00
      Matthias Clasen authored
      Sat Oct 11 23:14:36 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkactiongroup.h:
      	* gtk/gtkaction.h:
      	* gtk/gtkradioaction.h:
      	* gtk/gtkradiotoolbutton.h:
      	* gtk/gtkseparatortoolitem.h:
      	* gtk/gtktoggleaction.h:
      	* gtk/gtktoolitem.h:
      	* gtk/gtkuimanager.h: Add G_BEGIN_DECLS/G_END_DECLS to make
      	these usable in C++.  (#124351, Murray Cumming)
      c44e5b00
    • Kristian Rietveld's avatar
      Check if completion is non-NULL before accessing it. Oops. · 407e957c
      Kristian Rietveld authored
      Sat Oct 11 19:09:05 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkentry.c (gtk_entry_set_text): Check if completion is
      	non-NULL before accessing it. Oops.
      407e957c
    • Kristian Rietveld's avatar
      the gchar* parameters should be const (pointed out by both Marco Pesenti · 761a6745
      Kristian Rietveld authored
      Sat Oct 11 15:47:03 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkentrycompletion.[ch] (gtk_entry_completion_insert_action),
      	(gtk_entry_completion_insert_action_text),
      	(gtk_entry_completion_insert_action_markup): the gchar* parameters
      	should be const (pointed out by both Marco Pesenti Gritti and
      	Murray Cumming (#124356).
      761a6745
    • Kristian Rietveld's avatar
      for the custom child list mode, allocate the height allocation->height to · d75b1a1a
      Kristian Rietveld authored
      Sat Oct 11 15:37:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_size_allocate): for the custom
      	child list mode, allocate the height allocation->height to the
      	button instead of the height requested by the button. (Tiny
      	size allocation screwup noticed by Macro Pesenti Gritti).
      d75b1a1a
    • Kristian Rietveld's avatar
      Fixes based on comments from Marco Pesenti Gritti. · c3841e70
      Kristian Rietveld authored
      Sat Oct 11 15:23:27 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes based on comments from Marco Pesenti Gritti.
      
      	* gtk/gtkentry.c (gtk_entry_set_text): block the completion changed
      	signal handler, avoids the completion popup to popup when text is
      	set programmatically in most cases (we actually have to handle this
      	in the _editable functions as well, but that will break popping up
      	when the user actually typed something :),
      	(gtk_entry_completion_key_press): when handling enter, bail out
      	when nothing has been selected,
      	(gtk_entry_completion_changed): don't popdown when the entry content
      	changed.
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_init),
      	(gtk_entry_completion_selected_changed): unselect_all on the
      	first selected changed signal. Avoids having a default row selected,
      	(_gtk_entry_completion_popup): don't select the first row by default.
      
      	* gtk/gtkentryprivate.h (struct _GtkEntryCompletionPrivate): add a
      	first_sel_changed field.
      c3841e70
  5. 10 Oct, 2003 4 commits
    • Matthias Clasen's avatar
      Included gtk_progress_bar_get_orientation() in the list of undeprecated · 3b2003c9
      Matthias Clasen authored
      Sat Oct 11 00:18:46 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/tmpl/gtkprogressbar.sgml: Included
      	gtk_progress_bar_get_orientation() in the list of undeprecated
      	functions, use less clumsy markup for enumerations.
      3b2003c9
    • Matthias Clasen's avatar
      Replace GtkItemFactory by GtkUIManager in the intro (again). · dd548173
      Matthias Clasen authored
      Fri Oct 10 23:02:58 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* demos/gtk-demo/menus.c: Replace GtkItemFactory by GtkUIManager
      	in the intro (again).
      dd548173
    • Matthias Clasen's avatar
      Fixes for (#124212, Marco Pesenti Gritti): · e8bcc9af
      Matthias Clasen authored
      Fri Oct 10 22:50:05 2003  Matthias Clasen  <maclas@gmx.de>
      
      	Fixes for (#124212, Marco Pesenti Gritti):
      
      	* gtk/gtkuimanager.c (update_smart_separators): Don't spit
      	warnings for popups.
      	(_gtk_menu_is_empty): Return FALSE for non-menus.
      e8bcc9af
    • Kristian Rietveld's avatar
      Deprecate. Ditto. · e6100ecd
      Kristian Rietveld authored
      Fri Oct 10 19:10:12 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcombo.h: Deprecate.
      	* gtk/gtkoptionmenu.h: Ditto.
      
      	* gtk/gtkcombobox.c (gtk_combo_box_size_request),
      	(gtk_combo_box_size_allocate): Rework, things behave better now. Still
      	needs some work on requesting enough size when taking the items in
      	the list into account.
      
      	* gtk/gtkfilesel.c: put gtkoptionmenu.h include inside "enable
      	deprecated" guards.
      	* gtk/gtkinputdialog.c: ditto.
      	* gtk/gtkitemfactory.c: ditto.
      	* gtk/gtkoptionmenu.c: ditto.
      
      	* demos/gtk-demo/menus.c: remove the option menu.
      	* demos/gtk-demo/sizegroup.c: replace the option menus with
      	GtkComboBox.
      	* demos/gtk-demo/textview.c: ditto.
      	(A general GtkComboBox demo will be added later on).
      e6100ecd
  6. 09 Oct, 2003 2 commits
    • Federico Mena Quintero's avatar
      7d9c4f6e
    • Federico Mena Quintero's avatar
      Autosize the columns after the model is set. (shortcuts_append_path): Add · 3415416b
      Federico Mena Quintero authored
      2003-10-08  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtkfilechooserimpldefault.c (tree_selection_changed): Autosize
      	the columns after the model is set.
      	(shortcuts_append_path): Add optional indentation to items.
      	(shortcuts_append_bookmarks): Indent bookmark items.
      	(create_shortcuts_tree): Set the "xpad" attribute of the name
      	renderer to be fetched from the indent column.
      	(shortcuts_append_bookmarks): Use NULL for the name of the
      	bookmarks node, so that a separator gets drawn.
      	(create_shortcuts_tree): Create a GtkCellRendererSepText.
      
      	* gtkcellrendererseptext.[ch]: New files with a cell renderer that
      	can display text or a separator line.
      
      	* Makefile.am (libgtkfilechooser_la_SOURCES): Added
      	gtkcellrendererseptext.[ch].
      3415416b
  7. 08 Oct, 2003 2 commits
    • Raymond Penners's avatar
      Released 0.5.0 · 52595ffa
      Raymond Penners authored
      52595ffa
    • Federico Mena Quintero's avatar
      Added methods for ::get_supports_bookmarks(), ::set_bookmarks(), · 462aab4a
      Federico Mena Quintero authored
      2003-10-07  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtkfilesystem.h (struct _GtkFileSystemIface): Added methods for
      	::get_supports_bookmarks(), ::set_bookmarks(), ::list_bookmarks().
      	Added a ::bookmarks_changed() signal.
      
      	* gtkfilesystem.c (gtk_file_system_get_supports_bookmarks): New function.
      	(gtk_file_system_set_bookmarks): New function.
      	(gtk_file_system_list_bookmarks): New function.
      	(gtk_file_system_base_init): Create the "bookmarks-changed" signal.
      	(gtk_file_paths_copy): New function.
      
      	* gtkfilesystemunix.c (gtk_file_system_unix_get_supports_bookmarks): Implement.
      	(gtk_file_system_unix_set_bookmarks): Implement.
      	(gtk_file_system_unix_get_bookmarks): Implement.
      
      	* gtkfilesystemgnomevfs.c (struct _GtkFileSystemGnomeVFS): Added
      	fields for the bookmarks and the GConfClient.
      	(gtk_file_system_gnome_vfs_set_bookmarks): Implement.
      	(gtk_file_system_gnome_vfs_list_bookmarks): Implement.
      
      	* gtkfilechooserprivate.h (struct _GtkFileChooserIface): Added
      	methods for ::set_shortcut_folders(), ::list_shortcut_folders().
      
      	* gtkfilechooser.c (gtk_file_chooser_set_shortcut_folders): New
      	function.
      	(gtk_file_chooser_list_shortcut_folders): New function.
      
      	* gtkfilechooserimpldefault.c (create_shortcuts_model): Unref the
      	old shortcuts model if it exists.  Create the nodes for the
      	app-specific shortcut folders.
      	(struct _GtkFileChooserImplDefault): Added a field for the
      	shortcut_folders.
      	(gtk_file_chooser_impl_default_set_shortcut_folders): Implement.
      	(select_shortcuts_folder): New helper function.
      	(gtk_file_chooser_impl_default_set_current_folder): Use
      	select_shortcuts_folder().
      	(shortcuts_append_path): Get the file info here, instead of the
      	caller.
      	(shortcuts_append_home): Use shortcuts_append_path().
      	(shortcuts_append_file_system_roots): Likewise.
      	(create_shortcuts_model): Add the app-specific shortcut folders
      	and the bookmarks.
      	(gtk_file_chooser_impl_default_list_shortcut_folders): Implement.
      	(create_shortcuts_tree): Added a button to let the user add the
      	current folder to the bookmarks.
      	(gtk_file_chooser_impl_default_set_property): Connect to
      	"bookmarks-changed" on the file system.
      	(shortcuts_append_bookmarks): New function.
      
      	* configure.ac: Depend on GConf.
      462aab4a
  8. 07 Oct, 2003 11 commits