This adds specific marshallers for all of the locations where a generic
marshaller is being used. It also provides va_marshallers to reduce the
chances that we get stack traces from perf going through ffi_call_unix64.

This is forward ported from gtk-3-24.

# Conflicts:
#	gtk/gtkeventcontrollerkey.c
#	gtk/gtkeventcontrollermotion.c
#	gtk/gtkgesture.c
#	gtk/gtkgesturemultipress.c

Move private api into a private header.

Remove comments that are old enough to still
talk about option menus and item factories.

No use of GtkArrowPlacement anywhere.

The menu shell is not a direct parent anymore.

Now that menubar and menu are containers
with internal structure, we need to be
careful about doing the right thing in
forall and dispose.

Left/Right arrow now work again to enter
or leave a submenu.

Home, End, Page Up/Down, work again.

This gets us most of the way to working scrolling.

Make GtkMenuBar use a box as well,
and let GtkMenuShell get the items
from GtkMenuBar and GtkMenu via
a vfunc. Use that to fix the keynav
implementation in GtkMenuShell.

This brings back some support for scrolling.
We still need to reinstate some of the
scroll-to-selected and keynav functionality.

This makes some of the GtkMenuShell api
no longer work, since we don't let the
menu shell code maintain the list of
children anymore.

Nothing should use them anymore.

This commit removes support for scrolling and
for the keep-up triangle from GtkMenu, and gets
rid of all use of global coordinates.

Benjamin Otte authored Apr 25, 2019 and Matthias Clasen committed May 31, 2019

No need to do complicated math when we can just look at the allocation.

Benjamin Otte authored Apr 21, 2019 and Matthias Clasen committed May 31, 2019

Returns the parent menu shell or NULL.

Replace all calls to gtk_widget_get_parent() with this function.

Lubomir Rintel authored May 30, 2019 and Matthias Clasen committed May 31, 2019

Changes

  <object class="GtkDialog">
    <child internal-child="vbox">
      <...>
        <child internal-child="action_area">...</child>
        ...
      </...>
      <packing />
    </child>
  <object>

to

  <object class="GtkDialog">
    <child internal-child="content_area">
      <...>
        ...
      </...>
    </child>
    <child internal-child="action_area">...</child>
  <object>

If the gtk-overlay-scrolling setting is FALSE,
don't use overlay scrollbars.

This is in preparation for letting user opt out of
overlay scrolling in the control-center.

Similar to previous removals of g_cclosure_marshal_VOID__VOID we can remove
other marshallers for which are a simple G_TYPE_NONE with single parameter.
In those cases, GLib will setup both a c_marshaller and va_marshaller for
us. Before this commit, we would not get a va_marshaller because the
c_marshaller is set.

Related to Initiatives#10

The CSS transform should operate on the border-box, not the margin box.
So we need to shrink the bounds by the margin before we apply the CSS
transform.

Fixes several warnings by the GIR compiler.

Use cairo-script-interpreter to parse the scripts that generate cairo
nodes.

This requires libcairoscriptinterpreter.so to work properly, but if
it isn't found we disable this (unimportant for normal functioning)
code and just emits a parser warning.
The testsuite requires it however or it will fail.

A new test is included that tests all of this.

...and its property. Otherwise simplify_element() blows up when looking
up the hierarchy to determine a property type.

  $ gtk4-builder-tool simplify --3to4 /dev/stdin <<EOF
  > <?xml version="1.0" encoding="UTF-8"?>
  > <!-- Generated with glade 3.20.2 -->
  > <interface domain="nm-applet">
  >   <object class="GtkAssistant">
  >     <child>
  >       <object class="GtkBox" id="confirm_page">
  >       </object>
  >       <packing>
  >         <property name="page_type">confirm</property>
  >         <property name="complete">True</property>
  >       </packing>
  >     </child>
  >   </object>
  > </interface>
  > EOF
  /dev/stdin: Packing property GtkAssistant::page_type not found
  /dev/stdin: Packing property GtkAssistant::complete not found
  Segmentation fault (core dumped)

We were deferring the reflow until map, but this
leads to the section initially having an enormous
height and the window picks up that size before
we have a chance to reflow, This could be seen
in the "Builder" demo in gtk4-demo.

Closes: #11

If we set c_marshaller manually, then g_signal_newv() will not setup a
va_marshaller for us. However, if we provide c_marshaller as NULL, it will
setup both the c_marshaller (to g_cclosure_marshal_VOID__VOID) and
va_marshaller (to g_cclosure_marshal_VOID__VOIDv) for us.

Remove an unused variable.

We don't have windowed widgets anymore, and
gdk_surface_move_resize is about to go away.

position_constraints_changed is never used.

With gtk_window_set_position gone, we should never
come up with a new position to set in this code.

Leave a warning in place and remove the gdk_surface_move
calls.

gtk_window_constrain_position is not doing anything
anymore, so no need to call it.

need_default_position is never used.

initial_x/y and initial_pos_set are never used.

Root coordinates are going away. Stop
setting them in crossing events, so we
can drop this api.