1. 19 Apr, 2002 4 commits
    • Kristian Rietveld's avatar
      add _gtk_tree_view_column_autosize · 3e0a1a51
      Kristian Rietveld authored
      Fri Apr 19 23:38:16 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeprivate.h: add _gtk_tree_view_column_autosize
      
              * gtk/gtktreeview.c: privately export _gtk_tree_view_column_autosize,
              and add a small note about that function,
              (gtk_tree_view_button_press): check for double click and
              "not having an autosize" column before autosizing the column,
      
              * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_min_width):
              call _gtk_tree_view_column_autosize to update autosized column width
              (gtk_tree_view_column_set_max_width): ditto
      3e0a1a51
    • Kristian Rietveld's avatar
      cancel editing if tree_view->priv->edited_column != NULL (fixes #76066) · ae89375b
      Kristian Rietveld authored
      Fri Apr 19 21:31:04 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_row_changed): cancel editing
              if tree_view->priv->edited_column != NULL (fixes #76066)
      ae89375b
    • Kristian Rietveld's avatar
      subtract TREE_VIEW_HEADER_HEIGHT from allocation->height to get the real · a1f3d61d
      Kristian Rietveld authored
      Fri Apr 19 21:06:39 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_size_allocate): subtract
              TREE_VIEW_HEADER_HEIGHT from allocation->height to get the real
              size for the tree (fixes #72729),
              (gtk_tree_view_real_start_editing): correct cell_area->y for
              scrolling due to gtk_tree_view_real_set_cursor (fixes #75687)
      a1f3d61d
    • Kristian Rietveld's avatar
      rename last_single_clicked{,_2} to last_button_press{,_2}, as the latter · d3a12949
      Kristian Rietveld authored
      Fri Apr 19 16:30:09 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeprivate.h, gtk/gtktreeview.c: rename
              last_single_clicked{,_2} to last_button_press{,_2}, as the latter
              is a more sane name.
      
              * gtk/gtktreeview.c (gtk_tree_view_button_press): use ->priv->anchor
              instead of ->priv->cursor, check for the anchor at another place, as
              you can go in edit mode without having an anchor.
      d3a12949
  2. 16 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      check ->priv->cursor and ->priv->anchor rowrefs before removing · 8fbac80b
      Kristian Rietveld authored
      Tue Apr 16 17:28:21 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): check
              ->priv->cursor and ->priv->anchor rowrefs before removing
              node->children from the rbtree. Also check the
              ->priv->last_single_clicked and ->priv->last_single_clicked_2 rowrefs
              (I think I really need to rename those two someday).
      8fbac80b
  3. 14 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      add _gtk_tree_view_column_get_editable_cell and · 54db0fc9
      Kristian Rietveld authored
      Sun Apr 14 16:56:59 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeprivate.h: add _gtk_tree_view_column_get_editable_cell and
              _gtk_tree_view_column_get_neighbor_sizes
      
              * gtk/gtktreeviewcolumn.c (struct _GtkTreeViewColumnCellInfo): add
              real_width field,
              (_gtk_tree_view_column_get_editable_cell): implement,
              (gtk_tree_view_column_cell_process_action): fill info->real_width
              (_gtk_tree_view_column_get_neighbor_sizes): implement
      
              * gtk/gtktreeview.c (gtk_tree_view_button_press): make the "editable
              widget" show up with the same size as the actual cell, so it doesnt
              cover the complete column if there are any other cells in that column.
      54db0fc9
  4. 13 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      Fixes #75510 · 2666ab46
      Kristian Rietveld authored
      Sat Apr 13 22:49:45 2002  Kristian Rietveld  <kris@gtk.org>
      
              Fixes #75510
      
              * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): make this
              function work correctly and more sane
      
              * gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): remove
              node->children from rbtree before emitting GtkTreeSelection::changed
      
      Sat Apr 13 17:15:12 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_init): dont set
              the mode to GTK_CELL_RENDERER_MODE_EDITABLE by default,
              (gtk_cell_renderer_text_class_init): for some reason our default for
              editable was TRUE, of course this is FALSE.
              (gtk_cell_renderer_text_set_property): update mode when editable
              has been changed.
      2666ab46
  5. 12 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      add clamp_node argument (toplevel): update usages of · 8e84c6b9
      Kristian Rietveld authored
      Fri Apr 12 18:32:46 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_real_set_cursor): add
              clamp_node argument
              (toplevel): update usages of gtk_tree_view_real_set_cursor,
              (gtk_tree_view_focus_to_cursor): don't let
              gtk_tree_view_real_set_cursor clamp the node, so you won't get
              unexpected scrolling
      8e84c6b9
  6. 09 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      Fixes #78110 · 64e33eb6
      Kristian Rietveld authored
      Tue Apr  9 21:41:24 2002  Kristian Rietveld  <kris@gtk.org>
      
              Fixes #78110
      
              * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
              add override_browse_mode argument and implement,
              (gtk_tree_selection_unselect_path): always unselect the path,
              (toplevel): update uses of _gtk_tree_selection_internal_select_node
      
              * gtk/gtktreeview.c: update uses of
              _gtk_tree_selection_internal_select_node
      
              * gtk/gtktreeprivate.h (_gtk_tree_selection_internal_select_node):
              update prototype
      
      Tue Apr  9 21:39:44 2002  Kristian Rietveld  <kris@gtk.org>
      
              Fixes #77862
      
              * gtk/gtktreeprivate.h: add _gtk_tree_view_column_has_editable_cell
      
              * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_has_editable_cell):
              new function
      
              * gtk/gtktreeview.c (gtk_tree_view_button_press): send cell event
              on first click when cell isn't editable
      
      Tue Apr  9 21:37:31 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreedatalist.c (_gtk_tree_data_list_check_type): add some
              types which were missing and useful to use (fixes #77870)
      64e33eb6
  7. 05 Apr, 2002 2 commits
    • Kristian Rietveld's avatar
      free anchor row reference after unselecting the selection (fixes #76272) · 6d4655b0
      Kristian Rietveld authored
      Fri Apr  5 18:28:56 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeselection.c (gtk_tree_selection_set_mode): free
              anchor row reference after unselecting the selection (fixes #76272)
      
      Fri Apr  5 18:27:48 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_real_expand_row): only return
              when we don't have to open all children (fixes #75736)
      
      Fri Apr  5 18:24:24 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_clear): unref
              cellrenderer after clearing the attributes of the renderer (fixes
              #75592)
      6d4655b0
    • Jonathan Blandford's avatar
      implement. (gtk_tree_view_move_cursor_up_down): check for focus · 8c114fa6
      Jonathan Blandford authored
      Fri Apr  5 05:55:14 2002  Jonathan Blandford  <jrb@gnome.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_grab_focus): implement.
      	  (gtk_tree_view_move_cursor_up_down): check for focus
      	  (gtk_tree_view_move_cursor_page_up_down): ditto
      	  (gtk_tree_view_move_cursor_left_right): ditto
      	  (gtk_tree_view_move_cursor_start_end): ditto
      	  (gtk_tree_view_real_select_all): ditto
      	  (gtk_tree_view_real_unselect_all): ditto
      	  (gtk_tree_view_real_select_cursor_row): ditto
      	  (gtk_tree_view_real_toggle_cursor_row): ditto
      	  (gtk_tree_view_real_expand_collapse_cursor_row): ditto
      	  (gtk_tree_view_real_select_cursor_parent): ditto
      	  (gtk_tree_view_real_start_interactive_search): ditto
      
      	* gtk/gtktreeviewcolumn.c: grab focus
      8c114fa6
  8. 01 Apr, 2002 1 commit
    • Kristian Rietveld's avatar
      add check for y > tree_view->priv->height (fixes #76974) · 30896669
      Kristian Rietveld authored
      Mon Apr  1 22:20:24 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): add
              check for y > tree_view->priv->height (fixes #76974)
      
      Mon Apr  1 22:19:39 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreemodelsort.c (gtk_tree_model_sort_sort_level): get
              the stamp changes right this time
      
      Mon Apr  1 22:13:24 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreemodel.c (gtk_tree_row_reference_free): only
              disconnect the ref callbacks when model == proxy (Thanks go to
              Manuel Clos Crespo for the remote debugging)
      30896669
  9. 28 Mar, 2002 1 commit
  10. 27 Mar, 2002 1 commit
  11. 26 Mar, 2002 1 commit
  12. 25 Mar, 2002 1 commit
    • Jonathan Blandford's avatar
      Make path arg const, #75653 · 7cc14762
      Jonathan Blandford authored
      Sun Mar 24 10:32:38 2002  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
      
      	* gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
      	a warning
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
      	when we emit row_activated so that listeners of this signal can
      	grab the mouse, #75629
      7cc14762
  13. 20 Mar, 2002 3 commits
    • Kristian Rietveld's avatar
      fix logic (fixes #74235, #73593) · dc5be9ed
      Kristian Rietveld authored
      Thu Mar 21 00:05:14 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
              (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
      dc5be9ed
    • Kristian Rietveld's avatar
      add _gtk_rbtree_set_fixed_height() · 92febe27
      Kristian Rietveld authored
      Wed Mar 20 22:59:23 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
      
              * gtk/gtktreeprivate.h: add fixed_height_check field
      
              * gtk/gtktreeview.c (gtk_tree_view_init): initialize
              scroll_sync_timer and fixed_height_check
              (do_validate_rows): add fixed_height_check. If all validated rows
              in the first cycle have the same height, then we set that height for
              the entire tree. This is some sort of 'fake' optimization, but helps
              a lot for the common case. We keep validating the entire tree in
              the background though.
              (gtk_tree_view_set_model): reset fixed_height_check
      92febe27
    • Owen Taylor's avatar
      Patch from Erwann Chenede, #73900 fixing a lot of warnings with Forte CC, · 8acfd1e9
      Owen Taylor authored
      Wed Mar 20 16:36:08 2002  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
              a lot of warnings with Forte CC, mostly implicit
              casts between void * and function pointers.
      
              * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
              state field is not a GdkModifierType. (Also #73900)
      8acfd1e9
  14. 17 Mar, 2002 1 commit
  15. 16 Mar, 2002 1 commit
    • Kristian Rietveld's avatar
      just return when we have an input_only window (fix by Owen Taylor) · bd7678c7
      Kristian Rietveld authored
      Sat Mar 16 23:54:56 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
              return when we have an input_only window (fix by Owen Taylor)
      
              * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
              scroll_sync_timer
      
              * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
              (scroll_sync_handler): ditto,
              (gtk_tree_view_unrealize): take scroll_sync_timer into account
              (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
              calling top_row_to_dy/dy_to_top_row directly
              -- this greatly speeds up clearing the model (#73199)
      
              * gtk/gtktreemodelsort.c
              (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
              for some reason I really screwed it up (fixes #74663)
      bd7678c7
  16. 15 Mar, 2002 1 commit
  17. 11 Mar, 2002 2 commits
  18. 08 Mar, 2002 1 commit
    • Jonathan Blandford's avatar
      get rid of really bad focus loop. (gtk_tree_view_clamp_node_visible): only · 540751b9
      Jonathan Blandford authored
      Thu Mar  7 16:46:58 2002  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreeview.c (validate_visible_area): get rid of really
      	bad focus loop.
      	(gtk_tree_view_clamp_node_visible): only clamp the node when
      	realized.  Need to replace this with scroll_to_cell sometime.
      	(gtk_tree_view_header_focus): clickable or reorderable columns are
      	focusable, #73656
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_get_widget): fix
      	docs to reflect behaviour change, #73682
      540751b9
  19. 07 Mar, 2002 2 commits
    • Jonathan Blandford's avatar
      start implementing · 110e1cd7
      Jonathan Blandford authored
      Thu Mar  7 02:58:16 2002  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/tmpl/gtkliststore.sgml: start implementing
      
      	* gtk/question_index.sgml: "I can set with the tree, but not
      	get???!?!"
      
      Wed Mar  6 23:20:51 2002  Jonathan Blandford  <jrb@redhat.com>
      and			  Kristian Rietveld  <kris@gtk.org>
      
      	Finishing touch for 2.0.0 release, fixes #70782, #72729, the
      	'stealth' bug and other last-minute minor issues.
      
      	* gtk/gtktreeview.c (gtk_tree_view_bin_expose): set dnd dest line
      	drawing right. We can't draw the line at the position of the next
      	row, because that one still has to be drawn. So draw everthing at
      	a -1 offset.
      	(validate_visible_area): add check for invalid descendants and
      	NULL scroll_to_path path, get scrolling right.  Also, fix the
      	area_above value.  Pretty amazing I got it wrong.
      	(get_logical_dest_row): add gtk-tree-model-drop-append magic, so
      	dragging a row to the end of the model works right.
      	(gtk_tree_view_get_dest_row_at_pos): minor floating point fix
      	(gtk_tree_view_start_editing): add call to validate_row
      	(gtk_tree_view_tree_to_widget_coords): Never subtract
      	HEADER_HEIGHT from y values anymore!!!
      	(gtk_tree_view_widget_coords_to_tree): ditto.
      	(gtk_tree_view_scroll_to_point): allow -1 as values for the
      	scroll_to coords
      	(gtk_tree_view_move_cursor_page_up_down): Don't need scroll_to_y
      	as clamp_node_visible will make it work.
      
      	* gtk/gtktreestore.c (gtk_tree_store_drag_data_received): also check
      	path depth, as we can't get iters from empty paths
      
      	* gtk/gtkliststore.c (gtk_list_store_drag_data_received): handle
      	gtk-tree-model-drop-append
      
      	* gtk/gtktreednd.c (gtk_tree_set_row_drag_data): free path_str
      
      	* tests/testtreeflow.c (main): select path where we are scrolling to
      110e1cd7
    • Darin Adler's avatar
      Update offsets before finding where to insert the new value. · 1845cc43
      Darin Adler authored
      	* gtk/gtktreemodelsort.c: (gtk_tree_model_sort_insert_value):
      	Update offsets before finding where to insert the new value.
      
      	* gtk/gtktreeview.c: (validate_visible_area): Make sure we redraw when
      	we scroll, instead of just updating the scroll position variables.
      1845cc43
  20. 05 Mar, 2002 2 commits
    • Matthias Clasen's avatar
      Fix docs. · 981574a9
      Matthias Clasen authored
      	* gtk/gtktreemodel.c (gtk_tree_row_reference_deleted): Fix docs.
      
      	* gtk/gtkwindow.c (gtk_window_remove_mnemonic):
      	(gtk_window_add_mnemonic):
      	(gtk_window_mnemonic_activate): Add docs.
      
      	* gtk/gtktreeview.c (gtk_tree_view_get_search_equal_func): Fix
      	typo in docs.
      
      	* test-loaders.c, test-images.h: More random tests.
      
      	* io-bmp.c (DecodeHeader): Fail gracefully on OOM here.
      
      	* gtk/gtk-sections.txt: Remove gtk_win32_get_installation_directory.
      981574a9
    • Owen Taylor's avatar
      Don't use this same functions as idle callbacks and directly, to avoid · 3305137f
      Owen Taylor authored
      Tue Mar  5 10:29:09 2002  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtktreeview.c (do_presize_handler)
      	gtk/gtktreeview.c (do_validate_rows): Don't use this
      	same functions as idle callbacks and directly, to avoid
      	threading deadlocks. (#72392, Scott Guilbeaux)
      
      	* gtk/gtktable.c (gtk_table_size_request_init): Fix
      	row/column confusion from recent patch. (#73505,
      	Vitaly Tishkov.)
      3305137f
  21. 03 Mar, 2002 1 commit
  22. 01 Mar, 2002 1 commit
    • Kristian Rietveld's avatar
      set first_cell to FALSE after first iteration · aa83195a
      Kristian Rietveld authored
      Fri Mar  1 23:59:35 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_get_size): set
              first_cell to FALSE after first iteration
      
              * gtk/gtktreeview.c (validate_visible_area): reduce usage of
              GTK_RBNODE_GET_HEIGHT, check for node != NULL,
              (gtk_tree_view_top_row_to_dy): remove call to gtk_adjustment_changed
              (gtk_tree_view_search_iter): select iter after scrolling
      aa83195a
  23. 26 Feb, 2002 2 commits
  24. 25 Feb, 2002 1 commit
    • Kristian Rietveld's avatar
      free iter before going to done · 4d06c9d0
      Kristian Rietveld authored
      Mon Feb 25 01:14:26 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktextlayout.c (find_display_line_above): free iter before
              going to done
      
              * gtk/gtktreeview.c (validate_visible_area): free above_path,
              (set_destination_row): free path before returning,
              (gtk_tree_view_set_drag_dest_row): free current_dest
      4d06c9d0
  25. 24 Feb, 2002 2 commits
    • Jonathan Blandford's avatar
      at Feb 23 23:00:48 2002 Jonathan Blandford <jrb@redhat.com> · a265926e
      Jonathan Blandford authored
      	* gtk/gtktreemodel.h: add () to function macros as per owen's
      	request.
      
      	* gtk/gtkfontsel.c: (gtk_font_selection_select_best_style),
      	(gtk_font_selection_show_available_sizes),
      	(gtk_font_selection_set_font_name):
      	* gtk/gtktreemodel.c: (gtk_tree_model_get_iter_first),
      	(gtk_tree_model_foreach):
      	* gtk/gtktreemodelsort.c: (gtk_tree_model_sort_sort_level),
      	(gtk_tree_model_sort_build_level):
      	* gtk/gtktreeselection.c: (gtk_tree_selection_selected_foreach):
      	* gtk/gtktreeview.c: (validate_visible_area),
      	(gtk_tree_view_focus_to_cursor), (gtk_tree_view_set_model),
      	(gtk_tree_view_map_expanded_rows), (gtk_tree_view_search_move),
      	(gtk_tree_view_search_init):
      	* tests/testtreeview.c: (run_automated_tests): change iter_root
      	to iter_first
      a265926e
    • Jonathan Blandford's avatar
      Didn't refind node when it was NULL. Bug found by Tor Lillqvist. · 779ce437
      Jonathan Blandford authored
      Sat Feb 23 19:05:34 2002  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreeview.c (validate_visible_area): Didn't refind node
      	when it was NULL.  Bug found by Tor Lillqvist.
      779ce437
  26. 23 Feb, 2002 3 commits
    • Jonathan Blandford's avatar
      delay scrolling until we try to draw the window. · b2539ba4
      Jonathan Blandford authored
      Wed Feb 20 16:44:05 2002  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): delay
      	scrolling until we try to draw the window.
      
      	* gtk/gtktreeview.c (validate_visible_area): Implement
      	scroll_to_cell.
      b2539ba4
    • Kristian Rietveld's avatar
      honor min_width and max_width while resizing columns (pointed out by Jorn · c1a26cc3
      Kristian Rietveld authored
      Sat Feb 23 03:10:20 2002  Kristian Rietveld  <kris@gtk.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_key_press): honor min_width and
              max_width while resizing columns (pointed out by Jorn Baayen)
      c1a26cc3
    • Owen Taylor's avatar
      Fixes for AIX compilation from Miroslaw Dobrzanski-Neumann, #72182. · a504db9e
      Owen Taylor authored
      Fri Feb 22 18:36:45 2002  Owen Taylor  <otaylor@redhat.com>
      
      	Fixes for AIX compilation from Miroslaw Dobrzanski-Neumann,
      	#72182.
      
      	* demos/gtk-demo/main.c gtk/gtktreeview.c gtk/gtktoolbar.c
      	gtk/gtkpaned.c gtk/gtkobject.c gtk/gtkcontainer.c
      	gtk/gtkcolorsel.c gtk/gtkcellrender.c gdk/x11/xsettings-client.h:
      	Squash trailing commas on enumerations.
      
      	* gdk/gdktypes.h: Drop GDK_RELEASE_MASK to 1 << 30 instead
      	of 1 << 31 to work around AIX compiler problem. (C standard
      	seems to imply that compiler is required to use an unsigned
      	type for the enum value in this case.)
      
      	* gdk/gdkpixbuf-drawable.c: Fix lvalue casts.
      
      	* gtk/gtkwindow.h: Fix use of enum types for bitfields ...
      	compilers may choose to use a signed type for bitfields.
      a504db9e
  27. 22 Feb, 2002 1 commit