1. 15 Jun, 2005 6 commits
    • Matthias Clasen's avatar
      Keep a reference to the GdkCursor and add a private getter for it, so that · 3c96358f
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkwindow-x11.[hc]: Keep a reference to the
      	GdkCursor and add a private getter for it, so that we can
      	update the cursor when the cursor theme changes.
      
      	* gdk/gdk.symbols:
      	* gdk/x11/gdkx.h:
      	* gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
      	New function to change the cursor theme.
      3c96358f
    • Matthias Clasen's avatar
      Remove a lot of pointless g_return_if_fail() non-NULL checks. · cd872269
      Matthias Clasen authored
      2005-06-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkwindow-x11.c: Remove a lot of pointless
      	g_return_if_fail() non-NULL checks.
      cd872269
    • Matthias Clasen's avatar
      Make make check happier · abb3b2e7
      Matthias Clasen authored
      abb3b2e7
    • Matthias Clasen's avatar
      Fix some docs · f5bf23da
      Matthias Clasen authored
      f5bf23da
    • Matthias Clasen's avatar
      Fix 307689 · eee3d974
      Matthias Clasen authored
      eee3d974
    • Federico Mena Quintero's avatar
      Merged from gtk-2-6: · cd3c641c
      Federico Mena Quintero authored
      2005-06-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-6:
      
      	Fix #302087:
      
      	* gtk/gtkfilechooserdefault.c (list_selection_changed): Emit
      	"selection-changed" and do the normal housekeeping even if we are
      	in SAVE mode and there is nothing selected.  We didn't emit that
      	signal if we were in SAVE mode and unselect_all() got called.
      	(gtk_file_chooser_default_unselect_all): Call
      	pending_select_paths_free() so that we cancel any asynchronous
      	selections.
      	(gtk_file_chooser_default_set_current_name): Likewise.
      cd3c641c
  2. 14 Jun, 2005 6 commits
    • Federico Mena Quintero's avatar
      Merged from gtk-2-6: · fb323cfb
      Federico Mena Quintero authored
      2005-06-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-6:
      
      	Fixes #307640:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_should_respond): Oops, I broke SAVE
      	mode.  If the parent path is a folder, only create a subfolder if
      	we are in CREATE_FOLDER mode; if we are in SAVE mode, just return
      	and respond.  Also, pick up the case where the user types
      	"dirname/" instead of "dirname".
      	(check_save_entry): Make the return type void.  Add some return
      	parameters so that we can do more thorough checking.
      	(gtk_file_chooser_default_get_paths): If the file part is empty
      	and we are in SAVE mode, return an empty selection.
      fb323cfb
    • Kristian Rietveld's avatar
      Patch for #163214 (reported by Tommi Komulainen) and fixes some other · 5641d252
      Kristian Rietveld authored
      2005-06-15  Kristian Rietveld  <kris@gtk.org>
      
      	Patch for #163214 (reported by Tommi Komulainen) and fixes some
      	other scrolling/validation related bugs along the why.
      
      	* gtk/gtktreeview.c (gtk_tree_view_size_request): run
      	do_validate_rows once and don't queue a size request there,
      	(gtk_tree_view_size_allocate): don't update vadj value without
      	reason, sync top_row/dy after the window sizes and adjustments
      	are in sync again,
      	(validate_visible_area): always update dy when scrolling,
      	manually set top_row here after changing the vadj (don't depend
      	on _adjustment_changed and top_row/dy sync to do this), since we
      	now always set top_row here correctly, we can always free
      	scroll_to_path at the end which avoids infinite expose loops,
      	(do_validate_rows): add queue_resize boolean, remove top_row/dy
      	sync here, we cannot do it safely at this place since the
      	window sizes and adjustments are out of sync,
      	(validate_rows), (validate_rows_handler): update call to
      	do_validate_rows().
      5641d252
    • Matthias Clasen's avatar
      Add a stub for the no-Xcursor case. (noticed by Luis Villa) · daab95c2
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkcursor-x11.c (gdk_cursor_new_from_name): Add a
      	stub for the no-Xcursor case. (noticed by Luis Villa)
      daab95c2
    • Matthias Clasen's avatar
      Use named cursors for the DND cursors, the names are "dnd-none", · 920b5749
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	Use named cursors for the DND cursors, the names are "dnd-none",
      	"dnd-copy", "dnd-link", "dnd-move" and "dnd-ask". Also use an RGBA
      	cursor instead of cursor+window when possible. This saves
      	roundtrips during the drag operation, and makes translucent icons
      	possible.
      
      	* gtk/gtkdndcursors.h: New file, containing inlined pixbufs
      	for the default dnd cursors.
      
      	* gtk/gtkdnd.c (struct _GtkDragSourceInfo): Store the cursors
      	used during the drag here, also store the icon pixbuf here.
      
      	* gtk/gtkdnd.c (drag_cursors): Store the cursor names here. Also
      	switch the default cursors from xbm to inlined pixbufs.
      
      	* gtk/gtkdnd.c (gtk_drag_get_cursor): This function now takes the
      	GtkDragSourceInfo as well, since it has to composite the
      	drag-specific cursors. The cursors combined from the image of
      	the themed cursor and the icon_pixbuf stored in the info.
      
      	* gtk/gtkdnd.c (gtk_drag_begin_internal): Don't set the default
      	icon if there is an icon_pixbuf, which will be composited into
      	the cursor later.
      
      	* gtk/gtkdnd.c (set_icon_stock_pixbuf): If appropriate, store
      	the pixbuf in the info struct for later compositing into the
      	cursor instead of creating an icon window.
      
      	* gtk/gtkdnd.c (gtk_drag_drop_finished): If we used an
      	RGBA cursor for the drag, and need to display the cancel
      	animation, construct the icon window here.
      
      	* gtk/gtkdnd.c (gtk_drag_source_info_destroy): Unref the
      	drag-specific cursors and the icon_pixbuf when done with
      	the drag.
      920b5749
    • Matthias Clasen's avatar
      Use a named cursor with the name "color-picker", when available. · d1f2cb63
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcolorsel.c (make_picker_cursor): Use a named cursor
      	with the name "color-picker", when available.
      d1f2cb63
    • Matthias Clasen's avatar
      New functions to construct named cursors and to get the image used for a · 6b5b2698
      Matthias Clasen authored
      2005-06-14  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/gdk.symbols:
      	* gdk/gdkcursor.h:
      	* gdk/x11/gdkcursor-x11.c (gdk_cursor_get_image)
      	(gdk_cursor_new_from_name): New functions to construct named
      	cursors and to get the image used for a cursor.
      6b5b2698
  3. 13 Jun, 2005 5 commits
    • Matthias Clasen's avatar
      Rework the way in which rerooting of the path bar is done, implementing · 60113bed
      Matthias Clasen authored
      
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkpathbar.[hc]: Rework the way in which rerooting of the
      	path bar is done, implementing the following principles:
      	(#137289, patch by Benjamin Otte)
      
      	1. Re-root only if $HOME is an ancestor of the current path.
      
      	2. When re-rooting, make sure the Left arrow appears in the path
      	bar, so that you can navigate up from $HOME to /.  In that case,
      	make sure the Right arrow doesn't appear if the sub-hierarchy from
      	$HOME to the cwd fits in the window.
      
      	3. Make sure that hitting Alt-Up takes you always one folder up,
      	even when the path bar is re-rooted.
      60113bed
    • Matthias Clasen's avatar
      Try harder not to modify readonly strings. (#307541, Torsten Schoenfeld) · 9962a15c
      Matthias Clasen authored
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
      	Try harder not to modify readonly strings. (#307541, Torsten Schoenfeld)
      9962a15c
    • Matthias Clasen's avatar
      Free the data of the row before overwriting it. (#307490, Kjartan Maraas) · ae1e9866
      Matthias Clasen authored
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserbutton.c (model_update_current_folder):
      	Free the data of the row before overwriting it.  (#307490,
      	Kjartan Maraas)
      ae1e9866
    • Kjartan Maraas's avatar
      Don't leak the cairo context. Closes bug #307426. · 58b9aed1
      Kjartan Maraas authored
      2005-06-13  Kjartan Maraas  <kmaraas@gnome.org>
      
      	* gtk/gtkcalendar.c: (calendar_paint_arrow): Don't
      	leak the cairo context. Closes bug #307426.
      58b9aed1
    • Matthias Clasen's avatar
      Make invisible text work a bit better (#66194, patch by Jeroen · 4b14b2d4
      Matthias Clasen authored
      2005-06-13  Matthias Clasen  <mclasen@redhat.com>
      
      	Make invisible text work a bit better (#66194, patch by
      	Jeroen Zwartepoorte)
      
      	* gtk/gtk.symbols:
      	* gtk/gtktextiter.[hc]: Add function to move by
      	visible lines.
      
      	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal):
      	Skip invisible text when moving by paragraphs.
      
      	* gtk/gtktextlayout.c (gtk_text_layout_move_iter_visually):
      	Skip invisible lines here too.
      4b14b2d4
  4. 12 Jun, 2005 8 commits
  5. 11 Jun, 2005 5 commits
  6. 10 Jun, 2005 9 commits
    • Matthias Clasen's avatar
      Allow setting paragraph background. (#81045, Gustavo Carneiro, patch by · 43f263a0
      Matthias Clasen authored
      2005-06-10  Matthias Clasen  <mclasen@redhat.com>
      
      	Allow setting paragraph background.  (#81045, Gustavo
      	Carneiro, patch by Jeroen Zwartepoorte)
      
      	* gtk/gtktextlayout.c (set_para_values): Propagate
      	pg_bg_color to the display struct.
      	(gtk_text_layout_free_line_display): Free it here.
      
      	* gtk/gtktextdisplay.c (render_para): If pg_bg_color
      	is set, draw a rectangle in that color behind
      	the paragraph.
      
      	* gtk/gtktexttag.c (gtk_text_tag_class_init): Add
      	paragraph-background, paragraph-background-gdk and
      	paragraph-background-set properties.
      	(set_pg_bg_color): A setter for paragraph-background.
      
      	* gtk/gtktextlayout.h (struct _GtkTextLineDisplay): Add
      	pg_bg_color.
      
      	* gtk/gtktexttag.h (struct _GtkTextAttributes): Add
      	pg_bg_color.
      	(struct _GtkTextTag): Add pg_bg_color_set.
      43f263a0
    • Kjartan Maraas's avatar
      Destroy the cairo surface when done with it. Plugs a fairly large leak in · 3003d2ed
      Kjartan Maraas authored
      2005-06-10  Kjartan Maraas  <kmaraas@gnome.org>
      
      	* gdk/gdkcairo.c: (gdk_cairo_set_source_pixbuf): Destroy the
      	cairo surface when done with it. Plugs a fairly large leak in
      	some cases.
      	==6014== 1999824 (115640 direct, 1884184 indirect) bytes in
      	826 blocks are definitely lost in loss record 25239 of 25250
      	Like this from nautilus.
      3003d2ed
    • Michael Natterer's avatar
      gtk/gtk.symbols new function to get an action's accel_closure (Fixes · e4384dca
      Michael Natterer authored
      2005-06-10  Michael Natterer  <mitch@imendio.com>
      
      	* gtk/gtk.symbols
      	* gtk/gtkaction.[ch] (gtk_action_get_accel_closure): new function
      	to get an action's accel_closure (Fixes #141750 and #148106).
      e4384dca
    • Matthias Clasen's avatar
      Generate N_() calls for translatable key names. · 79d82223
      Matthias Clasen authored
      2005-06-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/gen-keyname-table.pl: Generate N_() calls for
      	translatable key names.
      
      	* gdk/keynames.txt: Mark some key names as translatable.
      
      	* gdk/keyname-table.h: Regenerated.
      
      	* gtk/gtkaccellabel.c (gtk_accel_label_class_init): Add
      	some context to the msg ids for keyboard modifiers and
      	key names.
      	(_gtk_accel_label_class_get_accelerator_label): Try to
      	translate key names.  (#300224, Christian Rose)
      79d82223
    • Federico Mena Quintero's avatar
      Merged from gtk-2-6: · ab44ea2b
      Federico Mena Quintero authored
      2005-06-10  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-6:
      
      	Fixes #162358:
      
      	* gtk/gtkfilechooserdefault.c (update_chooser_entry): Don't return
      	immediately if we are in CREATE_FOLDER mode, so that we can fill
      	the entry with the newly-selected folder.
      	(gtk_file_chooser_default_set_property): Warn against turning on
      	multiple selection for CREATE_FOLDER mode, or about setting that
      	action while multiple selection is on.
      	(update_chooser_entry): Change the entry's contents as well if we
      	are in CREATE_FOLDER mode.  If nothing is selected, clear the
      	chooser entry.
      	(trap_activate_cb): Don't trap enter/space if modifiers are
      	pressed.  This lets one use Ctrl-space to toggle rows in multiple
      	selection mode.
      	(gtk_file_chooser_default_should_respond): Clean up the if-chain
      	mess of special cases by using an array to determine what to do.
      	Also, for the save-entry case in CREATE_FOLDER mode, actually fix
      	the bug where the file chooser would switch to an existing folder
      	rather than confirming with it, and create the folder ourselves.
      	(error_creating_folder_over_existing_file_dialog): New function.
      
      	* gtk/gtkfilechooserentry.c (check_completion_callback): Only
      	insert the common prefix if we are in an "open" mode.  Use a
      	helper function.
      	(append_common_prefix): New helper function; code moved over from
      	check_completion_callback().
      	(find_common_prefix): New helper function.
      	(gtk_file_chooser_entry_focus): Append the common prefix if the
      	user requests it explicitly.
      ab44ea2b
    • Matthias Clasen's avatar
      · 80bf176f
      Matthias Clasen authored
      2005-06-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_expand):
      	* gtk/gtktoolbar.c (gtk_toolbar_get_show_arrow):
      	* gtk/gtktextview.c (gtk_text_view_get_iter_at_position):
      	* gtk/gtkstock.c (gtk_stock_set_translate_func):
      	* gtk/gtkspinbutton.c (gtk_spin_button_get_adjustment):
      	* gtk/gtkscrolledwindow.h:
      	* gtk/gtkmenushell.c (gtk_menu_shell_get_take_focus):
      80bf176f
    • Matthias Clasen's avatar
      Doc fixes. · 1a15d98c
      Matthias Clasen authored
      2005-06-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkiconview.c (gtk_icon_view_set_margin):
      	* gtk/gtkicontheme.c (gtk_icon_info_load_icon):
      	* gtk/gtkcalendar.c (gtk_calendar_thaw): Doc fixes.
      1a15d98c
    • Matthias Clasen's avatar
      Small markup fixes. · 0a833115
      Matthias Clasen authored
      0a833115
    • Matthias Clasen's avatar
      Add docs. (#306212, Steve Chaplin, docs provided by Billy Biggs) · abf069c0
      Matthias Clasen authored
      2005-06-09  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkwidget.c (gtk_widget_set_app_paintable): Add docs.
      	(#306212, Steve Chaplin, docs provided by Billy Biggs)
      abf069c0
  7. 09 Jun, 2005 1 commit