GitLab

This prevents some of our generic object implementation tests
from working with gesture objects. Instead, add g_return_if_fail
checks in all the gesture constructors.

Add a few missing symbols, and match up parameters in headers
and doc comments.

We were using event->button.time before. That works because it's part of
the common event header, but it's wrong.

This reverts commit 54d5b426.

Conflicts:
	gtk/gtkimage.c

This reverts commit b320c198.

This reverts commit 3b30cfa3.

This reverts commit 68c1e83c.

This prevents these windows from being raised above popovers, which
is about the only child widget that may overlap with those anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=730589

This gesture is meant to handle row-activated signaling, so make the
gesture ignore events from any other window.

In order to avoid the event from bubbling, as it used to (not) do.

The window must be part of the event controller widget, so
fix the inverted logic.

Signals are left hidden, so the only entry point to handle_event/reset
is API.

Mainly doing s/TARGET/BUBBLE/ on the fully ported widgets, but GtkTreeView
where the double click handler has moved to GTK_PHASE_TARGET so it runs
parallelly to the still existing event handlers.

Previously, there would be globally just a capture and a bubble phase,
with the event just going down the hierarchy once, and the up once.
GTK_PHASE_TARGET actually meaning "run within event handlers", so in
a hierarchy of 3 widgets, emission would be:

  Capture(C)
  Capture(B)
  Capture(A)
  Target(A) (if event handlers allow)
  Bubble(A)
  Target(B) (if event handlers allow)
  Bubble(B)
  Target(C) (if event handlers allow)
  Bubble(C)

This commit changes this behavior and uses GTK_PHASE_TARGET in a less
misleading way, running only on the widget that was meant to receive
the event. And GTK_PHASE_BUBBLE has taken over the execution place of
GTK_PHASE_TARGET, so the emission remains:

  Capture(C)
  Capture(B)
  Capture(A)
  Target(A)
  Bubble(A) (if event handlers allow)
  Bubble(B) (...)
  Bubble(C) (...)

As it was, GTK_PHASE_BUBBLE was useful for running event controllers
paralelly to event handlers, without modifying a single line in those.
For those mixed scenarios, Any of the other phases will have to be
used at discretion, or the event handlers eventually changed to chain
up and let the default event handlers in GtkWidget to be run.

The events to those are fed outside the regular event propagation scheme,
through _gtk_window_check_handle_wm_event(), so set the controller to
GTK_PHASE_NONE so events aren't processed first manually, and then
automatically.

Checking whether the gesture is active is a responsibility of the caller.

Whether the gesture is active or recognized should be checked before in
callers, or just not used naively.

Event controllers now auto-attach, and the GtkCapturePhase only determines
when are events dispatched, but all controllers are managed by the widget wrt
grabs.

All callers have been updated.

This will rarely have any use if no subclassing is allowed, so just make it
private for our own.

And document GtkOrientation to be more generic. There's little added
value in a separate enum for this.

Go back to respecting GtkMisc::xpad/ypad. Not doing so breaks
the misc-alignment reftest. As long as we still derive from
GtkMisc, we may as well do this.

When GtkMisc was removed, I forgot to apply the style context
padding. This caused the info-bar-message-types reftest to fail.

The icontheme lookup code has a special-case that prefers builtin icons
if the theme name is "hicolor". This is problematic for our reftests,
which run in a barebones environment with not settings.

Move GtkIMPreeditStyle nad GtkIMStatusStyle to the settings where
they are solely used.

Move GtkStateType to the GtkWidget apis where it is used, and
mark the enum as deprecated.

The overview chapters don't go through shorthand processing, so
don't use them there.

Drop the ref on the action muxer in finalize, and also make sure
shutdown() tears down the muxer setup done in startup().

When GtkApplication adds itself to a muxer, it causes the muxer to take
a ref on the GtkApplication. This has to be undone in shutdown() to make
sure the GtkApplication doesn't end up holding a ref on itself.

https://bugzilla.gnome.org/show_bug.cgi?id=730383

... for the new AtkValue interface that we implement.

Sort the icon list in check-icon-theme.c, and add
comments so we have a chance of keeping the order.

A downside of using templates is that we can have 'parasitic'
objects in there that don't get used for anything.

Still trying to track down test problems in gnome-continuous.

An important line of code was removed in
54d5b426 that lead to an undefined
variable. Add that line back.