1. 19 Dec, 2003 1 commit
  2. 18 Dec, 2003 3 commits
  3. 17 Dec, 2003 3 commits
    • Kristian Rietveld's avatar
      only try to strcmp or strlen if we managed to normalize and casefold the · b1187d9e
      Kristian Rietveld authored
      Wed Dec 17 23:31:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): only
      	try to strcmp or strlen if we managed to normalize and casefold
      	the string correctly. Fixes crashes with non-UTF8 strings.
      	(#121617, Patch from Tim-Philipp Müller).
      b1187d9e
    • Kristian Rietveld's avatar
      fix compile warning. (#122727, patch from Kjartan Maraas). · d1f4899f
      Kristian Rietveld authored
      Wed Dec 17 23:16:45 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix compile warning.
      	(#122727, patch from Kjartan Maraas).
      d1f4899f
    • Kristian Rietveld's avatar
      Yay! Fixed height mode! Hooray! (Part 2 of #80868). · f219093f
      Kristian Rietveld authored
      Wed Dec 17 21:23:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Yay! Fixed height mode! Hooray! (Part 2 of #80868).
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init),
      	(gtk_tree_view_init), (gtk_tree_view_set_property),
      	(gtk_tree_view_get_property), (gtk_tree_view_set_model): add a
      	fixed_height_mode property,
      	(intialize_fixed_height_mode), (do_validate_rows),
      	(column_sizing_notify), (gtk_tree_view_set_fixed_height_mode),
      	(gtk_tree_view_style_set), (gtk_tree_view_row_changed),
      	(gtk_tree_view_row_inserted), (gtk_tree_view_remove_column),
      	(gtk_tree_view_insert_column): implement fixed height mode,
      	(gtk_tree_view_append_column), (gtk_tree_view_insert_column),
      	(gtk_tree_view_insert_column_with_attributes),
      	(gtk_tree_view_insert_column_with_data_func): update docs.
      
      	* gtk/gtktreeprivate.h: add two fields to GtkTreePrivate.
      f219093f
  4. 13 Dec, 2003 1 commit
    • Kristian Rietveld's avatar
      A trick for a faster treeview, step 1. Patch to short circuit · 5f3cde77
      Kristian Rietveld authored
      Sat Dec 13 16:13:27 2003  Kristian Rietveld  <kris@gtk.org>
      
      	A trick for a faster treeview, step 1. Patch to short circuit
      	_build_tree(), inspired by Jonathan (#80868).
      
      	* gtk/gtktreeview.c (gtk_tree_view_init): don't put _IS_LIST in
      	flags by default,
      	(gtk_tree_view_build_tree): don't even try to recurse when the
      	model says that it is a list, remove flag unsetter,
      	(gtk_tree_view_set_model): change flag setting logic.
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_get_flags):
      	propagate whether or not the child model has _IS_LIST set.
      
      	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_get_flags):
      	ditto.
      5f3cde77
  5. 29 Nov, 2003 1 commit
  6. 21 Oct, 2003 1 commit
  7. 13 Oct, 2003 1 commit
  8. 19 Sep, 2003 1 commit
  9. 12 Sep, 2003 1 commit
    • Jonathan Blandford's avatar
      Merge from stable. · 9ded36af
      Jonathan Blandford authored
      Fri Sep 12 16:32:53 2003  Jonathan Blandford  <jrb@redhat.com>
      
      	Merge from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): only save the
      	pressed button (used to determine if we want to initiate a drag later
      	on) if the current grab widget is either NULL or tree_view (Reported
      	by Jeroen Zwartepoorte).
      9ded36af
  10. 09 Sep, 2003 1 commit
    • Kristian Rietveld's avatar
      Big TreeView DnD fixage, makes drops on empty models work, makes TreeStore · b78691f0
      Kristian Rietveld authored
      Wed Sep 10 01:06:44 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Big TreeView DnD fixage, makes drops on empty models work, makes
      	TreeStore DnD work and gets rid of gtk-tree-model-drop-append.
      	Related bugs #95362 and #113314. I don't want to touch this code
      	ever again.
      
      	* gtk/gtktreeprivate.h (GtkTreePrivate): add empty_view_drop field.
      
      	* gtk/gtktreednd.c (gtk_tree_get_row_drag_data): add check
      	for selection_data->length.
      
      	* gtk/gtktreeview.c (struct DestRow), (dest_row_free),
      	(set_dest_row), (get_dest_row): we don't store just the row ref
      	anymore, but a struct with the row ref and additional info,
      	(set_destination_row): handle drops on empty space and some
      	style fixes,
      	(get_logical_dest_row): also return path_down_mode/drop_append_mode
      	flags, handle dropping childs on their new parents, rewrite
      	drop append handling into something saner,
      	(gtk_tree_view_drag_motion): show a "drop possible arrow" on empty
      	spaces,
      	(gtk_tree_view_drag_drop): updates for updated backend,
      	(gtk_tree_view_drag_data_received): updates for updated backend,
      	path down mode (treestore DnD) handling,
      	(gtk_tree_view_set_drag_dest_row): set empty_view_drop flag,
      	when we are trying to drop a row on an empty model,
      	(gtk_tree_view_get_drag_dest_row): handle empty_view_drop flag.
      
      	* gtk/gtkliststore.c (gtk_list_store_drag_data_received),
      	(gtk_list_store_row_drop_possible): style and drop-append fixes.
      
      	* gtk/gtktreestore.c (gtk_tree_store_drag_data_received): ditto.
      b78691f0
  11. 02 Sep, 2003 1 commit
    • Kristian Rietveld's avatar
      Merge from stable. · e5efd714
      Kristian Rietveld authored
      Tue Sep  2 21:01:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merge from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): revert the change
      	to only select when button 1 is pressed introduced in the fix of
      	bug #120187.
      e5efd714
  12. 25 Aug, 2003 1 commit
    • Kristian Rietveld's avatar
      Merge from stable. · 43d99929
      Kristian Rietveld authored
      Mon Aug 25 23:21:43 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merge from stable.
      
      	Fixes #115871, reported by Michael Natterer.
      
      	* gtk/gtktreeprivate.h: added GtkTreeSelectMode enum,
      	added ctrl_pressed and shift_pressed bitfields,
      	(_gtk_tree_selection_internal_select_node): replace GdkModifierType
      	arg with GtkTreeSelectMode.
      
      	* gtk/gtktreeselection.c (gtk_tree_selection_set_mode),
      	(gtk_tree_selection_select_path), (gtk_tree_selection_unselect_path),
      	(_gtk_tree_selection_internal_select_node): all updated for
      	GdkModifierType -> GtkTreeSelectMode move.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): set ctrl_pressed
      	and shift_pressed around selection handling block,
      	(gtk_tree_view_real_select_cursor_row),
      	(gtk_tree_view_real_toggle_cursor_row),
      	(gtk_tree_view_real_selection_cursor_parent),
      	(gtk_tree_view_real_set_cursor): use ctrl_pressed and shift_pressed,
      	instead of checking the event state. And also updates for the
      	GdkModifierType -> GtkTreeSelectMode move.
      43d99929
  13. 21 Aug, 2003 1 commit
    • Kristian Rietveld's avatar
      Slightly modified patch from Yann Rouillard to improve selection behavior · 28a466a6
      Kristian Rietveld authored
      Thu Aug 21 20:53:46 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Slightly modified patch from Yann Rouillard to improve selection
      	behavior with the mouse. Fixes #120187.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): only
      	select/deselect items on the first button press of button 1,
      	expand checks for row_activated to include triple clicks.
      28a466a6
  14. 15 Aug, 2003 2 commits
    • Kristian Rietveld's avatar
      Merged from stable. · 4254bdbb
      Kristian Rietveld authored
      Fri Aug 15 21:57:34 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): stop editing
      	on vertical scrolling. (#108035, reported by Tim Janik).
      4254bdbb
    • Kristian Rietveld's avatar
      (Note: This is not exactly the same as the patch which went in gtk-2-2). · 2e299387
      Kristian Rietveld authored
      Fri Aug 15 19:43:14 2003  Kristian Rietveld  <kris@gtk.org>
      
      	(Note: This is not exactly the same as the patch which went in
      	 gtk-2-2).
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init),
      	(gtk_tree_view_key_press), (gtk_tree_view_search_key_press_event):
      	Also support the up, down, left, right, home, end, page up and
      	page down keys on the numpad. (#119419, reported by Alex Larsson).
      2e299387
  15. 17 Jul, 2003 3 commits
    • Kristian Rietveld's avatar
      Merged from stable. · e733ed3e
      Kristian Rietveld authored
      Thu Jul 17 19:24:51 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	Fixes issues pointed out by Morten Welinder in #115140.
      
      	* gtk/gtktreeview.c (gtk_tree_view_size_request): fix comment,
      	(do_validate_rows): update validated_area with a logic OR instead
      	of a bitwise OR,
      	(validate_rows_handler): make the if statement match the one in
      	validate_rows(), so we don't leak the timeout.
      e733ed3e
    • Kristian Rietveld's avatar
      Merged from stable. · fd9992d8
      Kristian Rietveld authored
      Thu Jul 17 19:12:02 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_remove_widget): the treeview
      	should only grab focus back if the "cell_editable" widget still
      	has focus. (Fixes #110104, testcase provided by Marco Pesenti
      	Gritti).
      fd9992d8
    • Kristian Rietveld's avatar
      Merged from stable. · bdce65ea
      Kristian Rietveld authored
      Thu Jul 17 16:11:21 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_rows_reordered): stop editing
      	if needed. (Fixes #115869, reported by Michael Natterer).
      bdce65ea
  16. 12 Jul, 2003 4 commits
    • Kristian Rietveld's avatar
      Merged from stable. · 497de299
      Kristian Rietveld authored
      Sat Jul 12 16:16:04 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_drag_data_received): special
      	case drags to "0", scroll to the top after dropping. (Fixes #94968,
      	reported by Alp Toker).
      497de299
    • Kristian Rietveld's avatar
      Merged from stable. · 1719b20a
      Kristian Rietveld authored
      Sat Jul 12 15:51:33 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	Fixes #113904, testcase provided by Rene Seindal.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): set
      	pressed_button to -1 when a row has been activated,
      	(gtk_tree_view_motion_bin_window): only start a drag if there's
      	a button being pressed.
      1719b20a
    • Kristian Rietveld's avatar
      Merged from stable. · 97ddec66
      Kristian Rietveld authored
      Sat Jul 12 15:51:18 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): use
      	gdk_window_get_pointer instead of gdk_display_get_window_at_pointer
      	to avoid a roundtrip (#110272, Owen Taylor).
      97ddec66
    • Kristian Rietveld's avatar
      Merged from stable. · e680d2f5
      Kristian Rietveld authored
      Sat Jul 12 15:28:26 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	This patch really really fixes scrolling. Related bugs: #81627,
      	testcase provided by Timo Sirainen, #111500, testcase provided by
      	manu, #113241, reported by Pedro Gimeno/Michael Natterer.
      
      	*  gtk/gtktreeview.c (validate_visible_area): scrolling to a dy
      	which is equal to the lower border of the window means scrolling
      	to an invisible row, always update the dy when scrolling to an
      	invisible row, corrected area_above/below calculations for
      	invisible rows, when walking the tree correct the size
      	subtracted for invalidated rows, fix wrong logic in comment.
      e680d2f5
  17. 06 Jun, 2003 1 commit
    • Kristian Rietveld's avatar
      Merged from stable. · e0e04dd8
      Kristian Rietveld authored
      Fri Jun  6 23:38:23 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (do_expand_collapse),
      	(expand_collapse_timeout), (cancel_arrow_animation): made
      	expand_collapse_timeout a wrapper with locks around
      	do_expand_collapse, made cancel_arrow_animation use
      	do_expand_collapse. Fixes threadlock. (Fixes #111286, patch from
      	Peter Bloomfield).
      e0e04dd8
  18. 04 Jun, 2003 1 commit
    • Kristian Rietveld's avatar
      Merged from stable. · 5afcde9a
      Kristian Rietveld authored
      Wed Jun  4 21:25:35 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_drag_begin): use a silent
      	assert for get_info. (reported by Michael Natterer),
      	(gtk_tree_view_expand_all_emission_helper),
      	(gtk_tree_view_expand_all_helper): emit row_expanded for all
      	expanded rows during an _expand_all operation. (Fixes #111280,
      	reported by Benjamin Bayart).
      5afcde9a
  19. 29 May, 2003 8 commits
    • Kristian Rietveld's avatar
      Merged from stable. · 76367269
      Kristian Rietveld authored
      Thu May 29 18:23:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): put the focus
      	grab separate, the user might clear the tree in the focus-in
      	callback. (Fixes #113086, testcase from Felipe Heidrich).
      76367269
    • Kristian Rietveld's avatar
      Merged from stable. · d718b973
      Kristian Rietveld authored
      Thu May 29 18:06:26 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_model_set_model): reset a bunch
      	of row reference when we unset the model. Also reset
      	dy and top_row_dy. (Fixes #109289, patch from Owen Taylor).
      d718b973
    • Kristian Rietveld's avatar
      Merged from stable. · 7554c3df
      Kristian Rietveld authored
      Thu May 29 17:12:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_set_cursor_on_cell): cancel
      	the current editing, if it exists. (Fixes #108956, reported by
      	Michael Natterer).
      7554c3df
    • Kristian Rietveld's avatar
      Merged from stable. · 4a03ea23
      Kristian Rietveld authored
      Thu May 29 17:06:09 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (check_selection_helper): new function,
      	(gtk_tree_view_row_deleted): traverse the tree from the
      	deleted node to see whether the selection changed, instead of
      	just checking this node. (Fixes #107400, reported by 'Duncan').
      4a03ea23
    • Kristian Rietveld's avatar
      Merged from stable. · c906acd0
      Kristian Rietveld authored
      Thu May 29 16:31:34 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row),
      	(gtk_tree_view_drag_begin): set the DnD icon in _drag_begin
      	instead of _maybe_begin_dragging_row, so the icon can be
      	overridden by apps. (Fixes #104374, patch from Daniel Elstner).
      c906acd0
    • Kristian Rietveld's avatar
      Merged from stable. · bdff7cdb
      Kristian Rietveld authored
      Thu May 29 16:14:04 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_start_editing): correct
      	cell_area x/width for the expander if needed. (Fixes #101748,
      	reported by Dave Cook and Mariano Suarez-Alvarez).
      bdff7cdb
    • Kristian Rietveld's avatar
      check if tree/node are still the same after _internal_select_node. (Fixes · fcabeed6
      Kristian Rietveld authored
      Thu May 29 16:01:38 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_real_set_cursor): check
      	if tree/node are still the same after _internal_select_node.
      	(Fixes #92256, reported by edscott).
      fcabeed6
    • Kristian Rietveld's avatar
      Fixes #75745, reported by Richard Hult. Merged from stable. · c3789891
      Kristian Rietveld authored
      Thu May 29 15:38:30 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes #75745, reported by Richard Hult. Merged from stable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_bin_expose): set/unset
      	GTK_CELL_RENDERER_FOCUSED flag whether the current node is the
      	cursor or not.
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
      	if we are rendering a cursor row, and the cell the be
      	processed has focus, then set the GTK_CELL_RENDERER_FOCUSED
      	flag (else we unset it).
      c3789891
  20. 28 Apr, 2003 1 commit
  21. 17 Apr, 2003 1 commit
  22. 07 Apr, 2003 1 commit
  23. 26 Mar, 2003 1 commit