1. 16 Mar, 2004 2 commits
    • Owen Taylor's avatar
      === Released 2.4.0 === · 221843e9
      Owen Taylor authored
      Tue Mar 16 13:29:58 2004  Owen Taylor  <otaylor@redhat.com>
      
              * === Released 2.4.0 ===
      
              * configure.in: Version 2.4.0, interface age 0;
              require glib-2.4.0, pango-1.4.0.
      
              * NEWS: Updates
      
              * README.in: Updates
      221843e9
    • Jonathan Blandford's avatar
      Block the ::changed handler during the ::match-selected when done by · 14582ece
      Jonathan Blandford authored
      Tue Mar 16 13:54:07 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkentry.c (gtk_entry_completion_key_press): Block the
              ::changed handler during the ::match-selected when done by
              keyboard.
      14582ece
  2. 15 Mar, 2004 24 commits
    • Matthias Clasen's avatar
      Block the ::changed handler during the emission of ::match-selected. · bf86da9d
      Matthias Clasen authored
      Tue Mar 16 00:56:11 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
      	Block the ::changed handler during the emission of ::match-selected.
      	Partial fix for #137226.
      
      	* gtk/gtkfilechooserentry.c: Remove the no longer needed
      	no_pop_down flag.
      bf86da9d
    • Tor Lillqvist's avatar
      Updates. · d6a2be32
      Tor Lillqvist authored
      2004-03-15  Tor Lillqvist  <tml@iki.fi>
      
      	* README.win32: Updates.
      d6a2be32
    • Federico Mena Quintero's avatar
      Only hide the "create folder" button in OPEN mode; all the others should · 7cd0c268
      Federico Mena Quintero authored
      2004-03-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (update_appearance): Only hide the
      	"create folder" button in OPEN mode; all the others should show it
      	it.
      	(get_paths_foreach): Handle the editable row.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder):
      	Force a re-get of the folder so that the new directory gets added
      	to its hash table of file info.
      7cd0c268
    • Federico Mena Quintero's avatar
      In the Save modes, set the Name entry of the file chooser if we get a · 3e3ca555
      Federico Mena Quintero authored
      2004-03-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (update_from_entry): In the Save
      	modes, set the Name entry of the file chooser if we get a
      	nonexistent filename from the file entry.  Fixes #135911.
      	(gtk_file_chooser_default_set_current_name): Oops, this should
      	also work if we are in CREATE_FOLDER mode.
      
      	* gtk/gtkfilesystem.c (gtk_file_path_real_copy): Use
      	gtk_file_path_copy().
      
      	* gtk/gtkfilechooserentry.c (check_completion_callback): Free the
      	path that we got from the model.
      	(completion_match_func): Use DISPLAY_NAME_COLUMN rather than a
      	hard-coded constant.
      3e3ca555
    • Owen Taylor's avatar
      Don't leak the temporary font description. (Nils O. Selåsdal) · cc77c2c8
      Owen Taylor authored
      Mon Mar 15 13:50:14 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
              Don't leak the temporary font description. (Nils O. Selåsdal)
      cc77c2c8
    • Federico Mena Quintero's avatar
      Only show the title string in OPEN/SELECT_FOLDER mode as it's · 77c70924
      Federico Mena Quintero authored
      Mon Mar 15 12:51:17 2004  Jonathan Blandford  <jrb@gnome.org>
      
      	* gtk/gtkfilechooserdefault.c (location_popup_handler): Only show
      	the title string in OPEN/SELECT_FOLDER mode as it's open-specific.
      	Put a blank title for SAVE/CREATE_FOLDER; we are in string freeze,
      	so we'll fix it for 2.4.1 as #137272.
      
      	* gtk/gtkpathbar.c (gtk_path_bar_scroll_down): calculate
      	space_available correctly for RTL mode.  w/o this, you can't
      	scroll down again.  Fixes #137021.
      
      2004-03-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkpathbar.c (gtk_path_bar_scroll_up): Queue a resize.
      	(gtk_path_bar_scroll_down): Likewise.
      77c70924
    • Owen Taylor's avatar
      Store the position of the file part and use that in · 84fecde8
      Owen Taylor authored
      Mon Mar 15 11:40:43 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkfilechooserentry.c: Store the position of the
              file part and use that in check_completion_callback()
              and match_selected_callback() to figure out where
              to operate on the text, rather than recomputing the
              information.
      84fecde8
    • Jonathan Blandford's avatar
      set changing_folders to be true so we don't trigger a callback when we · e8095cc8
      Jonathan Blandford authored
      Mon Mar 15 10:35:19 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): set
              changing_folders to be true so we don't trigger a callback when we
              remove the selection
              (shortcuts_add_bookmarks): ditto
      e8095cc8
    • Owen Taylor's avatar
      s/seperator/separator/. · 2ede6713
      Owen Taylor authored
      Mon Mar 15 10:47:18 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkfilechooserentry.c: s/seperator/separator/.
      2ede6713
    • Owen Taylor's avatar
      Check for Control-Tab or Control-Shift-Tab, not any Control-key as a · 4bbe84b5
      Owen Taylor authored
      Mon Mar 15 09:54:36 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtklabel.c (gtk_label_focus): Check for
              Control-Tab or Control-Shift-Tab, not any Control-key
              as a current event ... handles the case where a dialog
              is triggered from a control accelerator better.
      4bbe84b5
    • Jonathan Blandford's avatar
      implement correctly. (completion_match_func): Allow surpressing popdowns. · 486fc4fe
      Jonathan Blandford authored
      Mon Mar 15 08:48:48 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserentry.c (match_selected_callback): implement
              correctly.
              (completion_match_func): Allow surpressing popdowns.
              (maybe_append_seperator_to_path): New function to add a separator
              item to a display_name.  Bad hack.
              (check_completion_callback): Implement select-ahead as an idle.
              (add_completion_idle): new function to handle select-ahead
              (gtk_file_chooser_entry_do_insert_text): starf the select-ahead
              idle.
              (gtk_file_chooser_entry_focus): Override tab for completion.
              (gtk_file_chooser_entry_activate): commit select_ahead when
              activated.
      
              * gtk/gtkfilechooserdefault.c (location_popup_handler): grab the
              appropriate widget for the mode.
      486fc4fe
    • Tor Lillqvist's avatar
      Don't just copy the whole GdkGCWin32 with a single assignment, that · de2332ee
      Tor Lillqvist authored
      2004-03-15  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/win32/gdkgc-win32.c (gdk_gc_copy): Don't just copy the whole
      	GdkGCWin32 with a single assignment, that overwrites GObject's
      	private data (for instance ref_count). (#137012, John Ehresman)
      de2332ee
    • Mark McLoughlin's avatar
      remove the unused "lowest_folder" GtkFileChooserDefault member. Leftover · 2d23e05a
      Mark McLoughlin authored
      2004-03-15  Mark McLoughlin  <mark@skynet.ie>
      
              * gtk/gtkfilechooserdefault.c: remove the unused "lowest_folder"
              GtkFileChooserDefault member. Leftover from my original patch
              for bug #136987.
      2d23e05a
    • Jonathan Blandford's avatar
      Rewritten to use the GtkEntryCompletion API more correctly. Now pops down · 20808790
      Jonathan Blandford authored
      Mon Mar 15 01:50:28 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtkfilechooserentry.c: Rewritten to use the GtkEntryCompletion
              API more correctly.  Now pops down the dropdown well.
      
              * gtkfilesystem.c (gtk_file_path_get_type): New boxed type for the
              FilePath.
      
              * test/testfilechooser.c: disable preview widget temporarily.
              It's not representative of a good preview widget.
      20808790
    • Federico Mena Quintero's avatar
      Renamed from shortcuts_unselect_all(); now selects the row that · f956e3ae
      Federico Mena Quintero authored
      2004-03-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_find_current_folder):
      	Renamed from shortcuts_unselect_all(); now selects the row that
      	corresponds to the current folder, if any.  Fixes #135916.
      
      	* gtk/gtkpathbar.h: Added prototypes for _gtk_path_bar_up() and
      	_gtk_path_bar_down().
      f956e3ae
    • Federico Mena Quintero's avatar
      Surround the drag-outside-to-remove-bookmarks code with "#if 0" blocks; · 0abde229
      Federico Mena Quintero authored
      2004-03-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c: Surround the
      	drag-outside-to-remove-bookmarks code with "#if 0" blocks; it's
      	too unstable right now.
      0abde229
    • Owen Taylor's avatar
      Implement local_only by filtering the shortcuts and bookmarks list by · 2c9d190c
      Owen Taylor authored
      Sun Mar 14 23:36:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkfilechooserdefault.c: Implement local_only by
              filtering the shortcuts and bookmarks list by
              gtk_file_system_path_to_filename (file_system, path) != NULL.
              (#132894)
      
              * gtk/gtkfilesystem.c (gtk_file_system_path_is_local): Add
              a convenience function, may by interesting to push to the
              file system vtable later for performance.
      2c9d190c
    • Federico Mena Quintero's avatar
      Allow the path to be NULL, so that people can ask for information about a · 084bb2fe
      Federico Mena Quintero authored
      2004-03-14  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_folder_get_info): Allow the path
      	to be NULL, so that people can ask for information about a
      	parent-less file system root (e.g. get_info (get_folder ("/"), NULL)).
      
      	* gtk/gtkfilesystemunix.c (gtk_file_folder_unix_get_info): Allow
      	the condition describe above.
      
      	* gtk/gtkfilechooserdefault.c (get_file_info): Allow getting
      	information of root paths.
      
      	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Handle root paths correctly.
      084bb2fe
    • Owen Taylor's avatar
      Mention GtkTreeViewSearchEqualFunc return value oddity here as well. · 6bc9b7f5
      Owen Taylor authored
      Sun Mar 14 22:32:36 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Mention
              GtkTreeViewSearchEqualFunc return value oddity here as well.
      
              * gtk/gtktreeview.c (gtk_tree_view_search_equal_func): On failure
              to get a string to compare to, return TRUE (no match), not
              FALSE (match). Handle %NULL string values gracefully.
              Remove unused variable. (#135962, Mark McLoughlin)
      6bc9b7f5
    • Morten Welinder's avatar
      Kill g_prints. · 538ca81c
      Morten Welinder authored
      538ca81c
    • Owen Taylor's avatar
      Add _gtk_path_bar_up()/ _gtk_path_bar_down(). · f8b3e6fe
      Owen Taylor authored
      Sun Mar 14 21:03:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkpathbar.[ch]: Add _gtk_path_bar_up()/
              _gtk_path_bar_down().
      
              * gtk/gtkfilechooserdefault.c: Use _gtk_path_bar_up()/
              _gtk_path_bar_down() as bindings for Alt-Up
              and new Alt-Down. (Partly based on a patch by
              Mark McLoughlin, #136987)
      f8b3e6fe
    • Federico Mena Quintero's avatar
      Fixes #136185, patch by Morten Welinder, with some changes. · dfa36bb4
      Federico Mena Quintero authored
      2004-03-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Fixes #136185, patch by Morten Welinder, with some changes.
      
      	* gtk/gtkfilechooserdefault.c (check_is_folder): New helper function.
      	(shortcuts_insert_path): Check the path first with check_is_folder().
      	(gtk_file_chooser_default_set_current_folder): Likewise.
      	(gtk_file_chooser_default_add_shortcut_folder): Likewise.
      	(browse_widgets_create): Unref the size group.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder):
      	Handle the case where the file exists but it is not a directory.
      	(IconType): Add value for ICON_UNDECIDED.
      	(struct stat_info_entry): New structure to hold a file's struct
      	stat, its MIME type and its icon type.
      	(struct _GtkFileFolderUnix): Added a hash of struct
      	stat_info_entry, and flags to remember which info types we've read
      	so far.
      	(get_icon_type): Use a helper function for the icons-from-stat
      	types.
      	(gtk_file_system_unix_render_icon): Use the cached file info.
      	(gtk_file_folder_unix_get_info): Put the info in the cache.
      	(gtk_file_system_unix_get_folder): Create the cache of file info
      	structures.
      
      	* gtk/gtkfilesystem.c (gtk_file_info_set_display_name): Handle the
      	case where display_name is the same as the existing
      	info->display_name.
      dfa36bb4
    • Owen Taylor's avatar
      #136672, reported by Christian Persch; fixes based on a patch by Soeren · 3895bea4
      Owen Taylor authored
      Sun Mar 14 19:26:48 2004  Owen Taylor  <otaylor@redhat.com>
      
              #136672, reported by Christian Persch; fixes based
              on a patch by Soeren Sandmann.
      
              * gtk/gtkmenu.c: Change the handling of mixed gridded
              and non-gridded menu items; the old method was causing
              major performance problems even with the "avoid relayout
              on destruction" hack put in recently.
      
              Now we first lay out the gridded items and then put the
              non-gridded items into empty rows / after the gridded items.
              Layout is done in a central menu_shell_ensure_layout(). Also
              avoid emitting property notifications when we initially
              insert or attach items.
      
              * gtk/gtkmenushell.[ch] gtk/gtkmenu.c: Stop setting the
              unused menu_shell->menu_flag, and document it as unused
              in the header.
      
              * tests/testactions.c: Add a test of creating/removing
              lots of items.
      
              * test/testgtk.c: Add some more cruft to the menu test.
      3895bea4
    • Matthias Clasen's avatar
      Add some docs. · f2e252a2
      Matthias Clasen authored
      f2e252a2
  3. 14 Mar, 2004 5 commits
  4. 13 Mar, 2004 9 commits
    • Owen Taylor's avatar
      When not wrapping, do the offset of the line for justification ourselves. · 83eb184c
      Owen Taylor authored
      Sat Mar 13 18:13:13 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextlayout.c (gtk_text_layout_get_line_display): When not
              wrapping, do the offset of the line for justification ourselves.
              (#120256, Felipe Heidrich)
      83eb184c
    • Matthias Clasen's avatar
      Support the model-less use of GtkCellView shown in testcombo.c. · a6361456
      Matthias Clasen authored
      Sun Mar 14 00:03:18 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Support the
      	model-less use of GtkCellView shown in testcombo.c.
      a6361456
    • Tor Lillqvist's avatar
      Don't undefine HAVE_MONITOR_INFO when compiling with gcc. Mingw's headers · f6d1307a
      Tor Lillqvist authored
      2004-03-13  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/win32/gdkdisplay-win32.c: Don't undefine HAVE_MONITOR_INFO
      	when compiling with gcc. Mingw's headers do have the required
      	definitions.
      
      	* gdk/win32/gdkdrawable-win32.c (draw_polygon): When drawing
      	filled polygons, don't draw the outline, similarily as
      	draw_rectangle(). Apparently GTK and GIMP don't use
      	gdk_draw_polygon() much (or always draw the outline, too), as this
      	has gone undetected for so long. Thanks to Bruce Hochstetler.
      f6d1307a
    • Owen Taylor's avatar
      Remove the window from the toplevel_list here rather in destroy. While · 38bb62c4
      Owen Taylor authored
      Sat Mar 13 15:19:17 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkwindow.c (gtk_window_destroy): Remove
              the window from the toplevel_list here rather in destroy.
              While this is theoretically speaking wrong, it fits
              in better with the current reality that destroyed
              widgets are not reusable. (#126808, Michael Natterer)
      38bb62c4
    • Matthias Clasen's avatar
      Don't do anything beyond clearing to the background if there is no active · b1b58fe3
      Matthias Clasen authored
      Sat Mar 13 21:47:47 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Don't do anything
      	beyond clearing to the background if there is no active row.
      	(#137066, reported by Owen Taylor)
      b1b58fe3
    • Matthias Clasen's avatar
      Pop down the list when an item is selected via the keyboard. · 74fd8a02
      Matthias Clasen authored
      Sat Mar 13 21:37:44 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_key_press): Pop down the
      	list when an item is selected via the keyboard.
      74fd8a02
    • Anders Carlsson's avatar
      Remove trailing slashes in path names. · 72804ba4
      Anders Carlsson authored
      2004-03-13  Anders Carlsson  <andersca@gnome.org>
      
      	* gtk/gtkfilesystemunix.c: (remove_trailing_slash),
      	(gtk_file_system_unix_get_folder),
      	(gtk_file_system_unix_create_folder), (get_parent_dir),
      	(gtk_file_system_unix_get_parent), (gtk_file_folder_unix_get_info):
      	Remove trailing slashes in path names.
      72804ba4
    • Owen Taylor's avatar
      Make this a total no-op when the new or old parent is destroyed. (#134230, · ef5915da
      Owen Taylor authored
      Sat Mar 13 12:17:16 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Make
              this a total no-op when the new or old parent is
              destroyed. (#134230, patch from Soeren Sandmann)
      
              * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
              For foreign windows in our heirarchy, call
              _gdk_windowing_window_destroy_foreign (window) and skip
              all the normal destruction logic.
      
              * gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c:
              Move code to request destruction of a foreign window
              code into a separate _gdk_windowing_window_destroy_foreign().
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_impl_x11_finalize):
              Call GDK_WINDOW_DISPLAY() on the wrapper not on the
              impl. (Also from Soeren's patch)
      ef5915da
    • Owen Taylor's avatar
      For GTK_IS_PLUG toplevels, call gdk_window_get_origin() not · fadaa651
      Owen Taylor authored
      Sat Mar 13 10:49:46 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkdnd.c (_gtk_drag_dest_handle_event): For
              GTK_IS_PLUG toplevels, call gdk_window_get_origin()
              not gtk_window_get_position, as a hackround for not
              having accurate notification of window position for
              embedded windows. (#136112, Dan Winship)
      fadaa651