Setting variations to their default value causes
them to show up in the serialization of the font
description - a font description has no idea about
the default values, so can't filter them out.

Avoid that.

Benjamin Otte authored Nov 21, 2021 and Benjamin Otte committed Nov 21, 2021

Try to compute a min size that matches the current aspect ratio.

This means that when interactively resizing, we adapt the min size to
the current window area dynamically.

And that means that we always have a min size that is large enough, but
users can interactively cause it to be small-width x large-height,
large-width x small-width or anything inbetween.

Otherwise we can end up with a window that's too small in certain corner
cases after resizing.

... and not later.

Otherwise future calls to sizing fucntions will reuse an outdated cache
and compute wrong values.

When computing the window size, always try to clamp to the max size.
This will shrink a window down into a sane size if it was too big
before.

Testcase included

Fixes #4469

Previously, the code did not expand the size properly when a default
size was already set.

Reftest included.

Printing the affected widget leads people to assume that it is to blame
for the error. However, the widget is the object the function is being
called on, not the caller. And the caller is doing it wrong.

Usually the caller is the parent widget, so we could print that one, but
it's only usually, it can be an issue propagating from a grandparent and
it doesn't tell you from where the function is called (allocation or
measuring), so you need a debugger anyway.

So don't put anything there instead.

This reverts commit 22847563.

That consistency check is entirely outdated and just prints confusing
stuff.

This is a quickfix to avoid infinite runtime in nested boxes with
wrapped labels.

Test included

glib doesn't print debug messages by default anymore.

For shrinking children, we would not make sure of this and just throw
the current size at them.

When the stack is homogeneous in only one direction, the other direction
may produce min sizes to small for all children. Make sure to query at
least the min size for those.

that way, we can index them by orientation.

If halign=fill, force adjustment to height-for-width.
If valign=fill, force adjustment to width-for-height.
Otherwise look at request mode.

This way we don't try to adapt the filled dimension and only adjust
the one that is not set to fill.

This could lead to the wrong values being passed and computing invalid
sizes which would then lead to very unhappy code.

Test included.

It's not expensive to check it because we'll cache the dfault size
request anyway, and people do it wrong a lot.
As a bonus, don't do any return_if_fail(), just use the min size
instead.

- gtk_init() does not parse command-line options anymore.
- Gitlab's  WebIDE automatically cleans up whitespace.

Benjamin Otte authored Nov 18, 2021 and Benjamin Otte committed Nov 18, 2021

When the text width is larger than the measuring width, set the min
width to that value, don't also add 1 to it.

Link to the property, instead of copy-pasting its description.

When the compose file is a symbolic link, take the link itself's
modification time into account (in addition to its target's) in
determining whether to invalidate the compose cache.

This is useful e.g. on NixOS systems where the compose file might point
to a store path with an irrelevant modification time, and we want the
cache to expire when the symlink itself changes.

This grab-induced crossing event may come from outer means while there are
buttons pressed (e.g. WM window drags/resizes in X11), the implicit active
state should be undone in that situation.

Also, separate the handling of GDK_LEAVE_NOTIFY, as it's fundamentally
different from GDK_TOUCH_END/CANCEL handling.

Fixes: #4416

Touchpoint state and tracking are tangential, this is mixing up both.
This change was added in the fixes for
#3016 but is now unnecessary.

The sequence should be cancelled from the gesture despite its current state.
Also, there was a piece of pointer emulation that was not dropped here,
maybe breaking things further for the pointer emulated touchpoint.

Fixes: #4387

They are optional, and should be marked as such.

See issue: #4452

We only want to determine the size pixel-exact, not pango-unit-exact, so
don't spend lots of time wondering if text is half a pixel or a quarter
pixel wider.

Testcase included.

Fixes #4424

This was broken in wrapping labels.

Testcase included.

Assume a vbox with 2 wrapping labels saying
  Hello World
  Hi Ho
being measured for their minimum width for 3 rows of text.
This should be layouted like
  Hello
  World
  Hi Ho
and measured accordingly.

However, previously this was layouted as
  Hello World
  Hi Ho
with 1.5 lines being assigned to both labels.
That will obviously not compute the above wrapping which clearly
results in a smaller min width.

A reftest testing exactly this was included.

Turns it into 2 loops, one for the homogeneous part and one for the
complicated part.

... when they are wrong.

Instead, remove them.

Or in other words: GTK4 does not have a fill child property anymore, so
we don't need to run the measuring loop above to determine the size.

This reverts commit cf7fa931.

We store the baseline in the cache and we do not know if baselines might
be queried in the future. So always store them.

No reftest because I don't know how to write one.

premature optimization == √😈