Commit b08a6750 authored by Benjamin Otte's avatar Benjamin Otte

filechooser: Fix a crash when removing files

The file removal code was not properly clearing the file=>array index
cache, so later lookups into that cache would return invalid array

The easiest way to reproduce it is to create a directory with two files
and deleting both of them.
Reported-by: default avatarJavier Jardón <>
parent 4cf9ac5b
......@@ -1747,6 +1747,7 @@ remove_file (GtkFileSystemModel *model,
g_object_unref (node->info);
g_array_remove_index (model->files, id);
g_hash_table_remove_all (model->file_lookup);
/* We don't need to resort, as removing a row doesn't change the sorting order */
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment