Commit 53da925c authored by Havoc Pennington's avatar Havoc Pennington Committed by Havoc Pennington

put the warning explaining the validation error in front of the

2001-11-28  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_paint): put the warning
	explaining the validation error in front of the G_BREAKPOINT

	* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
	process updates with include_children = FALSE instead of TRUE, so
	we redraw the range only, not the whole darn window.  Making
	GtkRange a NO_WINDOW widget had weirdly caused the text widget
	Trace/breakpoint trap bug to become much easier to trigger.
parent 931fe180
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (gdk_public_h_sources): Remove reference * gdk/Makefile.am (gdk_public_h_sources): Remove reference
......
...@@ -1446,7 +1446,7 @@ gtk_range_adjustment_value_changed (GtkAdjustment *adjustment, ...@@ -1446,7 +1446,7 @@ gtk_range_adjustment_value_changed (GtkAdjustment *adjustment,
gtk_widget_queue_draw (GTK_WIDGET (range)); gtk_widget_queue_draw (GTK_WIDGET (range));
/* This is so we don't lag the widget being scrolled. */ /* This is so we don't lag the widget being scrolled. */
if (GTK_WIDGET_REALIZED (range)) if (GTK_WIDGET_REALIZED (range))
gdk_window_process_updates (GTK_WIDGET (range)->window, TRUE); gdk_window_process_updates (GTK_WIDGET (range)->window, FALSE);
/* Note that we don't round off to range->round_digits here. /* Note that we don't round off to range->round_digits here.
* that's because it's really broken to change a value * that's because it's really broken to change a value
......
...@@ -3719,8 +3719,8 @@ gtk_text_view_paint (GtkWidget *widget, ...@@ -3719,8 +3719,8 @@ gtk_text_view_paint (GtkWidget *widget,
if (!text_view->onscreen_validated) if (!text_view->onscreen_validated)
{ {
g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen - this is a known bug, no need to report.");
G_BREAKPOINT (); G_BREAKPOINT ();
g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen");
} }
#if 0 #if 0
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment