Commit 385b7ae0 authored by Ray Strode's avatar Ray Strode Committed by Matthias Clasen

wayland: unlink shm file earlier in create function

create_shm_pool unlinks the temporary file a little,
too late. It should be unlinked before ftruncate()
is called for two reasons:

1) if ftruncate fails, the file is currently not
getting cleaned up at all
2) in theory, if the file is public some other process
could muck with it

This commit just moves the unlink call a little higher
up.

https://bugzilla.gnome.org/show_bug.cgi?id=760897
parent 39ea2982
......@@ -992,6 +992,7 @@ create_shm_pool (struct wl_shm *shm,
filename, g_strerror (errno));
return NULL;
}
unlink (filename);
stride = width * 4;
size = stride * height;
......@@ -1004,7 +1005,6 @@ create_shm_pool (struct wl_shm *shm,
}
data = mmap (NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
unlink (filename);
if (data == MAP_FAILED)
{
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment