Commit 33798273 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

set_boxed will copy the color and will use a mem_chunk to do it. Avoid an

2002-01-13  Jody Goldberg <jody@gnome.org>

        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
	  and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
	  leak, and confusion.
parent 691be10d
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com> ...@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Unset * gtk/gtkwindow.c (gtk_window_move_resize): Unset
initial_pos_set after the first configure request. initial_pos_set after the first configure request.
2002-01-13 Jody Goldberg <jody@gnome.org>
* gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
and will use a mem_chunk to do it. Avoid an unnecessary copy, a
leak, and confusion.
Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com> Sun Jan 13 23:23:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where
......
...@@ -1358,12 +1358,8 @@ gtk_text_tag_set_property (GObject *object, ...@@ -1358,12 +1358,8 @@ gtk_text_tag_set_property (GObject *object,
static void static void
get_color_arg (GValue *value, GdkColor *orig) get_color_arg (GValue *value, GdkColor *orig)
{ {
GdkColor *color;
color = g_new (GdkColor, 1);
*color = *orig;
g_value_init (value, GDK_TYPE_COLOR); g_value_init (value, GDK_TYPE_COLOR);
g_value_set_boxed (value, color); g_value_set_boxed (value, orig);
} }
static void static void
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment