ChangeLog.pre-2-8 202 KB
Newer Older
Matthias Clasen's avatar
Updates    
Matthias Clasen committed
1
2
2004-11-10  Matthias Clasen  <mclasen@redhat.com>

3
4
	* gtk/gtkstatusbar.c (gtk_statusbar_size_allocate): Only
	shorten the label if it actually overlaps the resize grip.
5
6
	(gtk_statusbar_size_allocate): Handle extra children
	by leaving room for the resize grip.  (#157778, Christian Persch)
7

8
9
10
	* gdk/linux-fb/*: Fix many sparse warnings.  (#157253,
	Kjartan Maraas.
	
Matthias Clasen's avatar
Updates    
Matthias Clasen committed
11
12
	* NEWS: Updates

13
14
2004-11-09  Matthias Clasen  <mclasen@redhat.com>

15
16
17
18
19
	* gtk/gtkrange.c (gtk_range_real_change_value): Make 
	power a double.
	(gtk_range_class_init): s/digits/decimal digits/ in doc 
	comment.

Matthias Clasen's avatar
Matthias Clasen committed
20
21
22
	* gtk/gtkfilechooserbutton.c (update_idler): Remove debugging
	printfs. 

23
24
25
	* gtk/gtkicontheme.[ch]: Improve the docs.  (#157785,
	Torsten Schoenfeld)

26
27
28
	* gdk/x11/gdkwindow-x11.c (gdk_window_get_geometry): Add
	a hint about using gdk_drawable_get_size() instead.

Matthias Clasen's avatar
Matthias Clasen committed
29
30
	* gtk/gtk.symbols: Add new symbols.

31
32
33
	* gtk/gtkiconview.c (gtk_icon_view_scroll_to_item): Make
	it work with *big* icon views.  (#154466)

34
35
	* tests/testiconview.c: Add a real "Add many" button.

36
37
38
39
40
41
42
43
44
45
	* gtk/gtkaction.[hc]: 
	* gtk/gtkactiongroup.[hc]: Make return types G_CONST_RETURN
	instead of const.

	* gtk/gtk.symbols: 
	* gtk/gtkaction.h: 
	* gtk/gtkaction.c (gtk_action_get_accel_path): Add
	a function to obtain the accel path of an action. (#148106,
	Michael Natterer)

Matthias Clasen's avatar
Matthias Clasen committed
46
47
	* tests/testiconview.c: Fix double-click activation.

48
49
	* gtk/gtkstatusbar.c (gtk_statusbar_init): Raise the grip
	window when appropriate.
Matthias Clasen's avatar
Updates    
Matthias Clasen committed
50
	(gtk_statusbar_init): Instead of cutting the text off, make
51
52
53
	ellipsize the label.
	(gtk_statusbar_size_allocate): Don't let the label extend
	under the resize grip.
54

55
56
57
58
59
	* gtk/gtkcombobox.c (find_menu_by_path) 
	(gtk_combo_box_menu_fill_level, gtk_combo_box_menu_row_inserted): 
	Use a row reference, not a path, to associate separators
	with their tree row.  
	
60
61
62
	* gtk/gtkstatusbar.c (gtk_statusbar_set_has_resize_grip): 
	Show the grip_window if necessary.  

63
64
	* gtk/gtkstyle.c (gtk_default_draw_resize_grip): Only
	clear the triangle below the grip to the background,
65
	not the full area. 
66

67
68
69
70
71
	* gtk/gtklabel.c (draw_insertion_cursor, gtk_label_expose): 
	Clip when drawing the cursor. This prevents bits of a
	selectable label leaking out from underneath the resize
	grip in a statusbar.  (#73359)

72
73
74
75
	* gtk/gtkstatusbar.c: Apply a patch by Owen Taylor to
	get reasonable allocations for the statusbar and its
	children.  (#73359)

76
77
78
	* tests/testgtk.c: Apply a patch by Soeren Sandmann to 
	test long statusbar texts.

Matthias Clasen's avatar
Matthias Clasen committed
79
80
	* gtk/gtk.symbols: Add new symbols.

81
82
83
84
85
86
87
88
89
90
91
	Avoid resizing GtkStatusbar if the text of the label 
	changes  (#90955, He Qiangqiang, fix proposed by 
	Owen Taylor, patch by Christian Persch)
	
	* gtk/gtklabel.[hc]: Add a boolean single-line-mode property 
	which causes the label height not to depend on the actual
	text, but only on the font.

	* gtk/gtkstatusbar.c (gtk_statusbar_init): Turn on
	single-line-mode for the label.

92
93
2004-11-08  Matthias Clasen  <mclasen@redhat.com>

94
95
96
97
98
	* gtk/gtkfilefilter.c (gtk_file_filter_filter): Use 
	xdg_mime_mime_type_subclass() to match mime types. This
	also gives use wildcard matching. (#143760, #141224, 
	Tommi Komulainen, David A Knight)

99
100
101
	* gtk/gtkaction.c (_gtk_action_sync_menu_visible): Use 
	gtk_widget_{hide,show} instead of g_object_set (..."visible"...).

102
103
104
	* tests/testfilechooserbutton.c (main): Disable the SAVE 
	and CREATE_FOLDER modes.  (#157675, Christian Persch)

105
106
107
	* gtk/gtkaboutdialog.c (gtk_about_dialog_set_website): Hide the
	website button if the url is unset.  (#157630, John Finlay)

108
109
110
111
	* gtk/gtkaboutdialog.[hc]: Change the return types of the 
	gchar ** getters to be more const correct.  (#157566, Mariano 
	Suárez-Alvarez)

112
113
114
115
	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_init): Add
	uri targets before text targets, to make file dnd work 
	better.  (#157651, Christian Persch)

116
117
118
119
	* gtk/gtktreedatalist.c: Support columns whose declared type is
	an interface better, by treating them like G_TYPE_OBJECT if
	the interface types requires G_TYPE_OBJECT.

120
121
122
123
124
125
2004-11-08  Bastien Nocera  <hadess@hadess.net>

	* gtk/stock-icons/stock_media_play_rtl_16.png:
	* gtk/stock-icons/stock_media_play_rtl_24.png: add the icons again
	with the binary flag (Closes: #157665)

126
127
2004-11-07  Matthias Clasen  <mclasen@redhat.com>

128
129
130
131
132
133
134
	* gtk/gtkfilefilter.h:
	* gtk/gtkfilefilter.c (gtk_file_filter_add_pixbuf_formats): 
	New convenience function to add a filter for image files
	which can be loaded by GdkPixbuf. (#145388, Anders Carlsson)

	* tests/testfilechooser.c: Test the image filter.
	
Matthias Clasen's avatar
Matthias Clasen committed
135
136
	* gtk/gtkmenu.c (menu_change_screen): Remove some warnings.

137
138
139
140
141
142
143
144
145
146
147
148
	Show files in folder modes. (#157013, Nickolay V. Shmyrev)
	
	* gtk/gtkfilechooserdefault.c (create_file_list): Use a selection
	function to determine which rows can be selected.
	(update_appearance): Always show files. Also queue a redraw.
	(set_list_model): Always show files.
	(list_select_func): The selection function used for the file list.
	Don't allow to select files when in select/create folder mode.
	(list_row_activated): Don't activate files in folder modes.
	(list_icon_data_func, list_mtime_data_func, list_size_data_func): 
	Render files insensitive in folder modes.

149
150
2004-11-06  Matthias Clasen  <mclasen@redhat.com>

151
152
153
154
	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property): 
	Don't support CREATE_FOLDER and SAVE for now. UI authorities
	object to it.  (#157384, Seth Nickell)

155
156
157
158
	* gtk/gtkfilechooserdefault.c (file_pane_create): Jump through
	a few hoops to make the tooltip on the filter combo box work
	a bit better. This fixes #157273 and #157074.

159
160
161
162
	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_pack_end): 
	Add the ComboCellInfo to the list.  (#157528, Carlos Garnacho
	Parro)

Matthias Clasen's avatar
Matthias Clasen committed
163
164
2004-11-05  Matthias Clasen  <mclasen@redhat.com>

165
166
167
	* gtk/gtkcombobox.c (gtk_combo_box_menu_button_state_changed):
	Remove this unneeded function, as it breaks state propagation.

168
169
170
171
172
173
	* gtk/gtktearoffmenuitem.c (gtk_tearoff_menu_item_activate): 
	Queue the resize before setting the tearoff state, to 
	make sure the torn-off menu picks up the size increase due
	to the arrow in the torn off menu item.  (#157286, Adam
	Hooper, fix proposed by Owen Taylor)

174
175
176
177
178
	* gtk/gtkmenu.c (menu_change_screen): Don't unnecessarily
	call gtk_menu_position(), since that function has issues
	when called on a menu whose parent is unrealized.  (#157354,
	Adam Hooper)

Matthias Clasen's avatar
Matthias Clasen committed
179
180
	* gtk/gtkmain.c: Document new functions.

Matthias Clasen's avatar
Matthias Clasen committed
181
182
2004-11-04  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
183
184
	* gtk/stock-icons/Makefile.am: Typo fix.

Matthias Clasen's avatar
Matthias Clasen committed
185
186
	* gtk/gtkaboutdialog.c: Documentation updates.

187
188
189
190
191
192
193
194
195
2004-11-04  Bastien Nocera  <hadess@hadess.net>

	* gtk/gtkiconfactory.c: (get_default_icons): Make sure the RTL
	variants are used for media icons
	* gtk/stock-icons/Makefile.am: update following the addition of
	the 2 Play icon RTL variants
	* gtk/stock-icons/stock_media_play_rtl_16.png: added
	* gtk/stock-icons/stock_media_play_rtl_24.png: added

196
197
2004-11-03  Matthias Clasen  <mclasen@redhat.com>

198
199
200
	* gtk/gtkfilechooserdefault.c (new_folder_button_clicked): 
	Don't leak the path.  (#157301, Carlos Garnacho Parro)

201
202
203
204
	* gdk/x11/gdkdnd-x11.c (gdk_drag_motion): Handle the 
	case that the protocol version in the context is not 
	set yet.  (#157123, James Henstridge)

205
206
207
	* gtk/gtktreeview.c (gtk_tree_view_search_activate): Don't
	try to activate a node if the cursor is not valid.  

208
209
210
211
212
213
2004-11-03  James M. Cape  <jcape@ignore-your.tv>

	* gtk/gtkfilechooserbutton.c (update_dialog), (dialog_response_cb):
	Don't mysteriously go to the parent dir when hitting "Cancel" in
	folder mode (fixes #156971).

214
215
2004-11-03  Matthias Clasen  <mclasen@redhat.com>

216
217
218
	* gtk/gtkaccellabel.c (gtk_accel_label_expose_event): Don't
	access label->layout directly.  (#157080, Adam Hooper)

219
220
221
	* gtk/gtklabel.c (gtk_label_set_pattern_internal): Allow
	unsetting a pattern by passing NULL.  (#156720, Tristan Van Berkom)

222
223
224
225
	* gtk/gtkcombobox.c (gtk_combo_box_get_active): Don't crash 
	if the active_row reference has become invalid.  (#157156,
	Christophe Fergeau)
	
Matthias Clasen's avatar
Matthias Clasen committed
226
227
2004-11-02  Matthias Clasen  <mclasen@redhat.com>

228
229
230
231
232
233
	* gtk/gtkwindow.c (gtk_window_activate_key_after): As
	a last stage in GtkWindow key press handing, try adding
	window->mnemonic_modifier to event->state and see if it
	matches a mnemonic. (#53709, based on a patch by
	Pasupathi Duraisamy, patch by Owen Taylor)

Matthias Clasen's avatar
Matthias Clasen committed
234
235
236
	* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init): 
	Doc additions.

237
238
	* gtk/gtkfilechooserbutton.h: Fix trigraphs in private markers.

Matthias Clasen's avatar
Matthias Clasen committed
239
240
241
	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_class_init): 
	Fix a doc comment.

242
243
2004-11-01  Matthias Clasen  <mclasen@redhat.com>

244
245
246
	* gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup): 
	Remove a debug printf().  (#157087, Christian Persch)

247
248
249
	* gtk/gtkicontheme.c: Actually commit the "stat less" patch
	which appeared in the ChangeLog a few days ago.

Matthias Clasen's avatar
Matthias Clasen committed
250
251
	* gtk/gtkfilechooserbutton.c: Move some docs inline.

Matthias Clasen's avatar
Matthias Clasen committed
252
253
	* gtk/gtkaboutdialog.c (gtk_show_about_dialog): Doc update.

254
255
256
	* gtk/gtktextbuffer.c (gtk_text_buffer_backspace): Revalidate the
	iter.  (#156924, Murray Cumming)

257
258
259
	* gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Don't crash on
	broken ClientMessage events.  (#157056, Owen Taylor)

260
261
262
	* gtk/gtkactiongroup.c (gtk_action_group_get_visible): Fix a typo in
	the docs.  (#157044, Masao Mutoh)

Matthias Clasen's avatar
Matthias Clasen committed
263
264
2004-10-31  Matthias Clasen  <mclasen@redhat.com>

265
266
	* gtk/gtkcombobox.c (gtk_combo_box_button_state_changed): Update the
	state of the cell view when the state of the button changes (to 
267
268
	get prelighted drawing right).  (#138650, Frances Keenan, 
	Christian Persch)
269

270
271
272
273
274
	* gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup): 
	Don't force the height of the action area, we don't scroll 
	it anyway, and the current way of calculating the height can lead
	to broken display.  (#156573, Christian Persch)

275
276
277
	* tests/testentrycompletion.c (animation_timer): Don't try to
	remove stuff from an empty model.  (#156575, Christian Persch)

Matthias Clasen's avatar
Matthias Clasen committed
278
	* gtk/gtkentrycompletion.c (gtk_entry_completion_class_init): 
Matthias Clasen's avatar
Matthias Clasen committed
279
280
281
	* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init): 
	Update doc comments.

282
283
284
285
286
287
288
289
290
2004-10-31  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkprivate-win32.h
	* gdk/win32/gdkglobals-win32.c
	* gdk/win32/gdkmain-win32.c: Remove _windows_version and the
	IS_WIN_NT() macro.

	* gdk/win32/*.c: Use G_WIN32_IS_NT_BASED() from GLib instead.

291
292
2004-10-31  Matthias Clasen  <mclasen@redhat.com>

293
294
295
296
297
298
299
300
301
302
303
	Add api for image transfer via copy-and-paste (#156408)
	
	* gtk/gtkclipboard.c (gtk_clipboard_set_image) 
	(gtk_clipboard_request_image, gtk_clipboard_wait_for_image) 
	(gtk_clipboard_wait_is_image_available): New functions for image
	transfer.

	* gtk/gtkselection.h:
	* gtk/gtkselection.c (gtk_selection_data_targets_include_image): 
	New function, similar to gtk_selection_data_targets_include_text().

304
305
306
	* gtk/gtkprogressbar.[hc]: Add an ellipsize property with 
	getter and setter.  (#156845, Morten Welinder)

307
308
309
310
311
312
313
2004-10-29  Robert Ögren  <gtk@roboros.com>

	* gdk/win32/gdkwindow-win32.c (gdk_window_begin_resize_drag),
	(gdk_window_begin_move_drag): Implement these on win32, currently
	only for button 1. Fixes the resize grip of GtkStatusbar on 
	win32. (#143285)

314
315
2004-10-30  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
316
317
318
319
320
321
	* gtk/gtktextbtree.c (_gtk_text_btree_select_range): Redisplay
	the new selection.

	* gtk/gtktextview.c (gtk_text_view_select_all): Use 
	gtk_text_buffer_select_range().

322
323
324
	* tests/testtext.c: Add a "Select All" menuitem.  (#156792,
	Paolo Borelli)

325
326
327
328
329
	* gtk/gtkicontheme.c (insert_theme): Sort the dir_mtimes 
	list in the same way as the search path.
	(theme_subdir_load): Avoid stat()ing subdirs if the theme 
	directory doesn't exist.  (#156866)

330
331
332
333
334
335
2004-10-29  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize): 
	Drop the reference to the pixbuf, regardless whether it is
	a stock pixbuf.  (#156863, Philip Langdale)

Hans Breuer's avatar
updated    
Hans Breuer committed
336
337
338
339
340
341
342
343
344
2004-10-29  Hans Breuer  <hans@breuer.org>

	* gdk/makefile.msc gtk/makefile.msc.in : updated

	* gdk/win32/gdkdisplay-win32.c : dummy implementations for
	gdk_display_supports_clipboard_persistence, gdk_display_store_clipboard

	* gtk/gtkmodules.c : #include "gtkprivate.h" for GTK_LIBDIR

345
346
2004-10-29  Matthias Clasen  <mclasen@redhat.com>

347
348
349
350
	* gtk/gtkclipboard.c (gtk_clipboard_set_text): Don't hardwire
	the supported text targets here, use 
	gtk_target_list_add_text_targets().  (#156404)

351
352
353
	* gtk/gtkliststore.c (gtk_list_store_reorder): Don't
	loop over the sentinel node.  (#156298, Torsten Schoenfeld)

354
355
2004-10-28  Matthias Clasen  <mclasen@redhat.com>

356
357
358
359
360
	* gtk/gtkcombobox.c (gtk_combo_box_start_editing): Use
	g_signal_connect_object() to prevent premature finalization
	of the cell_editable while the key_press_event signal is
	handled.  (#156325, Olivier Andrieu)

Matthias Clasen's avatar
Matthias Clasen committed
361
362
	* *: Clean up many sparse warnings.  (#156698, Kjartan Maraas)
	
363
364
365
	* gtk/gtktreeview.c (gtk_tree_view_remove_widget): Disconnect
	from the remove-widget signal after removing the signal.

366
367
368
	* gtk/gtkaboutdialog.c (gtk_show_about_dialog): Destroy
	the dialog with the parent.  (#156557, Paolo Borelli)

Matthias Clasen's avatar
Matthias Clasen committed
369
370
2004-10-27  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
371
372
	* Bump version

Matthias Clasen's avatar
Matthias Clasen committed
373
374
375
376
	* === Released 2.5.4 ===

	* Makefile.am (EXTRA_DIST): Remove po/makefile.mingw

Anders Carlsson's avatar
Anders Carlsson committed
377
378
379
380
381
382
2004-10-28  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkclipboard.c: (gtk_clipboard_set_can_store):
	* gtk/gtkclipboard.h:
	Make targets const.

383
384
2004-10-27  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
385
386
387
388
389
390
	* gtk/Makefile.am (gtkalias.h): 
	* gdk/Makefile.am (gdkalias.h): Fix srcdir != builddir build.
	(#156547, Thomas Fitzsimmons)
	
	* NEWS: Updates.

391
392
393
	* gtk/gtkclipboard.c (gtk_clipboard_set_can_store): Silently
	ignore non-CLIPBOARD clipboards.  (#156610, Christian Persch)

394
395
396
	* gtk/gtksettings.c: Make it build on windows. (#156618,
	Kazuki IWAMOTO)

Matthias Clasen's avatar
Matthias Clasen committed
397
398
2004-10-26  Matthias Clasen  <mclasen@redhat.com>

399
400
	* gtk/gtkimcontextsimple.c (check_hex): Stop preediting if strtoul 
	couldn't parse the complete preedit string.  (#156434)
401

402
	* gtk/gtkmessagedialog.c: 
403
404
	* gtk/gtkfilechooserbutton.c: Add missing includes.  (#156503, 
	Kazuki IWAMOTO)
405

406
	* gtk/gtkimage.h: 
407
408
	* gtk/gtkimage.c (gtk_image_get_icon_name): Make the icon_name 
	parameter G_CONST_RETURN.
409
	
410
411
412
413
	* gtk/gtkimage.c: It is enough to listen for screen changes and 
	style-set to catch all icon theme changes.
	(gtk_image_set_property): Reset the image size if the pixel size 
	property is changed.
414

Matthias Clasen's avatar
Matthias Clasen committed
415
416
	* gtk/gtk.symbols: Add new symbols.

Matthias Clasen's avatar
Matthias Clasen committed
417
418
419
	* gdk/x11/gdkdisplay-x11.c (gdk_display_store_clipboard): Fix the 
	doc comment.

420
421
422
423
424
2004-10-26  Anders Carlsson  <andersca@imendio.com>

	* gtk/gtktextbuffer.c: (gtk_text_buffer_finalize),
	(create_clipboard_contents_buffer), (clipboard_get_contents_cb),
	(clipboard_clear_contents_cb), (cut_or_copy):
425
426
427
	Rewrite clipboard handling so that the clipboard contents 
	won't be freed when the text buffer is finalized. Also add 
	clipboard manager support. Fixes #95496.
428

429
430
431
432
433
434
435
436
437
438
439
440
441
442
2004-10-25  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkentry.c: (gtk_entry_completion_timeout):
	* gtk/gtkentrycompletion.c: (gtk_entry_completion_set_model),
	(gtk_entry_completion_get_model), (gtk_entry_completion_complete):
	Really handle a NULL model, fixes #137211 for real.

	* gtk/gtkfilechooserentry.c:
	(gtk_file_chooser_entry_maybe_update_directory):
	Remove _clear, #137211 is fixed.

	* tests/testentrycompletion.c: (main):
	Add completion with an empty model.
	
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
2004-10-25  Carlos Garnacho Parro  <carlosg@gnome.org>

	Fix for #118764, David Bordoley:
	
	* gtk/gtkmessagedialog.[ch]
	(gtk_message_dialog_format_secondary_text),
	(gtk_message_dialog_format_secondary_format): API additions to
	create HIG-like dialogs

	* demos/gtk-demo/dialog.c: Use the new API in the example

	* docs/reference/gtk/gtk-sections.txt:
	* docs/reference/gtk/tmpl/gtkmessagedialog.sgml: documented API
	additions

458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
2004-10-25  James M. Cape  <jcape@ignore-your.tv>

	Rework of GtkFileChooserButton, some cleanups. Fixes #154388,
	#154390, #154390, #156272.

	* docs/reference/gtk/gtk-docs.sgml: Moved GtkFileChooserButton
	below GtkFileChooser.
	* docs/reference/gtk/gtk-sections.txt: Added
	gtk_file_chooser_button_get_width_chars(),
	gtk_file_chooser_button_set_width_chars(),
	gtk_label_set_width_chars(), gtk_label_get_width_chars().
	* docs/reference/gtk/gtk.types: Added
	gtk_cell_renderer_combo_get_type,
	gtk_cell_view_get_type,
	gtk_text_iter_get_type.
	* docs/reference/gtk/tmpl/gtkaboutdialog.sgml: Add
	"logo-icon-name" property.
	* docs/reference/gtk/tmpl/gtkcellview.sgml: Updates for properties
	(b/c of get_type() inclusion above).
	* docs/reference/gtk/tmpl/gtkfilechooserbutton.sgml:
	* docs/reference/gtk/tmpl/gtklabel.sgml: Add "width-chars" property,
	getters/setters.
	* docs/reference/gtk/tmpl/gtkcellrenderercombo.sgml: Added.
	* gtk/gtkentrycompletion.c:
	(_gtk_entry_completion_popdown): Don't show if the entry isn't
	mapped.
	* gtk/gtkfilechooserbutton.[c,h]: (*): About 45%
	rewritten, adds "width-chars" property, icons, working save modes,
	volume/Home/Desktop friendly-naming support.
	* gtk/gtklabel.[c,h]:
	(gtk_label_class_init), (gtk_label_init),
	(gtk_label_get_property), (gtk_label_set_property),
	(gtk_label_get_width_chars), (gtk_label_set_width_chars),
	(gtk_label_size_request): Add "width-chars" property.
	* tests/testfilechooserbutton.c: Update, use 4 different buttons for
	the different ACTIONs.
	* gtk/.cvsignore: Ignore gtk-update-icon-cache.
	* tests/.cvsignore: Ignore testimage.

497
498
499
500
501
2004-10-25  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellrenderercombo.c (find_text): Don't leak text. (#156325,
	Olivier Andrieu)

502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
2004-10-25  Anders Carlsson  <andersca@imendio.com>

	* gdk/gdk.symbols: 
	* gdk/gdkdisplay.h:
	* gdk/x11/gdkdisplay-x11.c:
	(gdk_display_supports_clipboard_persistence), 
	(gdk_display_store_clipboard):
	New API to handle the clipboard manager.

	* gtk/gtk.symbols:
	* gtk/gtkclipboard.c: (gtk_clipboard_class_init),
	(gtk_clipboard_finalize), (selection_clear_event_cb),
	(clipboard_unset), (gtk_clipboard_set_text),
	(gtk_clipboard_request_targets), (gtk_clipboard_wait_for_targets),
	(clipboard_peek), (gtk_clipboard_owner_change),
	(gtk_clipboard_wait_is_target_available),
	(gtk_clipboard_store_timeout), (gtk_clipboard_set_can_store),
	(gtk_clipboard_selection_notify), (gtk_clipboard_store),
	(_gtk_clipboard_store_all):
	* gtk/gtkclipboard.h:
	Add API for clipboard persistence and implement it, also add
	gtk_clipboard_wait_is_target_available.
	
	* gtk/gtkmain.c: (gtk_main):
	Call _gtk_clipboard_store_all before exiting.
	
528
529
2004-10-25  Matthias Clasen  <mclasen@redhat.com>

530
531
532
533
534
	* gtk/gtkaboutdialog.h: 
	* gtk/gtkaboutdialog.c (gtk_about_dialog_set_logo_icon_name)
	(gtk_about_dialog_get_logo_icon_name): Support named icons as 
	logos.  (#156378, James Henstridge)

Matthias Clasen's avatar
Matthias Clasen committed
535
536
537
538
539
	* gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order): Fix the 
	doc formatting.

	* gtk/gtkcellview.[hc]: Make function parameter names consistent.

Matthias Clasen's avatar
Matthias Clasen committed
540
541
	* tests/Makefile.am (noinst_PROGRAMS): Add testimage.

542
543
	* tests/testicontheme.c (main): Use gtk_image_new_from_icon_name().

544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
2004-10-25  Matthias Clasen  <mclasen@redhat.com>

	Add a public setting for button ordering (#74669, Owen Taylor)
	
	* gtk/gtksettings.c (gtk_settings_class_init): Add a 
	gtk-alternative-button-order setting.

	* gtk/gtkdialog.h: 
	* gtk/gtkdialog.c (gtk_alternative_dialog_button_order): A 
	getter for the alternative button order setting.
	* gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order): 
	New function to install an alternative button order for a 
	dialog.

	* gtk/gtkfilesel.c (gtk_file_selection_init): 
	* gtk/gtkfontsel.c (gtk_font_selection_dialog_init): 
	* gtk/gtkmessagedialog.c (gtk_message_dialog_add_buttons): 
	* gtk/gtkcolorseldialog.c (gtk_color_selection_dialog_init): 
	* gtk/gtkfilechooserdefault.c (location_popup_handler): 
	Set up an alternative button order.
	
565
566
567
568
569
570
571
572
573
574
575
576
577
578
2004-10-25  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkimage.h: 
	* gtk/gtkimage.c (gtk_image_new_from_icon_name)
	(gtk_image_set_from_icon_name, gtk_image_get_icon_name)
	(gtk_image_set_pixel_size, gtk_image_get_pixel_size):  Add a
	new type GTK_IMAGE_ICON_NAME for named icons, update the size
	and content of stock, icon set and named icon images upon style
	changes, and allow to set a fixed pixel size for named icon
	images.  (#155688, James Henstridge)

	* tests/testimage.c: Test application for theming behaviour of
	different image types and for image dnd.

579
580
2004-10-24  Matthias Clasen  <mclasen@redhat.com>

581
	* gtk/gtkcellrenderercombo.c: Use G_DEFINE_TYPE, initialize the
582
583
584
	has_entry property, ref the model and add a finalizer.  (#156325,
	Olivier Andrieu)
	
585
586
587
588
Sun Oct 24 02:56:43 2004  Jonathan Blandford  <jrb@redhat.com>

	* docs/tools/widgets.c: Update GtkFileChooserButton doc shot.

589
590
2004-10-24  Matthias Clasen  <mclasen@redhat.com>

591
592
593
594
595
596
	* gtk/gtkicontheme.c: Use the new g_key_file api in GLib.

	* gtk/Makefile.am (gtk_c_sources): Remove gtkiconthemeparser.[hc]

	* gtk/gtkiconthemeparser.[hc]: Removed.

597
598
599
600
	* gtk/gtkfilechooserdefault.c (location_popup_handler): If the
	location dialog is brought up by typing '/', insert the slash
	in the entry.  (#155370, Warren Togami)

601
602
2004-10-23  Matthias Clasen  <mclasen@redhat.com>

603
604
605
606
607
	* gtk/gtkfilechooserdefault.c (tree_view_keybinding_cb) 
	(trap_activate_cb): Accept shift-/ for bringing up the location
	popup, since German and French keyboards generate such 
	events.  (#154163, Frederic Crozat)

608
609
610
611
612
	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Invalidate 
	the window if the tree is empty, to avoid resizing artifacts
	from the focus rectangle.  (#155881, Vincent Noel, patch by
	Billy Biggs)	

613
Sat Oct 23 16:14:37 2004  Søren Sandmann  <sandmann@redhat.com>
614

615
616
617
	* gtk/gtksequence.c (_gtk_sequence_node_insert_sorted): Remove
	assertion that can get triggered by broken sort functions.

618
619
620
621
622
623
624
625
626
627
Sat Oct 23 16:07:46 2004  Søren Sandmann  <sandmann@redhat.com>

	* gtk/gtksequence.c (_gtk_sequence_swap): Replace broken, overly
	clever implementation with one that works.
	
	* gtk/gtkliststore.c (gtk_list_store_swap): emit "rows_reordered"
	instead of "changed" twice.

	Bug 153479

628
629
630
631
632
Sat Oct 23 15:17:55 2004  Søren Sandmann  <sandmann@redhat.com>

	* gtk/gtkmenutoolbutton.c (button_state_changed_cb): Remove check
	for previous state being ACTIVE. Bug 153876.

Matthias Clasen's avatar
Matthias Clasen committed
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
2004-10-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_drag_data_received) 
	(gtk_file_chooser_button_init): Use the new file DND api.

	* gtk/gtkdnd.h:
	* gtk/gtkdnd.c (gtk_drag_dest_add_uri_targets) 
	(gtk_drag_source_add_uri_targets): 

	* gtk/gtkselection.h:
	* gtk/gtkselection.c (gtk_target_list_add_uri_targets):
	(gtk_selection_data_set_uris):  
	(gtk_selection_data_get_uris): New functions to allow
	handling file DND "without knowing jack shit".

	* configure.in: Bump glib requirement to 2.5.4.

	* gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Use
	g_uri_list_extract_uris().

653
654
655
656
657
658
659
Fri Oct 22 13:25:25 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktextbuffer.c (gtk_text_buffer_backspace): Fix 
	backspacing on the empty last line of a buffer 
	(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=136840,
	Dan Williams)

660
661
662
663
664
665
666
667
668
669
670
671
672
2004-10-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkdnd.c: Document how to use info with text/image 
	targets.

	* gtk/gtkselection.h: 
	* gtk/gtkselection.c (gtk_target_list_add_text_targets): 
	(gtk_target_list_add_image_targets): Add info argument.
	
	* gtk/gtkcalendar.c (gtk_calendar_motion_notify): 
	* gtk/gtkentry.c (gtk_entry_init): 
	* gtk/gtktextview.c (gtk_text_view_init): Adjust all callers.

673
674
675
676
677
2004-10-22  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtktexttag.c: (gtk_text_tag_get_property):
	GdkBitmap is a GObject, not a boxed type.
	
Owen Taylor's avatar
#155952    
Owen Taylor committed
678
679
680
681
682
683
684
685
686
687
688
689
690
Thu Oct 21 15:01:09 2004  Owen Taylor  <otaylor@redhat.com>

	#155952

	* gtk/gtkentry.c: Fix checking the wrong position for
	the backspace_deletes_character PangoLogAttr.

	* gtk/gtktextbuffer.[ch] gtk/gtk.symbols (gtk_text_buffer_backspace): 
	Move backspace logic from GtkTextView to here, check 
	backspace_deletes_char.	

	* gtk/gtktextview.c: Use gtk_text_buffer_backspace().

Matthias Clasen's avatar
Matthias Clasen committed
691
692
2004-10-21  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
693
694
695
696
697
	* gtk/gtkiconcache.c: Include io.h on windows.  (#156075,
	Kazuki IWAMOTO)
	(_gtk_icon_cache_new_for_path): Don't use MAP_FAILED if we don't
	have mmap.

Matthias Clasen's avatar
Matthias Clasen committed
698
699
700
701
702
703
704
705
706
707
708
709
710
711
	* gtk/gtkicontheme.c (gtk_icon_theme_has_icon): Implement for
	cached themes.

	* gtk/gtkiconcache.h: 
	* gtk/gtkiconcache.c (_gtk_icon_cache_has_icon): New function.

	* gtk/updateiconcache.c (scan_directory): Don't skip .icon 
	files which are listed before their images.
	(foreach_remove_func): Instead filter lonely .icon files out
	here.

	* gtk/gtkicontheme.c (theme_dir_get_icon_suffix): Filter out
	the HAS_ICON_FILE flag.

712
713
2004-10-21  Matthias Clasen  <mclasen@redhat.com>

714
715
716
	* gtk/gtkiconcache.c: Make it compile without mmap() and
	add some more checks.  (#155973, Morten Welinder)

717
718
719
720
721
722
723
724
725
726
727
728
729
	Add convenience api for image dnd (#150165):
	
	* gtk/gtkselection.h: 
	* gtk/gtkselection.c (gtk_target_list_add_image_targets) 
	(gtk_selection_data_set_pixbuf, gtk_selection_data_get_pixbuf): 
	New functions to handle the image formats readable/writable 
	by gdk-pixbuf. 
	
	* gtk/gtkdnd.h: 
	* gtk/gtkdnd.c (gtk_drag_dest_add_image_targets) 
	(gtk_drag_source_add_text_targets): New functions to handle
	the image formats readable/writable by gdk-pixbuf. 

730
731
2004-10-20  Matthias Clasen  <mclasen@redhat.com>

732
733
734
	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_new): Make
	the code clearer.  (#155239, Murray Cumming)

Matthias Clasen's avatar
Matthias Clasen committed
735
736
	* gtk/gtkicontheme.c: Small fixes.

737
738
739
740
	* gtk/gtkrc.c: Include gtkmodules.h.  (#155885, Kazuki IWAMOTO)

	* gtk/gtktoolbar.h: Add _gtk_toolbar_rebuild_menu(). (#155885)

741
742
743
	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init): 
	Fix a wrong blurb.  (#155838, Morten Welinder)

744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
2004-10-19  Matthias Clasen  <mclasen@redhat.com>

	Implement icon theme caching.  (#154034, Martijn Vernooij,
	caching schema proposed by Owen Taylor, initial implementation
	by Anders Carlsson)
	
	* gtk/gtkdebug.h: 
	* gtk/gtkmain.c: Add a "icontheme" debug flag.

	* gtk/Makefile.am (gtk_c_sources): Add gtkiconcache.c
	(gtk_private_h_sources): Add gtkiconcache.h
	(bin_PROGRAMS): Add gtk-update-icon-cache

	* gtk/gtkicontheme.c: Use icon caches if they are available.
	Currently, GTK+ uses the cache to get information about the
	available sizes, image file formats and .icon files. The
	actual image data, and the .icon file contents are not 
	cached yet.

	* gtk/updateiconcache.c: A cmdline utility for generating
	icon cache files.

	* gtk/gtkiconcache.h: 
	* gtk/gtkiconcache.c: The glue code to mmap an icon cache
	file and manage the information it contains.

Matthias Clasen's avatar
Matthias Clasen committed
770
771
	* tests/testicontheme.c: Add a "display" option.

772
773
774
775
2004-10-19  Matthias Clasen  <mclasen@redhat.com>

	* tests/testicontheme.c: Set the locale, tidy up output.

776
777
2004-10-18  Matthias Clasen  <mclasen@redhat.com>

Sebastien Bacher's avatar
Sebastien Bacher committed
778
	Fix #155658, Sebastien Bacher:
779
780
781
782
783
784
785
786
787
788
789
790
791
792
	
	* gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a new 
	is_leader flag.

	* gdk/x11/gdkwindow-x11.c (update_wm_hints): Set wm hints on
	leader windows even if they are withdrawn.
	(gdk_window_set_group): Mark the new leader window as such. We 
	never remove the flag again, but that should a) be vanishingly
	rare and b) not a problem, since the flag just turns off an
	optimization.

	* gdk/x11/gdkdisplay-x11.c (gdk_display_open): Mark the default
	leader window as such.

793
794
795
796
797
2004-10-17  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkaboutdialog.c (gtk_about_dialog_new): Destroy secondary
	dialogs if the main dialog is hidden. (#155084, Paolo Borelli)

798
799
2004-10-16  Matthias Clasen  <mclasen@redhat.com>

800
801
802
	* gtk/gtkaboutdialog.c (gtk_about_dialog_destroy): Don't leak
	the secondary dialogs.  (#155084, Paolo Borelli)

803
804
805
	* gtk/gtkhsv.c (gtk_hsv_expose): Fix redraw issues with the
	focus on the ring. 

806
807
808
809
810
2004-10-15  Matthias Clasen  <mclasen@redhat.com>

	* gdk/makegdkalias.pl: Include linux-fb/gdkfb.h when building
	the framebuffer backend.  (#155486, Olexiy Avramchenko)

811
812
2004-10-15  Matthias Clasen  <mclasen@redhat.com>

813
814
815
816
	* gtk/gtksizegroup.c (do_size_request): Unset GTK_REQUEST_NEEDED
	before emitting ::size-request, following this weeks discussion
	on gtk-devel-list@gnome.org.

817
818
819
820
	* gtk/gtkcellview.c (gtk_cell_view_get_size_of_row): Restore 
	the size info for the current row after measuring another 
	row.  (#154945, William Jon McCann)

821
822
823
824
2004-10-14  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Don't
	get text unnecessarily.  (#155384, Morten Welinder)
825
826
	(gtk_file_chooser_default_finalize): Don't forget to
	unref the tooltips.  (#155412, Morten Welinder)
827
828
	(shortcuts_add_current_folder): Don't leak volume. (#155400,
	Morten Welinder)
829

830
831
832
833
834
835
2004-10-12  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcontainer.c (_gtk_container_queue_resize): Acknowledge 
	the fact that invariants are broken and loop all the way up to 
	the resize container.

836
837
838
839
840
841
Tue Oct 12 17:11:02 2004    <timj@birnet.org>

	* gtk/gtkwidget.c (gtk_widget_set_usize_internal): don't queue the
	widget for resize or emit change notification if the usize didn't
	change. this works around a buggy signal connection in #155139.

842
843
2004-10-11  Matthias Clasen  <matthias@localhost.localdomain>

Matthias Clasen's avatar
Matthias Clasen committed
844
845
	* docs/tools/widgets.c: Create scrolledwindow, statusbar, 
	scale and image images. 
846

847
848
2004-10-10  Matthias Clasen  <matthias@localhost.localdomain>

849
850
	* docs/tools/widgets.c: Create a toolbar, menubar, progressbar,
	notebook and messagedialog images.
851
852
853
854

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_select_all): 
	Avoid a warning.

855
856
857
858
859
Sun Oct 10 11:24:56 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkcontainer.h (struct _GtkContainer): add /*< private >*/
	markings.

860
861
2004-10-09  Matthias Clasen  <mclasen@redhat.com>

862
863
	* docs/tools/widgets.c: Shrink panes and separators images to MEDIUM.

Matthias Clasen's avatar
Matthias Clasen committed
864
865
	* gtk/gtkcellview.c: Add docs.

Matthias Clasen's avatar
Matthias Clasen committed
866
867
868
	* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_get_menu): Fix
	doc comment.

869
870
871
872
	* gtk/gtkactiongroup.h: 
	* gtk/gtkactiongroup.c: Reinstate the accidentally lost addition 
	of gtk_action_group_translate_string().

873
874
	* gtk/gtkaccelgroup.h: Declare gtk_accelerator_get_label.

875
876
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
877
878
	* gdk/x11/gdkx.h: Declare gdk_x11_window_set_user_time here.

879
880
881
	* gtk/gtktreeview.c (gtk_tree_view_grab_notify): Don't start a 
	drag if we loose the grab.

882
883
884
885
886
	* gtk/gtkfilechooserdefault.c (renderer_edited_cb): Set the cell 
	renderer to inert mode to avoid bug #154921.  This fixes a crash
	which would otherwise occur if the editing is stopped for the second
	time.  (#154767, Manuel Baena García)

887
888
889
890
	* gtk/gtkdebug.h: 
	* gtk/gtkwidget.c (gtk_widget_size_allocate): Add a new debug
	flag, geometry, to debug size allocation.

891
892
893
	* gtk/gtktreeview.c (gtk_tree_view_button_press): Set cell data
	unconditionally.  (#152562, Federico Mena Quintero)

894
895
896
897
898
899
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkuimanager.c (update_node): Also update smart separators 
	if the visibility of a  menuitem with a submenu changes.  (#153791,
	Christian Persch)

900
901
902
903
904
905
906
907
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.h:
	* gtk/gtkentry.c: 
	* gtk/gtkentrycompletion.c: 
	* gtk/gtkspinbutton.c: Share the three copies of get_borders()
	under the name _gtk_entry_get_borders().  (#116368, Owen Taylor)

908
909
910
911
912
2004-10-07  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (check_is_folder): Don't free 
	info too early.  (#154703, Morten Welinder)

913
914
915
	* gtk/gtkfilechooserdefault.c: Include gtkeventbox.h.
	(#154798, Morten Welinder)

916
917
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

918
919
920
	* gtk/gtkpaned.c (gtk_paned_compute_position): Reduce rounding 
	error.  (#154658, John Cupitt)

921
922
923
	* gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Clear
	the iter instead of returning it unmodified. (#154186, Jonathan Blandford)

924
925
926
	* gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up
	the completions again after tab.  (#147700, Jens Bech Madsen)

927
928
929
930
	* gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor
	before changing the selection to make the file chooser preview
	update work better.  (#143826, Tommi Komulainen)

931
932
933
934
935
936
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkrange.c (gtk_range_real_change_value): Replace a really
	gross way of rounding to a specified number of digits.  (#145232,
	Peter Zelezny, patch by Soeren Sandmann)

937
938
939
940
941
Wed Oct  6 00:45:04 2004    <timj@birnet.org>

	* gdk/gdkwindow.c (gdk_window_is_viewable): check the iteration window
	variable, not just the window passed in. fixes #145270.

942
943
944
945
946
947
Tue Oct  5 21:00:54 2004  Tim Janik  <timj@gtk.org>

	* gtk/gtkwidget.c (gtk_widget_size_allocate): reverted my last change 
	and applied owen's leaner conditional flag update which should be good
	enough to preserve resizing flag invariants.

Matthias Clasen's avatar
Update    
Matthias Clasen committed
948
949
950
951
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* NEWS: Updates

952
953
954
955
Tue Oct  5 19:29:06 2004  Tim Janik  <timj@gtk.org>

	* gtk/gtkentry.h: removed redundant gtk_entry_get_layout() decl.

956
957
958
959
960
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): Go back to
	not scaling up at all. Less magic.

961
962
963
964
965
966
Tue Oct  5 17:06:26 2004  Tim Janik  <timj@gtk.org>

	* gtk/gtkwidget.c (gtk_widget_size_allocate): if REQUEST_NEEDED is still
	set on ::size-allocate, another size-request has been queued since
	::size-request and needs to be requeued.

967
968
969
970
971
2004-10-05  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtkmenutoolbutton.c: rename the activate-menu signal to
	show-menu as discussed in bug #153873.

972
973
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

974
975
976
	* gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Set 
	action_name.  (#154526, John Finlay)

977
978
979
980
	* gdk/x11/gdkwindow-x11.c (gdk_window_foreign_new_for_display): 
	Return a new reference to an existing GdkWindow if one already
	exists.  (#151378, Gustavo Carneiro)

981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	Provide access to the string representation of accelerators used
	in GtkAccelLabel.  (#154068, John Spray)

	* gtk/gtkaccelgroup.h:
	* gtk/gtkaccelgroup.c (gtk_accelerator_get_label): New function
	to return the accelerator label used in GtkAccelLabel. 
	(gtk_accelerator_name): Update docs to point to 
	gtk_accelerator_get_label().
	* gtk/gtkaccellabel.h:
	* gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label): 
	New auxiliary function which creates the string representing the
	accelerator.
	
996
997
998
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_set_model): Resize the
Matthias Clasen's avatar
Matthias Clasen committed
999
	popup if a new model is set.  (#154129, Bernd Demian)
1000

1001
1002
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

1003
1004
1005
1006
1007
1008
	* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): 
	Make the code work as intended for unthemed icons; don't scale
	them up too much. Allow to scale them down, and do so 
	exactly.  (#154142, Ross Burton)
	(gtk_icon_info_load_icon): Amend docs.

1009
1010
1011
	* gtk/gtkcelllayout.c (gtk_cell_layout_clear): Improve 
	docs.  (#154504, Dave Cook)

1012
1013
	* gtk/gtkwindow.c (gtk_window_set_icon_list): 
	(gtk_window_set_default_icon_list): Ref the new icons
1014
	before unreffing the old ones.  (#154468, Morten Welinder)
1015
1016
1017
	(gtk_window_realize_icon): Only set using_themed_icon if
	we actually got an icon list from the theme.  (#154472, Morten
	Welinder)
1018

1019
1020
2004-10-03  Matthias Clasen  <mclasen@redhat.com>

1021
1022
1023
	* gtk/gtkiconview.c (gtk_icon_view_set_model): Reset pointers
	pointing to the old model.  (#154350)

1024
1025
1026
	* gtk/gtkwindow.c (icon_list_from_theme): Don't leak the
	sizes array.  (#154310, Christian Persch)

1027
1028
1029
1030
1031
	* gtk/gtktreeviewcolumn.c 
	(gtk_tree_view_column_setup_sort_column_id_callback): 
	Set sort_indicator to FALSE when appropriate.  (#153714, 
	Reinout van Schouwen)

1032
1033
1034
1035
	* gtk/gtktreeview.c (gtk_tree_view_search_position_func): 
	Fix positioning near the monitor boundaries.  (#154341,
	Ken Harris)

1036
1037
2004-10-01  Paolo Borelli  <pborelli@katamail.com>

Matthias Clasen's avatar
Update    
Matthias Clasen committed
1038
	* gtk/gtkmenutoolbutton.c: deactivate the menu before setting it
1039
1040
	to something else. Bug #153887.

Matthias Clasen's avatar
Matthias Clasen committed
1041
1042
1043
1044
1045
1046
1047
1048
1049
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

	Fix bug #150790:
	
	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): Fix the
	calculation of x_offset when ellipsized and in RTL mode.
	(gtk_cell_renderer_text_render): Fix the calculation of the layout
	width when ellipsized.  

1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
2004-10-01  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkglobals-win32.c: Set _gdk_input_ignore_wintab to
	FALSE, thus enabling tablet input by default.

	* gdk/win32/gdkmain-win32.c (_gdk_windowing_args): Accept the
	--use-wintab option again (but without effect, as this is now the
	default, see above). (#153788)

	* modules/input/gtkimcontextime.c: Numerous changes.

	Remove the ifdef UNICODE conditionals. Always use the
	wide-character Imm* API. It is present also in Windows 98 and
	Me. (Not Windows 95, but I think we don't care about that.) Using
	the multibyte API wouldn't work anyway on systems where the system
	codepage doesn't support the language the user uses an IME for, so
	for instance I wouldn't be able to test this module on my English
	Windows 2000 although I do have C, J and K IMEs available.

	Guard against IMM not being active, always check ImmGetContext()
	returning NULL. Work to some extent even without any IME. Fixes
	#153800 at least partially.

	* modules/input/imime.c (ime_info): Rename to "ime" to match the
	naming pattern of other input modules. Make it default for
	ja:ko:zh only.

1077
1078
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

1079
1080
1081
	* gtk/gtkcombobox.c (gtk_combo_box_set_model): Add a comment regarding
	cell renderers to the docs.

1082
1083
1084
1085
1086
1087
1088
	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes): 
	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear_attributes): 
	Silently ignore info being NULL. This is unavoidable with the 
	current design where we have every implementation of layout_clear
	call layout_clear_attributes, and also delegate calls to dependent
	cell layouts.  (#154191, Martyn Russell)

1089
1090
1091
1092
1093
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

	* modules/input/iminuktitut.c: Fix the spelling of Inuktitut
	in several places.  (#154176, John Austin)

Paolo Borelli's avatar
Paolo Borelli committed
1094
1095
1096
1097
2004-09-30  Paolo Borelli  <pborelli@katamail.com>

	* tests/testellipsize.c: exit on close.

1098
1099
1100
1101
1102
2004-09-29  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmain.c: Make --g-fatal-warnings a G_OPTION_ARG_NONE,
	since it doesn't take an argument.

1103
1104
1105
1106
1107
2004-09-29  Christopher Blizzard  <blizzard@redhat.com>

	* gtk/gtkmenutoolbutton.h: Remove trailing semicolon on
	G_END_DECLS

Paolo Borelli's avatar
Paolo Borelli committed
1108
1109
1110
1111
2004-09-29  Paolo Borelli  <pborelli@katamail.com>

	* tests/testtoolbar.c: add a GtkMenuToolButton.

1112
1113
2004-09-29  Matthias Clasen  <mclasen@redhat.com>

1114
1115
1116
1117
1118
1119
	* gtk/gtkiconview.c (gtk_icon_view_move_cursor_left_right) 
	(gtk_icon_view_move_cursor_start_end) 
	(gtk_icon_view_move_cursor_page_up_down) 
	(gtk_icon_view_move_cursor_up_down): Handle an empty icon
	view gracefully.  (#152486)

Matthias Clasen's avatar
Matthias Clasen committed
1120
1121
	Allow keynav to selectable labels (#138085, David Hawthorne):
	
1122
1123
1124
1125
1126
1127
	* gtk/gtkdialog.c (gtk_dialog_map): Skip selectable labels when
	looking for the initial focus widget.

	* gtk/gtklabel.c (gtk_label_focus): Remove to put selectable labels 
	in the regular focus chain again.

1128
1129
2004-09-28  Matthias Clasen  <mclasen@redhat.com>

1130
1131
1132
1133
	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render): Don't
	reuse insensitive pixbufs across multiple rows.  (#153984, Milosz
	Derezynski)

1134
1135
1136
1137
1138
1139
	* gtk/gtkmain.c (gtk_parse_args): Use gtk_get_option_group() 
	to obtain an option group with correctly set pre- and post-
	parse hooks, instead of manually calling the hooks. This fixes
	a problem with setting the program class in the gdk preparse
	hook.  (#153788, Robert Ögren)

Matthias Clasen's avatar
Matthias Clasen committed
1140
1141
1142
1143
1144
1145
1146
1147
1148
2004-09-27  Matthias Clasen  <mclasen@redhat.com>

	Fix #153082:
	
	* gtk/gtkmain.c (do_pre_parse_initialization): Don't call gdk_parse_args()
	here, we don't want to parse args twice.
	(gtk_init_with_args): Add the ugid check here as well.
	(gtk_parse_args): Add the gdk options to the main option group as well.

1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
2004-09-27  Paolo Borelli  <pborelli@katamail.com>

	* gtk/Makefile.am:
	* gtk/gtk.h:
	* gtk/gtkmenutoolbutton.[ch]: add the GtkMenuToolButton widget
	discussed in bug #151441.

	* docs/reference/gtk/gtk-docs.sgml:
	* docs/reference/gtk/gtk-sections.txt:
	* docs/reference/gtk/gtk.types:
	* docs/reference/gtk/tmpl/gtkmenutoolbutton.sgml: docs for the
	new widget.

Matthias Clasen's avatar
Matthias Clasen committed
1162
1163
1164
1165
1166
2004-09-27  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilesystemunix.c (gtk_file_folder_unix_list_children): 
	Emit ::finished-loading.

1167
1168
1169
1170
2004-09-27  Roozbeh Pournader  <roozbeh@farsiweb.info>
 
	* configure.in: Added Iranian Azerbaijani (az_IR) to ALL_LINUGAS.

1171
1172
2004-09-27  Matthias Clasen  <mclasen@redhat.com>

1173
1174
1175
	* gtk/gtktreeview.c (gtk_tree_view_append_column): Fix typo in
	docs.  (#153811, Billy Biggs)

1176
1177
1178
	* gtk/gtkpathbar.h (struct _GtkPathBar): Only need a bit for
	need_timer.

1179
1180
1181
1182
1183
1184
2004-09-26  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_class_init): Add a missing _
	to the name of the has_secondary_backward_stepper property.
	Noticed by Michèle Garoche.

Jonathan Blandford's avatar
Jonathan Blandford committed
1185
1186
1187
1188
Sun Sep 26 02:06:43 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkpathbar.h (struct _GtkPathBar): add missing structures.

1189
1190
2004-09-26  Matthias Clasen  <mclasen@redhat.com>

1191
1192
1193
	* gtk/gtkpathbar.c (gtk_path_bar_check_parent_path): Scroll
	to make the current folder visible.  (#152921)

1194
1195
1196
1197
1198
1199
	* gtk/gtkbutton.c: Revert the button state to !button_down,
	if we're missing the release event due to grab shadowing
	or insensitivation.

	* gtk/gtkpathbar.c: Make the slider buttons scroll.

Matthias Clasen's avatar
Matthias Clasen committed
1200
1201
	* gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Remove 
	debug spew.
1202
1203
	(bookmarks_check_remove_sensitivity): Don't free an uninitialized
	pointer.
Matthias Clasen's avatar
Matthias Clasen committed
1204

1205
1206
1207
	* gtk/gtkimcontext.c (gtk_im_context_get_preedit_string): 
	cursor_pos is in characters, not bytes.  (#153332, Owen Taylor)

1208
1209
1210
1211
1212
1213
2004-09-25  Robert Ögren  <gtk@roboros.com>

	* gdk/win32/gdkinput-win32.c (gdk_input_wintab_init): Set
	lcSysOrgX and lcSysOrgY from device instead of hardcoding to 0,
	a further fix for bug #145467.

1214
2004-09-25  Matthias Clasen  <mclasen@redhat.com>
1215
1216
1217
1218

	* gtk/gtktextiter.c (inside_word_func): Don't access 
	attr[-1].  (#153628, Padraig O'Briain)

Matthias Clasen's avatar
Matthias Clasen committed
1219
1220
1221
1222
2004-09-23  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Add some tooltips.

1223
1224
2004-09-22  Matthias Clasen  <mclasen@redhat.com>

1225
1226
1227
	* gtk/gtkrange.c (gtk_range_map, gtk_range_unmap): 
	* gtk/gtkbutton.c (gtk_button_map, gtk_button_unmap): Remove
	unnecessary g_return_if_fail()s from virtual functions.  (#153469,
Matthias Clasen's avatar
Matthias Clasen committed
1228
	(Tristan Van Berkom) 
1229

1230
1231
1232
	* gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't leak
	cursors.  (#153468, Christian Persch)

1233
1234
1235
	* gtk/gtktreeview.c (gtk_tree_view_key_press): Don't leak old_text.
	(#153467, Christian Persch)

1236
1237
	* gtk/gtkfilechooserdefault.c (selection_check_foreach_cb): Don't use
	bitops on booleans.
1238
1239
	(gtk_file_chooser_default_should_respond): Make it easier to 
	select folders in SELECT_FOLDER mode.
1240

Matthias Clasen's avatar
Matthias Clasen committed
1241
1242
1243
1244
1245
Wed Sep 22 00:54:34 2004  Matthias Clasen  <mclasen@redhat.com>

	* demos/gtk-demo/pixbufs.c (do_pixbufs): Don't leak the frame
	pixbuf.

1246
1247
1248
1249
1250
Tue Sep 21 16:55:38 2004  Manish Singh  <yosh@gimp.org>

	* tests/testtreemodel.c: #include <config.h> for HAVE_MALLINFO define,
	other minor cleanups.

1251
1252
1253
1254
1255
1256
1257
1258
1259
Tue Sep 21 16:27:19 2004  Manish Singh  <yosh@gimp.org>

	* gdk/gdk.c: remove now unused arg variables.

	* gdk/gdkinternals.h: declare _gdk_windowing_init ().

	* gtk/gtkmain.c (do_pre_parse_initialization): call gdk_parse_args ()
	here instead of gdk_pre_parse_libgtk_only (). Should fix #153082.

1260
1261
2004-09-21  Matthias Clasen  <mclasen@redhat.com>

1262
1263
1264
	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_should_respond): 
	Don't assert that current_focus != NULL, just return FALSE.

1265
1266
1267
	* gtk/gtkpathbar.c (gtk_path_bar_size_request): Give the path
	bar arrows some more space.

Matthias Clasen's avatar
Matthias Clasen committed
1268
1269
1270
1271
1272
	* configure.in: Check for mallinfo.

	* tests/testtreemodel.c: Only include malloc.h if HAVE_MALLINFO
	is defined.  (#153168, Darren Creutz)

1273
1274
1275
	* gtk/gtkactiongroup.c: Fix typos in signal docs.  (#153224,
	John Finlay)

1276
1277
1278
1279
1280
Mon Sep 20 19:44:58 2004  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_activate_iter): Don't
	return FALSE from a void function.  (#153185, Joel Fredrikson)

1281
1282
1283
1284
1285
1286
2004-09-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkbutton.c (gtk_button_class_init): Add a boolean ::displace-focus
	style property and apply child displacement to the focus rectangle 
	if it is TRUE.  (#141170, Soeren Sandmann)

1287
1288
1289
1290
1291
Sun Sep 19 23:56:18 2004  Søren Sandmann  <sandmann@redhat.com>

	* gtk/gtkmenu.c (MENU_SCROLL_TIMEOUT2): Change from 50 to 20 to
	make the menus scroll faster.

Matthias Clasen's avatar
2.5.3    
Matthias Clasen committed
1292
1293
2004-09-19  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Matthias Clasen committed
1294
1295
	* configure.in: Bump version

Matthias Clasen's avatar
2.5.3    
Matthias Clasen committed
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
	* === Released 2.5.3 ===

2004-09-18  Matthias Clasen  <mclasen@redhat.com>

	Make GtkFileChooserButton activatable via mnemonics.
	(#152925, Dennis Cranston, patch by James M. Cape)

	* gtk/gtkfilechooserbutton.c: Add a ::mnemonic-activate signal
	and a suitable default handler.

	* tests/testfilechooserbutton.c: Add a mnemonic.

2004-09-18  Matthias Clasen  <mclasen@redhat.com>

	Fix win32 build errors.  (#153032, #153028, Robert Ögren)

	* gdk/win32/gdkmain-win32.c: Make it compile.  

	* gtk/gtkmain.c: Include glib.h.  

Federico Mena Quintero's avatar
Federico Mena Quintero committed
1316
1317
1318
1319
1320
1321
1322
1323
2004-09-18  Federico Mena Quintero  <federico@ximian.com>

	Merged from 2.4:

	* gtk/gtkfilesystem.h: Removed the GTK_FILE_PATH() and
	GTK_IS_FILE_PATH() macros.  They are not supposed to exist, as
	GtkFilePath is not an object.  And they never worked, anyway.

1324
1325
1326
1327
2004-09-18  Marco Pesenti Gritti  <marco@gnome.org>

	* gtk/gtkentry.c: (gtk_entry_completion_key_press):

Matthias Clasen's avatar
2.5.3    
Matthias Clasen committed
1328
1329
	Make numeric pad enter activate the selected completion
	entry. Fix bug 143486 reported by Edd Dumbill.
1330

1331
1332
2004-09-17  Matthias Clasen  <mclasen@redhat.com>

Matthias Clasen's avatar
Updates    
Matthias Clasen committed
1333
1334
	* NEWS: Updates

1335
1336
1337
	* gtk/gtkfilechooserdefault.c (select_func): Scroll to the selected
	row.  (#143868, Christian Persch)

Matthias Clasen's avatar
Matthias Clasen committed
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
2004-09-17  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
	leftover debug code.

	Improve the behaviour of the file chooser in save mode. Fixes bugs
	#151031, #151608, #151994 reported by Owen Taylor and Alexander 
	Larsson.
	
	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property): 
	(location_entry_create): Propagate the action to the file 
	chooser entries.
	(gtk_file_chooser_default_should_respond): Switch folders if 
	the user enters a directory name in the entry and clear the entry
	after switching folders.
	(gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb): 
	Move focus to the file list when activating a shortcut.
	(gtk_file_chooser_default_should_respond): Handle the case where the
	user clicks on "Save" after selecting a folder in the file list.

	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property): 
	Propagate the action to the file chooser entries.
	
	* gtk/gtkfilechooserentry.h: 
	* gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action): 
	(_gtk_file_chooser_entry_get_action): New functions to propagate
	the GtkFileChooserAction of the file chooser to the file chooser 
	entry.
	(check_completion_callback): If we are in save mode, only do 
	inline completion for directories. 

1369
1370
1371
1372
1373
Fri Sep 17 11:20:03 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtklabel.c (gtk_label_set_markup): Add an example to the
	docs.

1374
1375
1376
1377
1378
1379
1380
Thu Sep 16 23:20:05 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkselection.c (selection_get_text_plain): 
	* gdk/x11/gdkselection-x11.c (make_list): Warn if a UTF8_STRING
	or text/plain;charset=utf-8 roperty contains invalid 
	UTF-8.  (#152845, Owen Taylor)

1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
2004-09-16  Matthias Clasen  <mclasen@redhat.com>

	Fix #152760, Christian Persch:
	
	* gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't free
	private data.
	(gtk_about_dialog_set_translator_credits): Recommend the msg
	id translator-credits.
	(display_credits_dialog): Show translator credits if they're
	translated, not if they're untranslated.

1392
1393
1394
1395
1396
1397
1398
Thu Sep 16 02:07:56 2004  Jonathan Blandford  <jrb@gnome.org>

	* docs/tools/widgets.c (create_icon_view): load images at normal
	size.

	* docs/reference/gtk/images/*png: Update shots.

1399
1400
1401
1402
1403
1404
Thu Sep 16 00:33:11 2004  Jonathan Blandford  <jrb@gnome.org>

	* docs/tools/widgets.c (new_widget_info): Add constrained sizing
	to the widgets.  This gives us all images running the same size,
	which will make the table layout look better.

1405
1406
1407
1408
1409
1410
1411
1412
2004-09-15  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkwindow-win32.c (gdk_window_get_frame_extents):
	Remove bogus code that tried to do what the X11 backend does in
	its version of this function. There are no "frame windows" (for
	toplevel window decoration) on Windows. The desktop ("root")
	window is not the parent of a toplevel window. (#152481)

Matthias Clasen's avatar
Matthias Clasen committed
1413
1414
1415
1416
2004-09-15  Matthias Clasen  <mclasen@redhat.com>

	* NEWS: Update.

1417
1418
1419
1420
1421
Wed Sep 15 00:57:37 2004  Matthias Clasen  <maclas@gmx.de>

	* docs/tools/widgets.c: Add accel label, file button
	and icon view.

1422
1423
1424
1425
1426
1427
1428
1429
1430
Tue Sep 14 22:01:49 2004  Matthias Clasen  <maclas@gmx.de>

	* configure.in: New option --disable-visibility to disable
	the use of ELF visibility attributes for PLT reduction.

	* gtk/makegtkalias.pl: 
	* gdk/makegdkalias.pl: Respect the DISABLE_VISIBILITY
	define.

1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
Tue Sep 14 23:20:56 2004  Søren Sandmann  <sandmann@redhat.com>

	* gtk/gtkaction.c (connect_proxy): Call
	gtk_tool_item_rebuild_menu().

	* gtk/gtktoolitem.c (gtk_tool_item_class_init): Update
	documentation for GtkToolItem::create_menu_proxy.

	* gtk/gtktoolitem.c (gtk_tool_item_rebuild_menu): New
	API to make the toolbar update itself when the proxy menu item
	for a tool item changes.

	* gtk/gtktoolbutton.c (gtk_tool_button_construct_contents): Call
	gtk_tool_item_rebuild_menu here()

	* gtk/gtktoolbutton.c (gtk_tool_button_construct_contents):
	Remove redundant check for need_label.

1449
1450
2004-09-14  Matthias Clasen  <mclasen@redhat.com>

1451
1452
1453
	* gtk/gtkmain.c (do_post_parse_initialization): Remove an unused 
	variable, spotted by Morten Welinder.

1454
1455
1456
	* gtk/queryimmodules.c (escape_string): Copy code from queryloaders.c
	which turns backslashes in slashes on win32.  (#152608, Kazuki IWAMOTO)

1457
1458
1459
1460
1461
1462
	* gtk/gtktreeview.c (gtk_tree_view_focus_to_cursor): Set the cursor
	to the first selected row instead of always to the first row if there
	is no cursor.  (#143270, Jean Bréfort)

	* tests/testfilechooser.c (main): Fix a few typos.

1463
1464
2004-09-13  Matthias Clasen  <mclasen@redhat.com>

1465
1466
1467
1468
1469
	* gtk/gtkexpander.c: 
	* gtk/gtktreeview.c: Change the default expander size to 12 to compensate 
	for the recent change to gtk_default_draw_expander().

	* gtk/gtkstyle.c (gtk_default_draw_expander): Use a linewidth of one
Matthias Clasen's avatar
Matthias Clasen committed
1470
	for expander sizes up to 16
1471

1472
1473
1474
	* gtk/gtkentrycompletion.c (gtk_entry_completion_get_model): Resize the
	popup if the model is replaced.  (#152333)

1475
1476
1477
1478
1479
Mon Sep 13 09:11:53 2004  Manish Singh  <yosh@gimp.org>

	* gtk/gtkrange.c: fix gtk_range_real_change_value args. Addresses part
	of #152518.