ChangeLog.pre-2-8 416 KB
Newer Older
Owen Taylor's avatar
Owen Taylor committed
1 2 3 4 5 6 7 8 9 10 11
Tue Mar 16 13:29:58 2004  Owen Taylor  <otaylor@redhat.com>

	* === Released 2.4.0 ===

	* configure.in: Version 2.4.0, interface age 0; 
	require glib-2.4.0, pango-1.4.0.

	* NEWS: Updates

	* README.in: Updates

12 13 14 15 16 17
Tue Mar 16 13:54:07 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkentry.c (gtk_entry_completion_key_press): Block the
	::changed handler during the ::match-selected when done by
	keyboard.

18 19 20 21 22 23 24 25 26 27 28 29 30 31
Tue Mar 16 00:56:11 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press): 
	Block the ::changed handler during the emission of ::match-selected.
	Partial fix for #137226.

	* gtk/gtkfilechooserentry.c: Remove the no longer needed 
	no_pop_down flag.

Tue Mar 16 00:20:51 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkfilechooserwidget.c (gtk_file_chooser_widget_new_with_backend):
	Fix a typo in the docs.

Tor Lillqvist's avatar
Tor Lillqvist committed
32 33 34 35
2004-03-15  Tor Lillqvist  <tml@iki.fi>

	* README.win32: Updates.

36 37 38 39 40 41 42 43 44 45 46
2004-03-15  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (update_appearance): Only hide the
	"create folder" button in OPEN mode; all the others should show it
	it.
	(get_paths_foreach): Handle the editable row.

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder):
	Force a re-get of the folder so that the new directory gets added
	to its hash table of file info.

47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
2004-03-15  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (update_from_entry): In the Save
	modes, set the Name entry of the file chooser if we get a
	nonexistent filename from the file entry.  Fixes #135911.
	(gtk_file_chooser_default_set_current_name): Oops, this should
	also work if we are in CREATE_FOLDER mode.

	* gtk/gtkfilesystem.c (gtk_file_path_real_copy): Use
	gtk_file_path_copy().

	* gtk/gtkfilechooserentry.c (check_completion_callback): Free the
	path that we got from the model.
	(completion_match_func): Use DISPLAY_NAME_COLUMN rather than a
	hard-coded constant.

63 64 65 66 67
Mon Mar 15 13:50:14 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
	Don't leak the temporary font description. (Nils O. Selåsdal)

68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
Mon Mar 15 12:51:17 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (location_popup_handler): Only show
	the title string in OPEN/SELECT_FOLDER mode as it's open-specific.
	Put a blank title for SAVE/CREATE_FOLDER; we are in string freeze,
	so we'll fix it for 2.4.1 as #137272.

	* gtk/gtkpathbar.c (gtk_path_bar_scroll_down): calculate
	space_available correctly for RTL mode.  w/o this, you can't
	scroll down again.  Fixes #137021.

2004-03-15  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkpathbar.c (gtk_path_bar_scroll_up): Queue a resize.
	(gtk_path_bar_scroll_down): Likewise.

84 85 86 87 88 89 90 91
Mon Mar 15 11:40:43 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilechooserentry.c: Store the position of the 
	file part and use that in check_completion_callback()
	and match_selected_callback() to figure out where
	to operate on the text, rather than recomputing the
	information.

92 93 94 95 96 97 98
Mon Mar 15 10:35:19 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): set
	changing_folders to be true so we don't trigger a callback when we
	remove the selection
	(shortcuts_add_bookmarks): ditto

Owen Taylor's avatar
Owen Taylor committed
99 100 101 102
Mon Mar 15 10:47:18 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilechooserentry.c: s/seperator/separator/.

103 104 105 106 107 108 109
Mon Mar 15 09:54:36 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtklabel.c (gtk_label_focus): Check for 
	Control-Tab or Control-Shift-Tab, not any Control-key
	as a current event ... handles the case where a dialog
	is triggered from a control accelerator better.

110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
Mon Mar 15 08:48:48 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserentry.c (match_selected_callback): implement
	correctly.
	(completion_match_func): Allow surpressing popdowns.
	(maybe_append_seperator_to_path): New function to add a separator
	item to a display_name.  Bad hack.
	(check_completion_callback): Implement select-ahead as an idle.
	(add_completion_idle): new function to handle select-ahead
	(gtk_file_chooser_entry_do_insert_text): starf the select-ahead
	idle.
	(gtk_file_chooser_entry_focus): Override tab for completion.
	(gtk_file_chooser_entry_activate): commit select_ahead when
	activated.

	* gtk/gtkfilechooserdefault.c (location_popup_handler): grab the
	appropriate widget for the mode.

128 129 130 131 132 133
2004-03-15  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkgc-win32.c (gdk_gc_copy): Don't just copy the whole
	GdkGCWin32 with a single assignment, that overwrites GObject's
	private data (for instance ref_count). (#137012, John Ehresman)

134 135 136 137 138 139
2004-03-15  Mark McLoughlin  <mark@skynet.ie>

	* gtk/gtkfilechooserdefault.c: remove the unused "lowest_folder"
	GtkFileChooserDefault member. Leftover from my original patch
	for bug #136987.

140 141 142 143 144 145 146 147 148 149 150
Mon Mar 15 01:50:28 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtkfilechooserentry.c: Rewritten to use the GtkEntryCompletion
	API more correctly.  Now pops down the dropdown well.

	* gtkfilesystem.c (gtk_file_path_get_type): New boxed type for the
	FilePath.

	* test/testfilechooser.c: disable preview widget temporarily.
	It's not representative of a good preview widget.

151 152 153 154 155 156 157 158 159
2004-03-15  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_find_current_folder):
	Renamed from shortcuts_unselect_all(); now selects the row that
	corresponds to the current folder, if any.  Fixes #135916.

	* gtk/gtkpathbar.h: Added prototypes for _gtk_path_bar_up() and
	_gtk_path_bar_down().

160 161 162 163 164 165
2004-03-15  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c: Surround the
	drag-outside-to-remove-bookmarks code with "#if 0" blocks; it's
	too unstable right now.

166 167 168 169 170 171 172 173 174 175 176
Sun Mar 14 23:36:15 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilechooserdefault.c: Implement local_only by
	filtering the shortcuts and bookmarks list by 
	gtk_file_system_path_to_filename (file_system, path) != NULL.
	(#132894)

	* gtk/gtkfilesystem.c (gtk_file_system_path_is_local): Add
	a convenience function, may by interesting to push to the 
	file system vtable later for performance.

177 178 179 180 181 182 183 184 185 186 187 188 189 190
2004-03-14  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilesystem.c (gtk_file_folder_get_info): Allow the path
	to be NULL, so that people can ask for information about a
	parent-less file system root (e.g. get_info (get_folder ("/"), NULL)).

	* gtk/gtkfilesystemunix.c (gtk_file_folder_unix_get_info): Allow
	the condition describe above.

	* gtk/gtkfilechooserdefault.c (get_file_info): Allow getting
	information of root paths.

	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Handle root paths correctly.

191 192 193 194 195 196 197 198 199 200
Sun Mar 14 22:32:36 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Mention
	GtkTreeViewSearchEqualFunc return value oddity here as well.

	* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): On failure
	to get a string to compare to, return TRUE (no match), not 
	FALSE (match). Handle %NULL string values gracefully.
	Remove unused variable. (#135962, Mark McLoughlin)

Morten Welinder's avatar
Morten Welinder committed
201 202 203 204
2004-03-14  Morten Welinder  <terra@gnome.org>

	* gtk/gtkfilesystemunix.c: Kill some debug g_prints.

205 206 207 208 209 210 211 212 213 214
Sun Mar 14 21:03:15 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkpathbar.[ch]: Add _gtk_path_bar_up()/
	_gtk_path_bar_down().

	* gtk/gtkfilechooserdefault.c: Use _gtk_path_bar_up()/
	_gtk_path_bar_down() as bindings for Alt-Up
	and new Alt-Down. (Partly based on a patch by
	Mark McLoughlin, #136987)

215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243
2004-03-14  Federico Mena Quintero  <federico@ximian.com>

	Fixes #136185, patch by Morten Welinder, with some changes.

	* gtk/gtkfilechooserdefault.c (check_is_folder): New helper function.
	(shortcuts_insert_path): Check the path first with check_is_folder().
	(gtk_file_chooser_default_set_current_folder): Likewise.
	(gtk_file_chooser_default_add_shortcut_folder): Likewise.
	(browse_widgets_create): Unref the size group.

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder):
	Handle the case where the file exists but it is not a directory.
	(IconType): Add value for ICON_UNDECIDED.
	(struct stat_info_entry): New structure to hold a file's struct
	stat, its MIME type and its icon type.
	(struct _GtkFileFolderUnix): Added a hash of struct
	stat_info_entry, and flags to remember which info types we've read
	so far.
	(get_icon_type): Use a helper function for the icons-from-stat
	types.
	(gtk_file_system_unix_render_icon): Use the cached file info.
	(gtk_file_folder_unix_get_info): Put the info in the cache.
	(gtk_file_system_unix_get_folder): Create the cache of file info
	structures.

	* gtk/gtkfilesystem.c (gtk_file_info_set_display_name): Handle the
	case where display_name is the same as the existing
	info->display_name.

244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268
Sun Mar 14 19:26:48 2004  Owen Taylor  <otaylor@redhat.com>

	#136672, reported by Christian Persch; fixes based
	on a patch by Soeren Sandmann.

	* gtk/gtkmenu.c: Change the handling of mixed gridded
	and non-gridded menu items; the old method was causing
	major performance problems even with the "avoid relayout
	on destruction" hack put in recently.

	Now we first lay out the gridded items and then put the 
	non-gridded items into empty rows / after the gridded items. 
	Layout is done in a central menu_shell_ensure_layout(). Also
	avoid emitting property notifications when we initially
	insert or attach items.
	
	* gtk/gtkmenushell.[ch] gtk/gtkmenu.c: Stop setting the
	unused menu_shell->menu_flag, and document it as unused
	in the header.

	* tests/testactions.c: Add a test of creating/removing
	lots of items.

	* test/testgtk.c: Add some more cruft to the menu test.

Matthias Clasen's avatar
Matthias Clasen committed
269 270 271 272 273
Mon Mar 15 02:36:07 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkentrycompletion.c (gtk_entry_completion_class_init): Add
	some signal docs.

274 275 276 277 278
Sun Mar 14 15:38:39 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkentrycompletion.c (gtk_entry_completion_visible_func):
	always use the match_func, even if text_column is set.

279 280
2004-03-14  Morten Welinder  <terra@gnome.org>

281 282 283 284 285
	* gtk/gtkfilesystemunix.c (get_parent_dir): Don't turn "/" into
	"".
	(gtk_file_system_unix_get_folder): Use the same value for lookup
	as for insertion.  Make sure we have a directory.

286 287 288
	* gtk/gtkfilechooserdefault.c (error_dialog): Don't crash on NULL
	path; don't crash on NULL error.

289 290 291 292 293 294 295 296 297
2004-03-14  Hans Breuer  <hans@breuer.org>

	gtk/gtkcombobox.c : prototype cell_view_sync_cells() before 
	first usage

	gtk/makefile.msc.in : updated 'gtk_public_h_sources'

	tests/makefile.msc : added testspinbutton

298 299 300 301 302 303 304 305 306 307 308 309
Sun Mar 14 01:01:18 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Align
	this function with gtk_tree_view_column_set_cell_data();
	call the cell data func after setting the attributes.

Sun Mar 14 01:00:08 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_expose): One more try;
	make sure not to call gtk_cell_view_set_cell_data() when
	displayed_row is NULL.

310 311 312 313 314 315
Sat Mar 13 18:13:13 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktextlayout.c (gtk_text_layout_get_line_display): When not
	wrapping, do the offset of the line for justification ourselves.
	(#120256, Felipe Heidrich)

316 317 318 319 320
Sun Mar 14 00:03:18 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_expose): Support the
	model-less use of GtkCellView shown in testcombo.c.

321 322 323 324 325 326 327 328 329 330 331 332
2004-03-13  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkdisplay-win32.c: Don't undefine HAVE_MONITOR_INFO
	when compiling with gcc. Mingw's headers do have the required
	definitions.

	* gdk/win32/gdkdrawable-win32.c (draw_polygon): When drawing
	filled polygons, don't draw the outline, similarily as
	draw_rectangle(). Apparently GTK and GIMP don't use
	gdk_draw_polygon() much (or always draw the outline, too), as this
	has gone undetected for so long. Thanks to Bruce Hochstetler.

333 334 335 336 337 338 339 340
Sat Mar 13 15:19:17 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkwindow.c (gtk_window_destroy): Remove
	the window from the toplevel_list here rather in destroy.
	While this is theoretically speaking wrong, it fits
	in better with the current reality that destroyed
	widgets are not reusable. (#126808, Michael Natterer)

341 342 343 344 345 346
Sat Mar 13 21:47:47 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_expose): Don't do anything
	beyond clearing to the background if there is no active row.
	(#137066, reported by Owen Taylor)

347 348 349 350 351
Sat Mar 13 21:37:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_list_key_press): Pop down the
	list when an item is selected via the keyboard.

352 353 354 355 356 357 358 359
2004-03-13  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkfilesystemunix.c: (remove_trailing_slash),
	(gtk_file_system_unix_get_folder),
	(gtk_file_system_unix_create_folder), (get_parent_dir),
	(gtk_file_system_unix_get_parent), (gtk_file_folder_unix_get_info):
	Remove trailing slashes in path names.
	
360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
Sat Mar 13 12:17:16 2004  Owen Taylor  <otaylor@redhat.com>

	* gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Make
	this a total no-op when the new or old parent is
	destroyed. (#134230, patch from Soeren Sandmann)

	* gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
	For foreign windows in our heirarchy, call
	_gdk_windowing_window_destroy_foreign (window) and skip
	all the normal destruction logic.

	* gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c:
	Move code to request destruction of a foreign window
	code into a separate _gdk_windowing_window_destroy_foreign().

	* gdk/x11/gdkwindow-x11.c (gdk_window_impl_x11_finalize):
	Call GDK_WINDOW_DISPLAY() on the wrapper not on the
	impl. (Also from Soeren's patch)

379 380 381 382 383 384 385 386
Sat Mar 13 10:49:46 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkdnd.c (_gtk_drag_dest_handle_event): For
	GTK_IS_PLUG toplevels, call gdk_window_get_origin() 
	not gtk_window_get_position, as a hackround for not
	having accurate notification of window position for
	embedded windows. (#136112, Dan Winship)

387 388 389 390 391 392
Sat Mar 13 10:34:03 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktextview.c gtk/gtktextbuffer.c: Revert last change;
	it causes problems for pastes from other applications; see
	comments in bugzilla for #81880.

393 394 395 396 397 398 399 400 401 402 403 404
Sat Mar 13 02:55:51 2004  Matthias Clasen  <maclas@gmx.de>

	Fix middle button pasting in the TextView  (#81880, reported
	by Evert Verhellen, patch by Paolo Borelli):
	
	* gtk/gtktextview.c (gtk_text_view_button_press_event): Retrieve 
	the insert mark and move the cursor to it making sure of also 
	scroll the window if needed.
	
	* gtk/gtktextbuffer.c (pre_paste_prep): Move the insert mark
	to the insertion point.

405 406 407 408 409 410
Sat Mar 13 01:38:55 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_remove): Add a remove 
	implemenatation which restores the cell_view when the custom 
	child is removed.  (#136555, Owen Taylor)

411 412 413 414 415 416 417
Sat Mar 13 00:07:51 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear): 
	Keep the cell_list in a consistent state while iterating over it, 
	since clear_attributes() also iterates over it.  (another instance
	of #136585, Morten Welinder)
	
418 419 420 421 422 423 424 425 426 427
Fri Mar 12 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkarrow.c (gtk_arrow_expose): Swap GTK_ARROW_LEFT
	and GTK_ARROW_RIGHT for GTK_TEXT_DIR_LTR. (#129159,
	Semion Chichelnitsky)

	* gtk/gtkpathbar.c gtk/gtktoolbar.c: Remove no-longer-needed 
	gtk_toolbar_direction-changed handlers and explicit
	flipping of GtkArrow widgets.

428 429 430 431 432 433
Fri Mar 12 23:37:15 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtkfilechooserdialog.c
	(file_chooser_widget_default_realized_size_changed): Clamp the
	new size to the screen.

434 435 436 437 438 439
Fri Mar 12 15:06:44 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkexpander.c (gtk_expander_realize): Create the
	event_window at the right size using the same logic as
	in size_allocate. (#136994, Niklas Knuttson)

440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459
2004-03-12  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkwindow.c (gtk_window_activate_focus): Don't ignore the
	return value of gtk_widget_activate().
	(gtk_window_activate_default): Likewise.  Fixes #137008.

	* gtk/gtkfilechooserdialog.c (response_cb): Act on positive
	response IDs we recognize, rather than bailing out on cancellation
	ones.  Fixes #136237; patch by Olivier Andrieu
	<oliv__a@users.sourceforge.net>.
	(file_chooser_widget_file_activated): If the dialog doesn't have a
	default widget, try to find a suitable response widget on our own.
	People should *really* be using gtk_dialog_set_default_response(),
	but this is to help lazy programmers.

	* gtk/gtkdialog.c (_gtk_dialog_get_response_for_widget): New
	internal function.
	(get_response_data): Add a "create" argument so that we don't
	unconditionally create the response data.

Morten Welinder's avatar
Morten Welinder committed
460 461 462 463
2004-03-12  Morten Welinder  <terra@gnome.org>

	* tests/Makefile.am: Add new testspinbutton.c

464 465 466 467 468 469 470
2004-03-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
	Put the trash icon on the right for LTR locales, or on the left
	for RTL.
	(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
	(shortcuts_drag_leave_cb): Test whether the idle is present.
471
	(shortcuts_drag_data_received_cb): Ahem, don't assert here.
472

473 474 475 476 477 478
Thu Mar 11 17:51:10 2004  Owen Taylor  <otaylor@redhat.com>

	* modules/input/gtkimcontextxim.c (preedit_done_callback):
	Clear preedit string and emit preedit_changed as needed
	on AIX. (#130617, Philip K Warren)

Morten Welinder's avatar
Morten Welinder committed
479 480 481 482
2004-03-11  Morten Welinder  <terra@gnome.org>

	* gtk/gtkpathbar.c (_gtk_path_bar_set_file_system): Plug leak.

483 484 485 486 487
Thu Mar 11 16:28:15 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkmenu.c (gtk_menu_get_toplevel): Fix attach/attach->parent
	type. (#136919, Tim Mooney)

488 489 490 491 492 493 494 495 496
Thu Mar 11 16:18:51 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_insert_path): revert
	earlier change to insert_path so that we test that the directory
	exists.

	* gtk/gtkfilechooserdialog.c
	(gtk_file_chooser_dialog_constructor): move focus.

497 498 499 500 501 502
Thu Mar 11 22:12:14 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkspinbutton.c (gtk_spin_button_size_request): Use the same
	logic as GtkEntry when calculating border width.  (#116368, reported
	by Morten Welinder)

503 504 505 506 507
Thu Mar 11 15:59:05 2004  Owen Taylor  <otaylor@redhat.com>

	* tests/testgtk.c (create_spins): Use gtk_entry_set_width_chars()
	rather than gtk_widget_set_size_request().

508 509 510 511 512 513 514 515 516 517
2004-03-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (remove_settings_signal): New
	function, copied from gtkpathbar.c.
	(gtk_file_chooser_default_dispose): Use remove_settings_signal()
	rather than our own code.
	(gtk_file_chooser_default_screen_changed): Use
	remove_settings_signal(); this should handle per-screen settings
	correctly.

Owen Taylor's avatar
Owen Taylor committed
518 519 520 521 522
Thu Mar 11 14:07:18 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtklabel.c (gtk_label_focus): Fix a missing return
	value.

523 524 525 526 527 528 529 530 531
Thu Mar 11 13:58:24 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkmessagedialog.c gtk/gtklabel.c: Back out the
	put-labels-into-the-standard-focus-chain patches 
	from bug #59707.

	* gtk/gtklabel.c (gtk_label_focus): Only put the
	label in the tab chain when the control key is pressed.

532 533 534 535 536 537 538
2004-03-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (error_message_with_parent): Use a
	single OK button, not a Close button, as per the HIG.

	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Likewise.

539 540 541 542 543
2004-03-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_drag_motion_cb): Oops,
	initialize "action" before jumping.  Fixes #136900.

544 545 546 547 548
2004-03-11  Mark McLoughlin  <mark@skynet.ie>

	* gtk/gtksettings.c: (apply_queued_setting): don't overwrite
	application properties. Fixes bug #136802.

549 550 551 552 553 554 555
2004-03-11  Dov Grobgeld  <dov@imagic.weizmann.ac.il>

	* gtk/gtktextlayer.c: (gtk_text_layout_set_buffer): Added
	call to gtk_text_layout_update_cursor_line() to solve in 
	problem of switching keyboard direction at widget creation:
	bug #136680

556 557 558 559 560
Thu Mar 11 10:28:30 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilechooserembed.c (delegate_initial_focus): Remove
	stray 'return' statement. (#136855, David L. Cooper II)

561 562 563 564 565 566
2004-03-11  Mark McLoughlin  <mark@skynet.ie>

	* gtk/gtkstyle.c: (gtk_default_draw_expander): Use the PRELIGHT
	fg color for drawing the expander when prelit. Fixes problem
	with the HighContrast theme: bug #136789.

567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
2004-03-11  Federico Mena Quintero  <federico@ximian.com>

	Fix #135912 and #135913.

	* gtk/gtkfilechooserdefault.c
	(shortcuts_filter_model_row_draggable): Implement.
	(shortcuts_model_filter_new): New function, create a
	ShortcutsModelFilterClass derived from GtkTreeModelFilter, so that
	we can implement our own DnD interface methods.
	(shortcuts_model_create): Use shortcuts_model_filter_new().
	(shortcuts_list_create): Enable the shortcuts list as a drag
	source.
	(file_list_source_targets): Renamed from shortcuts_targets.
	(shortcuts_list_create): Change the options for
	gtk_drag_dest_set().  Connect to more drag signals so that we can
	implement drops by hand.
	(shortcuts_drag_data_delete_cb): New handler; just stop the emission.
	(shortcuts_drag_motion_cb): New handler; validate the drop.
	(shortcuts_drag_leave_cb): New handler; unset the drag_dest_row.
	(shortcuts_drag_drop_cb): New handler; just stop the emission and
	remove the idle handler for the drag cursor.
	(shortcuts_add_bookmark_from_path): Add a position argument,
	return a boolean success code.
	(shortcuts_drag_data_received_cb): Handle two cases:  1) Insert
	the bookmarks at the proper position, rather than always appending
	them to the list; 2) alternatively, reorder the bookmarks.
	(struct _GtkFileChooserDefault): New field shortcuts_drag_outside.
	(shortcuts_drag_motion_cb): Turn off impl->shortcuts_drag_outside.
	(shortcuts_drag_leave_cb): Turn on impl->shortcuts_drag_outside in
	an idle handler.
	(shortcuts_drag_end_cb): New handler; remove the selected bookmark.

599 600 601 602 603 604 605 606 607
Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (location_entry_create): up the
	width of the entry a tad.

	* gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
	gtk_entry_completion_selection_changed.  Also, unref the
	completion as we were leaking a reference to it.

608 609 610 611 612
2004-03-10  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to
	Kjartan Maraas for pointing it out.

613 614
Wed Mar 10 23:40:15 2004  Matthias Clasen  <maclas@gmx.de>

615 616 617 618
	* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Set the
	background on the action view cell renderer here, not in init, so 
	that a) we catch style changes, and b) we get the real style, not 
	the default one. Partial fix for #127648, reported by Dave Bordoley.
619

620 621 622 623 624 625 626 627 628 629 630 631
2004-03-10  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkevents-win32.c (build_key_event_state): Set also
	the pointer button bits. (#136636, Dave Neary)

	* gdk/win32/gdkwindow-win32.c (show_window_internal): Show
	transparent (input only) windows using SetWindowPos(). (#132331,
	John Ehresman)

	(gdk_window_set_type_hint): For splash screens, remove the resize
	handles, menu, and minimize/maximize/close buttons. (#132896)

632 633 634 635 636 637
Wed Mar 10 22:30:23 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Keep the
	cell_list in a consistent state while iterating over it, since
	clear_attributes() also iterates over it.  (#136585, Morten Welinder)

638 639 640 641 642 643 644
2004-03-10  Mark McLoughlin  <mark@skynet.ie>

	* gtk/gtkexpander.c: (gtk_expander_expose): don't propagate
	the expose to the label. The expose handler for GtkContainer
	already does that. Fixes bug #136719. Reported by Dennis
	Cranston, exact cause nailed down by Owen.

645 646 647 648 649 650
2004-03-10  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Use an
	untranslatable "%x" for dates, rather than a custom format.  Fixes
	#136357.

Morten Welinder's avatar
Morten Welinder committed
651 652
2004-03-10  Morten Welinder  <terra@gnome.org>

653 654 655 656 657 658
	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_add_shortcut_folder): Test validity of
	path here.
	(shortcuts_insert_path): Don't check here.
	(get_file_info): Barf if name-only fails.

Morten Welinder's avatar
Morten Welinder committed
659 660
	* tests/testfilechooser.c (main): Add support for --multiple.

661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
Wed Mar 10 02:41:05 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkpathbar.c: (gtk_path_bar_init), (gtk_path_bar_class_init),
	(remove_settings_signal), (gtk_path_bar_dispose),
	(gtk_path_bar_style_set), (gtk_path_bar_screen_changed),
	(gtk_path_bar_scroll_up), (reload_icons), (change_icon_theme),
	(settings_notify_cb), (gtk_path_bar_check_icon_theme),
	(get_button_image), (gtk_path_bar_update_button_appearance),
	(make_directory_button), (gtk_path_bar_check_parent_path): Support
	changes in icon themes.

	* gtk/gtkpathbar.h: add two elements

	* tests/testfilechooser.c: (main): use gnome-vfs method again to
	get more testing.

677 678 679 680 681
Wed Mar 10 01:17:40 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkpathbar.c: added 'Desktop' to the list of volumes.  We
	don't have any more untranlated strings in the dialog.

682 683 684 685 686
Wed Mar 10 00:24:24 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (error_dialog): use uri instead of
	the pathname for UTF-8 safety.

687 688 689 690 691 692
Wed Mar 10 00:10:47 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Always
	check to see if the shortcuts exists.  We don't want to put
	invalid dirs in the shortcuts pane.

693 694 695 696 697
Tue Mar  9 16:40:34 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
	remove unneeded shortuts_swin;

Matthias Clasen's avatar
Matthias Clasen committed
698 699 700 701 702 703 704 705 706 707 708
Wed Mar 10 01:49:27 2004  Matthias Clasen  <maclas@gmx.de>

	Fix #136614 in a better way:
	
	* gtk/gtkoptionmenu.c (gtk_option_menu_init): Undo the last change.
	* gtk/gtkbutton.c (struct _GtkButtonPrivate): Add a flag, align_set.
	* gtk/gtkbutton.c (gtk_button_init): Initialize align_set to 0.
	* gtk/gtkbutton.c (maybe_set_alignment): Rework to only set the
	alignment if priv->align_set is set.
	* gtk/gtkbutton.c (gtk_button_set_alignment): Set align_set to 1.

709 710 711 712 713
Wed Mar 10 01:21:05 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Place
	grid mode popups left aligned, not right aligned.

714 715 716 717 718 719
Tue Mar  9 23:09:46 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkoptionmenu.c (gtk_option_menu_init): Avoid centering 
	the label that is reparented from the menuitem.  (#136614, Dennis
	Cranston)

720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738
Tue Mar  9 16:19:09 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkpathbar.c (struct _ButtonData): Encapsulate all of the
	information about a button in a struct instead of ugly
	g_object_set_data.
	(gtk_path_bar_size_request): Use ButtonData.
	(gtk_path_bar_update_slider_buttons): ditto
	(gtk_path_bar_size_allocate): ditto
	(gtk_path_bar_remove): ditto
	(gtk_path_bar_forall): ditto
	(gtk_path_bar_scroll_down): ditto
	(gtk_path_bar_clear_buttons): ditto
	(button_clicked_cb): ditto.  Also, add an ignore_changes variable
	(button_data_free): destroy ButtonData
	(update_button_appearance): Use ButtonData
	(make_directory_button): ditto
	(gtk_path_bar_check_parent_path): ditto
	(_gtk_path_bar_set_path): ditto

Federico Mena Quintero's avatar
Federico Mena Quintero committed
739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756
2004-03-09  Federico Mena Quintero  <federico@ximian.com>

	Fix #136533.

	* gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): New
	function.
	(check_icon_theme): New helper function, installs a handler for
	changes in the icon theme.
	(gtk_file_chooser_default_style_set): Use check_icon_theme().
	(gtk_file_chooser_default_screen_changed): Use check_icon_theme().
	(gtk_file_chooser_default_dispose): Disconnect from GtkSettings.
	(change_icon_theme): New function, updates impl->icon_size and
	reloads the icons.
	(struct _GtkFileChooserDefault): New field settings_signal_id.
	(struct _GtkFileChooserDefault): New field icon_size.
	(shortcuts_insert_path): Use impl->icon_size.
	(list_icon_data_func): Likewise.

757 758 759 760 761
2004-03-09  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (get_file_info): Handle the returned
	parent_path being NULL.  Fixes #136662.

762 763 764 765 766 767
2004-03-09  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_drag_data_received_cb):
	Stop the emission so that GtkTreeView's handler won't try to poke
	the filter model.  Fixes #136127.

768 769 770 771 772 773
Tue Mar  9 13:49:14 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkstyle.c (gtk_paint_polygon): Fix 
	g_return_if_fail() that was checking draw_shadow.
	(#136669, Morten Welinder)

Owen Taylor's avatar
Owen Taylor committed
774 775 776 777 778 779 780 781
Tue Mar  9 09:57:25 2004  Owen Taylor  <otaylor@redhat.com>

	* === Released 2.3.6 ===

	* configure.in: Version 2.3.6, interface age 0.

	* NEWS: Updates

Jonathan Blandford's avatar
Jonathan Blandford committed
782 783
Tue Mar  9 11:01:45 2004  Jonathan Blandford  <jrb@gnome.org>

Jonathan Blandford's avatar
credit  
Jonathan Blandford committed
784
	* gtk/gtkpathbar.c (gtk_path_bar_finalize): unref the correct
Owen Taylor's avatar
Owen Taylor committed
785
	icon.  Reported by Michael Natterer <mitch@gimp.org>.
Jonathan Blandford's avatar
Jonathan Blandford committed
786

787 788 789 790
2004-03-09  Morten Welinder  <terra@gnome.org>

	* tests/testfilechooser.c (main): Destroy widgets to reveal leaks.

791 792
Tue Mar  9 02:11:50 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

Owen Taylor's avatar
Owen Taylor committed
793
	* gtk/gtkmenu.c Fix bug 136446. [Marco Pesenti Gritti]
794 795 796 797 798 799 800 801 802
	(struct _GtkMenuPrivate): Add boolean destroying
	(gtk_menu_destroy): Set priv->destroying
	(gtk_menu_remove): don't update the table information when the
	menu is being destroyed.

	* gtk/gtkmenu.c (gtk_menu_set_monitor): Formatting fix

	* gtk/gtktoolbar.[ch]: Some formatting fixes

Matthias Clasen's avatar
Matthias Clasen committed
803 804 805 806
Tue Mar  9 01:25:10 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkframe.c (gtk_frame_paint): Fix a typo.

Federico Mena Quintero's avatar
Federico Mena Quintero committed
807 808 809 810 811 812 813 814
2004-03-08  Federico Mena Quintero  <federico@ximian.com>

	Fixes #136080.

	* gtk/gtkfilesystemunix.c: Only lstat() if stat() failed due to
	ENOENT.
	(filename_get_info): Likewise.

815 816 817 818 819 820
2004-03-08  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_initial_focus): Use
	gtk_tree_view_set_cursor().

821 822 823 824 825 826 827 828 829 830 831 832
2004-03-08  Federico Mena Quintero  <federico@ximian.com>

	Patch "1a" from #136185, by Morten Welinder.

	* gtk/gtkfilechooserdefault.c (get_file_info): Take in an argument
	that says whether the caller just wants the display name.
	(shortcuts_insert_path): We only want the name in the call to
	get_file_info().

	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Don't request more
	info than needed from the file_folder.

Federico Mena Quintero's avatar
Federico Mena Quintero committed
833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853
2004-03-08  Federico Mena Quintero  <federico@ximian.com>

	Fixes #136105.

	* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
	Added an ::initial_focus() method.

	* gtk/gtkfilechooserembed.c
	(_gtk_file_chooser_embed_delegate_iface_init): Set the
	initial_focus method.
	(delegate_initial_focus): Implement.
	(_gtk_file_chooser_embed_initial_focus): New function.

	* gtk/gtkfilechooserdialog.c
	(gtk_file_chooser_dialog_constructor): Call
	_gtk_file_chooser_embed_initial_focus().

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
	Install the ::initial_focus() handler.
	(gtk_file_chooser_default_initial_focus): Implement.

854 855 856 857 858 859 860 861 862 863 864 865 866 867 868
2004-03-08  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (update_from_entry): Return a
	boolean success code.
	(location_popup_handler): Refocus the file chooser if appropriate.
	Fixes #135905.
	(save_widgets_create): Don't set the text of the save_folder_label
	here.
	(update_appearance): Set the text here as appropriate for the save
	mode.  Also fixes #136387.
	(update_appearance): Don't show the Create Folder button in
	SELECT_FOLDER mode.
	(update_appearance): Show the extra widget in all Save modes
	correctly.

869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898
Mon Mar  8 11:57:27 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't
	call g_signal_handler_disonnect() if priv->model is
	NULL. (#136551, Damon Chaplin)

	* gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
	Back out code to set the active item when the first
	item is added to the model; this causes problems for
	GtkComboBoxText. (#136535)

	* gtk/gtkcombobox.c (gtk_combo_box_menu_destroy)
	* gtk/gtkcombobox.c (gtk_combo_box_list_destroy):
	* gtk/gtkcombobox.c (gtk_combo_box_list_setup): 
	* gtk/gtkcombobox.c (gtk_combo_box_menu_setup): 
	Remove calls to gtk_combo_box_unset_model.

	* gtk/gtkcombobox.c (gtk_combo_box_check_appearance): 
	Clean up handling of wrap->width > 0.

	* gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't
	switch list/menu mode here.

	* gtk/gtkcombobox.c (gtk_combo_box_set_model): Protect
	against the same model being set back.

	* gtk/gtkcombobox.c (gtk_combo_box_relayout): Call
	gtk_combo_box_menu_fill() rather than duplicating
	a large chunk of code.

899 900 901 902 903
2004-03-08  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkfilesystemmodel.c (gtk_file_system_model_get_flags): 
	If max_depth is 0 then we have a list.

Morten Welinder's avatar
Morten Welinder committed
904 905
2004-03-08  Morten Welinder  <terra@gnome.org>

906 907 908
	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): If we fail, leave
	widget unchanged.  Explicitly verify final directory.

Morten Welinder's avatar
Morten Welinder committed
909 910 911
	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder,
	get_icon_type, filename_get_info): Protect errno.

912 913 914 915 916 917 918
2004-03-08  Marco Pesenti Gritti  <marco@gnome.org>

	* gtk/gtkentry.c: (gtk_entry_completion_key_press):

	When an action is selected stop the event to be propagated
	otherwise the activate signal is emitted too. (Bug #133394)

919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938
Mon Mar  8 04:50:12 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (create_path_bar): new function to
	consolidate creating the path_bar.
	(gtk_file_chooser_default_set_current_folder): no longer need to
	pass in the filesystem.

	* gtk/gtkpathbar.h: Removed unused set_pixbuf functions in favor
	of just setting the filesystem.

	* gtk/gtkpathbar.c (gtk_path_bar_finalize): Free root path and
	home_dir.
	(get_button_image): Add images to path_bar.
	(update_button_appearance): use images
	(make_directory_button): Clasify buttons based upon location.
	(_gtk_path_bar_set_path): no longer need a file-system.  Also, add
	rerooting, #135845, #135914

	* tests/testfilechooser.c: Fix reused error handling.

939 940 941 942 943 944
2004-03-08  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkfilesystemunix.c: (get_icon_for_directory),
	(gtk_file_system_unix_render_icon):
	Use better icons for home and desktop.

945 946 947 948 949 950
2004-03-08  Anders Carlsson  <andersca@gnome.org>

	* gtk/gtkfilechooserentry.c:
	(_gtk_file_chooser_entry_set_base_folder):
	Set the base folder path in the entry.
	
951 952 953 954
2004-03-08  Christian Neumair  <chris@gnome-de.org>

	* tests/testentrycompletion.c: Fix typo.

Tor Lillqvist's avatar
Update.  
Tor Lillqvist committed
955 956 957 958 959 960
2004-03-08  Tor Lillqvist  <tml@iki.fi>

	* README.win32: Update.

	* gtk/gtk.def: Small update. Thanks to J. Ali Harlow. Re-sorted.

961 962 963
	* tests/testfilechooser.c: Correct localtime_r() emulation on
	Win32. Remove a couple of unnecessary Win32-only includes.

964 965 966 967 968 969 970 971 972
Mon Mar  8 01:06:17 2004  Matthias Clasen  <maclas@gmx.de>

	* tests/testentrycompletion.c: Test dynamic addition/removal. 

Sun Mar  7 22:38:49 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkframe.c (gtk_frame_paint): Use ythickness, not 
	xthickness in the calculation of vertical dimensions.

973 974 975 976 977 978 979 980 981 982 983 984 985 986
Sun Mar  7 17:38:03 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkbutton.c (gtk_button_class_init): actually use
	gtk_button_add.

	* gtk/gtkfilechooserdefault.c (error_building_filename_dialog):
	use the uri, not the path, #136317
	(renderer_edited_cb): ditto
	(shortcuts_add_bookmark_from_path): ditto
	(remove_bookmark_button_clicked_cb): ditto
	(gtk_file_chooser_default_remove_shortcut): ditto
	(update_from_entry): ditto
	(up_folder_handler): ditto

987 988 989 990 991 992 993 994 995
Sun Mar  7 16:07:08 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): set
	redraw_on_allocate, #135902.

	* gtk/gtkfilesystemmodel.c (model_refilter_recurse): Patch from
	Damon Chaplin to set a node to be visible before emitting the
	inserted signal, #135555.

996 997 998 999 1000
Sun Mar  7 22:24:28 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkbutton.c (_gtk_button_paint): Don't use xthickness in the
	height calculation.

1001 1002
Sun Mar  7 14:34:04 2004  Jonathan Blandford  <jrb@gnome.org>

1003 1004
	Fixes #121500.

1005 1006 1007
	* gtk/gtkfilechooserdefault.c (trap_activate_cb): stop activate
	from unselecting rows when pressed in multiple-selection mode.

1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021
2004-03-07  Hans Breuer  <hans@breuer.org>

	* gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting) :
	some more settings from system, also reflect some name changes
	done a while ago in the x11 backend

	* gdk/win32/makefile.msc : build gdkspawn-win32.c

	* gtk/gtkdnd.c : gtk_drag_source_[gs]et_target_list, added "Since: 2.4"

	* gtk/makefile.msc.in : build gtkpathbar, link shell32.lib

	* tests/makefile.msc : some more tests get build

1022 1023 1024 1025 1026 1027 1028 1029 1030
Sun Mar  7 03:03:57 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_get_paths): if action is
	SELECT_FOLDER, then return the currentd folder if none is
	selected.
	(gtk_file_chooser_default_should_respond): Allow 'Ok' to be hit if
	no directory is selected in SELECT_FOLDER mode.

1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
Sat Mar  6 23:31:18 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
	remove unneeded elements.
	(tree_selection_changed): removed
	(tree_name_data_func): removed
	(gtk_file_chooser_default_finalize): don't unref dir model
	(create_folder_tree): removed
	(get_selection): no longer need to abstract away the selection
	function.
	(create_file_list): We now create a tree for all actions.
	(file_pane_create): Make one tree.
	(update_appearance) We really change the mode only, now.

1045 1046 1047 1048 1049 1050 1051
Sun Mar  7 02:38:00 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_size_request): Do a 
	size_request on the button and cell_view_frame, otherwise
	their style will still be the default here in the initial 
	size_request. (#136301, Mark McLoughlin)

1052 1053 1054 1055 1056 1057
2004-03-06  Gustavo J. A. M. Carneiro  <gustavo@users.sourceforge.net>

	* gtk/gtktoolbar.c (internal_insert_element): Check return value
	of gtk_stock_lookup; if stock lookup fails, just use stock_id as
	label, instead of crashing. Fixes #136202.

1058 1059 1060 1061 1062 1063 1064
2004-03-05  Federico Mena Quintero  <federico@ximian.com>

	* gdk/linux-fb/gdkglobals-fb.c: Make <config.h> the very first
	include.
	* gdk/linux-fb/gdkwindow-fb.c: Likewise.
	* gdk/linux-fb/gdkinput.c: Likewise.

1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
2004-03-05  Federico Mena Quintero  <federico@ximian.com>

	Fixes #136082 and #135265, patch by Morten Welinder.

	* configure.in: Use AC_SYS_LARGEFILE.

	* */*.c: #include <config.h>

2004-03-05  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_select_path): No need to have a
	temporary error variable.

1079 1080
2004-03-05  Tor Lillqvist  <tml@iki.fi>

1081 1082 1083 1084
	* configure.in: Move check for native Win32 (mingw) a bit
	earlier. If Win32, disable static builds (as in GLib). Remove
	unnecessary AC_LIBTOOL_WIN32_DLL.

1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
	* gdk/gdk.def: Add missing entries, thanks to J. Ali Harlow.

	* gdk/win32/gdkcursor-win32.c (color_is_white): const-correctness.

	(gdk_cursor_new_from_pixbuf): Copy of the non-Xcursor X11
	implementation.

	(gdk_display_supports_cursor_alpha,
	gdk_display_supports_cursor_color): Dummy implementations.

	(gdk_display_get_default_cursor_size,
	gdk_display_get_maximal_cursor_size): Implement.

	* gdk/win32/gdkdisplay-win32.c (gdk_display_get_default_group):
	Dummy implementation.

	* gdk/win32/gdkevents-win32.c (gdk_net_wm_supports): Dummy
	implementation.

	* gdk/win32/gdkfont-win32.c (gdk_font_get_display): Implement.

	* gdk/win32/gdkinput-win32.c (gdk_input_motion_events): Remove,
	not in API.

	* gdk/win32/gdkwindow-win32.c (gdk_window_get_group): Dummy
	implementation.

Jonathan Blandford's avatar
Jonathan Blandford committed
1112 1113 1114 1115 1116 1117 1118 1119
Fri Mar  5 18:00:36 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkfilechooserdefault.c (new_folder_button_clicked): scroll
	to the new path.

	* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update the
	allocation when scrolling instead of cancelling editing.

Matthias Clasen's avatar
Matthias Clasen committed
1120 1121 1122 1123 1124
Fri Mar  5 23:52:34 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_set_modify_func): 
	Improve the docs.  (#127727, Murray Cumming)

1125 1126 1127 1128 1129
Fri Mar  5 23:37:16 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreeview.c (gtk_tree_view_set_reorderable): Clarify the
	doc comment.  (#118602)

1130 1131 1132 1133 1134
Fri Mar  5 22:37:15 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkbutton.c (gtk_button_construct_child): Don't let
	the priv->image pointer dangle.  (#136259, Padraig O'Briain)

1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157
2004-03-05  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserprivate.h (struct _GtkFileChooserIface): Add
	gboolean return values and GError arguments to
	::set_current_folder() and ::select_path().

	* gtk/gtkfilechooser.c (gtk_file_chooser_set_current_folder):
	Return a boolean value for success/failure.
	(gtk_file_chooser_set_current_folder_uri): Likewise.
	(gtk_file_chooser_select_filename): Likewise.
	(gtk_file_chooser_select_uri): Likewise.
	(gtk_file_chooser_set_filename): Likewise.
	(gtk_file_chooser_set_uri): Likewise.
	(_gtk_file_chooser_set_current_folder_path): Likewise, plus take
	in a GError.
	(_gtk_file_chooser_select_path): Likewise.

	* gtk/gtkfilechooserutils.c (delegate_set_current_folder):
	Likewise.
	(delegate_select_path): Likewise.

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_select_path): Likewise.
1158 1159
	(gtk_file_chooser_default_set_current_folder): Likewise; this also
	fixes #136024.
1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
	(error_changing_folder_dialog): New helper function.
	(change_folder_and_display_error): New helper function.
	(switch_to_selected_folder): Use change_folder_and_display_error().
	(tree_selection_changed): Likewise.
	(shortcuts_activate_volume): Likewise.
	(shortcuts_activate_item): Likewise.
	(list_row_activated): Likewise.
	(path_bar_clicked): Likewise.
	(update_from_entry): Likewise.
	(up_folder_handler): Likewise.
	(home_folder_handler): Get the home path from the shortcuts model,
	and use change_folder_and_display_error().

	* tests/testfilechooser.c (set_current_folder): New helper
	function; pops up a simple error dialog if necessary.
	(set_filename): Likewise.
	(set_folder_nonexistent_cb): Use set_current_folder().
	(set_folder_existing_nonexistent_cb): Likewise.
	(set_filename_nonexistent_cb): Use set_filename().
	(set_filename_existing_nonexistent_cb): Likewise.

1181 1182 1183 1184 1185 1186 1187 1188
Fri Mar  5 11:17:35 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktreemodel.c (gtk_tree_row_reference_new_proxy): 
	Improve the docs (reported by Vitaly Tishkov, 
	#74362) Add some comments to the code about the 
	row reference handling that are hopefully not entirely
	wrong.

1189 1190 1191 1192 1193
2004-03-05  Michael Natterer  <mitch@gimp.org>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
	s/object/widget/. Makes it compile again.

1194 1195 1196 1197 1198
Fri Mar  5 03:37:14 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
	chain to the extra_widget.

1199 1200 1201 1202 1203 1204
Fri Mar  5 02:53:41 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
	Patch from Damon Chaplin to free models when we're finalized,
	#134053

1205 1206 1207 1208 1209 1210 1211 1212 1213
2004-03-05  Alexander Larsson  <alexl@redhat.com>

	* gtk/gtkfilesystem.c (gtk_file_system_get_volume_for_path):
	Document the fact that there might not be a volume for all
	paths.

	* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
	Don't assume there is a volume for all paths.

1214 1215 1216 1217 1218 1219 1220 1221
Fri Mar  5 01:45:04 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (shortcuts_append_paths): insert in
	the correct place instead of naïvely appending.
	(shortcuts_add_volumes): refilter the model
	(shortcuts_add_bookmarks): refilter the model
	(gtk_file_chooser_default_add_shortcut_folder): refilter the model

1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254
2004-03-04  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdialog.c (response_cb):  New handler.  Ask the
	GtkFileChooser widget if it wants to do something special rather
	than letting us terminate the dialog.
	(gtk_file_chooser_dialog_init): Connect to "response"; see the
	comment in the sources to see why we don't override the method in
	class_init.

	* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
	Added a ::should_respond() method.

	* gtk/gtkfilechooserembed.c
	(_gtk_file_chooser_embed_delegate_iface_init): Add a delegate for ::should_respond().
	(delegate_should_respond): New delegate.
	(_gtk_file_chooser_embed_should_respond): New function.

	* gtk/gtkfilechooserdefault.c (set_list_model, create_file_list):
	Use dashes in signal names rather than underscores.
	(gtk_file_chooser_default_init): Hook up our ::should_respond() implementation.
	(gtk_file_chooser_default_should_respond): Implement.  go into a
	folder rather than responding if we are in File mode and the
	selected file is a folder.
	(get_selection): New helper function.
	(add_bookmark_button_clicked_cb): Use get_selection().
	(bookmarks_check_add_sensitivity): Likewise.
	(gtk_file_chooser_default_get_paths): Likewise.
	(check_save_entry): New helper function.
	(gtk_file_chooser_default_get_paths): Use check_save_entry().
	(selection_check): Renamed from selection_is_folders().  Now
	checks whether the selection is empty, all files, all folders.
	(bookmarks_check_add_sensitivity): Use selection_check().

1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268
Fri Mar  5 00:05:59 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_list_setup): 
	* gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Connect to 
	key_press_event and handle Alt-Down/Alt-Up to show or hide the
	list popup. Also handle Down/Up/PageDown/PageUp/Home/End and 
	make them change the active item without popping up the list.
	These keybindings are inherited from GtkCombo. 

Thu Mar  4 23:15:58 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Initially 
	select the active item when using optionmenu-like positioning. 

1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283
Thu Mar  4 16:54:30 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Don't
	open/close the file, just check for existence
	with g_file_test(). This is considerably cheaper,
	and lack-of-permissions for pixmap dirs is 
	pathological.

Wed Mar  3 17:53:21 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtksocket.c (gtk_socket_class_init): Overide
	show_all/hide_all to be gtk_widget_show/gtk_widget_hide,
	since we don't want to propagate to the in-process
	plug, if any. (#122949, Michael Meeks)

1284 1285 1286 1287 1288
Thu Mar  4 15:20:55 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (update_appearance): show the 'New
	Folder' button in SAVE mode again.

1289 1290 1291 1292 1293 1294
Thu Mar  4 21:53:46 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkiconfactory.c (copy_cache): Increment the reference
	count of the style when copying the cached icon.  (#135890, Crispin
	Flowerday)

1295 1296 1297 1298 1299 1300
Thu Mar  4 21:45:43 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c: In list mode, set the background color 
	of the cell view to the base color of the style, instead of
	hardwiring white. (#136158)

1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
Thu Mar  4 01:32:19 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkpathbar.c (gtk_path_bar_set_path): Modified patch from
	muppet <scott@asofyet.org> to keep child directories around if we
	change to a child.

	* gtk/gtkpathbar.c (_gtk_path_bar_set_home_icon): Start of
	icon-setting functions.  Not used yet.
	(_gtk_path_bar_set_root_icon): Ditto.
	
1311 1312 1313 1314 1315 1316
Thu Mar  4 00:31:54 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktextview.c (extend_selection): 
	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): Allow
	to select the last word in the buffer.  (#135487, Paolo Borelli)

Matthias Clasen's avatar
Matthias Clasen committed
1317 1318 1319 1320
Wed Mar  3 23:54:31 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkentrycompletion.c: Doc update.

1321 1322 1323 1324 1325 1326
Wed Mar  3 17:30:18 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkwindow.c (gtk_window_mnemonic_activate): Check
	whether widgets are viewable, not just if they are
	mapped. (#122912, reported by Tim Evans)

1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345
Wed Mar  3 23:28:48 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_set_active): Move the actual
	implementation into a new gtk_combo_box_set_active_internal() 
	function, which doesn't do the short-circuiting. 
	* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted): Use
	set_active_internal() here, since the active item may change here,
	although the index is unchanged.

Wed Mar  3 23:26:49 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Reintroduce the
	traditional option menu placement of the popup for regular combo
	boxes. Grids and editable combo boxes use the combo-like placement 
	below the entry.  (#136021)
	* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): 
	* gtk/gtkcombobox.c (gtk_combo_box_popup): Call gtk_menu_set_active()
	before popping up the menu, to make the placement work.
	
1346 1347 1348 1349 1350 1351 1352
Wed Mar  3 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkmain.c (gtk_propagate_event): Special case
	scroll events so that they propagate up the widget
	heirarchy when received on insensitive widgets.
	(#101102, reported by Geoff Reedy)

1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363
Wed Mar  3 16:47:10 2004  Owen Taylor  <otaylor@redhat.com>

	 #109594, reported by Olivier Ripoll

	* gtk/gtkentry.c (gtk_entry_size_request): Use max of 
	width and digit width for gtk_entry_set_width_chars,
	and round up.

	* gtk/gtkcolorsel.c (gtk_color_selection_init): Set the
	width of the entry to 7 chars.

1364 1365 1366 1367 1368
Wed Mar  3 16:00:10 2004  Owen Taylor  <otaylor@redhat.com>

	* configure.in: Strip out the "export-dynamic" libtool
	option from library link lines. (#124687, James Henstridge)

1369 1370 1371 1372 1373 1374
Wed Mar  3 16:06:03 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdefault.c (save_folder_combo_changed_cb):
	Don't activate the combo if we're in the midst of changing
	folders.

1375 1376 1377 1378 1379
2004-03-03  Mark McLoughlin  <mark@skynet.ie>

	* tests/testsocket_common.c: (print_hello): don't try and store
	pointers in ints. Fixes 64-bit build.

1380 1381 1382 1383 1384 1385
2004-03-03  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilesystem.c (gtk_file_system_get_parent): Simplify by
	not using a temporary variable, and clarify the documentation.
	Fixes #136008.

1386 1387 1388 1389 1390 1391 1392
2004-03-03  Mark McLoughlin  <mark@skynet.ie>

	* gtk/gtkexpander.c:
	(gtk_expander_enter_notify), (gtk_expander_leave_notify),
	(gtk_expander_set_label_widget): Set the label widget's
	state to prelight if we're prelit. Fixes bug #136078.

1393 1394 1395 1396 1397 1398
2004-03-03  Murray Cumming  <murrayc@murrayc.com>

	* gtk/gtkradiobutton.h, radiomenuitem.h: Corrected the group_changed
	signal vfunc declaration, adding the first parameter, which is the
	widget emitting the signal.

Morten Welinder's avatar
Morten Welinder committed
1399 1400 1401 1402
2004-03-03  Morten Welinder  <terra@gnome.org>

	* tests/testfilechooser.c (update_preview_cb): Plug leak.

1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415
Tue Mar  2 23:39:55 2004  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtkfilechooserdialog.c
	(file_chooser_widget_default_realized_size_changed): Split
	function into realized and unrealized variants, and consolidate
	the handling fo size-changing and default changing.

	* gtk/gtkfilechooserembed.[ch] (gtk_file_chooser_embed_class_init):
	remove resizable-hints-changed, as it just complicated things.

	* gtk/gtkfilechooserdefault.c (update_appearance): Don't emit
	resizable-hints-changed.
	
1416 1417 1418 1419 1420 1421
2004-03-03  Tor Lillqvist  <tml@iki.fi>

	* gtk/gtk.def: Add a missing entry. (#135982, J. Ali Harlow)

	* NEWS: Correct spelling of my name in one place.

1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
2004-03-02  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_set_current_folder): Handle errors in
	setting the path bar's path.  Fixes #136000, based on a patch by
	Morten Welinder.

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_insert_bookmark):
	Don't free our own propagated error.

	* gtk/gtkpathbar.c (gtk_path_bar_set_path): Likewise, and free the
	parent_path upon error.  Fixes #136006, patch by Morten Welinder.
	(gtk_path_bar_set_path): Unref the file_folder upon error.
	(gtk_path_bar_set_path): Return a boolean success code.

1437 1438 1439 1440 1441 1442
Wed Mar  3 00:28:59 2004  Matthias Clasen  <maclas@gmx.de>

	* tests/testcombochange.c: Add an animation mode, to test 
	how the combobox behaves if the model changes while it is popped
	up.

Owen Taylor's avatar
Owen Taylor committed
1443 1444 1445 1446 1447 1448 1449 1450 1451
Tue Mar  2 17:06:05 2004  Owen Taylor  <otaylor@redhat.com>

	* === Released 2.3.5 ===

	* NEWS: Updates

	* configure.in: Version 2.3.5, interface age 0.
	Require glib-2.3.5, pango-1.3.5.

1452 1453 1454 1455 1456 1457
Tue Mar  2 23:08:12 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Avoid
	popping up the completions across the edge of the monitor.
	Part of #135561.

1458 1459 1460 1461 1462 1463
Tue Mar  2 16:47:40 2004  Owen Taylor  <otaylor@redhat.com>

	* tests/testfilechooser.c (set_filename_existing_nonexistent_cb): 
	Move the /nonexistant stuff out of the main window,
	keep the main window somewhat normal looking.

1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479
Tue Mar  2 16:18:43 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktreestore.c (gtk_tree_store_reorder)
	* gtk/gtkliststore.c (gtk_list_store_reorder): Fix
	up the interpretation of new_order to match what
	it means elsewhere, document the meaning of new_order.

	* gtk/gtkcombobox.c (gtk_combo_box_model_rows_reordered):
	Fix interpretation of new_order.

	* tests/testcombochange.c (on_reorder): Fix interpretation
	of new_order.

	* tests/testcombochange.c (on_reorder): Fix hitting
	"reorder" with an empty list.

1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495
Tue Mar  2 21:23:30 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	Patch from Frederic Crozat, test code from Jean-Philippe
	Chancelier. Fixes bug #120479.
	
	* gtk/gtkcombo.c (gtk_combo_popup_list): Make sure popup belongs
	to the right window group.

	* gtk/gtkmenu.c (gtk_menu_popup): Same

	* tests/testsocket.c (main): Pack the plugs into an hbox instead
	of a vbox.

	* tests/testsocket_common.c: Add a GtkMenuBar, a GtkCombo and a
	GtkComboBox to the children.

1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510
Tue Mar  2 14:38:23 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
	If the model was empty before, select the first inserted
	item.

	* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted):
	Fix up the logic for the new row to select.

	* gtk/gtkcombobox.c (gtk_combo_box_class_init):
	Rename "appearance" property to "appears-as-list".

	* tests/testcombochange.c tests/Makefile.am: Test case
	for combos and dynamically changing models.

1511 1512 1513 1514 1515 1516
Tue Mar  2 15:19:52 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_get_resizable_hints): set the default
	value, spotted by Morten Welinder.

1517 1518 1519 1520 1521 1522 1523 1524
Tue Mar  2 15:03:15 2004  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_get_resizable_hints): get the logic
	correct.  This will fix sizing on save dialogs.

	(save_widgets_create): set_mnemonic_widget.

1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
2004-03-02  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_set_current_folder): Don't update the
	save folder combo if we are already switching folders; based on a
	patch by Jonathan Blandford.

	* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
	Handle failure to insert the path.  Based on a patch by Morten
	Welinder attached to bug #135380.

	* tests/testfilechooser.c (extra_widget_create): Add a bunch of
	buttons to test various things.

Matthias Clasen's avatar
Matthias Clasen committed
1539 1540 1541 1542 1543 1544 1545
Tue Mar  2 20:59:23 2004  Matthias Clasen  <maclas@gmx.de>

	* tests/Makefile.am: Add testentrycompletion.

	* tests/testentrycompletion.c: New file to test some of the
	more exotic GtkEntryCompletion features.

Jonathan Blandford's avatar
Jonathan Blandford committed
1546 1547 1548 1549
Tue Mar  2 14:38:10 2004  Jonathan Blandford  <jrb@redhat.com>

	* tests/testfilechooser.c (main): improve tests a little.

1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560
Tue Mar  2 11:45:50 2004  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkcombobox.c: Always connect to the changed
	signals on the model, update the active item as
	appropriate when rows are inserted/deleted/reordered,
	re-layout the menu on ::rows-reordered.

	* gtk/gtkcellview.c (gtk_cell_view_set_displayed_row):
	Allow %NULL for path to unset and leave no current
	path.

1561 1562 1563 1564 1565 1566 1567