1. 25 Sep, 2019 1 commit
  2. 22 Aug, 2019 2 commits
    • Tom Schoonjans's avatar
      build: implement some macOS specific fixes · 94377d87
      Tom Schoonjans authored
      * Add some CPPFLAGS
      * Ensure -Wl,--no-undefined is only used when supported, which is not
      the case on macOS
      * Add darwin_versions for correct versioning
      94377d87
    • Jan Tojnar's avatar
      examples: fix dependencies · 8588bc1c
      Jan Tojnar authored
      Without this, I am getting:
      
      ../examples/gvncviewer.c:34:10: fatal error: gio/gunixsocketaddress.h: No such file or directory
       #include <gio/gunixsocketaddress.h>
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
      8588bc1c
  3. 07 Aug, 2019 2 commits
  4. 06 Aug, 2019 5 commits
  5. 05 Aug, 2019 12 commits
  6. 03 May, 2019 6 commits
  7. 02 May, 2019 4 commits
  8. 12 Jan, 2019 8 commits
    • Ján Tomko's avatar
      configure: do not quote EXTRA_ARGS · f41c3340
      Ján Tomko authored
      Without this using ./autogen.sh --system results in a funny definition
      of SYSCONFDIR:
      Searching for certs in /usr --sysconfdir=/etc --localstatedir=/var --libdir=/usr/lib64/etc/pki
      Signed-off-by: default avatarJán Tomko <jtomko@redhat.com>
      f41c3340
    • Ján Tomko's avatar
      vnc_connection_start_tls: set tls_session to NULL after deinit · 7879ae9c
      Ján Tomko authored
      Avoid a double free in case of a failure, e.g. when vnc_connection_tls_initialize_cert_cred
      fails to read the certificate:
      
      ==1154== Invalid read of size 4
      ==1154==    at 0x60870FB: gnutls_bye (record.c:288)
      ==1154==    by 0x4A46B73: vnc_connection_close (vncconnection.c:5120)
      ==1154==    by 0x4A4E6CA: vnc_connection_coroutine (vncconnection.c:5650)
      ==1154==    by 0x4A51BCE: coroutine_trampoline (coroutine_ucontext.c:55)
      ==1154==    by 0x5BD81FF: ??? (in /usr/lib64/libc-2.28.so)
      ==1154==    by 0x175DB277: ???
      ==1154==  Address 0x1847fcf0 is 384 bytes inside a block of size 6,496 free'd
      ==1154==    at 0x4839A0C: free (vg_replace_malloc.c:540)
      ==1154==    by 0x4A4B019: vnc_connection_start_tls (vncconnection.c:4466)
      ==1154==    by 0x4A4CBE8: vnc_connection_perform_auth_vencrypt (vncconnection.c:4708)
      ==1154==    by 0x4A4CBE8: vnc_connection_perform_auth (vncconnection.c:4818)
      ==1154==    by 0x4A4CBE8: vnc_connection_initialize (vncconnection.c:5415)
      ==1154==    by 0x4A4E50F: vnc_connection_coroutine (vncconnection.c:5639)
      ==1154==    by 0x4A51BCE: coroutine_trampoline (coroutine_ucontext.c:55)
      ==1154==    by 0x5BD81FF: ??? (in /usr/lib64/libc-2.28.so)
      ==1154==    by 0x175DB277: ???
      ==1154==  Block was alloc'd at
      ==1154==    at 0x483AB1A: calloc (vg_replace_malloc.c:762)
      ==1154==    by 0x60B6FDE: gnutls_init (state.c:465)
      ==1154==    by 0x4A4AB28: vnc_connection_start_tls (vncconnection.c:4434)
      ==1154==    by 0x4A4CBE8: vnc_connection_perform_auth_vencrypt (vncconnection.c:4708)
      ==1154==    by 0x4A4CBE8: vnc_connection_perform_auth (vncconnection.c:4818)
      ==1154==    by 0x4A4CBE8: vnc_connection_initialize (vncconnection.c:5415)
      ==1154==    by 0x4A4E50F: vnc_connection_coroutine (vncconnection.c:5639)
      ==1154==    by 0x4A51BCE: coroutine_trampoline (coroutine_ucontext.c:55)
      ==1154==    by 0x5BD81FF: ??? (in /usr/lib64/libc-2.28.so)
      ==1154==    by 0x175DB277: ???
      Signed-off-by: default avatarJán Tomko <jtomko@redhat.com>
      7879ae9c
    • Ján Tomko's avatar
      vnc_connection_start_tls: add deinit label · e62d0107
      Ján Tomko authored
      Introduce a deinit label to unify cleanup paths which call gnutls_deinit.
      Signed-off-by: default avatarJán Tomko <jtomko@redhat.com>
      e62d0107
    • Christophe Fergeau's avatar
      conn: Use vnc_connection_has_error() extensively · ad6478a1
      Christophe Fergeau authored
      It's better to call this helper rather than directly checking for
      priv->coroutine_stop.
      Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
      ad6478a1
    • Christophe Fergeau's avatar
      conn: Remove redundant vnc_connection_has_error() calls · 247eaddd
      Christophe Fergeau authored
      No need to call it twice in:
      if (vnc_connection_has_error(conn))
          return !vnc_connection_has_error(conn);
      
      and no need to call it after calling vnc_connection_set_error() as it
      will always return TRUE in this scenario.
      Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
      247eaddd
    • Christophe Fergeau's avatar
      conn: Report error if vnc_connection_perform_auth_vnc fails · fa21beab
      Christophe Fergeau authored
      At the moment, when the various crypto operations that
      vnc_connection_perform_auth_vnc performs fail, no error is reported to
      the client application. This commit adds the emission of a vnc-error
      signal when this happens. This is not reported as an auth failure as
      these errors are not something which is recoverable, they indicate
      system failures.
      Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
      fa21beab
    • Christophe Fergeau's avatar
      sasl: Emit vnc-auth-failure signal on SASL auth failures · 3f4f79ff
      Christophe Fergeau authored
      When the SASL username or password are wrong, at the moment client
      application will not get any specific notification for it, they will
      just know that the remote connection was closed because of an error.
      
      This commit adds the emission of the vnc-auth-failure signal when
      vnc_connection_perform_auth_sasl() fails.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1456175Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
      3f4f79ff
    • Christophe Fergeau's avatar
      sasl: Factor common code auth failure · 83cac0cb
      Christophe Fergeau authored
      The new vnc_connection_auth_failure() method will be reused in the
      next commit.
      Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
      83cac0cb