GitLab

This is another case of the bug fixed in

commit d2c93a2b
Author: Daniel P. Berrangé <dan@berrange.com>
Date:   Tue Mar 30 15:00:00 2021 +0100

    Add missing include of gdkwin32.h

Closes: #16

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

On each click on the new menu item, the screen is rotated by additional
90 degrees clockwise.

As with vncEncryptBytes2 in the earlier patch,
the connection error must be set, otherwise the connection
stays in the mainloop, but nothing is happening.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

With the current code, if one of the gcry functions in
vnc_connection_perform_auth_ard() fails:
* key isn't released
* md5 isn't closed
* mpis and dh aren't released
Signed-off-by: Jakub Janků <jjanku@redhat.com>

If vncEncryptBytes2 fails, the false return value propagates
upwards, but no error is set. The connection ends up stuck in
the mainloop with nothing happening.

Additionally, the mpis and dh aren't freed.

To fix that, return the gcry error from vncEncryptBytes2
and set the connection error accordingly.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

In vnc_connection_perform_auth_vnc(), if the user enters an empty
password, gcry_cipher_setkey() fails with GPG_ERR_WEAK_KEY.

In such case, we want to give the useranother chance to reenter
the password, as is the case when the password is incorrect.

To enable that, the auth-failure signal needs to be emitted.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1941398

Signed-off-by: Jakub Janků <jjanku@redhat.com>

Otherwise with_vala is not defined, and meson setup results in

    src/meson.build:169:5: ERROR: Unknown variable "with_vala".

When the required ucontext functions aren't found, switch to gthread
coroutines instead of failing during the build.

These functions are absent from the POSIX.1-2008.

Fixes: #11

Signed-off-by: Jakub Janků <jjanku@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

The syntax-check rules use git to get a list of files to check.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

This allows the remote desktop be to kept at a fixed scaling
factor between 10% and 400%.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

This is the more modern approach to layout sizing in GTK, compared to
setting an explicit size request. The main benefit is that we can
force a resize to match the remote desktop size, while still allowing
the user to resize the window smaller. This is useful when either
scaling, or client initiated framebuffer resizes are enabled.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Lower_case is the prefered glib C style.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

GEnum works with values that fit in int. However 0xffffffa doesn't fit,
it is actually -6. We can't change the assigned value as this would
likely change the representation of the enum back to int and may break ABI.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Obsoletes are recommended to include the max version that is intended to
be erased, to allow the package to be reintroduced more easily at a
later date if required.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Setting the cflags globally causes them to be picked up by g-ir-scanner
which is not desired.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

This makes us respect the meson warning level and avoids warnings from
meson about reinventing its warninglevel feature.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Avoiding setting it in meson.build means we can honour the optimization
level defined by meson.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

This (mostly) reverts commit 0b0afcad.

Widget resize requests are handled asynchronously, so when the
idle func runs, we may not have actually done the resize yet.
This resulted in the window not honouring the desktop resize
notifications at all times.

The do_size_request() call in vnc_display_set_scaling was
a separate bug fix that must be kept.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

The src pixel is always rgb24 format, regardless of what the
remote pixel format is, so we should not be using the remote
pixel shifts.

Fixes #14

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

We we picking the rgb24_blt function based on the remote
pixel format, rather than the local pixel format. This
caused the pixel data to be horizontally compressed in
low color depth modes.

Fixes #14

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

The remote pixel format for alpha cursor is always RGB888
true colour, regardless of the framebuffer pixel format.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

This avoids printing debug messages on every mouse event
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>