1. 02 May, 2009 1 commit
  2. 08 Apr, 2009 1 commit
  3. 07 Apr, 2009 1 commit
  4. 20 Feb, 2009 1 commit
  5. 19 Feb, 2009 1 commit
  6. 13 Feb, 2009 2 commits
  7. 23 Jan, 2009 1 commit
    • Michael J. Chudobiak's avatar
      Use G_FILE_COPY_TARGET_DEFAULT_PERMS (if glib >= 2.19.0) so that · 8aaebfb7
      Michael J. Chudobiak authored
      2009-01-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/gfile-utils.c: (gfile_xfer):
              Use G_FILE_COPY_TARGET_DEFAULT_PERMS (if glib >= 2.19.0)
              so that copied/moved files receive the default permissions
              for the user (respecting the umask and any directory setgid bits)
              rather than trying to copy the old permissions.
      
      
      svn path=/trunk/; revision=2498
      8aaebfb7
  8. 22 Jan, 2009 2 commits
  9. 05 Jan, 2009 4 commits
    • Michael J. Chudobiak's avatar
      Isolate gnome_vfs code in dlg-file-utils by adding a gerror wrapper. Patch · b69d6007
      Michael J. Chudobiak authored
      2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/gth-utils.c: (gthumb_display_help):
              * src/catalog-web-exporter.c: (export__final_step),
              (export__copy_to_destination__step2):
              * src/dlg-file-utils.c: (set_error_from_vfs_result),
              (real_files_delete__continue2), (real_files_delete__continue),
              (file_move_ask__continue), (file_copy_ask__continue),
              (dlg_file_rename_series), (file_copy_data_free),
              (file_copy__continue_or_abort__response_cb),
              (continue_or_abort_dialog), (files_copy__done),
              (file_progress_update_cb), (xfer_file), (copy_current_file),
              (copy_next_file), (dlg_files_copy), (dlg_files_move_to_trash),
              (file_delete_data_free), (files_delete__done),
              (file_delete_progress_update_cb), (dlg_files_delete),
              (folder_copy_data_free), (folder_progress_update_cb),
              (folder_copy), (dlg_folder_move_to_trash), (copy_item__continue2),
              (item_copy__continue_or_abort__response_cb),
              (copy_item__continue1), (copy_current_item), (dlg_copy_items):
              * src/dlg-file-utils.h:
              * src/dlg-write-to-cd.c: (write_to_cd__continue):
              * src/gth-browser-actions-callbacks.c: (show_folder),
              (folder_delete__continue2), (folder_delete__continue),
              (folder_copy__continue):
              * src/gth-browser.c: (move_items__continue):
              Isolate gnome_vfs code in dlg-file-utils by adding a gerror wrapper.
              Patch by Christophe Bisière. Bug #525482.
      
      
      svn path=/trunk/; revision=2490
      b69d6007
    • Michael J. Chudobiak's avatar
      Simplify the previous commit, by not duplicating the already existing · 0d42b8e2
      Michael J. Chudobiak authored
      2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/image-viewer.c: (load_image__step2):
              Simplify the previous commit, by not duplicating the already existing
              FileData.
      
      
      svn path=/trunk/; revision=2489
      0d42b8e2
    • Michael J. Chudobiak's avatar
      Fixed crash due to unitialized FileData introduced in the refactoring of · 181db1b3
      Michael J. Chudobiak authored
      2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/image-viewer.c: (load_image__step2):
              Fixed crash due to unitialized FileData introduced in the refactoring
              of the image viewer (see bug #501512). Patch by Christophe Bisière.
              Bug #566377.
      
      
      svn path=/trunk/; revision=2488
      181db1b3
    • Michael J. Chudobiak's avatar
      Add "=NULL" to "GError *error" declarations to initialize properly. · 2738420b
      Michael J. Chudobiak authored
      2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c: (dir_make), (dir_remove):
              * libgthumb/gconf-utils.c: (eel_gconf_set_string_list),
              (eel_gconf_get_string_list):
              * src/dlg-web-exporter.c: (theme_dialog__go_to_folder_clicked):
              Add "=NULL" to "GError *error" declarations to initialize properly.
              Expanded version of patch by Christophe Bisière. Bug #566421.
      
              * libgthumb/gth-utils.c: (gthumb_display_help):
              Reformat the GError initialization in the more usual form.
      
      
      svn path=/trunk/; revision=2487
      2738420b
  10. 27 Dec, 2008 5 commits
    • Michael J. Chudobiak's avatar
      Removed the unusued "priority" variable in the image loader, which also · 380a45df
      Michael J. Chudobiak authored
      2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/image-loader.c: (image_loader_init):
              * libgthumb/image-loader.h:
              * src/gthumb-preloader.c: (gthumb_preloader_load__step2):
              Removed the unusued "priority" variable in the image loader, which
              also permitted the removal of the gnomevfs code in the image loader.
      
      
      svn path=/trunk/; revision=2484
      380a45df
    • Michael J. Chudobiak's avatar
      The metadata copying wasn't working quite right in the "Save As" case, · 13165abd
      Michael J. Chudobiak authored
      2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/dlg-save-image.c: (save_image), (file_save_ok_cb),
              (dlg_save_image_as), (dlg_save_image):
              The metadata copying wasn't working quite right in the "Save As" case,
              because the original uri wasn't forwarded to the metadata copying
              routine. Fixed now.
      
      
      svn path=/trunk/; revision=2483
      13165abd
    • Michael J. Chudobiak's avatar
      GFileInfo doesn't work for non-existent files, so we have to use · fc412301
      Michael J. Chudobiak authored
      2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c: (get_file_mime_type):
              GFileInfo doesn't work for non-existent files, so we have to use
              g_content_type_guess to determine the mime type based on a proposed
              filename.
      
      
      svn path=/trunk/; revision=2482
      fc412301
    • Michael J. Chudobiak's avatar
      Use the gfile functions to determine the file extension. Return the · 4b224491
      Michael J. Chudobiak authored
      2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c: (get_filename_extension),
              (get_temp_file_name), (get_cache_full_path),
              (get_cache_filename_from_uri):
              * libgthumb/file-utils.h:
              * libgthumb/gfile-utils.c: (gfile_get_file_mime_type):
              * libgthumb/gfile-utils.h:
              * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
              * src/dlg-photo-importer.c: (valid_mime_type),
              (load_images_preview__step):
              * src/gth-window-actions-callbacks.c:
              (gth_window_activate_action_file_print):
              Use the gfile functions to determine the file extension. Return the
              extension as a char*, rather than const char*. Treat the dot before
              the extension more consistently.
      
      
      svn path=/trunk/; revision=2481
      4b224491
    • Michael J. Chudobiak's avatar
      Migrated permissions-copying code from gnomevfs to gfile. · 8cf10668
      Michael J. Chudobiak authored
      2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/gth-exif-utils.c: (update_and_save_metadata):
              Migrated permissions-copying code from gnomevfs to gfile.
      
      
      svn path=/trunk/; revision=2480
      8cf10668
  11. 26 Dec, 2008 1 commit
  12. 24 Dec, 2008 8 commits
    • Michael J. Chudobiak's avatar
      More gfile migration and gnomevfs purging. · 4749f58e
      Michael J. Chudobiak authored
      2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/gfile-utils.c: (gfile_get_display_name):
              * libgthumb/gfile-utils.h:
              * src/dlg-web-exporter.c: (add_theme_dir),
              (theme_dialog__install_theme_clicked):
              More gfile migration and gnomevfs purging.
      
      
      svn path=/trunk/; revision=2475
      4749f58e
    • Michael J. Chudobiak's avatar
      Simplify theme_present and use gfile-based functions. · d034ec72
      Michael J. Chudobiak authored
      2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * src/dlg-web-exporter.c: (theme_present):
              Simplify theme_present and use gfile-based functions.
      
      
      svn path=/trunk/; revision=2474
      d034ec72
    • Michael J. Chudobiak's avatar
      Deleted unused functions: get_file_path_from_uri, · bb96ee46
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c:
              * libgthumb/file-utils.h:
              Deleted unused functions: get_file_path_from_uri,
              get_catalog_path_from_uri, get_search_path_from_uri,
              remove_scheme_from_uri, new_path_from_uri.
      
      
      svn path=/trunk/; revision=2473
      bb96ee46
    • Michael J. Chudobiak's avatar
      Removed an unused function (checksum_simple). · 4b3d4ce5
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c:
              * libgthumb/file-utils.h:
              Removed an unused function (checksum_simple).
      
      
      svn path=/trunk/; revision=2472
      4b3d4ce5
    • Michael J. Chudobiak's avatar
      Removed obsolete comment. · 52b05114
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-data.c: (load_info):
              Removed obsolete comment.
      
              * libgthumb/file-utils.c: (get_file_mtime), (get_file_ctime),
              (set_file_mtime):
              Migrated these functions to gfile.
      
      
      svn path=/trunk/; revision=2471
      52b05114
    • Michael J. Chudobiak's avatar
      Remove the gnome-vfs mimetype detection routine, and replace it with the · f17b7d1e
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.c: (get_mime_type_from_ext):
              * libgthumb/file-utils.h:
              * src/dlg-image-prop.c: (update_general_info):
              * src/dlg-open-with.c: (dlg_open_with):
              Remove the gnome-vfs mimetype detection routine, and replace
              it with the existing gfile-based one.
      
      
      svn path=/trunk/; revision=2470
      f17b7d1e
    • Michael J. Chudobiak's avatar
      Ported to gfile. Also, use default umask rather than specifying one. · 1cf6a40e
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-utils.h:
              * libgthumb/file-utils.c: (dir_make)
              Ported to gfile. Also, use default umask rather than specifying one.
              
              * (dir_remove),
              (dir_remove_recursive), (ensure_dir_exists):
              Rename file -> gfile for clarity.
      
              * src/catalog-web-exporter.c: (save_image_preview_cb):
              Fixed a crash-causing typo.
      
              * src/dlg-catalog.c: (new_dir_cb):
              * src/dlg-web-exporter.c: (ensure_local_theme_dir_exists):
              * src/gth-browser-actions-callbacks.c:
              (create_new_folder_or_library):
              Use the umask-less version of dir_make.
      
      
      svn path=/trunk/; revision=2469
      1cf6a40e
    • Michael J. Chudobiak's avatar
      Turn off verbose error reports. · a3b7bb10
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-data.c: (load_info):
              Turn off verbose error reports.
      
              * libgthumb/file-utils.c: (can_read_write_execute):
              * libgthumb/file-utils.h:
              * src/dlg-file-utils.c: (dlg_check_folder):
              * src/dlg-photo-importer.c: (ok_clicked_cb):
              Convert gnomevfs-based check_permissions to gfile-based
              can_read_write_execute.
      
      
      svn path=/trunk/; revision=2468
      a3b7bb10
  13. 23 Dec, 2008 3 commits
    • Michael J. Chudobiak's avatar
      Deleted some unused #defines. · ccabe356
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/bookmarks.c:
              * libgthumb/catalog.c:
              Deleted some unused #defines.
      
      
      svn path=/trunk/; revision=2467
      ccabe356
    • Michael J. Chudobiak's avatar
      Removed some unused gnome-vfs includes. · 9986dcab
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/dlg-save-image.c:
              * libgthumb/glib-utils.c:
              * libgthumb/image-viewer.c:
              * libgthumb/print-callbacks.c:
              * src/catalog-list.c:
              * src/dlg-brightness-contrast.c:
              * src/dlg-change-date.c:
              * src/dlg-color-balance.c:
              * src/dlg-convert.c:
              * src/dlg-hue-saturation.c:
              * src/dlg-jpegtran.c:
              * src/dlg-posterize.c:
              * src/dlg-preferences.c:
              * src/dlg-reset-exif.c:
              * src/dlg-scale-image.c:
              * src/dlg-scale-series.c:
              * src/gth-category-selection-dialog.c:
              * src/gth-folder-selection-dialog.c:
              Removed some unused gnome-vfs includes.
      
      
      svn path=/trunk/; revision=2466
      9986dcab
    • Michael J. Chudobiak's avatar
      Load the fast mime_type initially. · 1c0a6e15
      Michael J. Chudobiak authored
      2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/file-data.c: (load_info):
              Load the fast mime_type initially.
      
              * libgthumb/file-utils.c: (path_list_new),
              (visit_rc_directory_sync), (free_cache), (check_cache_free_space):
              Use the new gfile_path_list_new, and fix a small memory leak.
      
              * libgthumb/gfile-utils.c: (gfile_path_list_new):
              * libgthumb/gfile-utils.h:
              Add a gfile version of path_list_new, as part of the gio porting.
      
      
      svn path=/trunk/; revision=2465
      1c0a6e15
  14. 22 Dec, 2008 1 commit
  15. 21 Dec, 2008 3 commits
    • Michael J. Chudobiak's avatar
      Revert previous commit - too flawed for now. · 4b584214
      Michael J. Chudobiak authored
      svn path=/trunk/; revision=2463
      4b584214
    • Michael J. Chudobiak's avatar
      Stop using the gthumb cache of remote files and use the gvfs mount point · ce7abdb8
      Michael J. Chudobiak authored
      2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/comments.c: (save_comment_to_metadata),
              (load_comment_from_xml), (save_comment):
              * libgthumb/dlg-save-image.c: (save_image):
              * libgthumb/file-data.c: (file_data_new), (file_data_dup),
              (file_data_unref), (file_data_set_path):
              * libgthumb/file-data.h:
              * libgthumb/file-utils.c: (gfile_get_path_from_uri),
              (get_pixbuf_using_external_converter), (gth_pixbuf_new_from_file),
              (gth_pixbuf_animation_new_from_file):
              * libgthumb/file-utils.h:
              * libgthumb/gth-exif-utils.c: (gth_read_exiv2), (update_metadata):
              * libgthumb/gth-exif-utils.h:
              * src/catalog-png-exporter.c: (begin_page), (end_page):
              * src/catalog-web-exporter.c: (save_image_preview_cb):
              * src/dlg-convert.c: (save_image_and_remove_original):
              * src/dlg-jpegtran.c: (apply_transformation__trim_response),
              (apply_transformation__step2):
              * src/dlg-photo-importer.c: (save_image):
              * src/dlg-reset-exif.c: (apply_transformation__step2):
              * src/gth-batch-op.c: (pixbuf_op_done_cb):
              * src/gth-browser.c: (get_image_to_preload):
              * src/rotation-utils.c: (apply_transformation_jpeg),
              (apply_transformation_generic):
      
              Stop using the gthumb cache of remote files and use the gvfs mount
              point instead. Still need to purge copy_remote_file_to_cache,
              update_file_from_cache, obtain_local_file, and allied functions.
      
              Added a local_path entry to the FileData structure to record the
              local path or .gvfs mount point.
      
      
      svn path=/trunk/; revision=2462
      ce7abdb8
    • Michael J. Chudobiak's avatar
      When saving a file, specify the original file from which metadata should · 0f3ccade
      Michael J. Chudobiak authored
      2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/dlg-save-image.c: (save_image):
              * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev),
              (_gdk_pixbuf_save):
              * libgthumb/pixbuf-utils.h:
              * src/catalog-web-exporter.c: (save_thumbnail_cb),
              (save_image_preview_cb), (save_resized_image_cb):
              * src/dlg-convert.c: (save_image_and_remove_original):
              * src/gth-batch-op.c: (pixbuf_op_done_cb):
              * src/rotation-utils.c: (apply_transformation_generic):
              When saving a file, specify the original file from which metadata 
              should be copied. The previous commit had a flaw where if you saved
              a pixbuf to overwrite already-existing file, the metadata from the
              existing file was copied into the new file. This commit fixes that.
      
      
      svn path=/trunk/; revision=2461
      0f3ccade
  16. 20 Dec, 2008 1 commit
    • Michael J. Chudobiak's avatar
      Fixed metadata saving with exiv2 0.18. When saving an edited pixbuf, first · 6ff711bc
      Michael J. Chudobiak authored
      2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/gth-exiv2-utils.cpp:
              * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
              Fixed metadata saving with exiv2 0.18. When saving an edited pixbuf,
              first try copying the metadata from a backup copy of the original
              file. If that fails, copy from the internal metadata glist, which is
              less robust, because it does not contain variable-typing data.
      
      
      svn path=/trunk/; revision=2460
      6ff711bc
  17. 19 Dec, 2008 1 commit
  18. 18 Dec, 2008 1 commit
  19. 17 Dec, 2008 1 commit
    • Michael J. Chudobiak's avatar
      Cleaned up gtk and glib includes to use only toplevel headers. Bug · 7210712c
      Michael J. Chudobiak authored
      2008-12-17  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libgthumb/catalog.h:
              * libgthumb/cursors.c:
              * libgthumb/dlg-save-image.h:
              * libgthumb/eel-canvas-rect.c:
              * libgthumb/file-utils.c:
              * libgthumb/gth-file-view.h:
              * libgthumb/gth-image-list.c:
              * libgthumb/gth-image-list.h:
              * libgthumb/gth-iviewer.h:
              * libgthumb/gth-nav-window.h:
              * libgthumb/image-loader.c:
              * libgthumb/image-loader.h:
              * libgthumb/image-viewer-image.h:
              * libgthumb/image-viewer.c:
              * libgthumb/image-viewer.h:
              * libgthumb/nav-window.h:
              * libgthumb/preferences.h:
              * libgthumb/print-callbacks.c:
              * libgthumb/thumb-loader.c:
              * src/bookmark-list.h:
              * src/catalog-list.h:
              * src/catalog-png-exporter.c:
              * src/catalog-png-exporter.h:
              * src/catalog-web-exporter.h:
              * src/dlg-open-with.h:
              * src/gth-batch-op.h:
              * src/gth-browser-actions-callbacks.h:
              * src/gth-category-selection-dialog.h:
              * src/gth-exif-data-viewer.h:
              * src/gth-filter-bar.h:
              * src/gth-folder-selection-dialog.h:
              * src/gth-fullscreen-actions-callbacks.h:
              * src/gth-location.c:
              * src/gth-location.h:
              * src/gth-viewer-actions-callbacks.h:
              * src/gth-window-actions-callbacks.h:
              * src/gth-window.h:
              * src/gtkcellrendererthreestates.c:
              * src/gtkcellrendererthreestates.h:
      
              Cleaned up gtk and glib includes to use only toplevel headers.
              Bug #564298. Patch by Przemysław Grzegorczyk
              <pgrzegorczyk@gmail.com>.
      
      
      
      svn path=/trunk/; revision=2456
      7210712c
  20. 16 Dec, 2008 1 commit