svn path=/trunk/; revision=2537

svn path=/trunk/; revision=2535

2009-02-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gfile-utils.c: (gfile_get_file_mime_type):
        Fixed bug #572498 - don't forget to return the result!
        Patch by Matthias Hawran <matthias@hawran.net>.


svn path=/trunk/; revision=2511

2009-02-19  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gth-exif-utils.c: Store keywords in XMP
        metadata by default, instead of IPTC. Bug #572424.
        Patch by Jef Driesen <jefdriesen@hotmail.com>.


svn path=/trunk/; revision=2510

svn path=/trunk/; revision=2508

svn path=/trunk/; revision=2506

2009-01-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gfile-utils.c: (gfile_xfer):
        Use G_FILE_COPY_TARGET_DEFAULT_PERMS (if glib >= 2.19.0)
        so that copied/moved files receive the default permissions
        for the user (respecting the umask and any directory setgid bits)
        rather than trying to copy the old permissions.


svn path=/trunk/; revision=2498

svn path=/trunk/; revision=2496

svn path=/trunk/; revision=2494

2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gth-utils.c: (gthumb_display_help):
        * src/catalog-web-exporter.c: (export__final_step),
        (export__copy_to_destination__step2):
        * src/dlg-file-utils.c: (set_error_from_vfs_result),
        (real_files_delete__continue2), (real_files_delete__continue),
        (file_move_ask__continue), (file_copy_ask__continue),
        (dlg_file_rename_series), (file_copy_data_free),
        (file_copy__continue_or_abort__response_cb),
        (continue_or_abort_dialog), (files_copy__done),
        (file_progress_update_cb), (xfer_file), (copy_current_file),
        (copy_next_file), (dlg_files_copy), (dlg_files_move_to_trash),
        (file_delete_data_free), (files_delete__done),
        (file_delete_progress_update_cb), (dlg_files_delete),
        (folder_copy_data_free), (folder_progress_update_cb),
        (folder_copy), (dlg_folder_move_to_trash), (copy_item__continue2),
        (item_copy__continue_or_abort__response_cb),
        (copy_item__continue1), (copy_current_item), (dlg_copy_items):
        * src/dlg-file-utils.h:
        * src/dlg-write-to-cd.c: (write_to_cd__continue):
        * src/gth-browser-actions-callbacks.c: (show_folder),
        (folder_delete__continue2), (folder_delete__continue),
        (folder_copy__continue):
        * src/gth-browser.c: (move_items__continue):
        Isolate gnome_vfs code in dlg-file-utils by adding a gerror wrapper.
        Patch by Christophe Bisière. Bug #525482.


svn path=/trunk/; revision=2490

2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/image-viewer.c: (load_image__step2):
        Simplify the previous commit, by not duplicating the already existing
        FileData.


svn path=/trunk/; revision=2489

2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/image-viewer.c: (load_image__step2):
        Fixed crash due to unitialized FileData introduced in the refactoring
        of the image viewer (see bug #501512). Patch by Christophe Bisière.
        Bug #566377.


svn path=/trunk/; revision=2488

2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c: (dir_make), (dir_remove):
        * libgthumb/gconf-utils.c: (eel_gconf_set_string_list),
        (eel_gconf_get_string_list):
        * src/dlg-web-exporter.c: (theme_dialog__go_to_folder_clicked):
        Add "=NULL" to "GError *error" declarations to initialize properly.
        Expanded version of patch by Christophe Bisière. Bug #566421.

        * libgthumb/gth-utils.c: (gthumb_display_help):
        Reformat the GError initialization in the more usual form.


svn path=/trunk/; revision=2487

2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/image-loader.c: (image_loader_init):
        * libgthumb/image-loader.h:
        * src/gthumb-preloader.c: (gthumb_preloader_load__step2):
        Removed the unusued "priority" variable in the image loader, which
        also permitted the removal of the gnomevfs code in the image loader.


svn path=/trunk/; revision=2484

2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/dlg-save-image.c: (save_image), (file_save_ok_cb),
        (dlg_save_image_as), (dlg_save_image):
        The metadata copying wasn't working quite right in the "Save As" case,
        because the original uri wasn't forwarded to the metadata copying
        routine. Fixed now.


svn path=/trunk/; revision=2483

2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c: (get_file_mime_type):
        GFileInfo doesn't work for non-existent files, so we have to use
        g_content_type_guess to determine the mime type based on a proposed
        filename.


svn path=/trunk/; revision=2482

2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c: (get_filename_extension),
        (get_temp_file_name), (get_cache_full_path),
        (get_cache_filename_from_uri):
        * libgthumb/file-utils.h:
        * libgthumb/gfile-utils.c: (gfile_get_file_mime_type):
        * libgthumb/gfile-utils.h:
        * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
        * src/dlg-photo-importer.c: (valid_mime_type),
        (load_images_preview__step):
        * src/gth-window-actions-callbacks.c:
        (gth_window_activate_action_file_print):
        Use the gfile functions to determine the file extension. Return the
        extension as a char*, rather than const char*. Treat the dot before
        the extension more consistently.


svn path=/trunk/; revision=2481

2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gth-exif-utils.c: (update_and_save_metadata):
        Migrated permissions-copying code from gnomevfs to gfile.


svn path=/trunk/; revision=2480

2008-12-26  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * doc/C/gthumb.xml:
        * src/dlg-scripts.c:
        Fixed default launch-with-gimp hotkey to launch gimp in the
        background. Bug #565708.


svn path=/trunk/; revision=2479

2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gfile-utils.c: (gfile_get_display_name):
        * libgthumb/gfile-utils.h:
        * src/dlg-web-exporter.c: (add_theme_dir),
        (theme_dialog__install_theme_clicked):
        More gfile migration and gnomevfs purging.


svn path=/trunk/; revision=2475

2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * src/dlg-web-exporter.c: (theme_present):
        Simplify theme_present and use gfile-based functions.


svn path=/trunk/; revision=2474

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c:
        * libgthumb/file-utils.h:
        Deleted unused functions: get_file_path_from_uri,
        get_catalog_path_from_uri, get_search_path_from_uri,
        remove_scheme_from_uri, new_path_from_uri.


svn path=/trunk/; revision=2473

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c:
        * libgthumb/file-utils.h:
        Removed an unused function (checksum_simple).


svn path=/trunk/; revision=2472

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-data.c: (load_info):
        Removed obsolete comment.

        * libgthumb/file-utils.c: (get_file_mtime), (get_file_ctime),
        (set_file_mtime):
        Migrated these functions to gfile.


svn path=/trunk/; revision=2471

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.c: (get_mime_type_from_ext):
        * libgthumb/file-utils.h:
        * src/dlg-image-prop.c: (update_general_info):
        * src/dlg-open-with.c: (dlg_open_with):
        Remove the gnome-vfs mimetype detection routine, and replace
        it with the existing gfile-based one.


svn path=/trunk/; revision=2470

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-utils.h:
        * libgthumb/file-utils.c: (dir_make)
        Ported to gfile. Also, use default umask rather than specifying one.
        
        * (dir_remove),
        (dir_remove_recursive), (ensure_dir_exists):
        Rename file -> gfile for clarity.

        * src/catalog-web-exporter.c: (save_image_preview_cb):
        Fixed a crash-causing typo.

        * src/dlg-catalog.c: (new_dir_cb):
        * src/dlg-web-exporter.c: (ensure_local_theme_dir_exists):
        * src/gth-browser-actions-callbacks.c:
        (create_new_folder_or_library):
        Use the umask-less version of dir_make.


svn path=/trunk/; revision=2469

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-data.c: (load_info):
        Turn off verbose error reports.

        * libgthumb/file-utils.c: (can_read_write_execute):
        * libgthumb/file-utils.h:
        * src/dlg-file-utils.c: (dlg_check_folder):
        * src/dlg-photo-importer.c: (ok_clicked_cb):
        Convert gnomevfs-based check_permissions to gfile-based
        can_read_write_execute.


svn path=/trunk/; revision=2468

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/bookmarks.c:
        * libgthumb/catalog.c:
        Deleted some unused #defines.


svn path=/trunk/; revision=2467

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/dlg-save-image.c:
        * libgthumb/glib-utils.c:
        * libgthumb/image-viewer.c:
        * libgthumb/print-callbacks.c:
        * src/catalog-list.c:
        * src/dlg-brightness-contrast.c:
        * src/dlg-change-date.c:
        * src/dlg-color-balance.c:
        * src/dlg-convert.c:
        * src/dlg-hue-saturation.c:
        * src/dlg-jpegtran.c:
        * src/dlg-posterize.c:
        * src/dlg-preferences.c:
        * src/dlg-reset-exif.c:
        * src/dlg-scale-image.c:
        * src/dlg-scale-series.c:
        * src/gth-category-selection-dialog.c:
        * src/gth-folder-selection-dialog.c:
        Removed some unused gnome-vfs includes.


svn path=/trunk/; revision=2466

2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/file-data.c: (load_info):
        Load the fast mime_type initially.

        * libgthumb/file-utils.c: (path_list_new),
        (visit_rc_directory_sync), (free_cache), (check_cache_free_space):
        Use the new gfile_path_list_new, and fix a small memory leak.

        * libgthumb/gfile-utils.c: (gfile_path_list_new):
        * libgthumb/gfile-utils.h:
        Add a gfile version of path_list_new, as part of the gio porting.


svn path=/trunk/; revision=2465

2008-12-22  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * many files: Ported file-data.c from gnome_vfs to gfile.
        Simplified file-data.c slightly and removed some redundant functions.


svn path=/trunk/; revision=2464

svn path=/trunk/; revision=2463

2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/comments.c: (save_comment_to_metadata),
        (load_comment_from_xml), (save_comment):
        * libgthumb/dlg-save-image.c: (save_image):
        * libgthumb/file-data.c: (file_data_new), (file_data_dup),
        (file_data_unref), (file_data_set_path):
        * libgthumb/file-data.h:
        * libgthumb/file-utils.c: (gfile_get_path_from_uri),
        (get_pixbuf_using_external_converter), (gth_pixbuf_new_from_file),
        (gth_pixbuf_animation_new_from_file):
        * libgthumb/file-utils.h:
        * libgthumb/gth-exif-utils.c: (gth_read_exiv2), (update_metadata):
        * libgthumb/gth-exif-utils.h:
        * src/catalog-png-exporter.c: (begin_page), (end_page):
        * src/catalog-web-exporter.c: (save_image_preview_cb):
        * src/dlg-convert.c: (save_image_and_remove_original):
        * src/dlg-jpegtran.c: (apply_transformation__trim_response),
        (apply_transformation__step2):
        * src/dlg-photo-importer.c: (save_image):
        * src/dlg-reset-exif.c: (apply_transformation__step2):
        * src/gth-batch-op.c: (pixbuf_op_done_cb):
        * src/gth-browser.c: (get_image_to_preload):
        * src/rotation-utils.c: (apply_transformation_jpeg),
        (apply_transformation_generic):

        Stop using the gthumb cache of remote files and use the gvfs mount
        point instead. Still need to purge copy_remote_file_to_cache,
        update_file_from_cache, obtain_local_file, and allied functions.

        Added a local_path entry to the FileData structure to record the
        local path or .gvfs mount point.


svn path=/trunk/; revision=2462

2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/dlg-save-image.c: (save_image):
        * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev),
        (_gdk_pixbuf_save):
        * libgthumb/pixbuf-utils.h:
        * src/catalog-web-exporter.c: (save_thumbnail_cb),
        (save_image_preview_cb), (save_resized_image_cb):
        * src/dlg-convert.c: (save_image_and_remove_original):
        * src/gth-batch-op.c: (pixbuf_op_done_cb):
        * src/rotation-utils.c: (apply_transformation_generic):
        When saving a file, specify the original file from which metadata 
        should be copied. The previous commit had a flaw where if you saved
        a pixbuf to overwrite already-existing file, the metadata from the
        existing file was copied into the new file. This commit fixes that.


svn path=/trunk/; revision=2461

2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/gth-exiv2-utils.cpp:
        * libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
        Fixed metadata saving with exiv2 0.18. When saving an edited pixbuf,
        first try copying the metadata from a backup copy of the original
        file. If that fails, copy from the internal metadata glist, which is
        less robust, because it does not contain variable-typing data.


svn path=/trunk/; revision=2460

2008-12-19  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * NEWS:
        * README:
        * configure.in:
        * libgthumb/gth-exiv2-utils.cpp:
        Adapt to exiv2 0.18, which has API changes. Metadata writing is
        partly broken, so don't use trunk for editing until that is fixed.
        Working on it!


svn path=/trunk/; revision=2459

svn path=/trunk/; revision=2458

2008-12-17  Michael J. Chudobiak  <mjc@svn.gnome.org>

        * libgthumb/catalog.h:
        * libgthumb/cursors.c:
        * libgthumb/dlg-save-image.h:
        * libgthumb/eel-canvas-rect.c:
        * libgthumb/file-utils.c:
        * libgthumb/gth-file-view.h:
        * libgthumb/gth-image-list.c:
        * libgthumb/gth-image-list.h:
        * libgthumb/gth-iviewer.h:
        * libgthumb/gth-nav-window.h:
        * libgthumb/image-loader.c:
        * libgthumb/image-loader.h:
        * libgthumb/image-viewer-image.h:
        * libgthumb/image-viewer.c:
        * libgthumb/image-viewer.h:
        * libgthumb/nav-window.h:
        * libgthumb/preferences.h:
        * libgthumb/print-callbacks.c:
        * libgthumb/thumb-loader.c:
        * src/bookmark-list.h:
        * src/catalog-list.h:
        * src/catalog-png-exporter.c:
        * src/catalog-png-exporter.h:
        * src/catalog-web-exporter.h:
        * src/dlg-open-with.h:
        * src/gth-batch-op.h:
        * src/gth-browser-actions-callbacks.h:
        * src/gth-category-selection-dialog.h:
        * src/gth-exif-data-viewer.h:
        * src/gth-filter-bar.h:
        * src/gth-folder-selection-dialog.h:
        * src/gth-fullscreen-actions-callbacks.h:
        * src/gth-location.c:
        * src/gth-location.h:
        * src/gth-viewer-actions-callbacks.h:
        * src/gth-window-actions-callbacks.h:
        * src/gth-window.h:
        * src/gtkcellrendererthreestates.c:
        * src/gtkcellrendererthreestates.h:

        Cleaned up gtk and glib includes to use only toplevel headers.
        Bug #564298. Patch by Przemysław Grzegorczyk
        <pgrzegorczyk@gmail.com>.



svn path=/trunk/; revision=2456

svn path=/trunk/; revision=2455