ChangeLog.pre-git 446 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
2009-04-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/pixbuf-utils.c: (_gdk_pixbuf_save_as_jpeg):
	* src/dlg-bookmarks.c: (dlg_edit_bookmarks):
	* src/dlg-catalog.c: (dlg_add_to_catalog),
	(dlg_move_to_catalog_directory):
	* src/dlg-comment.c: (dlg_comment_new):
	* src/dlg-duplicates.c: (dlg_duplicates):
	* src/dlg-png-exporter.c: (dlg_png_exporter_pref):
	Plugged a variety of small memory leaks, detected using
	"cppcheck -q -a -f .". Bug #578282.

13
14
15
16
17
18
19
20
21
22
23
24
25
2009-04-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* data/gthumb-import.desktop.in:
	The existing import scripts did not properly unmount gvfs-mounted
	cameras. Gnome bug #560352, Ubuntu bug #351122.

2009-04-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* data/glade/gthumb_tools.glade:
	Made the OK button the default widget in the rename dialog.

26
27
28
29
30
31
2009-02-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gfile-utils.c: (gfile_get_file_mime_type):
	Fixed bug #572498 - don't forget to return the result!
	Patch by Matthias Hawran <matthias@hawran.net>.

32
33
34
35
36
37
2009-02-19  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gth-exif-utils.c: Store keywords in XMP
	metadata by default, instead of IPTC. Bug #572424.
	Patch by Jef Driesen <jefdriesen@hotmail.com>.

38
39
40
41
42
43
44
2009-02-13  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-loader.c: (image_loader_finalize__step2),
	(image_loader_finalize):
	Fixed bug #570473, gthumb write to freed memory.
	Patch by Jerry Tan <jerry.tan@sun.com>.

45
46
47
48
49
50
51
52
53
54
55
56
57
2009-02-13  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/gth-browser.c: (menu_item_select_cb):
	* src/gth-viewer.c: (menu_item_select_cb):
	Fixed bug #568894 - use gtk_widget_get_action (foo), instead of
	g_object_get_data (foo,  "gtk-action").

2009-02-13  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gtk-utils.c: (panel_find_icon):
	Fix a possible crash. Patch taken from Fedora 2.10.10 source rpm,
	which I don't recall seeing upstream...

58
59
60
61
62
63
64
65
2009-01-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gfile-utils.c: (gfile_xfer):
	Use G_FILE_COPY_TARGET_DEFAULT_PERMS (if glib >= 2.19.0)
	so that copied/moved files receive the default permissions
	for the user (respecting the umask and any directory setgid bits)
	rather than trying to copy the old permissions.

66
67
68
69
70
2009-01-22  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* data/gthumb-import.desktop.in:
	Change the comment field too, following up on the last change.

71
72
73
74
75
76
77
2009-01-22  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* data/gthumb-import.desktop.in:
	Give the photo-import desktop file different name parameters, so 
	that users can distinguish it from the normal desktop file.
	Ubuntu bug http://bugs.launchpad.net/bugs/318694.

78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gth-utils.c: (gthumb_display_help):
	* src/catalog-web-exporter.c: (export__final_step),
	(export__copy_to_destination__step2):
	* src/dlg-file-utils.c: (set_error_from_vfs_result),
	(real_files_delete__continue2), (real_files_delete__continue),
	(file_move_ask__continue), (file_copy_ask__continue),
	(dlg_file_rename_series), (file_copy_data_free),
	(file_copy__continue_or_abort__response_cb),
	(continue_or_abort_dialog), (files_copy__done),
	(file_progress_update_cb), (xfer_file), (copy_current_file),
	(copy_next_file), (dlg_files_copy), (dlg_files_move_to_trash),
	(file_delete_data_free), (files_delete__done),
	(file_delete_progress_update_cb), (dlg_files_delete),
	(folder_copy_data_free), (folder_progress_update_cb),
	(folder_copy), (dlg_folder_move_to_trash), (copy_item__continue2),
	(item_copy__continue_or_abort__response_cb),
	(copy_item__continue1), (copy_current_item), (dlg_copy_items):
	* src/dlg-file-utils.h:
	* src/dlg-write-to-cd.c: (write_to_cd__continue):
	* src/gth-browser-actions-callbacks.c: (show_folder),
	(folder_delete__continue2), (folder_delete__continue),
	(folder_copy__continue):
	* src/gth-browser.c: (move_items__continue):
	Isolate gnome_vfs code in dlg-file-utils by adding a gerror wrapper.
	Patch by Christophe Bisière. Bug #525482.

106
107
108
109
110
111
2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-viewer.c: (load_image__step2):
	Simplify the previous commit, by not duplicating the already existing
	FileData.

112
113
114
115
116
117
118
2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-viewer.c: (load_image__step2):
	Fixed crash due to unitialized FileData introduced in the refactoring
	of the image viewer (see bug #501512). Patch by Christophe Bisière.
	Bug #566377.

119
120
121
122
123
124
125
126
127
128
129
130
2009-01-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (dir_make), (dir_remove):
	* libgthumb/gconf-utils.c: (eel_gconf_set_string_list),
	(eel_gconf_get_string_list):
	* src/dlg-web-exporter.c: (theme_dialog__go_to_folder_clicked):
	Add "=NULL" to "GError *error" declarations to initialize properly.
	Expanded version of patch by Christophe Bisière. Bug #566421.

	* libgthumb/gth-utils.c: (gthumb_display_help):
	Reformat the GError initialization in the more usual form.

131
132
133
134
135
136
137
138
2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-loader.c: (image_loader_init):
	* libgthumb/image-loader.h:
	* src/gthumb-preloader.c: (gthumb_preloader_load__step2):
	Removed the unusued "priority" variable in the image loader, which
	also permitted the removal of the gnomevfs code in the image loader.

139
140
141
142
143
144
145
146
2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/dlg-save-image.c: (save_image), (file_save_ok_cb),
	(dlg_save_image_as), (dlg_save_image):
	The metadata copying wasn't working quite right in the "Save As" case,
	because the original uri wasn't forwarded to the metadata copying
	routine. Fixed now.

147
148
149
150
151
152
153
2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (get_file_mime_type):
	GFileInfo doesn't work for non-existent files, so we have to use
	g_content_type_guess to determine the mime type based on a proposed
	filename.

154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (get_filename_extension),
	(get_temp_file_name), (get_cache_full_path),
	(get_cache_filename_from_uri):
	* libgthumb/file-utils.h:
	* libgthumb/gfile-utils.c: (gfile_get_file_mime_type):
	* libgthumb/gfile-utils.h:
	* libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
	* src/dlg-photo-importer.c: (valid_mime_type),
	(load_images_preview__step):
	* src/gth-window-actions-callbacks.c:
	(gth_window_activate_action_file_print):
	Use the gfile functions to determine the file extension. Return the
	extension as a char*, rather than const char*. Treat the dot before
	the extension more consistently.

171
172
173
174
175
2008-12-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gth-exif-utils.c: (update_and_save_metadata):
	Migrated permissions-copying code from gnomevfs to gfile.

176
177
178
179
180
181
182
2008-12-26  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/C/gthumb.xml:
	* src/dlg-scripts.c:
	Fixed default launch-with-gimp hotkey to launch gimp in the
	background. Bug #565708.

183
184
185
186
187
188
189
190
2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gfile-utils.c: (gfile_get_display_name):
	* libgthumb/gfile-utils.h:
	* src/dlg-web-exporter.c: (add_theme_dir),
	(theme_dialog__install_theme_clicked):
	More gfile migration and gnomevfs purging.

191
192
193
194
195
2008-12-24  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/dlg-web-exporter.c: (theme_present):
	Simplify theme_present and use gfile-based functions.

196
197
198
199
200
201
202
203
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c:
	* libgthumb/file-utils.h:
	Deleted unused functions: get_file_path_from_uri,
	get_catalog_path_from_uri, get_search_path_from_uri,
	remove_scheme_from_uri, new_path_from_uri.

204
205
206
207
208
209
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c:
	* libgthumb/file-utils.h:
	Removed an unused function (checksum_simple).

210
211
212
213
214
215
216
217
218
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-data.c: (load_info):
	Removed obsolete comment.

	* libgthumb/file-utils.c: (get_file_mtime), (get_file_ctime),
	(set_file_mtime):
	Migrated these functions to gfile.

219
220
221
222
223
224
225
226
227
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (get_mime_type_from_ext):
	* libgthumb/file-utils.h:
	* src/dlg-image-prop.c: (update_general_info):
	* src/dlg-open-with.c: (dlg_open_with):
	Remove the gnome-vfs mimetype detection routine, and replace
	it with the existing gfile-based one.

228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.h:
	* libgthumb/file-utils.c: (dir_make)
	Ported to gfile. Also, use default umask rather than specifying one.
	
	* (dir_remove),
	(dir_remove_recursive), (ensure_dir_exists):
	Rename file -> gfile for clarity.

	* src/catalog-web-exporter.c: (save_image_preview_cb):
	Fixed a crash-causing typo.

	* src/dlg-catalog.c: (new_dir_cb):
	* src/dlg-web-exporter.c: (ensure_local_theme_dir_exists):
	* src/gth-browser-actions-callbacks.c:
	(create_new_folder_or_library):
	Use the umask-less version of dir_make.

247
248
249
250
251
252
253
254
255
256
257
258
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-data.c: (load_info):
	Turn off verbose error reports.

	* libgthumb/file-utils.c: (can_read_write_execute):
	* libgthumb/file-utils.h:
	* src/dlg-file-utils.c: (dlg_check_folder):
	* src/dlg-photo-importer.c: (ok_clicked_cb):
	Convert gnomevfs-based check_permissions to gfile-based
	can_read_write_execute.

259
260
261
262
263
264
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/bookmarks.c:
	* libgthumb/catalog.c:
	Deleted some unused #defines.

265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/dlg-save-image.c:
	* libgthumb/glib-utils.c:
	* libgthumb/image-viewer.c:
	* libgthumb/print-callbacks.c:
	* src/catalog-list.c:
	* src/dlg-brightness-contrast.c:
	* src/dlg-change-date.c:
	* src/dlg-color-balance.c:
	* src/dlg-convert.c:
	* src/dlg-hue-saturation.c:
	* src/dlg-jpegtran.c:
	* src/dlg-posterize.c:
	* src/dlg-preferences.c:
	* src/dlg-reset-exif.c:
	* src/dlg-scale-image.c:
	* src/dlg-scale-series.c:
	* src/gth-category-selection-dialog.c:
	* src/gth-folder-selection-dialog.c:
	Removed some unused gnome-vfs includes.

287
288
289
290
291
292
293
294
295
296
297
298
299
2008-12-23  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-data.c: (load_info):
	Load the fast mime_type initially.

	* libgthumb/file-utils.c: (path_list_new),
	(visit_rc_directory_sync), (free_cache), (check_cache_free_space):
	Use the new gfile_path_list_new, and fix a small memory leak.

	* libgthumb/gfile-utils.c: (gfile_path_list_new):
	* libgthumb/gfile-utils.h:
	Add a gfile version of path_list_new, as part of the gio porting.

300
301
302
303
304
2008-12-22  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* many files: Ported file-data.c from gnome_vfs to gfile.
	Simplified file-data.c slightly and removed some redundant functions.

305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/dlg-save-image.c: (save_image):
	* libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev),
	(_gdk_pixbuf_save):
	* libgthumb/pixbuf-utils.h:
	* src/catalog-web-exporter.c: (save_thumbnail_cb),
	(save_image_preview_cb), (save_resized_image_cb):
	* src/dlg-convert.c: (save_image_and_remove_original):
	* src/gth-batch-op.c: (pixbuf_op_done_cb):
	* src/rotation-utils.c: (apply_transformation_generic):
	When saving a file, specify the original file from which metadata
	should be copied. The previous commit had a flaw where if you saved
	a pixbuf to overwrite already-existing file, the metadata from the
	existing file was copied into the new file. This commit fixes that.

321
322
323
324
325
326
327
328
329
2008-12-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gth-exiv2-utils.cpp:
	* libgthumb/pixbuf-utils.c: (_gdk_pixbuf_savev):
	Fixed metadata saving with exiv2 0.18. When saving an edited pixbuf,
	first try copying the metadata from a backup copy of the original
	file. If that fails, copy from the internal metadata glist, which is
	less robust, because it does not contain variable-typing data.

330
331
332
333
334
335
336
337
338
339
2008-12-19  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* README:
	* configure.in:
	* libgthumb/gth-exiv2-utils.cpp:
	Adapt to exiv2 0.18, which has API changes. Metadata writing is
	partly broken, so don't use trunk for editing until that is fixed.
	Working on it!

340
341
342
343
344
345
2008-12-18  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/comments.c: (load_comment_from_xml), (save_comment):
	Fixed XML comment reading. Bug #563956. Modified version of
	patch by Jef Driesen <jefdriesen@hotmail.com>.

346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
2008-12-17  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/catalog.h:
	* libgthumb/cursors.c:
	* libgthumb/dlg-save-image.h:
	* libgthumb/eel-canvas-rect.c:
	* libgthumb/file-utils.c:
	* libgthumb/gth-file-view.h:
	* libgthumb/gth-image-list.c:
	* libgthumb/gth-image-list.h:
	* libgthumb/gth-iviewer.h:
	* libgthumb/gth-nav-window.h:
	* libgthumb/image-loader.c:
	* libgthumb/image-loader.h:
	* libgthumb/image-viewer-image.h:
	* libgthumb/image-viewer.c:
	* libgthumb/image-viewer.h:
	* libgthumb/nav-window.h:
	* libgthumb/preferences.h:
	* libgthumb/print-callbacks.c:
	* libgthumb/thumb-loader.c:
	* src/bookmark-list.h:
	* src/catalog-list.h:
	* src/catalog-png-exporter.c:
	* src/catalog-png-exporter.h:
	* src/catalog-web-exporter.h:
	* src/dlg-open-with.h:
	* src/gth-batch-op.h:
	* src/gth-browser-actions-callbacks.h:
	* src/gth-category-selection-dialog.h:
	* src/gth-exif-data-viewer.h:
	* src/gth-filter-bar.h:
	* src/gth-folder-selection-dialog.h:
	* src/gth-fullscreen-actions-callbacks.h:
	* src/gth-location.c:
	* src/gth-location.h:
	* src/gth-viewer-actions-callbacks.h:
	* src/gth-window-actions-callbacks.h:
	* src/gth-window.h:
	* src/gtkcellrendererthreestates.c:
	* src/gtkcellrendererthreestates.h:
	Cleaned up gtk and glib includes to use only toplevel headers.
	Bug #564298. Patch by Przemysław Grzegorczyk
	<pgrzegorczyk@gmail.com>.

391
392
393
394
395
396
397
398
399
400
401
402
403
404
2008-12-16  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* configure.in:
	* src/Makefile.am:
	* src/gs-fade.c:
	* src/gth-application.c:
	* src/gth-browser-ui.h:
	* src/gth-browser.c: (gth_browser_construct):
	* src/totem-scrsaver.c:
	Provide support for the Mac OS X menubar. Bug #554240. Modified
	version of the patch by W. Michael Petullo <mike@flyn.org>.
	Also, define the HAVE_GDKX macro properly so it really works.

405
406
407
408
409
410
2008-11-17  Paolo Bacchilega  <paobac@svn.gnome.org>

	* libgthumb/gth-filter.c (test_keywords): 

	Fixed bug #560055 – filter problems
	
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
2008-11-13  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* configure.in:
	* libgthumb/eel-canvas-rect.c:
	* libgthumb/gth-image-list.c:
	* src/gth-application.c: (show_grabbing_focus):
	* src/gth-fullscreen.c: (gth_fullscreen_finalize),
	(gth_fullscreen_init), (gth_fullscreen_show),
	(gth_fullscreen_pause_slideshow):
	* src/totem-scrsaver.c:
	* src/totem-scrsaver.h:
	Modified the build files to better support gtk on MAC OS / Quartz.
	Bug #551225. Based on a patch by W. Michael Petullo <mike@flyn.org>.

426
427
428
429
430
431
432
433
434
435
436
2008-11-12  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* data/Makefile.am:
	* data/gthumb-import.desktop.in:
	* data/gthumb.desktop.in:
	Added a new gthumb-import.desktop.in file to handle gvfs-mounted
	cameras more elegantly. The camera is first unmounted, and the 
	libgphoto import routines are then run. Merged from Ubuntu.
	Bug #560352. Patch by Martin Pitt <martin.pitt@canonical.com>.

437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
2008-11-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* data/glade/gthumb_convert.glade:
	* data/glade/gthumb_crop.glade:
	* data/glade/gthumb_edit.glade:
	* data/glade/gthumb_png_exporter.glade:
	* data/glade/gthumb_preferences.glade:
	* data/glade/gthumb_print.glade:
	* data/glade/gthumb_redeye.glade:
	* data/glade/gthumb_tools.glade:
	* data/glade/gthumb_web_exporter.glade:
	Set pagesize adjustment to zero for spinbuttons, to avoid annoying
	warnings. Bug #557640. Trunkified version of the patch by
	Matthias Clasen <mclasen@redhat.com>.

452
453
454
455
456
457
2008-10-27  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/C/figures/main-win.png:
	Improved screenshot by Bryan Quigley <gQuigs@gMail.com>.
	Bug #557339.

458
459
460
461
462
463
2008-10-22  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/C/gthumb.xml: Fixed typos in the manual. Bug #557233. Patch
	by Christian Kirbach <Christian.Kirbach@googlemail.com>.

2008-10-22  Michael J. Chudobiak  <mjc@svn.gnome.org>
464
465
466
467
468

	* doc/C/figures/main-win.png: 
	Replaced obsolete screenshot with a more recent one provided
	by Bryan Quigley <gQuigs@gMail.com>. Bug #557339.

469
470
471
472
473
474
475
2008-10-15  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/dlg-photo-importer.c: (destroy_cb), (save_image),
	(ok_clicked_cb):
	Go to the last-used subfolder (instead of the base folder) after 
	importing photos, when the group-into-subfolders mode is used.

476
477
478
479
480
481
482
483
484
2008-10-08  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* doc/C/gthumb.xml:
	* src/dlg-preferences.c: (dlg_preferences):
	* src/gth-browser.c: (key_press_cb):
	The "g" key now launches the "gimp" command, instead of the
	deprecated "gimp-remote" command. Bug #555549.

485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
2008-09-20  Paolo Bacchilega  <paobac@svn.gnome.org>

	* libgthumb/file-utils.c (mime_type_is_image): 
	
	Do not exclude xcf images.

	* src/gth-dir-list.h: 
	* src/gth-dir-list.c: 
	* src/gth-browser.c: 
	* libgthumb/preferences.h: 
	* libgthumb/file-utils.h: 
	* libgthumb/file-utils.c: 
	* libgthumb/catalog.c: 
	* data/gthumb.schemas.in: 
	
	Added ability to hide video and audio files, using the gconf key 
	/apps/gthumb/browser/show_only_images.
	
	* COPYING: new file.
	
	Fixes bug #552453 – gthumb 2.10.9 contains COPYING for GPL v3

507
508
509
510
511
512
513
514
515
516
517
518
519
520
2008-09-11  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-loader.c: (image_loader_set_pixbuf)
	Allow setting the pixbuf to NULL.

	* libgthumb/image-viewer-image.c: (create_pixbuf_from_iter),
	(image_viewer_image_new), (pixbuf_to_surface):
	* libgthumb/image-viewer.c: (set_pixbuf__step2),
	(image_viewer_set_pixbuf), (image_viewer_set_void):
	Avoid dereferencing NULL pointers.

	Fixes regression from bug #501512. Patch by 
	Geoffrey Antos <dynamotwain@aim.com>.

521
522
523
524
525
526
2008-09-10  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/catalog-png-exporter.c:
	* src/main.c:
	Remove unnecessary gdkx.h includes. Bug #551225.

527
528
529
530
531
532
533
2008-09-04  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/catalog.c: (catalog_load_from_disk__common):
	Call g_propagate_error only when there is an error, to reduce
	needless warnings. Patch by Geoffrey Antos <dynamotwain@aim.com>.
	From bug #525482.

534
535
536
537
538
2008-09-04  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* data/gthumb.desktop.in: Removed deprecated "Encoding" directive.
	Bug #549993. Patch by Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>.

539
540
541
542
543
2008-08-21  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gfile-utils.c:
	Ran "astyle --style=linux" to tidy up the code. No functional changes.

544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
2008-08-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/bookmarks.c: (bookmarks_write_to_disk):
	* libgthumb/catalog.c: (catalog_write_to_disk):
	* libgthumb/file-utils.c: (dir_remove), (file_unlink),
	(get_file_mime_type), (image_is_jpeg), (image_is_gif):
	* libgthumb/gfile-utils.c: (gfile_warning),
	(gfile_get_filename_extension), (gfile_get_file_mime_type),
	(_gfile_image_is_type), (_gfile_image_is_type__gconf_file_type),
	(gfile_image_is_jpeg), (gfile_image_is_gif), (gfile_is_filetype),
	(gfile_get_file_size), (_gfile_make_directory_tree),
	(gfile_ensure_dir_exists), (_gfile_ith_temp_folder_to_try),
	(gfile_get_temp_dir_name), (_gfile_delete_directory_recursive),
	(gfile_dir_remove_recursive), (gfile_output_stream_write),
	(gfile_output_stream_write_line):
	* libgthumb/gfile-utils.h:
	* src/albumtheme.c: (yyparse):
	* src/albumtheme.l:
	* src/albumtheme.y:
	* src/catalog-web-exporter.c: (_write_line), (_write_locale_line),
	(write_line), (write_markup_escape_line),
	(write_markup_escape_locale_line), (gth_parsed_doc_print),
	(gfile_parsed_doc_print), (save_html_image_cb),
	(save_html_index_cb), (export__copy_image), (get_parsed_file),
	(parse_theme_files):
	* src/lex.albumtheme.c:
	Greater use of g_output_stream_write. Use gfile-based mime-type
	detection. Patch by Christophe Bisière. Bug #525482.

573
574
575
576
577
2008-08-20  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* configure.in: Added AC_PROG_CXX to fix bug #547803.
	Patch by Christophe Bisière.

578
579
580
581
582
583
2008-08-15  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (get_destination_free_space):
	Don't put the free space into a gboolean. That's only suitable for
	1-bit storage systems. guint64 is more capacious.

584
585
586
587
588
589
590
591
592
593
594
595
2008-08-13  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/catalog.c: (catalog_load_from_disk__common),
	(catalog_write_to_disk):
	gfile migration. Bug #525482. Purged gnome_vfs from catalog code.	

	* src/dlg-catalog.c: (add_to_catalog__ok_cb):
	* src/gth-browser.c: (catalog_activate),
	(add_image_list_to_catalog):
	* src/gth-window-utils.c: (remove_files_from_catalog):
	Initialize gerror to NULL.

596
597
598
599
600
601
2008-08-12  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/bookmarks.c: (bookmarks_load_from_disk),
	(bookmarks_write_to_disk):
	Added better error reporting.

602
603
604
605
606
2008-08-12  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/bookmarks.c:
	Remove unused macro, MAX_LINE_LENGTH.

607
608
609
610
611
612
613
614
2008-08-12  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/bookmarks.c: (bookmarks_load_from_disk),
	(bookmarks_write_to_disk):
	* libgthumb/gfile-utils.c: (gfile_output_stream_write_line):
	* libgthumb/gfile-utils.h:
	gfile migration. Bug #525482. Purged gnome_vfs from bookmark code.

615
616
617
618
619
620
621
622
2008-08-11  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (obtain_local_file):
	* libgthumb/file-utils.h:
	* libgthumb/gth-exif-utils.c: (update_and_save_metadata):
	More gfile migration by Christophe Bisière. Bug #525482.
	Replace gnome_vfs_xfer_uri with file_copy in the local cache code.

623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
2008-08-11  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (xfer_file), (file_rename):
	* libgthumb/file-utils.h:
	* libgthumb/gfile-utils.c: (gfile_warning),
	(_empty_file_progress_cb), (gfile_xfer), (gfile_copy),
	(gfile_move):
	* libgthumb/gfile-utils.h:
	* src/dlg-file-utils.c: (dlg_file_rename_series):
	* src/gth-browser-actions-callbacks.c: (catalog_rename),
	(folder_rename), (folder_copy__response_cb):
	More gfile migration by Christophe Bisière. Bug #525482.
	Migrated simple (synchronous) file transfer bits of code.

	* src/catalog-web-exporter.c: (export__save_other_files),
	(export__copy_image):
	Purged more gnome-vfs bits from the web exporter.

641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
2008-08-11  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (dir_remove_recursive),
	(ensure_dir_exists), (xfer_file), (local_file_move), (file_rename),
	(path_is_file), (path_is_dir), (get_file_size),
	(get_destination_free_space):
	* libgthumb/gfile-utils.c: (gfile_debug), (gfile_warning),
	(gfile_new), (gfile_new_va), (gfile_append_path), (gfile_is_local),
	(gfile_get_home_dir), (gfile_get_tmp_dir),
	(gfile_make_temp_in_dir):
	* libgthumb/gfile-utils.h:
	* src/catalog-web-exporter.c: (gfile_get_style_dir),
	(catalog_web_exporter_finalize), (catalog_web_exporter_init),
	(catalog_web_exporter_set_style),
	(catalog_web_exporter_set_location), (get_album_file),
	(get_image_file), (export__save_other_files), (parse_theme_files),
	(ensure_album_dir_exists), (catalog_web_exporter_export):
	* src/catalog-web-exporter.h:
	More gfile migration by Christophe Bisière. Bug #525482. Most
	notably, added gfile_new and gfile_new_va to elegantly construct
	gfiles from paths / uris.

663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
2008-08-10  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (dir_remove_recursive),
	(local_dir_remove_recursive), (ensure_dir_exists), (path_is_file),
	(path_is_dir), (get_file_size), (get_temp_dir_name),
	(get_destination_free_space):
	* libgthumb/file-utils.h:
	* libgthumb/gfile-utils.c: (gfile_get_uri), (gfile_get_path),
	(gfile_warning), (gfile_is_filetype), (gfile_path_is_file),
	(gfile_path_is_dir), (gfile_get_file_size), (make_directory_tree),
	(gfile_ensure_dir_exists), (gfile_is_local),
	(gfile_get_destination_free_space), (gfile_get_home_dir),
	(gfile_get_tmp_dir), (ith_temp_folder_to_try),
	(gfile_make_temp_in_dir), (gfile_get_temp_dir_name),
	(delete_directory_recursive), (gfile_dir_remove_recursive):
	* libgthumb/gfile-utils.h:
	* src/catalog-web-exporter.c: (gfile_get_relative_uri),
	(gfile_get_relative_path), (gth_parsed_doc_print),
	(export__save_other_files), (save_thumbnail_cb),
	(save_html_image_cb), (save_html_index_cb),
	(save_image_preview_cb), (save_resized_image_cb),
	(export__copy_image), (ensure_album_dir_exists),
	(ensure_dir_structure), (catalog_web_exporter_export):

	More gfile migration by Christophe Bisière. Bug #525482.
	The new gfile-only utility functions are going into
	gfile-utils.[ch]. The old path/uri functions are being reduced
	to wrappers for the new gfile functions, until they can be
	purged entirely.

693
694
695
696
697
698
699
2008-08-09  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (get_path_relative_to_uri):
	* src/catalog-web-exporter.c: (gth_parsed_doc_print):
	Fixed bug 546875 – Web exporter: attribute " relative_path" of tag
	<gthumb:file_path/> does not work. Patch by Christophe Bisière.

700
701
702
703
704
705
706
707
2008-08-09  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/Makefile.am:
	* libgthumb/gfile-utils.c:
	* libgthumb/gfile-utils.h:
	* po/POTFILES.in:
	Added gfile-utils.[ch] to contain gfile utility functions.

708
709
710
711
712
713
714
715
2008-08-09  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/catalog-png-exporter.c:
	* src/catalog-web-exporter.c:
	* src/catalog-web-exporter.h:
	Continuation of the gio migration. Christophe Bisière's updates
	to the index-image and web-album exporters. Bug #525482.

716
717
718
719
720
721
2008-08-09  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-viewer.c: (image_viewer_size_allocate):
	Make scrollbars go away in zoom-to-fit modes, regression from
	bug #501512. Patch by Geoffrey Antos <dynamotwain@aim.com>.

722
723
724
725
726
2008-08-08  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/theme-xml.txt: Corrected theme documentation, as per
	bug #546874. Patch by Christophe Bisière. 

727
728
729
730
731
732
733
2008-08-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/gth-browser.c: (ask_whether_to_save):
	* src/gth-viewer.c: (ask_whether_to_save):
	"Do Not Save" -> "Do _Not Save". Pulls in downstream keybinding
	patch from Debian, Ubuntu. Bug #546655.
	
734
735
736
737
738
739
740
741
742
743
744
745
2008-08-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-viewer.c: (set_pixbuf__step2), (image_loaded),
	(create_image): 
	Do not emit image_loaded signal when image_viewer_set_pixbuf is 
	called, fixing prompts to save modified images. 

	* libgthumb/image-viewer-image.c: (image_viewer_image_get_path):
	Fix a NULL-dereference.

	Patches by Geoffrey Antos <dynamotwain@aim.com>. Bug #501512.

746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
2008-08-07  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/file-utils.c: (_empty_file_progress_cb), (xfer_file),
	(file_rename), (path_exists), (copy_data_new),
	(copy_file_async_done), (copy_remote_file_to_cache_done):
	* libgthumb/file-utils.h:
	* libgthumb/image-loader.c: (image_loader_start__step3),
	(image_loader_start__step2):
	* src/catalog-png-exporter.c:
	(copy_current_file_to_destination_done), (begin_page), (end_page),
	(paint_frame):
	* src/catalog-png-exporter.h:
	* src/catalog-web-exporter.c: (gth_parsed_doc_print):
	* src/dlg-convert.c: (save_image_and_remove_original_step2):
	* src/dlg-file-utils.c: (dlg_file_rename_series):
	* src/dlg-jpegtran.c: (apply_transformation_done),
	(apply_transformation__step2), (apply_transformation),
	(apply_transformation_to_all_continue),
	(load_next_image_after_transformation):
	* src/dlg-photo-importer.c: (async_step_done):
	* src/dlg-png-exporter.c:
	* src/dlg-reset-exif.c: (apply_transformation_done),
	(apply_transformation__step2), (apply_transformation),
	(apply_transformation_to_all_continue):
	* src/gth-batch-op.c: (save_image_and_remove_original_step2):
	* src/gth-browser-actions-callbacks.c: (catalog_rename),
	(folder_rename), (folder_copy__response_cb):
	* src/gth-browser.c: (dir_list_key_press_cb),
	(dir_list_button_release_cb), (catalog_list_button_release_cb),
	(key_press_cb), (viewer_drag_data_received):
	* src/gth-window-actions-callbacks.c: (set_wallpaper_step_2):
	* src/rotation-utils.c: (apply_transformation_jpeg):

	Continuation of the gio migration. File transfers now use the gio
	code. Tweaked version of Gabriel Falcão's (gabriel@nacaolivre.org)
	patches from bug #525482.

783
784
785
786
787
788
789
2008-08-05  Paolo Bacchilega  <paobac@svn.gnome.org>

	* libgthumb/Makefile.am: added RENDER_LIBS and png to list of libraries.
	
	Fixes bug #546383 – gthumb 2.10.9 fails to link
	Patch by Götz Waschk.

790
791
792
793
794
795
796
797
798
799
800
801
802
2008-08-05  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* data/glade/gthumb_tools.glade:
	* data/gthumb.schemas.in:
	* libgthumb/async-pixbuf-ops.c: (scale_step), (_gdk_pixbuf_scale):
	* libgthumb/async-pixbuf-ops.h:
	* libgthumb/preferences.h:
	* src/dlg-scale-series.c: (ok_cb), (dlg_scale_series):
	Allow swapping of height and width during scale-series for
	best fit. Bug #507216. Tweaked version of the patch by
	Roman Ovseytsev <romovs@gmail.com>.

803
804
805
806
807
808
809
810
811
812
813
814
815
816
2008-08-01  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/theme-xml.txt:
	* libgthumb/pixbuf-utils.c: (scale_keeping_ratio_min),
	(scale_keeping_ratio):
	* libgthumb/pixbuf-utils.h:
	* src/catalog-web-exporter.c: (catalog_web_exporter_init),
	(catalog_web_exporter_set_preview_min_size), (get_var_value),
	(image_loader_done), (parse_theme_files):
	* src/catalog-web-exporter.h:
	Allow a minimum thumbnail size to be specified in the web album
	exporter, to handle panoramic images better. Bug #488832.
	Patch by Christophe Bisiere, based on Antoine Calando's patch.

817
818
819
820
821
822
823
2008-08-01  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* doc/theme-xml.txt:
	* src/catalog-web-exporter.c: (gth_parsed_doc_print):
	Add thumbnail and preview attributes to file_name and file_path tags
	in web album exporter. Patch by Christophe Bisiere. Bug #545750.

Michael J. Chudobiak's avatar
Michael J. Chudobiak committed
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
2008-08-01  Michael J. Chudobiak  <mjc@svn.gnome.org>

	Merge from gthumb-2-10:

	* src/gth-browser.c (window_update_sensitivity): set only_one_is_selected
	when n_selected is 1 (was 0).
	
	Fixes bug: doesn't allow to go to the image destination folder from the 
	catalog list.
	
	* libgthumb/thumb-loader.c (thumb_loader_start__step2): move the
	5 seconds test after the valid failed thumbnail test.
	
	* src/dlg-search.c (directory_load_cb): update the files mime type or the 
	thumbnail will not be created if necessary.
	
	* libgthumb/comments.c (save_comment): just check if data is NULL 
	before saving (#543771).
	
	* src/catalog-web-exporter.c (get_var_value): check whether 
	ce->eval_image is NULL before using it. 
	(export__save_html_files): init ce->eval_image to NULL.

847
848
849
850
851
852
853
2008-08-01  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/albumtheme.l:
	* src/lex.albumtheme.c:
	Fix yyunput-defined-but-not-used warning.
	Patch by Christophe Bisiere. Bug #543966.

854
855
856
857
858
859
860
861
862
863
2008-08-01  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* configure.in:
	Remove checks for XF86Gamma headers and libs.

	* data/gthumb.schemas.in:
	Remove old fading preference from schema.

	Patch by Geoffrey Antos <dynamotwain@aim.com>. Bug #501512.

864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
2008-07-31  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-loader.c: (image_loader_set_pixbuf):
	When setting a static pixbuf, free any loaded animation
	as animations override static pixbufs.

	* libgthumb/image-viewer-image.c: (image_viewer_image_paint):
	Remove unused variable.

	* libgthumb/image-viewer.c: (set_pixbuf__step2),
	(image_viewer_set_pixbuf):
	Fix a potential race-condition if called while still
	loading an image.

	Patch by Geoffrey Antos <dynamotwain@aim.com>. Bug #501512.

880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
2008-07-31  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/gth-nav-window.c: (size_changed_cb):
	Remove assumptions about GtkAdjustment->lower being 0

	* libgthumb/nav-window.c: (nav_window_events), (update_view):
	* libgthumb/image-viewer-image.c, libgthumb/image-viewer-image.h:
	Adjust [xy]-offset scales such that an offset of (0,0)
	will draw the image in the center of the widget even if
	widget is bigger or smaller than the image itself (important
	when there are two images with different sizes  on the screen at 
	once).

	* libgthumb/image-viewer-image.c, libgthumb/image-viewer-image.h:
	Have image paint itself to a cairo buffer to be used
	by a transition or directly by the widget.

	Removed the "repainted" signal as it is no longer needed
	as scrolling triggers an "exposed" event that takes care
	of it for gth-fullscreen.

	* src/gth-fullscreeen.c:
	No longer connect to the "repainted" event.

	Patch by Geoffrey Antos <dynamotwain@aim.com>. Bug #501512.

906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
2008-07-31  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* libgthumb/image-viewer.c:
	* libgthumb/image-viewer-image.c:
	Refactor ImageViewer widget to split image state information
	to a new ImageViewerImage object and hide all private variables.
	ImageViewer now emits "image_loaded", "image_error", and
	"image_progress" signals to compensate for lack of direct access
	to the ImageLoaded contained within.

	* src/gth-browser.c: (gth_browser_construct), (image_loader_done_cb),
	(image_loader_progress_cb):
	Renamed to image_viewer_{done,progress}_cb as signal handlers
	that are now connected to the ImageViewer and not an ImageLoader.

	* src/gth-browser.c: (gth_browser_get_animation), (viewer_drag_get),
	(window_update_zoom_sensitivity):
	* src/gth-fullscreen.c: (gth_fullscreen_get_animation),
	(update_zoom_sensitivity), (get_file_info)
	* src/gth-viewer.c: (viewer_update_zoom_sensitivity), 
	(viewer_update_statusbar_zoom_info), (viewer_drag_data_get):
	Use ImageViewer accessor functions instead of directly accessing
	private variables.

	Patch by Geoffrey Antos <dynamotwain@aim.com>. Bug #501512.

932
933
934
935
936
937
938
939
940
941
942
943
944
2008-07-31  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* src/albumtheme-private.h:
	* src/albumtheme.c: (yyparse):
	* src/albumtheme.l:
	* src/albumtheme.y:
	* src/catalog-web-exporter.c: (get_var_value),
	(gth_parsed_doc_print):
	* src/lex.albumtheme.c: 
	Added page_rows and page_cols web album tags. Bug #543966.
	Patch by Christophe Bisiere.

945
946
947
948
949
950
951
2008-07-31  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* src/catalog-web-exporter.c: (gth_parsed_doc_print):
	Fix for Bug #544893: Crash in web album <gthumb:if/>.
	Patch by Christophe Bisiere.

952
953
954
955
956
957
958
959
960
961
962
963
964
965
2008-07-30  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/gth-browser-ui.h:
	* src/gth-browser.c: (window_update_sensitivity):
	* src/gth-viewer-ui.h:
	* src/gth-window-actions-callbacks.c:
	* src/gth-window-actions-callbacks.h:
	* src/gth-window-actions-entries.h:
	Removed the "Delete Comment" function, because the comments are
	now linked to the embedded image metadata. Deleting the comments
	would mean deleting quite a few metadata fields, which is
	probably too invasive. Use the "Edit Comment" function instead.
	Might need to revisit this issue.

966
967
968
969
970
971
972
2008-07-30  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/dlg-jpegtran.c: (apply_transformation__step2):
	If a no-physical-transformation rotation is requested, and the
	original jpeg has no exif orientation tag, then add the tag instead
	of doing a physical transform. Fixes bug #432756.

973
974
975
976
977
2008-07-26  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* src/dlg-web-exporter.c: (get_default_theme): Minor code tidy-up,
	to avoid an uninitialized variable.

978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
2008-07-25  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* data/gthumb.schemas.in: The default web album theme did not
	exist any longer (Clean). Set it to an existing theme (Wiki).

	* data/glade/gthumb_web_exporter.glade:
	* libgthumb/gtk-utils.c: (_gtk_button_set_filename_label),
	(_gtk_button_get_filename_label):
	* libgthumb/gtk-utils.h:
	* src/dlg-web-exporter.c: (export), (get_default_theme),
	(dlg_web_exporter), (theme_dialog__ok_clicked), (load_themes):
	Made the UI for selecting a web album theme more obvious.
	Patch by Christophe Bisiere, bug #501570.

	Also, fall back to the default theme when the theme stored in
	gconf does not actually exist.

995
996
997
998
999
1000
2008-07-21  Michael J. Chudobiak  <mjc@svn.gnome.org>

	* NEWS:
	* src/catalog-web-exporter.c: (_write_line), (_write_locale_line),
	(write_line), (write_markup_escape_line),
	(write_markup_escape_locale_line):