async metadata store seems to finalize media objects
@mschraal
Submitted by Marinus Schraal Assigned to gri..@..e.bugs
Link to original bug (#775713)
Description
Created attachment 341480 make metadata store async
I added metadata storage to tracker through grilo in gnome-music recently. Making the calls sync works, async however they fail and segfault. It seems the original media object is in some cases finalized in the latter case.
The patch supplied is to make the calls async in gnome-music git master, reproduce by selecting an album and starring/unstarring a track of the album (3 clicks should suffice).
GRL_DEBUG=media:* with the patch produces :
-- 1st click --
<__gi__.GrlTrackerSource object at 0x7fd605397c60 (GrlTrackerSource at 0x2053840)> <Grl.Media object at 0x7fd6041b2bd0 (GrlMedia at 0x5174a20)> [] <Grl.Media object at 0x7fd6041b2bd0 (GrlMedia at 0x5174a20)> None
-- 2nd click --
<__gi__.GrlTrackerSource object at 0x7fd605397c60 (GrlTrackerSource at 0x2053840)> <Grl.Media object at 0x7fd6041b2bd0 (GrlMedia at 0x5174a20)> [] <Grl.Media object at 0x7fd6041b2bd0 (GrlMedia at 0x5174a20)> None
(gnome-music:8895): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize (I Know Places)
(gnome-music:8895): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
-- 3rd click --
Segmentation fault (core dumped)
and without produces:
-- 1st click --
(gnome-music:9211): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
-- 2nd click --
(gnome-music:9211): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
(gnome-music:9211): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
-- 3rd click --
(gnome-music:9211): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
(gnome-music:9211): Grilo-DEBUG: [media] data/grl-media.c:140: grl_media_finalize ((null))
-- etc --
Patch 341480, "make metadata store async":
0001-grilo-Async-the-metadata-store-calls.patch
Version: git master
Edited by Marinus Schraal