1. 24 Feb, 2019 2 commits
  2. 18 Feb, 2019 1 commit
  3. 06 Feb, 2019 7 commits
  4. 24 Jan, 2019 1 commit
  5. 14 Dec, 2018 1 commit
  6. 25 Nov, 2018 1 commit
  7. 19 Nov, 2018 2 commits
  8. 16 Nov, 2018 3 commits
    • Bastien Nocera's avatar
      registry: Fix possible crasher on startup in Totem · 79b36bc5
      Bastien Nocera authored
      When announcing that a source was added, the application might choose to
      say "actually, I'm not interested in this source" and unref it. As we
      want to be able to carry on checking some of its properties, such as
      tags, we either need to check whether the source was finalized in
      between calls, or keep a list of sources to be added/removed after we've
      done computation.
      
      The latter is easier to implement, so add all sources to temporary lists
      to avoid the tags disappearing from under us when emitting the signals.
      
      See https://github.com/flathub/org.gnome.Totem/issues/6
      79b36bc5
    • Bastien Nocera's avatar
      registry: Fix g_hash_table_iter_next() warning · 0711247c
      Bastien Nocera authored
      As we loop through the sources as listed in the hash table, there's a
      good chance that the hash table will be modified as sources are added or
      removed. But as we shouldn't be modifying the hash table while it's
      being iterated over, the code throws a warning, and will exit the loop.
      
      Warning: g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->version' failed
      
      Solve this by getting a list of all the sources in advance.
      0711247c
    • Bastien Nocera's avatar
      core: Fix g-ir-scanner warning · 915e3f8b
      Bastien Nocera authored
      src/data/grl-data.c:615: Error: Grl: identifier not found on the first line:
       * Returns whether the string is a canonical one.
         ^
      
      This is an internal function, so remove the double-* used for
      documenting public functions.
      915e3f8b
  9. 14 Nov, 2018 1 commit
  10. 07 Nov, 2018 1 commit
  11. 01 Nov, 2018 1 commit
  12. 30 Oct, 2018 1 commit
  13. 29 Oct, 2018 1 commit
  14. 26 Oct, 2018 1 commit
  15. 09 Oct, 2018 1 commit
  16. 02 Oct, 2018 7 commits
    • Victor Toso's avatar
      core: Include GType name in log · 78cbfb75
      Victor Toso authored
      And add a FIXME to grl_data_add_for_id() as it needs to handle other
      key types too.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      78cbfb75
    • Victor Toso's avatar
      tests: Supported metadata-key transformations · 00937274
      Victor Toso authored
      Grilo got support to transform similar GValues while using
      grl_data_add_for_id() and grl_data_set_for() API.
      
      This commmit include tests to verify supported and unsupported
      GValues.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      00937274
    • Victor Toso's avatar
      core: Fix return value of invalid argument on grl_data_*_for_id() · af568e8c
      Victor Toso authored
      If g_value_type_transformable () fails, we can't take the @GValue for
      that given metadata-key. Return FALSE instead of TRUE.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      af568e8c
    • Victor Toso's avatar
      core: support transform GValue to key's GType · bbad302f
      Victor Toso authored
      Although some conversions might imply losing precision, there is a
      major gain over situations like deserializing data.
      
      APIs that might be affected by this are the ones handling GValue as
      argument. In grl_related_keys_set() is where the code rely on checking
      the GType and failing if needed.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      bbad302f
    • Victor Toso's avatar
      tests: Add tests for grl_data_*_for_id() · a43916a2
      Victor Toso authored
      Basic tests to handle API that was recently introduced to the
      following cases:
      
      - When a metadata-key does not exist and shall be created by this API
        with GType based on GValue (parameter). This test checks all
        supported GTypes by those APIs.
      
      - When the metadata-key exists, so it sets or adds the GValue
        to it.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      a43916a2
    • Victor Toso's avatar
      registry: fix SIGSEGV on unhandled GType · 1169e447
      Victor Toso authored
      Found it while writing unit tests for it.
      
      Backtrace:
       | Thread 1 "media" received signal SIGSEGV, Segmentation fault.
       | grl_registry_register_metadata_key_for_type (registry=registry@entry=0x6180d0,
       | key_name=key_name@entry=0x615fdd "grl-key-double-set-that-does-not-exist",
       | type=type@entry=60) at ../src/grl-registry.c:643
      
       | 643           GRL_WARNING ("'%s' is being ignored as G_TYPE '%s' is not being handled",
      
       | (gdb) bt
       | #0  0x00007ffff7bbd260 in grl_registry_register_metadata_key_for_type
       |     (registry=registry@entry=0x6180d0, key_name=key_name@entry=0x615fdd
       |     "grl-key-double-set-that-does-not-exist", type=type@entry=60)
       |     at ../src/grl-registry.c:643
       | #1  0x00007ffff7bad1e9 in grl_data_set_for_id (data=0x642d60,
       |     key_name=0x615fdd "grl-key-double-set-that-does-not-exist",
       |     key_name@entry=0x60da10 "grl-key-double-set-that-does-not-exist",
       |     value=value@entry=0x7fffffffd2e0) at ../src/data/grl-data.c:685
       | #2  0x00000000004016b9 in test_set_for_id_new_key (fixture=0x613bf0,
       |     data=0x1) at ../tests/media.c:103
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      1169e447
    • Victor Toso's avatar
      core: handle NULL as NOP for grl_data_*_for_id() · 2be94f85
      Victor Toso authored
      To avoid handling a value that is treated as NOP by
      grl_data_set () anyway.
      Signed-off-by: Victor Toso's avatarVictor Toso <victortoso@gnome.org>
      2be94f85
  17. 28 Sep, 2018 2 commits
    • Thiago's avatar
      docs: Update document on how to build using meson · 8d700b18
      Thiago authored
      The documentation on how to build Grilo was out-of-date after the port
      from autotools to meson. This commit also contains the update needed
      after the migration to the gitlab.gnome.org
      8d700b18
    • Thiago's avatar
      docs: Fix documentation typo · dc2e7d0f
      Thiago authored
      Change it from contaddiner to container. This text is used to generate
       part of the Grilo docs
      dc2e7d0f
  18. 25 Sep, 2018 4 commits
  19. 04 Sep, 2018 2 commits