[lua] plugins don't fall through on empty resultset
@mschraal
Submitted by Marinus Schraal Assigned to gri..@..e.bugs
Link to original bug (#761852)
Description
I noticed the lua lastfm-cover plugin doesn't fall through to eg. the spotify cover plugin if no cover images are found. Apparently an empty set is currently considered resolved in lua.
The patch adapts the plugin to truly return nothing, with some debug statements to see what's going on.
Example debug output of gnome-music trying to resolve cover images :
(gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:496: fetch_done element 1 of 1 urls (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size small = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size medium = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size large = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size extralarge = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size mega = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size = (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: V nil (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: lastfm return empty (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1003: grl.callback() (gnome-music:6100): Grilo-DEBUG: [source] grl-source.c:1980: resolve_result_relay_cb (gnome-music:6100): Grilo-DEBUG: [source] grl-source.c:933: operation_set_finished (150) (gnome-music:6100): Grilo-DEBUG: [wc] grl-net-wc.c:251: cache down (gnome-music:6100): Grilo-DEBUG: [wc] grl-net-wc.c:251: cache down (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:496: fetch_done element 1 of 1 urls (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size small = http://img2-ak.lst.fm/i/u/34s/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size medium = http://img2-ak.lst.fm/i/u/64s/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size large = http://img2-ak.lst.fm/i/u/174s/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size extralarge = http://img2-ak.lst.fm/i/u/300x300/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size mega = http://img2-ak.lst.fm/i/u/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1054: Image size = http://img2-ak.lst.fm/i/u/arQ/9e3d9a4bb5d3f9a0792558887afff578.png (gnome-music:6100): Grilo-DEBUG: [lua-library] grl-lua-library.c:1003: grl.callback() (gnome-music:6100): Grilo-DEBUG: [source] grl-source.c:1980: resolve_result_relay_cb (gnome-music:6100): Grilo-DEBUG: [source] grl-source.c:933: operation_set_finished (195)
Version: git master