- 22 Aug, 2020 16 commits
-
-
Carlos Garnacho authored -
Carlos Garnacho authored
Do things straight from the query, so we get a proper media type for the given row.
-
Carlos Garnacho authored
This is no longer used.
-
Carlos Garnacho authored
A number of fields in the struct is now unused, can be removed.
-
Carlos Garnacho authored
The utils code to create sparql queries is no unused, this can be removed.
-
Carlos Garnacho authored
The data stored by miner-fs is no longer considered readwrite for all. These updates used to trigger the tracker writeback service which would rewrite file metadata and make everything match again. Make this use the writeback service directly, the miner-fs data will then be updated indirectly.
-
Carlos Garnacho authored
We now look up variable names here, so update this. Also drop the other (no longer necessary) mappings.
-
Carlos Garnacho authored
Set it afterwards, instead of relying on a second for the same metadata key. This is the only place where this is needed and can be easily handled in other ways.
-
Carlos Garnacho authored
tracker:id() is an internal detail, it sounds better not to expose it in public API.
-
Carlos Garnacho authored
Shuffle things so we don't miss errors there.
-
Carlos Garnacho authored
In tracker3 these 2 classes are no longer attributed to the very same resource object. Those are 2 different entities, so this must be accounted for. Prefer to stay wherever possible in the InformationElement domain, and resolve properly the DataObject from the InformationElement otherwise.
-
Carlos Garnacho authored
Those are not used anymore.
-
Carlos Garnacho authored
We drop the support for full queries, the query is extended so that subselects work.
-
Carlos Garnacho authored
-
Carlos Garnacho authored
-
Carlos Garnacho authored
-
- 21 Aug, 2020 24 commits
-
-
This is essentially a GRL_TRACKER_QUERY_MEDIA_FROM_URI with no additional keys or filters.
-
-
-
We match by GrlTypeFilter, so it's easy to discard those that don't apply.
-
So it can be used to generate variable names in SPARQL queries, and parameter bindings for filters.
-
If a leak happened, this shouldn't be warned on random app's stderr.
-
This only unsets the private connection, which is rather wrong. Let it live so it can be used during the object lifetime.
-
For a large part, this work duplicates tracker's internal handling (eg. updates are already guaranteed to be executed sequentially), or even hinders it (eg. select queries are serialized even though they can run in parallel). This will also get a bit in the middle, as it makes sense to minimize the time between a query happening and a TrackerSparqlStatement being executed for that TrackerSparqlStatement to be ready for reuse ASAP. Drop this queue and let Tracker handle things itself.
-
The operation is passed as data to the cursor asynchronous method, so it's already implicitly attached to it.
-
The cursor will already error out if the cancellable was cancelled. Check for that error and avoid checking the cancellable directly.
-
Rely on the limit as set in the query. This accounting is a best effort anyway, as asking for 100 elements is not guaranteed to return 100 elements.
-
We only have one source, with name "". This was unused.
-
This query string is unused.
-
Instead of being a singleton, the GrlSource sets up its own notification.
-
This got unused long ago, it seems these functions can just go.
-
The port is shoddy atm, queries will be updated to making use of this one by one.
-
It seems a little bit shoehorned as there's no GrlMediaType to express documents. Drop this configuration option as it also does seem unused according to codesearch.debian.net.
-
So it is possible to open a specific store. Queries will be updated to use the org.freedesktop.Tracker3.Miner.Files service where necessary.
-
Besides allowing to browse folders as media containers, this option makes change notifications work by enabling tracker:notify on nfo:Folder type, so the grilo client (and everyone else, really ) may receive TrackerNotifier notifications about folder additions/changes. It's not in the hand of a client to do this, it ought not. Besides the option seems completely unused according to codesearch.debian.net. The Tracker plugin should not be intended for browsing as a filesystem structure, and it is possible to create media containers specifically for folders that do contain media. Drop this configuration option in the tracker3 module.
-
This ontology was never upstreamed, probably belonged somewhere to maemo/moblin. Anyhow, it seems like dead code today, drop this.
-
This is a separate plugin as it requires a version bump, different queries, and can do some niceties supported in the new version.
-
This patch is an extension of !87 Some containers can also have properties like artist, album and genre, these need to be set for album media.
-
The API is no longer accessible without authorization.
-
Victor Toso authoredRawhide is breaking the introspecting build with a permission to read error. ldd: error: you do not have read permission for `/builds/victortoso/grilo-plugins/_build/tmp-introspectv0kuw8ww/Grl-0.3' That is a temporary folder created by meson (0.55.0-2) but I think the issue is in the new python 3.9. I could not reproduce locally but for now, let's fix CI for grilo and grilo-plugins (due subprojects)
-
